View Issue Details

IDProjectCategoryView StatusLast Update
0002198JEDI VCL00 JVCL Componentspublic2005-08-10 03:36
Reporterralf.kaiserAssigned Toasnepvangers 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version3.10 
Summary0002198: TJvCustomComboEdit.SetClipboardCommands (weired code)
DescriptionThe method SetClipboardCommands in TJvCustomComboEdit contains this code which makes not much sense (as discussed in the newsgroup) and partially breaks existing programs where ClipboardCommands are set to [].

procedure TJvCustomComboEdit.SetClipboardCommands(const Value: TJvClipboardCommands);
begin
  if ClipboardCommands <> Value then
  begin
    inherited SetClipboardCommands(Value);
    ReadOnly := ClipboardCommands <= [caCopy];
  end;
end;
Additional InformationWould be good to change this to:

if ReadOnly then ClipboardCommands := [caCopy];

(or leave the lines out completely)
TagsNo tags attached.

Activities

user72

2004-10-08 01:59

  ~0005346

I vote for removing it altogether

obones

2004-10-08 23:07

administrator   ~0005352

Please have a look at the latest CVS version, Fred has provided a fix for this.

asnepvangers

2004-10-24 04:16

developer   ~0005471

Still weird code.

New implementation:

If the inherited ReadOnly is set, CutToClipBoard & PasteFromClipboard will never occur: the code prevents this. In other words if ReadOnly is true, caCut and caPaste in ClipboardCommands are ignored! They are only active if ReadOnly = false.
 
This behaviour is also more practic if you modify property ReadOnly at runtime:
no need to restore ClipBoardCommands, when you reset ReadOnly.

The SetClipBoardCommands method will be removed from the new JvExVCL & JvExCLX classes.

obones

2005-08-10 03:36

administrator   ~0007770

This is then assumed to be resolved.

Issue History

Date Modified Username Field Change
2004-10-07 07:18 ralf.kaiser New Issue
2004-10-08 01:59 user72 Note Added: 0005346
2004-10-08 01:59 user72 Status new => acknowledged
2004-10-08 23:07 obones Note Added: 0005352
2004-10-08 23:07 obones Status acknowledged => feedback
2004-10-09 09:56 obones Status feedback => resolved
2004-10-09 09:56 obones Resolution open => fixed
2004-10-09 09:56 obones Assigned To => obones
2004-10-24 04:16 asnepvangers Status resolved => feedback
2004-10-24 04:16 asnepvangers Resolution fixed => reopened
2004-10-24 04:16 asnepvangers Note Added: 0005471
2004-10-24 04:18 asnepvangers Status feedback => assigned
2004-10-24 04:18 asnepvangers Assigned To obones => asnepvangers
2005-08-10 03:36 obones Status assigned => resolved
2005-08-10 03:36 obones Resolution reopened => fixed
2005-08-10 03:36 obones Note Added: 0007770