Project JEDI - Issue Tracker
Mantis Bugtracker

Viewing Issue Advanced Details Jump to Notes ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0003113 [JEDI VCL] 00 JVCL Components feature always 2005-07-26 11:31 2005-08-09 03:29
Reporter vlador View Status public  
Assigned To obones
Priority normal Resolution fixed Platform
Status resolved   OS
Projection none   OS Version
ETA none Fixed in Version 3.10 Product Version 3.00
  Target Version Product Build
Summary 0003113: JvXPBar: add BodyFrame color property
Description As far as I can see, now it is not possible to define body frame color. It would be great if you allow frame width, too.

I can change this for myself, but thought that you might want to add it in the official version.
Steps To Reproduce
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0007625)
obones (administrator)
2005-07-27 01:10

Well, if you do the changes in your copy and know they work, we would appreciate if you could post them here. A modified version of the latest CVS file would be good, an unified diff (-u3) would even be better.
Cheers
Olivier
(0007635)
vlador (reporter)
2005-07-27 14:05

Ah, ok. Sorry not doing it right away. Here is how I have done this:

--- JvXPBar.pas v1.91
+++ JvXPBar.pas new
@@ -315,6 +315,7 @@
     FSeparatorColor: TColor;
     FBorderColor: TColor;
     FOnChange: TNotifyEvent;
+ FBodyBorderColor: TColor;
     procedure SetBorderColor(const Value: TColor);
     procedure SetBodyColor(const Value: TColor);
     procedure SetGradientFrom(const Value: TColor);
@@ -324,6 +325,7 @@
     procedure SetFocusedColor(const Value: TColor);
     procedure SetCheckedFrameColor(const Value: TColor);
     procedure SetFocusedFrameColor(const Value: TColor);
+ procedure SetBodyBorderColor(const Value: TColor);
   public
     constructor Create;
     procedure Assign(Source: TPersistent); override;
@@ -335,6 +337,7 @@
     property CheckedFrameColor: TColor read FCheckedFrameColor write SetCheckedFrameColor default dxColor_CheckedFrameColorXP;
     property FocusedFrameColor: TColor read FFocusedFrameColor write SetFocusedFrameColor default dxColor_FocusedFrameColorXP;
     property BodyColor: TColor read FBodyColor write SetBodyColor default TColor($00F7DFD6);
+ property BodyBorderColor: TColor read FBodyBorderColor write SetBodyBorderColor default TColor($00F7DFD6);
     property GradientFrom: TColor read FGradientFrom write SetGradientFrom default clWhite;
     property GradientTo: TColor read FGradientTo write SetGradientTo default TColor($00F7D7C6);
     property SeparatorColor: TColor read FSeparatorColor write SetSeparatorColor default TColor($00F7D7C6);
@@ -1414,6 +1417,7 @@
   inherited Create;
   // (rom) needs local color constants
   FBodyColor := TColor($00F7DFD6);
+ FBodyBorderColor := TColor($00F7DFD6);
   FBorderColor := clWhite;
   FGradientFrom := clWhite;
   FGradientTo := TColor($00F7D7C6);
@@ -1550,6 +1554,15 @@
   end;
 end;
 
+procedure TJvXPBarColors.SetBodyBorderColor(const Value: TColor);
+begin
+ if FBodyBorderColor <> Value then
+ begin
+ FBodyBorderColor := Value;
+ Change;
+ end;
+end;
+
 //=== { TJvXPCustomWinXPBar } ================================================
 
 constructor TJvXPCustomWinXPBar.Create(AOwner: TComponent);
@@ -2113,8 +2126,14 @@
       if Assigned(FOnDrawBackground) then
         FOnDrawBackground(Self, ACanvas, R);
     end
- else
- ACanvas.FillRect(R);
+ else begin
+ if not FCollapsed and (FColors.FBodyColor <> FColors.FBodyBorderColor) then
+ begin
+ ACanvas.Pen.Color := FColors.FBodyBorderColor;
+ ACanvas.Rectangle(R.Left, R.Top, R.Right, R.Bottom - 1);
+ end
+ else ACanvas.FillRect(R);
+ end;
   end;
 
   procedure DoDrawHeader(ACanvas: TCanvas; var R: TRect);
(0007704)
obones (administrator)
2005-08-09 03:29

This is now in CVS, thanks for the report and the diff.

- Issue History
Date Modified Username Field Change
2005-07-26 11:31 vlador New Issue
2005-07-27 01:10 obones Note Added: 0007625
2005-07-27 01:10 obones Status new => feedback
2005-07-27 14:05 vlador Note Added: 0007635
2005-08-09 03:29 obones Status feedback => resolved
2005-08-09 03:29 obones Resolution open => fixed
2005-08-09 03:29 obones Assigned To => obones
2005-08-09 03:29 obones Note Added: 0007704


Mantis 1.1.6[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker