View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003662JEDI VCL00 JVCL Componentspublic2006-04-25 04:572006-06-09 02:15
Reporteruser72Assigned Touser72 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version3.30 
Summary0003662: TJvMRUManager: MaxLength has no effect if ShowAccelChar is false
DescriptionWhen ShowAccelChar is false, the setting of MaxLength has no effect, resulting in nio path compaction unless an accelerator character is shown
Steps To ReproduceThis is due to a logical error in UpdateRecentMenu:

[code]
      if FShowAccelChar then
      begin
        L := Cardinal(I) + FStartAccel;
        if L < 10 then
          C := '&' + Char(Ord('0') + L)
        else
        if L <= (Ord('Z') + 10) then
          C := '&' + Char(L + Ord('A') - 10)
        else
          C := ' ';
        Item.Caption := C + AccelDelimChars[FAccelDelimiter] + DoMinimizeName(S);
      end;
[/code]

this should've been:
[code]
      if FShowAccelChar then
      begin
        L := Cardinal(I) + FStartAccel;
        if L < 10 then
          C := '&' + Char(Ord('0') + L)
        else
        if L <= (Ord('Z') + 10) then
          C := '&' + Char(L + Ord('A') - 10)
        else
          C := ' ';
        Item.Caption := C + AccelDelimChars[FAccelDelimiter] + DoMinimizeName(S);
      end;
      else
        Item.Caption := DoMinimizeName(S);
[/code]

TagsNo tags attached.

Activities

user72

2006-04-25 07:53

  ~0009182

Fixed in CVS

obones

2006-04-26 00:45

administrator   ~0009184

I'm sorry Peter, but CVS is no longer used as indicated in the news sections for the project and the newsgroups. I'm even surprised you managed to commit, I removed write access to every developer in the group. Anyway, you will have to either do the commit in SVN, or tell me and I'll do it.
Sorry for the inconvenience.

obones

2006-06-09 02:15

administrator   ~0009513

Backported changes from CVS

Issue History

Date Modified Username Field Change
2006-04-25 04:57 user72 New Issue
2006-04-25 07:50 user72 Status new => assigned
2006-04-25 07:50 user72 Assigned To => user72
2006-04-25 07:53 user72 Status assigned => resolved
2006-04-25 07:53 user72 Resolution open => fixed
2006-04-25 07:53 user72 Note Added: 0009182
2006-04-26 00:45 obones Status resolved => feedback
2006-04-26 00:45 obones Resolution fixed => reopened
2006-04-26 00:45 obones Note Added: 0009184
2006-06-09 02:15 obones Status feedback => resolved
2006-06-09 02:15 obones Resolution reopened => fixed
2006-06-09 02:15 obones Note Added: 0009513