View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003900 | JEDI VCL | 00 JVCL Components | public | 2006-09-13 09:29 | 2007-01-04 04:02 |
| Reporter | drader | Assigned To | obones | ||
| Priority | normal | Severity | block | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | Daily / GIT | ||||
| Target Version | Fixed in Version | 3.30 | |||
| Summary | 0003900: Application with both Standard and CustomDoking features raise an unneeded assert condition | ||||
| Description | The assert condition in the function TJvDockClient.CreateTabDockClass(TabHost: TForm): TJvDockTabPageControl; doesn't allow me to uses CustomDocking feature. I can't understand any real reason for this kind of assert | ||||
| Additional Information | function TJvDockClient.CreateTabDockClass(TabHost: TForm): TJvDockTabPageControl; begin Result := nil; { copy properties of the JvTabDockPageControl's DockClient from the form it contains. } TJvDockTabHostForm(TabHost).DockClient.Assign(Self); Assert(TJvDockTabHostForm(TabHost).DockClient.CustomDock, 'DEBUG HELPER: Not working!'); if (FTabDockClass <> nil) and (FTabDockClass <> TJvDockTabClass(ClassType)) then begin Result := FTabDockClass.Create(TabHost); Result.Align := alClient; TJvDockTabHostForm(TabHost).DockableControl := Result; TJvDockTabHostForm(TabHost).PageControl := Result; SetDockSite(Result, True); end; end; | ||||
| Tags | No tags attached. | ||||
|
|
Well, it says it "Not working". Try to remove it and see what is not working, propose a bug fix and we'll remove this assert. |
|
|
I already removed the assert and I hadn't any problem. This assert totally prevents the use of CustomDock feature. Couldn't it be a refuse? |
|
|
hum... I'm a bit uneasy at removing the assert without extended testing. Can you do this with the examples from the JVCL? |
|
|
Ok! Try this simple test: Take a docking demo, for example DockOptionDemo. Open DockWindows.pas and set lbDockClient1.CustomDock = false because we don't want to dock this form in a hypothetical customdock panel. Enable the asserts, compile and try to tabdock the forms .... you will get in this assert condition ... this doesn't make sense. If you remove the assertion it works fine. |
|
|
This is now fixed in SVN. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-09-13 09:29 | drader | New Issue | |
| 2006-09-29 06:45 | obones | Note Added: 0010239 | |
| 2006-09-29 06:45 | obones | Status | new => feedback |
| 2006-09-30 06:02 | drader | Note Added: 0010263 | |
| 2006-10-06 02:38 | obones | Note Added: 0010300 | |
| 2006-10-06 12:31 | drader | Note Added: 0010325 | |
| 2007-01-04 04:01 | obones | Status | feedback => resolved |
| 2007-01-04 04:01 | obones | Fixed in Version | => Daily / SVN |
| 2007-01-04 04:01 | obones | Resolution | open => fixed |
| 2007-01-04 04:01 | obones | Assigned To | => obones |
| 2007-01-04 04:01 | obones | Note Added: 0010521 |
