View Issue Details

IDProjectCategoryView StatusLast Update
0003973JEDI VCL00 JVCL Componentspublic2007-06-19 02:50
ReporterAriochAssigned Toobones 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformDelphi 5OSOS Version
Product VersionDaily / GIT 
Target VersionFixed in Version3.34 
Summary0003973: JvMemoryDataset, troubles with .RecNo
Description1) SetRecNo method should call *Scroll events.
Look at TBDEDataSet.SetRecNo or TClientDataSet.SetRecNo

Thus it is better to like like that:
~~~~~
procedure TJvMemoryData.SetRecNo(Value: Integer);
begin
  if (Value > 0) and (Value <= FRecords.Count) then
  begin
    DoBeforeScroll; // Arioch
    FRecordPos := Value - 1;
    Resync([]);
    DoAfterScroll; // Arioch
  end;
end;
~~~~~


2. Seems like UpdateCursorPos is not to be called from GetRecNo, ro some of routines it calls is implemented wrong, i didn't got ends together yet.

So it is to be done yet.
Steps To ReproduceAbout item 2:

Just make a DBGrid to JvMemoryDataset

dataset let consists of integer field and string calcfield, that is calculated to InToStr of field1

and one more statement in OnCalcFields let be "Self.Tag := JvMemoryDataSet1.RecNo" - seems like NOP, yes ?

then make a button to do
  JMDS1.EmptyTable;
  for i := 1 to 10 do JMDS1.AppendRecord([i]);

After that just focus the grid and press up/down to run through records.
Something very cursed is happening to record buffers !!!
TagsNo tags attached.

Relationships

related to 0003461 closed Bug en MemoryData when in CalcFields events field = Dataset.RecNo 

Activities

2006-10-29 16:27

 

Project1.exe (234,496 bytes)

2006-10-29 16:28

 

MemoryDataset, GetRecNo in OnCalc.zip (1,902 bytes)

moore

2006-10-30 07:21

reporter   ~0010393

This is relates to the issue 0003461

Arioch

2006-10-30 12:37

developer   ~0010395

true.

I vote for checking in fix .SetRecNo, and then marking the rest of the ticket - duplicate of 0003461

obones

2007-06-19 02:49

administrator   ~0013394

The change is in SVN

Issue History

Date Modified Username Field Change
2006-10-29 14:12 Arioch New Issue
2006-10-29 16:27 Arioch File Added: Project1.exe
2006-10-29 16:28 Arioch File Added: MemoryDataset, GetRecNo in OnCalc.zip
2006-10-30 07:21 moore Note Added: 0010393
2006-10-30 12:37 Arioch Relationship added related to 0003461
2006-10-30 12:37 Arioch Note Added: 0010395
2007-06-19 02:49 obones Status new => resolved
2007-06-19 02:49 obones Fixed in Version => Daily / SVN
2007-06-19 02:49 obones Resolution open => fixed
2007-06-19 02:49 obones Assigned To => obones
2007-06-19 02:49 obones Note Added: 0013394