View Issue Details

IDProjectCategoryView StatusLast Update
0003987JEDI VCL00 JVCL Componentspublic2007-01-04 09:43
ReporterEinWillAssigned Tooutchy 
PrioritynormalSeveritytextReproducibilityN/A
Status resolvedResolutionfixed 
Product Version3.20 
Target VersionFixed in Version3.30 
Summary0003987: Strange initial value for TJvDBSpinEdit.DownClick
DescriptionFile jvdbspinedit.pas, lines 182-193:

-------------------------------------------------------------
procedure TJvDBSpinEdit.DownClick(Sender: TObject);
begin
  FDataLink.Edit;
  if IsNull then
  begin
    FIsNull := False;
    Value := 1;
    FIsNull := False;
    Text := '1';
  end;
  inherited DownClick(Sender);
end;
-------------------------------------------------------------

Did you really mean it? It's a matter of agreement, but "Value := 0" or
"Value := -1" (and correspondingly Text :=...) will look more naturally.


Right now this value is overwritten, therefore it doesn't cause any problem. But it might lead to a strange behavior of the component in the future. So it's better to fix it.
TagsNo tags attached.

Activities

outchy

2007-01-04 09:41

administrator   ~0010536

Fixed in revision 11130.

Issue History

Date Modified Username Field Change
2006-11-05 23:12 EinWill New Issue
2007-01-04 09:41 outchy Status new => resolved
2007-01-04 09:41 outchy Fixed in Version => Daily / SVN
2007-01-04 09:41 outchy Resolution open => fixed
2007-01-04 09:41 outchy Assigned To => outchy
2007-01-04 09:41 outchy Note Added: 0010536