View Issue Details

IDProjectCategoryView StatusLast Update
0005035JEDI VCL00 JVCL Componentspublic2011-06-10 16:10
ReporterLastRomanticAssigned Tojfudickar 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.39 
Target VersionFixed in Version3.40 
Summary0005035: TJvFormStorage not restore TPageControl.ActivePage
DescriptionTJvFormStorage raises exception "Then component named "xxx" already exists"
TagsNo tags attached.

Activities

2009-11-24 07:20

 

store error.zip (11,571 bytes)

obones

2009-12-04 15:27

administrator   ~0016945

Thanks for this, we will review it

jfudickar

2009-12-26 22:33

developer   ~0017026

I've changed the handling of the TJvPropertyStorage.ReadProperty and TJvPropertyStorage.WriteProperty procedures. Now component properties are no longer stored with all the properties. only the name is stored. When reading the stored name the component is searched in the list of all components.

Someone else should have a look on this changes.

The change is commited to svn with revision 12625.

jfudickar

2009-12-26 22:34

developer   ~0017027

Please verify my changes

obones

2009-12-28 16:36

administrator   ~0017031

They look fine, except for this test:

        if Assigned(SearchOwner.Owner) then
          SearchOwner := SearchOwner.Owner
        else
          SearchOwner := nil;


It is useless as if SearchOwner.Owner is not Assigned, hence nil, you assign nil to SearchOwner.
This could thus be simplified as this:

        SearchOwner := SearchOwner.Owner

I'll let you do the change, unless you want me to do it

Regards
Olivier

jfudickar

2009-12-29 10:17

developer   ~0017042

Done

Issue History

Date Modified Username Field Change
2009-11-24 07:20 LastRomantic New Issue
2009-11-24 07:20 LastRomantic File Added: store error.zip
2009-12-04 15:27 obones Note Added: 0016945
2009-12-04 15:27 obones Status new => acknowledged
2009-12-26 22:33 jfudickar Assigned To => jfudickar
2009-12-26 22:33 jfudickar Note Added: 0017026
2009-12-26 22:34 jfudickar Note Added: 0017027
2009-12-26 22:34 jfudickar Status acknowledged => feedback
2009-12-28 16:36 obones Note Added: 0017031
2009-12-29 10:17 jfudickar Note Added: 0017042
2010-06-07 13:54 obones Status feedback => resolved
2010-06-07 13:54 obones Fixed in Version => Daily / SVN
2010-06-07 13:54 obones Resolution open => fixed
2011-06-10 16:10 obones Fixed in Version Daily / SVN => 3.40