Project JEDI - Issue Tracker - ISSUES

0005783: Add feature: JV Docking should notify client TForms when they are docked and undocked.

From JVCL newsgroups:

I am willing to add the following feature to JvDocking...

Saw this question on StackOverflow:
http://stackoverflow.com/questions/9068016/delphi-jvdockserver-jvdockclient [^]

Problem:
TForm has events OnUnDock and OnEndDock, but these are not fired when Jedi
JvDocking does a dock or undock operation. There are also no "on dock" or
"on float" events available anywhere in the code. This seems like a design
oversight by the original Chinese Delphi developers who contributed the
original JvDocking code, which I have done some improvements on.

My answer is that JvDocking does not support it, but I can fix it so it
does. Any JVCL devs have an opinion on this? SHould I fix it?

In short, the JvDocking code in JvDockSupportControl.pas needs to check for
Dock Client = TForm, and check if TForm.OnUnDock is assigned, and if so,
fire an event so that the form is notified that it is being undocked. Same
approach will work for Docking.

0004894: GetDockedControls(WinControls) function always returns zero (DockingInCode example)

Reproduce: Try the DockingInCode example and add a few Sibling dock-forms.
The placing of the forms should be related to the amount of docked forms using the GetDockedControls(WinControls : TList) function. Yet the function always returns a list with 0 items.

0005023: ManualTabDock fails to work first time and works incorrectly subsequent times, Dock to Tab Grabber invisibility.

This is reproducable in the DockingInCode demo project but applies to any custom project that uses ManualTabDock to dock programmatically.

Change the tab dock button functionality to create tabs to the RightDockPanel instead of custom.
Start the docking in code demo and click the tab dock button.
Instead of creating 3 tabs docked to the right, it creates a blank dock panel
Click the button again will now create 3 tabs docked to the Right Dock Panel but these windows will not resize with the panel.

If you create windows via another method and tab dock them via drag/drop, everything works as it should. It seems like ManualTabDock is not working correctly.

Also, workaround shown in comments, solves initial problem, but makes the Dock To Tabs grabber (a custom version of the windows titlebar nonclient area similar to the top of MDI windows) is not visible, preventing you from seeing the window caption (title) or closing tabs.

0005773: The component always reload the form size even the option [fpSize] isn't checked

I only tested this with a window formstyle set to .

Steps to reproduce the bug :

- Create a simple project with a single form.
- Set the form's property to .
- Put on the form a TJvAppRegistryStorage component.
- Put on the form a TJvFormStorage component linked with the previous TJvAppRegistryStorage.
- Select the component and set the property to [fpSize, fpLocation]
- Compile and run the project. When the application is loaded, note the size of the form.
- Stop the execution of the project and modify the property of the component to [fpLocation].
- Modify the size of the form in design mode, recompile and reexecute the application.
- The form have the same size than the first time. The haven't the option [fpSize] checked but still reload the first size saved.

0005782: JVScheduledevents doesn't load all settings after Revision 11163

After revision JVScheduledEvents doesn't load all settings anymore.
The error is located in the TJvEventCollectionItem.Loadstate procedure.

0005781: Install failed with an error : Invalid Document: Unexpected text in file prolog at position 1

Install failed with an error : Invalid Document: Unexpected text in file prolog at position 1

Steps:
Update your SVN repository
Run "Install.Bat"

Act: installer is compiled but failed with the above error message
Expt: installer should display package option

0005779: Coreide error

Version Info:
Delphi and C++ Builder 2010 Updt 4
Rad Studio 2010 Help Updt 3
Delphi and C++ Builder 2010 Updt 5 (Database5)
Jedi 2.4.5.0

Making changes to a proj, run, build raises this exception. Also get the rtl140.bpl error after this.

Have chkd Lib path for invalid paths.

Have a JVCL error too, which is not consistent.

0005780: FileSearch Demo broken on XE2 WIN7 x64

I've compiled the demo on Win7 x64 using XE2 when I set a last changed after date it won't find any files.

0005754: JclCreateThreadStackTrace fails unpredictably on Win7 64 bit

I noticed some tools using JclDebug didn't produce a stack-trace, while others did. After some digging, this turned out to be caused by a failing call to GetThreadContext in JclCreateThreadStackTrace. According to http://stackoverflow.com/a/4705201/12170, [^] the argument passed to GetThreadContext needs to be 16-byte aligned, if that isn't the case, you'll get a : 'System Error. Code: 998. Invalid access to memory location'.

Once I figured that out, the fix was rather easy. Please commit the following fix to the JclDebug. Thanks!

0005772: JclPrint settings corruption bugfixes

JclPrint loses printer settings. Following are reasons.

1. Uses Byte for storing printer config data which causes data loss say when there are more than 255 paper sizes.

2. Doesn't lock global memory handle while working on it which can mean there is corruption.

3. Printer drivers can have extra configuration information, that is not windows standard. Windows allows driver developers to store extra driver information separately. This configuration is lost as this is not currently persisted to ini file.

4. Using TIniFile in SaveToIniFile() and ReadFromIniFile() truncates data to be stored. This is particularly relevant to the Printer Driver Extra Private data, as this can be quite long (this is stored in Hex encoding by TCustomIniFile.SaveBinaryStream).

5. ReadFromIniFile() and SaveToIniFile() cannot be overridden currently which I found useful to do in a descendent class.

0005771: EJclSimpleXMLError: Invalid Document: Unexpected text in file prolog at position

In the moment whenever I try to open an xml file I've got the named exception.

Can't say why.

Eaysiest Test Application:
\jvcl\examples\JvSimpleXML\

I will attach the error log also.

0005701: JCL Version Control Integration doesn't work with SVN 1.7 anymore

After upgrading TortoiseSVN from v1.6.x to version 1.7, the JCL version control expert doesn't work anymore on single files; the menu items are grayed out.
Operations on folders are still working.

0005775: Installation Failure XE

D/L 2.3.1.4197 and attempted to install. Errors were with .hpp files.

Then D/L daily version 2.4.0.4344 and got the same errors.

0005770: Install does not compile with Delphi 7

Due to update in JclBase.pas for CheckOSError we get an error when compiling the installer with Delphi 7. Wrong parameter..

See line 529-535. Comes from revision 3677.

You have to set a conditional define to have earlier or same as F7 use
RaiseLastOSError; instead of RaiseLastOSError(ErrorCode);

This works:
{$IFNDEF RTL230_UP}
procedure CheckOSError(ErrorCode: Cardinal);
begin
if ErrorCode <> ERROR_SUCCESS then
{$if CompilerVersion <= 15}
RaiseLastOSError;
{$else}
RaiseLastOSError(ErrorCode);
{$ifend}
end;
{$ENDIF RTL230_UP}

Or use this with jedi.inc

{$IFDEF DELPHI8_UP}
RaiseLastOSError(ErrorCode);
{$ELSE}
RaiseLastOSError;
{$ENDIF}

0005690: Add option to use Delphi zlib

Currently, there are 3 methods to use ZLIB : ZLIB_LINKDLL, ZLIB_LINKONREQUEST and ZLIB_STATICLINK. I propose a ZLIB_USEDELPHIZLIB which uses Delphi's own Zlib unit.

This might involve a bit of work, but it could reduce executable size a bit (by preventing linking in multiple versions of the zlib OBJect files) and at the same time solves any 64 bit porting issues (as that seems to have been done by Embarcadero themselves already).

By the way : Now that Delphi XE2 has it's own System.ZLib unit, adding a HAS_UNIT_ZLIB define to the jcl.inc might be a good idea (and while we're at it, you another define, HAS_UNIT_ZIP, could be added for the System.Zip unit that comes with Delphi XE2).

0005685: download the version but comes without the installer executable

Hello, I need help installing jvcl, download and install the xe2, then download the latest versions and jvck jcl, jcl but when trying to install I get the following error.

Step one : download the version but comes without the installer executable
Step two : I came up with the Delphi executable and run the install.bat xe2 but got the following error:

Embarcadero C++ 6.41 for Win32 Copyright (c) 1993-2011 Embarcadero Technologies, Inc.
jcl_a2z.cpp:
Error E2209 jcl_a2z.cpp 2: Unable to open include file 'bzip2.hpp'
Error E2209 jcl_a2z.cpp 3: Unable to open include file 'Hardlinks.hpp'
Error E2209 jcl_a2z.cpp 4: Unable to open include file 'Jcl8087.hpp'
Error E2209 jcl_a2z.cpp 5: Unable to open include file 'JclAbstractContainers.hpp'
Error E2209 jcl_a2z.cpp 6: Unable to open include file 'JclAlgorithms.hpp'
Error E2209 jcl_a2z.cpp 7: Unable to open include file 'JclAnsiStrings.hpp'
Error E2209 jcl_a2z.cpp 8: Unable to open include file 'JclAppInst.hpp'
Error E2209 jcl_a2z.cpp 9: Unable to open include file 'JclArrayLists.hpp'
Error E2209 jcl_a2z.cpp 10: Unable to open include file 'JclArraySets.hpp'
Error E2209 jcl_a2z.cpp 11: Unable to open include file 'JclBase.hpp'
Error E2209 jcl_a2z.cpp 12: Unable to open include file 'JclBinaryTrees.hpp'
Error E2209 jcl_a2z.cpp 13: Unable to open include file 'JclCharsets.hpp'
Error E2209 jcl_a2z.cpp 14: Unable to open include file 'JclCIL.hpp'
Error E2209 jcl_a2z.cpp 15: Unable to open include file 'JclCLR.hpp'
Error E2209 jcl_a2z.cpp 16: Unable to open include file 'JclCOM.hpp'
Error E2209 jcl_a2z.cpp 17: Unable to open include file 'JclCompilerUtils.hpp'

0005778: JvDockServer. On another form i have JvDockClien

No undock notification

0005454: Patch to allow SVN version of Jcl to compile with latest SVN version of FreePascal compiler.

This patch only allows Jcl to compile with FPC.

0005777: Vista and onwards : OS terminates console application immidiately after returning from CtrlHandler procedure.

For proper shutdown of application there should be some way to add wait function after handling all other events in CtrlHandler.

Attached patch (JclConsole.pas.patch) gives one alternative option to solve this bug.

0005776: file JCLBASE.INC has syntax error

In the file cl\source\include\JCLBASE.INC will not compile in
Delphi 7 since RaiseLastOSError takes no parameters.
needs to be changed as follows

{$IFNDEF RTL230_UP}
procedure CheckOSError(ErrorCode: Cardinal);
begin
if ErrorCode <> ERROR_SUCCESS then
{$ifdef VER150}
RaiseLastOSError;
{$ELSE}
RaiseLastOSError(ErrorCode);
{$ENDIF VER150}
end;
{$ENDIF RTL230_UP}

0005765: Optionally use TIniFile in stead of TMemIniFile in TJvAppIniFileStorage

In some cases (when using multiple TJvAppIniFileStorage components pointing to the same file) it's required to write changed settings immediately to the Ini-file.

When using the TMemIniFile, these settings are only written in memory, so an other instance cannot read these settings.

When using TIniFile, the settings are written directly.

So I think it would be nice to have the user specify a property of the TJvAppIniFileStorage, which allows the user to determine which underlaying Ini-component he/she want's to use.

0005737: TJvDatabaseActionList

I have installed version 3.45 and now TJvDatabaseSingleRecordWindowAction raises AV.
I go to verify in the included example and TJvDatabaseActionList raises AV as well..

0005761: AnsiStrHashSet & WideStrHashSet raise access violations (HashingExample)

Try "AnsiStrHashSet" and "WideStrHashSet" in the HashingExample (common/containers/hashing/HashingExample), both raise access violations with line:
...
It := MySet.First;
while It.HasNext do
...

0005768: JvValidators problems clearing error indicators

As far as I can tell, TJvValidators fails to clear error indicators under the following circumstances:
- A validator failed validation (Valid := False) then was disabled (Enabled := False).
- A validator's ControlToValidate does not equal its ErrorControl.

In both cases, the problem appears to be with how the Controls array is handled in TJvValidators.Validate. The Controls array is intended to list controls whose error indicators should be cleared, but it's never initialized with the ControlToValidate properties for disabled validators, and it's never initialized with the ErrorControl properties, and on successful validation, the ErrorControl isn't cleared from Controls, even though ErrorControl is used to show the error indicator on failed validation.

0005774: Values by TJvValidateEdit multiplied by 10^NumberOfDecimals

Please change in JvJCLUtils the function _JvSafeStrToFloat() the next lines

-----------------------------------------------------------------------
{ Locale Handling logic October 2008 supercedes former StrToFloatUS functionality. }
{$IFDEF RTL150_UP}
LocalFormatSettings.ThousandSeparator := GetLocaleChar(LOCALE_SYSTEM_DEFAULT, LOCALE_STHOUSAND, '.');
LocalFormatSettings.DecimalSeparator := GetLocaleChar(LOCALE_SYSTEM_DEFAULT, LOCALE_SDECIMAL, '.');
{$ELSE}
-----------------------------------------------------------------------

to these lines:

-----------------------------------------------------------------------
{ Locale Handling logic October 2008 supercedes former StrToFloatUS functionality. }
{$IFDEF RTL150_UP}
LocalFormatSettings.ThousandSeparator := GetLocaleChar(LOCALE_USER_DEFAULT, LOCALE_STHOUSAND, '.');
LocalFormatSettings.DecimalSeparator := GetLocaleChar(LOCALE_USER_DEFAULT, LOCALE_SDECIMAL, '.');
{$ELSE}
-----------------------------------------------------------------------

This fucking bug caused us a headache and lot of time, because in our application the values were multiplied by 10^x (where x = number of decimals) everywhere the TJvValidateEdit is used. You can image which dramatic effects this has :(

Mainly on Terminal Systems we see this, because the DecimalSeparator in LOCALE_SYSTEM_DEFAULT is totally different from the LOCALE_USER_DEFAULT one.