Project JEDI - Issue Tracker
Mantis Bugtracker

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004174 [JEDI VCL] 00 JVCL Components crash always 2007-07-10 13:20 2007-10-12 06:57
Reporter Xire View Status public  
Assigned To obones
Priority normal Resolution fixed  
Status resolved   Product Version 3.32
Summary 0004174: TJvID3V2.Frames.Assign fails when source has multiple PRIV frames (fix included)
Description Hi,
I tried to assign frames from one TJvID3V2 to other TJvID3V2. This failed when source had multiple PRIV frames (I got error that TAG already contains PRIV frame). I checked code and only MCDI tag was not allowed to be several times in tag.

I added fix to JvID3v2Base.pas and now it works. Here's the fix:
I added this part ({ EA 10.07.2007 added fix } AFrameID <> fiCDID)


class function TJvID3BinaryFrame.CanAddFrame(AController: TJvID3Controller;
  AFrameID: TJvID3FrameID): Boolean;
begin
  { There may only be one 'MCDI' frame in each tag. }
  Result := ((AFrameID = fiCDID) and not AController.HasFrame(fiCDID)) or
    ({ EA 10.07.2007 added fix } AFrameID <> fiCDID)
or inherited CanAddFrame(AController, AFrameID);
end;

I attached modified JvID3v2Base.pas as well.
Additional Information
Tags No tags attached.
Attached Files ? file icon JvID3v2Base.pas [^] (277,880 bytes) 2007-07-10 13:20

- Relationships

-  Notes
(0013920)
obones (administrator)
2007-10-12 06:56

Thanks, this is now in SVN

- Issue History
Date Modified Username Field Change
2007-07-10 13:20 Xire New Issue
2007-07-10 13:20 Xire File Added: JvID3v2Base.pas
2007-10-12 06:56 obones Status new => resolved
2007-10-12 06:56 obones Fixed in Version => Daily / SVN
2007-10-12 06:56 obones Resolution open => fixed
2007-10-12 06:56 obones Assigned To => obones
2007-10-12 06:56 obones Note Added: 0013920


Mantis 1.1.6[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker