View Issue Details

IDProjectCategoryView StatusLast Update
0005200JEDI VCL00 JVCL Componentspublic2011-06-10 16:09
Reporteru_kornAssigned ToAHUser 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product VersionDaily / GIT 
Target VersionFixed in Version3.40 
Summary0005200: Patch for JvFooter.Pas to allow each Button to have its own width
DescriptionHi there,
i am using TJvFooter very often an till now it is nessesary that each Butten has the same width to have a good looking footer.
But in many cases it is a huge waste of space, one Button with a large caption requires the others to have the same width.
So i decided to make a patch.

I hope it is good as it needs to merge into the next version of JVCL
MfG

Uli
Additional Information73c73
< out BtnCount, BtnTotalSpc: Integer);
---
> out BtnCount, BtnTotalSpc, BtnLeft: Integer);
268c268
< out BtnCount, BtnTotalSpc: Integer);
---
> out BtnCount, BtnTotalSpc, BtnLeft: Integer);
281a282
> Inc(BtnLeft, TJvFooterBtn(Controls[Idx]).Width);
305c306
< FBtnCount, FBtnCount_2, FBtnSpace, FBtnSpace_2: Integer;
---
> FBtnCount, FBtnCount_2, FBtnSpace, FBtnSpace_2, FBtnLeft_2: Integer;
319a321
> FBtnLeft_2 := 0;
322c324
< FBtnSpace_2);
---
> FBtnSpace_2, FBtnLeft_2);
323a326
> FBtnLeft := 0;
325c328
< FBtnCount, FBtnSpace);
---
> FBtnCount, FBtnSpace, FBtnLeft);
328,329c331,332
< ((FBtnCount * FBtnWidth) + FBtnSpace) div 2 +
< (FBtnCount_2 * FBtnWidth) + FBtnSpace_2;
---
> (FBtnLeft + FBtnSpace) div 2 +
> (FBtnLeft_2 + FBtnSpace_2);
336a340
> FBtnLeft := 0;
338c342,343
< TJvFooterBtn(Controls[Idx]).Alignment, -1, FBtnCount, FBtnSpace);
---
> TJvFooterBtn(Controls[Idx]).Alignment, -1, FBtnCount, FBtnSpace,
> FBtnLeft);
340d344
< FBtnLeft := FBtnCount * FBtnWidth;
351a356
> FBtnLeft := 0;
353c358
< TJvFooterBtn(Controls[Idx]).Alignment, 1, FBtnCount, FBtnSpace);
---
> TJvFooterBtn(Controls[Idx]).Alignment, 1, FBtnCount, FBtnSpace, FBtnLeft);
355c360
< FBtnLeft := Width - ((FBtnCount + 1) * FBtnWidth);
---
> FBtnLeft := Width - (FBtnLeft + FBtnWidth);
TagsNo tags attached.

Activities

2010-03-16 14:15

 

JvFooter.diff (1,569 bytes)
73c73
<       out BtnCount, BtnTotalSpc: Integer);
---
>       out BtnCount, BtnTotalSpc, BtnLeft: Integer);
268c268
<   out BtnCount, BtnTotalSpc: Integer);
---
>   out BtnCount, BtnTotalSpc, BtnLeft: Integer);
281a282
>       Inc(BtnLeft, TJvFooterBtn(Controls[Idx]).Width);
305c306
<   FBtnCount, FBtnCount_2, FBtnSpace, FBtnSpace_2: Integer;
---
>   FBtnCount, FBtnCount_2, FBtnSpace, FBtnSpace_2, FBtnLeft_2: Integer;
319a321
>             FBtnLeft_2 := 0;
322c324
<               FBtnSpace_2);
---
>               FBtnSpace_2, FBtnLeft_2);
323a326
>             FBtnLeft := 0;
325c328
<               FBtnCount, FBtnSpace);
---
>               FBtnCount, FBtnSpace, FBtnLeft);
328,329c331,332
<               ((FBtnCount * FBtnWidth) + FBtnSpace) div 2 +
<               (FBtnCount_2 * FBtnWidth) + FBtnSpace_2;
---
>               (FBtnLeft + FBtnSpace) div 2 +
>               (FBtnLeft_2 + FBtnSpace_2);
336a340
>             FBtnLeft := 0;
338c342,343
<               TJvFooterBtn(Controls[Idx]).Alignment, -1, FBtnCount, FBtnSpace);
---
>               TJvFooterBtn(Controls[Idx]).Alignment, -1, FBtnCount, FBtnSpace,
>               FBtnLeft);
340d344
<             FBtnLeft := FBtnCount * FBtnWidth;
351a356
>             FBtnLeft := 0;
353c358
<               TJvFooterBtn(Controls[Idx]).Alignment, 1, FBtnCount, FBtnSpace);
---
>               TJvFooterBtn(Controls[Idx]).Alignment, 1, FBtnCount, FBtnSpace, FBtnLeft);
355c360
<             FBtnLeft := Width - ((FBtnCount + 1) * FBtnWidth);
---
>             FBtnLeft := Width - (FBtnLeft + FBtnWidth);
JvFooter.diff (1,569 bytes)

AHUser

2010-03-16 22:21

developer   ~0017306

Patch applied to SVN head.

Issue History

Date Modified Username Field Change
2010-03-16 14:15 u_korn New Issue
2010-03-16 14:15 u_korn File Added: JvFooter.diff
2010-03-16 22:21 AHUser Note Added: 0017306
2010-03-16 22:21 AHUser Status new => resolved
2010-03-16 22:21 AHUser Fixed in Version => Daily / SVN
2010-03-16 22:21 AHUser Resolution open => fixed
2010-03-16 22:21 AHUser Assigned To => AHUser
2011-06-10 16:09 obones Fixed in Version Daily / SVN => 3.40