View Issue Details

IDProjectCategoryView StatusLast Update
0006060JEDI VCL00 JVCL Componentspublic2013-01-26 21:47
ReporterKarlheinzAssigned Tojfudickar 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product VersionDaily / GIT 
Target VersionFixed in Version 
Summary0006060: Hints and Warning under XE3 for not specified units and deprecated functions
DescriptionPlease add System.UITypes, System.Types to several units (see compiler messages below) and add functionality for overloaded method of "InternalGotoBookmark".


Thank you very much.
Steps To Reproduce[dcc32 Warning] JvDBUtils.pas(935): W1000 Symbol 'InternalGotoBookmark' is deprecated: 'Use overloaded method instead'
[dcc32 Hint] JvDBRadioPanel.pas(204): H2443 Inline function 'TList.Remove' has not been expanded because unit 'System.Types' is not specified in USES list
[dcc32 Hint] JvComputerInfoEx.pas(1510): H2443 Inline function 'TFont.GetStyle' has not been expanded because unit 'System.UITypes' is not specified in USES list
[dcc32 Hint] JvComputerInfoEx.pas(2788): H2443 Inline function 'Point' has not been expanded because unit 'System.Types' is not specified in USES list
[dcc32 Hint] JvMenus.pas(1256): H2443 Inline function 'TFont.GetStyle' has not been expanded because unit 'System.UITypes' is not specified in USES list
[dcc32 Hint] JvErrorIndicator.pas(612): H2443 Inline function 'TList.Extract' has not been expanded because unit 'System.Types' is not specified in USES list
[dcc32 Hint] JvColorCombo.pas(616): H2443 Inline function 'TBrush.GetColor' has not been expanded because unit 'System.UITypes' is not specified in USES list
[dcc32 Hint] JvGradient.pas(242): H2443 Inline function 'TBrush.GetColor' has not been expanded because unit 'System.UITypes' is not specified in USES list
[dcc32 Hint] JvAppEvent.pas(322): H2443 Inline function 'TList.Remove' has not been expanded because unit 'System.Types' is not specified in USES list
[dcc32 Hint] JvThread.pas(827): H2443 Inline function 'TThreadList.Remove' has not been expanded because unit 'System.Types' is not specified in USES list
[dcc32 Hint] JvThread.pas(1056): H2443 Inline function 'MessageDlg' has not been expanded because unit 'System.UITypes' is not specified in USES list
[dcc32 Hint] JvMRUManager.pas(500): H2443 Inline function 'TList.Remove' has not been expanded because unit 'System.Types' is not specified in USES list
TagsNo tags attached.

Activities

obones

2013-01-15 16:16

administrator   ~0020386

Please provide a Tortoise SVN diff file with the changes

2013-01-15 17:37

 

JVCLDiffFor_System.Types_System.UiTypes.diff (3,827 bytes)
Index: JvAppEvent.pas
===================================================================
--- JvAppEvent.pas	(revision 13494)
+++ JvAppEvent.pas	(working copy)
@@ -45,6 +45,9 @@
   {$ENDIF UNITVERSIONING}
   Windows, Messages,
   SysUtils, Classes, Controls, Graphics, Forms, ActnList,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.Types,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvTypes, JvComponentBase;
 
 const
Index: JvColorCombo.pas
===================================================================
--- JvColorCombo.pas	(revision 13494)
+++ JvColorCombo.pas	(working copy)
@@ -43,6 +43,9 @@
   {$ENDIF UNITVERSIONING}
   Windows, Messages,
   Classes, Controls, Dialogs, Graphics,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.UITypes,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvCombobox;
 
 type
Index: JvComputerInfoEx.pas
===================================================================
--- JvComputerInfoEx.pas	(revision 13494)
+++ JvComputerInfoEx.pas	(working copy)
@@ -50,6 +50,10 @@
   Windows, Messages, SysUtils, ShlObj, ShellAPI,
   Classes, Graphics, Controls,
   JclWin32, JclSysInfo,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.Types,
+  System.UITypes,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvJVCLUtils, JvComponentBase, JvTypes;
 
 {$HPPEMIT '#include <dbt.h>'}
Index: JvDBRadioPanel.pas
===================================================================
--- JvDBRadioPanel.pas	(revision 13494)
+++ JvDBRadioPanel.pas	(working copy)
@@ -40,6 +40,9 @@
   Windows,
   Messages,
   Classes, Controls, StdCtrls, DB, DBCtrls,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.Types,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvExtComponent;
 
 type
Index: JvErrorIndicator.pas
===================================================================
--- JvErrorIndicator.pas	(revision 13494)
+++ JvErrorIndicator.pas	(working copy)
@@ -45,6 +45,9 @@
   JclUnitVersioning,
   {$ENDIF UNITVERSIONING}
   Windows, Classes, Graphics, Controls, ImgList,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.Types,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvComponentBase;
 
 type
Index: JvGradient.pas
===================================================================
--- JvGradient.pas	(revision 13494)
+++ JvGradient.pas	(working copy)
@@ -35,6 +35,9 @@
   {$ENDIF UNITVERSIONING}
   Windows, Messages, Graphics, Controls,
   SysUtils, Classes,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.UITypes,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvTypes, JvComponent;
 
 type
Index: JvMenus.pas
===================================================================
--- JvMenus.pas	(revision 13494)
+++ JvMenus.pas	(working copy)
@@ -36,6 +36,9 @@
   {$ENDIF UNITVERSIONING}
   Windows, Messages, SysUtils, Contnrs, Graphics, Controls, Forms, Classes,
   ExtCtrls, ImgList, Menus,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.UITypes,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvWndProcHook, JVCLVer;
 
 const
Index: JvMRUManager.pas
===================================================================
--- JvMRUManager.pas	(revision 13494)
+++ JvMRUManager.pas	(working copy)
@@ -38,6 +38,9 @@
   {$ENDIF UNITVERSIONING}
   SysUtils, Classes,
   Windows, Menus, Graphics, Controls, Forms,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.Types,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvFormPlacement, JvAppStorage, JvComponentBase;
 
 type
Index: JvThread.pas
===================================================================
--- JvThread.pas	(revision 13494)
+++ JvThread.pas	(working copy)
@@ -34,6 +34,10 @@
   JclUnitVersioning,
   {$ENDIF UNITVERSIONING}
   Windows, SysUtils, Classes, SyncObjs, Controls, ExtCtrls, Forms, Dialogs,
+  {$IFDEF HAS_UNIT_SYSTEM_UITYPES}
+  System.Types,
+  System.UITypes,
+  {$ENDIF HAS_UNIT_SYSTEM_UITYPES}
   JvTypes, JvComponentBase, JvComponent;
 
 type

Karlheinz

2013-01-15 17:51

reporter   ~0020392

I have added the diff file for System.Types and System.UITypes.
Maybe it is better to rename the HAS_UNIT_SYSTEM_UITYPES
And use in general something like HAS_NEW_NAMESPACE_D16UP.
I am not sure if NAMESPACE is the right word for it.

I will check if I can provide a solution for the bookmark issue.

Issue History

Date Modified Username Field Change
2013-01-13 08:32 Karlheinz New Issue
2013-01-15 16:16 obones Note Added: 0020386
2013-01-15 16:16 obones Status new => feedback
2013-01-15 17:37 Karlheinz File Added: JVCLDiffFor_System.Types_System.UiTypes.diff
2013-01-15 17:51 Karlheinz Note Added: 0020392
2013-01-26 21:47 jfudickar Status feedback => resolved
2013-01-26 21:47 jfudickar Resolution open => fixed
2013-01-26 21:47 jfudickar Assigned To => jfudickar