View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006348 | JEDI Code Library | JclCompression | public | 2014-10-30 16:35 | 2014-10-30 16:35 |
| Reporter | ldsandon | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | ||
| Product Version | Version 2.5 (Subversion repository/Daily zips) | ||||
| Target Version | Fixed in Version | ||||
| Summary | 0006348: Wrong call to SysErrorMessage() in SevenzipCheck() | ||||
| Description | SevenZipCheck() calls SysErrorMessage() when raising an exception, but: 1) SevenZip APIs return an HRESULT, which is not handled by SysErrorMessage() and may return a wrong and deceiveing message. For example if a call returns S_FALSE (which is defined as $00000001), a call to SysErrorMessage() will return as if it was called with ERROR_INVALID_FUNCTION (which is 1). 2) The real error code is not returned in the function HRESULT return value, but is for example returned in the SetOperationResult() methods of some callback interfaces. If a function call doesn't succeed, only the HRESULT should be returned in the exception, it doesn't look 7zip uses fully meaningful HRESULT codes. | ||||
| Tags | No tags attached. | ||||
| Fixed in GIT commit | |||||
| Fixed in SVN revision | |||||
| IDE version | All | ||||
