View Issue Details

IDProjectCategoryView StatusLast Update
0006518JEDI VCL00 JVCL Componentspublic2019-04-30 16:14
ReporterandreykorolAssigned Toobones 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in VersionDaily / GIT 
Summary0006518: TJvHidDeviceController - missed OnDeviceDataError handler setup
DescriptionTJvHidDevice.CtlCreate constructor is missing setting Controller.OnDeviceDataError to OnDataError. So, in this way TJvHidDeviceReadThread.DoDataError will never call Device.FDataError (user event).
fix patch:
-------------------------------------------------------------------------
diff --git a/JvHidControllerClass.pas b/JvHidControllerClass.pas
index b1f43b2..9264a6e 100644
--- a/JvHidControllerClass.pas
+++ b/JvHidControllerClass.pas
@@ -807,6 +807,7 @@ begin
   FDataThread := nil;
   OnData := Controller.OnDeviceData;
   OnUnplug := Controller.OnDeviceUnplug;
+ OnDataError := Controller.OnDeviceDataError;
 
   FHidFileHandle := CreateFile(PChar(PnPInfo.DevicePath), GENERIC_READ or GENERIC_WRITE,
     FILE_SHARE_READ or FILE_SHARE_WRITE, nil, OPEN_EXISTING, 0, 0);
-------------------------------------------------------------------------
TagsNo tags attached.

Activities

obones

2018-07-18 15:47

administrator   ~0021504

Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.

mh

2019-04-28 10:45

reporter   ~0021772

Created pull request for this:
https://github.com/project-jedi/jvcl/pull/107

Issue History

Date Modified Username Field Change
2016-07-21 15:11 andreykorol New Issue
2018-07-18 15:47 obones Note Added: 0021504
2018-07-18 15:47 obones Status new => feedback
2019-04-28 10:45 mh Note Added: 0021772
2019-04-30 16:14 obones Status feedback => resolved
2019-04-30 16:14 obones Fixed in Version => Daily / GIT
2019-04-30 16:14 obones Resolution open => fixed
2019-04-30 16:14 obones Assigned To => obones