Project JEDI - Issue Tracker
Mantis Bugtracker

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006622 [JEDI VCL] 00 JVCL Components minor have not tried 2018-03-11 13:22 2018-03-15 21:51
Reporter dummzeuch View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version Daily / GIT
Summary 0006622: wrong use of {$ifdef DELPHI2009OROLDER} in JvGnuGettext
Description In TGnuGettextInstance.TranslateStrings there are various places where the {$ifdef DELPHI2009OROLDER} is used. TStringList.OwnsObjects was introduced in later versions, so it should actually be $ifndef:

line 2122:
  {$ifdef DELPHI2009OROLDER}
  originalOwnsObjects: Boolean;
  {$endif}

Line 2132:
    {$ifdef DELPHI2009OROLDER}
    originalOwnsObjects := False; // avoid warning
    {$endif}

Line 2157:
        {$ifdef DELPHI2009OROLDER}
        if Assigned(slAsTStringList) then begin
          originalOwnsObjects := slAsTStringList.OwnsObjects;
          slAsTStringList.OwnsObjects := False;
        end;
        {$endif}

Line 2183:
          {$ifdef DELPHI2009OROLDER}
          if Assigned(slAsTStringList) then
            slAsTStringList.OwnsObjects := originalOwnsObjects;
          {$endif}
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0021457)
pyscripter (reporter)
2018-03-12 03:38

Actually the problem is the misnaming of the conditionals.
DELPHI2009OROLDER means newer!!

See
http://issuetracker.delphi-jedi.org/view.php?id=6607 [^]
(0021458)
pyscripter (reporter)
2018-03-12 04:49

In other words it works correctly but it so confusing.
(0021459)
AHUser (developer)
2018-03-15 21:51
edited on: 2018-03-15 21:52

The JvGnugettext unit is a copy of the dxgettext project ( http://dxgettext.po.dk [^] ). The unit was once adjusted to the JEDI code style but that made it impossible to update the unit. The current version of the unit is the code of the original project from 2012 with some minor bugfixes.


- Issue History
Date Modified Username Field Change
2018-03-11 13:22 dummzeuch New Issue
2018-03-12 03:38 pyscripter Note Added: 0021457
2018-03-12 04:49 pyscripter Note Added: 0021458
2018-03-15 21:51 AHUser Note Added: 0021459
2018-03-15 21:52 AHUser Note Edited: 0021459


Mantis 1.1.6[^]
Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker