View Issue Details

IDProjectCategoryView StatusLast Update
0006309JEDI VCL00 JVCL Componentspublic2015-09-21 17:47
ReporterZENsanAssigned ToAHUser 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformAnyOSWindowsOS VersionAny
Product VersionDaily / GIT 
Target VersionFixed in Version3.49 
Summary0006309: Unsafe code in the TJvDebugHandler.ExceptionNotifier
DescriptionExceptionStringList is freed but not niled in the method. In a complex call order we cannot determine if the ExceptionStringList is released or not. I think FreeAndNil should be called on this PUBLIC field, which is accessible from outside. Otherwise invalid pointer lives in the component public section.
TagsNo tags attached.

Activities

2014-07-25 17:21

 

JvDebugHandler.patch (569 bytes)
diff --git "a/C:\\Users\\dev23\\AppData\\Local\\Temp\\TortoiseGit\\JvDE20B.tmp\\JvDebugHandler-8b6e209-left.pas" "b/C:\\COMPS\\jvcl_git\\jvcl\\run\\JvDebugHandler.pas"
index 9a11504..9d2ffa7 100644
--- "a/C:\\Users\\dev23\\AppData\\Local\\Temp\\TortoiseGit\\JvDE20B.tmp\\JvDebugHandler-8b6e209-left.pas"
+++ "b/C:\\COMPS\\jvcl_git\\jvcl\\run\\JvDebugHandler.pas"
@@ -308,7 +308,7 @@ begin
       else
         Application.ShowException(Exception(ExceptObj));
     finally
-      ExceptionStringList.Free;
+      FreeAndNil(ExceptionStringList);
     end;
   end;
 end;
JvDebugHandler.patch (569 bytes)

AHUser

2014-07-25 17:38

developer   ~0021007

Patch applied to master branch.

Issue History

Date Modified Username Field Change
2014-07-25 17:21 ZENsan New Issue
2014-07-25 17:21 ZENsan File Added: JvDebugHandler.patch
2014-07-25 17:38 AHUser Note Added: 0021007
2014-07-25 17:38 AHUser Status new => resolved
2014-07-25 17:38 AHUser Fixed in Version => Daily / GIT
2014-07-25 17:38 AHUser Resolution open => fixed
2014-07-25 17:38 AHUser Assigned To => AHUser
2015-09-21 17:47 obones Fixed in Version Daily / GIT => 3.49