View Issue Details

IDProjectCategoryView StatusLast Update
0000200JEDI VCL00 JVCL Componentspublic2005-08-10 08:34
ReporterAriochAssigned Toobones 
PrioritynoneSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.32 
Target VersionFixed in Version3.10 
Summary0000200: update to JvComCtrls: TJVPageControl
Description0) {$IFDEF LINUX} This unit is only supported on Windows! {$ENDIF}
I think there should not be such a line!
We should check for {$IfNDef WIN32} instead
Or better we should rely on Jedi.Inc - see extra info in attached file.

Also i integrated one of my components - i contributed it as PCHints.zip. Later i'll do it with RxCheckBox.

Also - icon for TJvPageControl updated.
I wonder, Do delphi support palletised 16-coloured bitmaps?
ImageEdit - do not :(
TagsNo tags attached.

Activities

2002-07-21 19:00

 

PageControl.zip (13,689 bytes)

Arioch

2002-07-25 04:54

developer   ~0000309

i fix (re-query hint, when mouse is moving over items of the control)

In CMShowHitn method:
Find:
    if Choice=cT then HintStr:=GetShortHint(Tab.Hint);
Change to:
    if Choice=cT then begin
       HintStr:=GetShortHint(Tab.Hint);
       CursorHint:=TabRect(TabNo);
    end;

user72

2003-06-18 06:25

  ~0002226

This will be revisited when updating to JVCL 3.0

user72

2003-06-25 15:37

  ~0002260

I tested this but it seems CM_HINTSHOW is never called (in D6)? Also, D6 and D7 displays the tabs hint when the mouse is over the tab client area and the page control hint when the mouse is over the tab. Isn't this what your code does as well (or would do if it worked)?

2003-06-27 14:43

 

hpc_demo.7z (12,253 bytes)

Arioch

2003-06-27 14:46

developer   ~0002265

as: demo is for Delphi7, You may unpack with http://sevenzip.sf.net

by default it works exactly in standard PageControl manner.
But change HintSource property - and try again.

Just hold the mouse (i needed to click on PageControl before :( ) over tab #3 (not sheet) for both PageControls and compare hints.

user72

2003-06-28 08:17

  ~0002268

Please use zip when you upload files. I am not going to install yet another compression program just to unpack this demo and I seriously doubt that anyone else will either.

Arioch

2003-06-28 15:50

developer   ~0002278

I'm seriously thinking about using 7zip:

Solid archiving will save A LOT of spaces.
Some times ago You told RAR will never be used since it is commercial software.
No i'd like You to consider 7-zip cause it is GPLed freeware and packs the same good as RAR (smth better, smth worse)
And to the end it has it's own 2-paneled file manager :-)

I'll repack to ZIP, but indeed 7-zip is MUCH stronger than any other zero-priced archiver, and there is nothing bad to give it a try.


also i'll post a sreenshot, so take a look at hints displayed for:
TForm, TabSheet1 for both original and modified TPageControl, tab associated to TabSheet1 for both..., tab associated to TabSheet3....

And sure you can take latest sources from demo, or You can take original zip and apply the patch above :-)

2003-06-28 15:50

 

200-hpc_demo.png (12,125 bytes)
200-hpc_demo.png (12,125 bytes)

2003-06-28 15:52

 

200-hpc_demo.Zip (13,325 bytes)

anonymous

2003-08-27 04:04

viewer   ~0002470

PS: latest separate version is http://arioch.nm.ru/Delphi/PCHints/
Currently there is nothing different from this one (i hope)

Arioch

2004-11-11 15:04

developer   ~0005612

The bugs are still here.
Year after i told about them in jedi.vcl newsgroup and gave fixes, and heard a replies...

Pity.
I wonder why this donation was accepted, if later it was broken and was never fixed ?

2004-11-11 15:05

 

TestCase_Sources.zip (6,242 bytes)

2004-11-11 15:05

 

TestCase_EXE.zip (190,369 bytes)

user72

2004-11-12 11:22

  ~0005618

What bugs? The only difference I can see is the CursorRect assignment for Tab hints. Is there any more?

Arioch

2004-11-12 12:52

developer   ~0005619

There were more. In the versions i posted to jedi.vcl.
I don't have them on the fingertips, so i hope someone else do.

Did You run testcase?
There is told all the troubles.

user72

2004-11-12 13:26

  ~0005620

>Did You run testcase?
I made my own with the TJvPageControl and the only issue is that when the mouse is over the tab page (not the tab itself), no CM_HINTSHOW is sent to the PageControl, so we can't modify the behavior in that case.

Other than that, i couldn't find anything that was misbehaving.

Arioch

2004-11-12 14:19

developer   ~0005621

Let's discuss it in the newsgroup beter, ok ?

>no CM_HINTSHOW is sent to the PageControl, so we can't modify the behavior in that case.
And it should not IMHO, so i do not know, what you called an issue and how You need to change behavior.

>> Did You run testcase? There is told all the troubles
> I made my own
I just want to repeat, that TestCase is self-documented, as every good testcase is to be.
I can paste DFM text here of course, but it is simplier IMHO to run test and read what is written on its form :-)

user72

2004-11-13 14:30

  ~0005624

An update is committed to CVS

obones

2004-11-30 04:38

administrator   ~0005775

Please try with the latest zip files and tell us if the problem is fixed. These files are available here:

http://jvcl.sf.net/daily/
http://jcl.sf.net/daily/

If we don't hear from you in the next 14 days, we will consider this issue fixed.

Arioch

2004-12-09 11:21

developer   ~0005845

i did not look the code yet, i just recompiled my testcase with daily update

Test 2 - seems to be fixed
Test 1 - Move mouse cursot over Tab 2 until hint for TabSheet 2 pops up.
Then move mouse to the right, until hint for the Main PageControl pops up.
After that move mouse back to Tab 2 - hint should change, but it does not.

obones

2005-08-10 08:34

administrator   ~0007782

I'm marking this as resolved because test 1 is ok.
Further to this, I tried to reproduce test 2, but the hint only shows up when the tabsheet is active, not when merely hovering its tab. Please post a new issue if need be.

Issue History

Date Modified Username Field Change
2004-01-27 01:51 user72 Status assigned => closed
2004-11-11 15:04 Arioch Status closed => feedback
2004-11-11 15:04 Arioch Resolution open => reopened
2004-11-11 15:04 Arioch Note Added: 0005612
2004-11-11 15:05 Arioch File Added: TestCase_Sources.zip
2004-11-11 15:05 Arioch File Added: TestCase_EXE.zip
2004-11-12 11:22 user72 Note Added: 0005618
2004-11-12 12:52 Arioch Note Added: 0005619
2004-11-12 13:26 user72 Note Added: 0005620
2004-11-12 14:19 Arioch Note Added: 0005621
2004-11-13 14:30 user72 Note Added: 0005624
2004-11-15 14:58 user72 Assigned To user72 =>
2004-11-30 04:38 obones Note Added: 0005775
2004-12-09 11:21 Arioch Note Added: 0005845
2005-08-10 08:34 obones Status feedback => resolved
2005-08-10 08:34 obones Resolution reopened => fixed
2005-08-10 08:34 obones Assigned To => obones
2005-08-10 08:34 obones Note Added: 0007782