View Issue Details

IDProjectCategoryView StatusLast Update
0003994JEDI VCL00 JVCL Componentspublic2007-01-05 02:05
ReporterWerewolfAssigned Toobones 
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionXP+SP2
Product VersionDaily / GIT 
Target VersionFixed in Version3.30 
Summary0003994: TJvCustomInspectorItem.SetEditCtrl crashes in unit JvInspector when custom edit control was created
Descriptionbefore replacing WindowProc of current EditCtrl we must check if it was set by InitEdit method
patch attached
TagsNo tags attached.

Activities

2006-11-09 00:30

 

JvInspector.patch (739 bytes)
Index: JvInspector.pas
===================================================================
--- JvInspector.pas	(revision 10960)
+++ JvInspector.pas	(working copy)
@@ -3995,7 +3995,7 @@
       NewItem := VisibleItems[Value]
     else
       NewItem := nil;
-
+    
     if not (csDestroying in ComponentState) then
       // bugfix WAP.  Why repaint the screen when the component is going away anyway.
       if DoBeforeItemSelect(NewItem) then
@@ -7024,6 +7024,7 @@
         if Assigned(EditCtrl) then
         begin
           {$IFDEF VCL}
+          if TMethod(EditCtrl.WindowProc).Code=@EditWndPrc then          
           EditCtrl.WindowProc := FEditWndPrc; //Edit_WndProc;
           {$ENDIF VCL}
           {$IFDEF VisualCLX}
JvInspector.patch (739 bytes)

Werewolf

2006-11-09 00:33

reporter   ~0010428

see also
Following Mantis 3391, setting the Focus may set EditCtrl to nil

obones

2007-01-05 02:04

administrator   ~0010546

This is now merged into SVN

Issue History

Date Modified Username Field Change
2006-11-09 00:30 Werewolf New Issue
2006-11-09 00:30 Werewolf File Added: JvInspector.patch
2006-11-09 00:33 Werewolf Note Added: 0010428
2007-01-05 02:04 obones Status new => resolved
2007-01-05 02:04 obones Fixed in Version => Daily / SVN
2007-01-05 02:04 obones Resolution open => fixed
2007-01-05 02:04 obones Assigned To => obones
2007-01-05 02:04 obones Note Added: 0010546