View Issue Details

IDProjectCategoryView StatusLast Update
0001831JEDI VCL00 JVCL Componentspublic2004-06-25 05:00
ReporterTaslerAssigned Touser72 
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0001831: JVStarfield flickering
Description
Hi Peter

JVStarfield is flickering in the latest CVS.
Check it, what's wrong?
TagsNo tags attached.

Activities

Tasler

2004-06-03 08:04

reporter   ~0004450

If you are checking this issue, please add "Visible" property to this component.
I know that when Active := False then Starfield is invisible...

But nice feature could be if Active = False and Visible := True,
then you will see static (stopped ) starfield...

Thanx

user72

2004-06-04 01:16

  ~0004461

Add this to the constructor:

constructor TJvStarfield.Create(AOwner: TComponent);
begin
  inherited Create(AOwner);
ControlStyle := ControlStyle + [csOpaque];
...

A rewrite of the paint procedure caused this problem...

user72

2004-06-04 01:18

  ~0004462

BTW, "Visible" is a standard property that denotes whether the control is showing at all or not.

Trying to reuse it as denoting whether the control is showing stars or not, is not good OOP practice.

I could probably add a "ClearStars" procedure that you could call when necessary.

Tasler

2004-06-05 01:07

reporter   ~0004473

Yes, you're absolutely right...

But, when you're talking about OOP...

property "Active" should only start/stop the starfield and not
To SHOW & START when "true", or HIDE & STOP when "false" as it is now (this is not so clear)...

Good "OOP" example can be TAnimate Delphi control. It has also "active"
and "visible" property, you know how it works...

Consider nice effect when starfield is "flying" and you can it suddenly stop it and after some period of time continue "flying" from this point...

So it is up to you, maybe you will agree a little with me :)

Cheers

user72

2004-06-05 04:50

  ~0004476

Actually, if you toggle the Active property, it does stop and start just as you request, at least in the latest CVS version.

user72

2004-06-07 01:21

  ~0004485

I've posted an update to CVS (fixed flicker and added Clear procedure + published Visible and useable events). Try it out and let me know what you think

Tasler

2004-06-07 03:27

reporter   ~0004486

I will do it with pleasure, then I tell you my experiences :).

Thanx for now

user72

2004-06-25 05:00

  ~0004621

No reply, so assuming it works

Issue History

Date Modified Username Field Change
2004-06-03 07:49 Tasler New Issue
2004-06-03 08:04 Tasler Note Added: 0004450
2004-06-04 01:16 user72 Note Added: 0004461
2004-06-04 01:18 user72 Note Added: 0004462
2004-06-04 01:35 user72 Status new => assigned
2004-06-04 01:35 user72 Assigned To => user72
2004-06-05 01:07 Tasler Note Added: 0004473
2004-06-05 04:50 user72 Note Added: 0004476
2004-06-07 01:21 user72 Note Added: 0004485
2004-06-07 03:27 Tasler Note Added: 0004486
2004-06-25 05:00 user72 Status assigned => resolved
2004-06-25 05:00 user72 Resolution open => fixed
2004-06-25 05:00 user72 Note Added: 0004621