View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6682 [JEDI VCL] 00 JVCL Components major always 2019-05-30 12:07 2019-05-31 18:58
Reporter: OuatuBogdan Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: loop on WM_DRAWITEM
Description: From last update:
at line: 1839 SetDefaultMenuFont(Screen.MenuFont)
in JvMenus: TJvPopupMenu.WMDrawItem starts a infinite loop with FORMS: TCustomForm.WndProc at WM_DRAWITEM.

Just right-click to get pop-up menu, draws menu items again an again.
Tags:
Steps To Reproduce:
Additional Information: remedy:
Canvas.Font := Screen.MenuFont;
instead of offending line
Attached Files: PopupTest.zip (54,740 bytes) 2019-05-31 18:56
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002739&type=bug
Notes
(0021855)
mh   
2019-05-31 18:58   
Hello,

I cannot reproduce your problem.
What I did can be seen in the attached demo.

1. Unzip it and run it.
2. right click into the edit at the bottom

On my Windows 10 x64 VM this opens a TJvPopupMenu with 2 entries, both call ShowMessage each and I do not see any flicker. I can click them and they bring up their message each.

=> how does your test case differ?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6683 [JEDI VCL] 00 JVCL Components minor always 2019-05-31 18:38 2019-05-31 18:47
Reporter: mh Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvFileListbox.AutoUpdate not working if Directory property changes
Description: With TJvFileListbox.AutoUpdate := true one can have a TJvFileListbox automatically refresh its contents if new files are being added to the directory or files are being deleted.

Unfortunatelly changing the .Directory property at runtime tries to update the internal notification component, but the way it uses does not work. If one only changes the directory property of the TJvChangeNotify component's Notofication[0] property it will not inform the OS about the change.
Tags:
Steps To Reproduce:
Additional Information: As I'm not sure how or whether we should fix TJvChangeNotify, I developed a workaround: deactivate notifications before assigning the directory, then reactivate them.

In order to show the failure run the attached demo and click on any folder in the directory list box. Then copy or create a .pas file in the folder you selected there. It will not immediately appear in the file list box. It appears if you go to another directory and back via the directory listbox.
Attached Files: FileListBoxTest.zip (54,509 bytes) 2019-05-31 18:38
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002738&type=bug
Notes
(0021854)
mh   
2019-05-31 18:47   
Pull request created:
https://github.com/project-jedi/jvcl/pull/133


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6462 [JEDI VCL] 00 JVCL Components major always 2015-10-22 20:08 2019-05-31 12:00
Reporter: arnikos Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: duplicate  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JVInterpreterTest Demo Error (confirmed but not resolved)
Description: Running JVInterpreterTest Demo when I select OLE Automation example, MSWord opens but when it tries to write something in the new document I get the following error:
201: Calling 'Insert' failed: Incompatible Types.
If I try to open a new document based on a MSWord template using
MSW.FileNew('<template name>');
I get the same error
201: Calling 'FileNew' failed: Incompatible Types.

IDE: Delphi 2010, JVCL 3.49 and Git
The same Demo runs perfectly with Delphi5 and JVCL V3.37

See my previous post 0006036
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021483)
obones   
2018-07-18 15:38   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021839)
mh   
2019-05-19 10:55   
This one is an exact duplicate of that one:
http://issuetracker.delphi-jedi.org/view.php?id=6036

Can we get it marked as such?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6361 [JEDI VCL] 00 JVCL Components minor always 2014-11-22 00:40 2019-05-29 10:10
Reporter: ricolebo Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvDBCombobox : Bug because search key is case insensitive
Description: When the keyList are like this : kkk;KKK,KkK ... the comboBox can't work because the indeOf to find the key is case insensitive and so the seach found always the first value of the list.

This bug can be simply fixed, just set the TSTringList.caseSensitive to true

I attach a demo to show you the bug and how to fix it.
Tags:
Steps To Reproduce:
Additional Information: The Fix : unit JvDBCombobox.pas

//=== { TJvCustomDBComboBox } ================================================

constructor TJvCustomDBComboBox.Create(AOwner: TComponent);
begin
  inherited Create(AOwner);
  ControlStyle := ControlStyle + [csReplicatable];
  FDataLink := TFieldDataLink.Create;
  FDataLink.Control := Self;
  FDataLink.OnDataChange := DataChange;
  FDataLink.OnUpdateData := UpdateData;
  FDataLink.OnEditingChange := EditingChange;
  FPaintControl := TPaintControl.Create(Self, 'COMBOBOX');
  FBeepOnError := False;

  FListSettings := TJvDBComboBoxListSettings.Create(Self);
  FValues := TStringList.Create;
  FValues.CaseSensitive := True; // Fix
  FValues.OnChange := ValuesChanged;
  FEnableValues := True;
  Style := csDropDownList;
end;

Attached Files: TJvDBComboBox.zip (19,369 bytes) 2014-11-22 00:40
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002594&type=bug
Notes
(0021847)
mh   
2019-05-20 21:40   
Pull request created and a property for controlling the search behavior added:
https://github.com/project-jedi/jvcl/pull/128
(0021851)
mh   
2019-05-28 22:42   
Can be closed now as the fix for this has been merged in!


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6332 [JEDI VCL] 00 JVCL Components major always 2014-10-02 10:01 2019-05-24 12:00
Reporter: lstauber Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Jvrollout realigns controls on collapse/expand
Description: create a rollout and place 2 panels with Align=alTop into it (panel1 lies now on the top of the panel2). if you start this application, collapse this rollout and expand it again, the panels are switched, the panel1 lies now below the panel2.
Tags:
Steps To Reproduce:
Additional Information: bug in the (relatively new) method CheckVisibility. The alignment must be disabled during the visibility setting task. 4 added lines are commented.

[code]

procedure TJvCustomRollOut.CheckChildVisibility;
  procedure GetChildVisibility;
  var
    I: Integer;
  begin
    if FChildControlVisibility = nil then
    begin
      FChildControlVisibility := TStringList.Create;
      FChildControlVisibility.Sorted := True;
    end;
    DisableAlign; // !!!!!!!!!!!!!! ADD THIS LINE !!!!!!!!!!!!!!
    for I := 0 to ControlCount - 1 do
      if (Controls[I] is TWinControl) and (TWinControl(Controls[I]).Visible) then
      begin
        FChildControlVisibility.AddObject(Controls[I].Name, Controls[I]);
        TWinControl(Controls[I]).Visible := False;
      end;
    EnableAlign; // !!!!!!!!!!!!!! ADD THIS LINE !!!!!!!!!!!!!!
  end;

  procedure SetChildVisibility;
  var
    I: Integer;
  begin
    if FChildControlVisibility <> nil then
    begin
      DisableAlign; // !!!!!!!!!!!!!! ADD THIS LINE !!!!!!!!!!!!!!
      for I := 0 to FChildControlVisibility.Count - 1 do
        if FindChildControl(FChildControlVisibility[I]) <> nil then
          TWinControl(FChildControlVisibility.Objects[I]).Visible := True;
      EnableAlign; // !!!!!!!!!!!!!! ADD THIS LINE !!!!!!!!!!!!!!
      FreeAndNil(FChildControlVisibility);
    end;
  end;
begin
  if csDesigning in ComponentState then
    Exit;

  if Collapsed then
    GetChildVisibility
  else
    SetChildVisibility;
end;
[/code]

This change could also bring some performance.
You can naturally also use try...finally :)

notice: I also do not understand, why the code only works with TWinControl and not with all TControls - perhaps from the old, removed method, that only worked with tabstops?!
Attached Files: rollout content moving.zip (4,859 bytes) 2014-12-05 11:38
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002599&type=bug
Notes
(0021079)
obones   
2014-12-04 15:00   
Please provide the zipped sources of a sample application showing this.
(0021130)
lstauber   
2014-12-05 11:40   
zipped sources uploaded
(0021814)
mh   
2019-05-05 09:37   
Created a pull request for this one:
https://github.com/project-jedi/jvcl/pull/121
(0021838)
mh   
2019-05-16 22:23   
My bad. Had deleted the branch too early so I created a new pull request for this one, I hope it is good enough now:
https://github.com/project-jedi/jvcl/pull/125


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6302 [JEDI VCL] 00 JVCL Components minor always 2014-07-09 17:11 2019-05-23 20:46
Reporter: cguser Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvDBGrid: dgIndicator option currently required to show TitlePopup
Description: Assigning a TPopupMenu to the grid's TitlePopup, (which has dgTitle on it's options) but no dgIndicator included, won't trigger the display of such menu when right clicking on the Title.
Tags:
Steps To Reproduce:
Additional Information: Seems an old bug spotted on JvDBGrid.pas 12831 2010-09-05,
however the latest version from
https://github.com/project-jedi/jvcl/blob/master/jvcl/run/JvDBGrid.pas
still has it: line 2418
{code}
      if (Button = mbRight) and
        (dgTitles in Options) and (dgIndicator in Options) and
        (Cell.Y = 0) then
      begin
{/code}

Why is dgIndicator required to show the TitlePopup?

The third condition of "and (dgIndicator in Options)" seems kinda lost in there.
Attached Files: Issue6302.zip (5,612 bytes) 2014-09-03 17:55
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002576&type=bug
Notes
(0021002)
cguser   
2014-07-16 13:31   
Hi Olivier, could you please check with Andreas if there is any reason to require the presence of dgIndicator to popup the TitlePopup menu?

I suspect that that isn't, and if so, the fix is just to remove the second condition on line 2419, where

" (dgTitles in Options) and (dgIndicator in Options) and"

becomes just
" (dgTitles in Options) and"

A workaround on every caller side is somewhat messy (catch mouse click, was it on title?, was it a right-click? is it internally reversed? etc...).

Thanks
(0021034)
obones   
2014-09-03 11:39   
Please provide the zipped sources of a sample application showing this
(0021046)
cguser   
2014-09-03 17:56   
Uploaded.
(0021850)
mh   
2019-05-23 20:46   
Pull request created:
https://github.com/project-jedi/jvcl/pull/132


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6328 [JEDI VCL] 00 JVCL Components tweak always 2014-09-13 13:15 2019-05-23 20:39
Reporter: moore Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvDBGrid focused cell does not draw like DBGrid
Description: After RAD XE, TDBGrid has been themed and so the TJvDBGrid
However, TJvDBGrid focused cell does not draw like DBGrid in color in Windows7/8.1

This problem does not occur with TStringGrid.

Thanks for your efforts..
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: Project3.dpr (234 bytes) 2014-12-11 14:11
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002601&type=bug
Projects.zip (1,699 bytes) 2014-12-11 14:13
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002602&type=bug
GridSel.jpg (49,432 bytes) 2014-12-11 14:13
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002603&type=bug
grdbug.jpg (67,980 bytes) 2015-04-28 15:38
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002615&type=bug
ThemeDBGrid.jpg (56,495 bytes) 2015-09-15 13:43
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002630&type=bug
Notes
(0021077)
obones   
2014-12-04 14:58   
Please provide the zipped sources of a sample application showing this.
(0021134)
moore   
2014-12-11 14:14   
Attached project and image showing the issue..
(0021162)
moore   
2015-04-28 15:39   
Moreover, I noticed that a fine line under the header (titles zone) does not appear in JvDBGrid (below). See attachement..
(0021170)
frank_jepsen   
2015-06-18 10:43   
I saw this bug also.
This patch seems to solve it:
--- a/jvcl/run/JvDBGrid.pas
+++ b/jvcl/run/JvDBGrid.pas
@@ -3425,7 +3425,7 @@ begin
         Indicator := 0
       else
         Indicator := 1; { multiselected and current row }
-// MsIndicators.BkColor := FixedColor;
+ MsIndicators.BkColor := FixedColor;
       ALeft := FixRect.Right - MsIndicators.Width - FrameOffs;
       if InBiDiMode then
         Inc(ALeft);
It reverts some change Obarden did. Without backgroud the triangle with dot is drawn transparently on a full triangle already drawn from TDBGrid.
(0021209)
moore   
2015-09-15 13:45   
After the changes commited, now they appear as in the last attached jpg.
For me it is acceptable, Do not know for others,
Thnx for your efforts :)
(0021241)
ZENsan   
2015-10-14 13:01   
It does work with the latest version, but raises another incompatible issue noted in 0006454.
(0021242)
moore   
2015-10-14 15:32   
Which Rad Studio version?
I do not see UseThemedSelection option in XE7 :(
(0021849)
mh   
2019-05-23 20:39   
Created this pull request for this issue as it has been approved:
https://github.com/project-jedi/jvcl/pull/131


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6419 [JEDI VCL] 00 JVCL Components tweak always 2015-07-12 05:47 2019-05-22 17:46
Reporter: Gustavo Costa Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Position of TJvDesktopAlert with multi screen
Description: When we are using the TJvDesktopAlert, with property Location.Position = dapBottomRight, with multi monitors, the alert is showed always in the main monitor.

I think that it is better to show the alert in bottom, right of the monitor where the active form is showing.

Or add this option in Location.Position.
Tags:
Steps To Reproduce:
Additional Information: I've tried and works using the follow code in the JvJVCLUtils.ScreenWorkArea function

Result := Screen.MonitorFromWindow(Screen.ActiveForm.Handle).WorkareaRect;
Attached Files: Mantis6419_JvDesktopAlertDemo.zip (5,387 bytes) 2019-05-04 12:55
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002722&type=bug
Mantis6419_JvDesktopAlertDemoNew.zip (54,057 bytes) 2019-05-04 13:07
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002723&type=bug
Notes
(0021195)
obones   
2015-09-14 11:26   
Please provide the zipped sources of a sample application showing this
(0021801)
mh   
2019-05-04 13:09   
The first attachment can be deleted, my mistake - sorry!
For the second: unzip it on a computer with 2 displays. Run it and click the button. No matter on which screen the application is, the alert will always be shown at the same position: at the bottom right of the main monitor.
(0021802)
mh   
2019-05-04 13:25   
Created this pull request for the issue now:
https://github.com/project-jedi/jvcl/pull/120

If implemented the alert (run attached demo after implementing the fix) does not always appear on the main screen bottom right, but on the bottom right of the screen the form calling the alert is on.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6508 [JEDI VCL] 00 JVCL Components major always 2016-04-17 20:15 2019-05-22 17:35
Reporter: kgizmo Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvDBTreeView - unnecessary warning for ftLargeint types of fields
Description: If my master/detail key field is recognized by dataset as ftLargeint I get a warning message RsMasterFieldError/RsDetailFieldError. It is strange because I get this warning only if jvDBLookupTreeViewCombo is closed by clicking outside the component (ex. on form) and occurs while trying open again.
When the list of component is closed by choosing an element or by clicking in the top part of component warnings don't occur (while trying open again).
Is it enough to add ftLargeint to DefaultValidMasterFields const or is it more complicated?
I'm using XE6 and last version of ZEOS components.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JvDBLookupTreeViewCombo.zip (8,478 bytes) 2018-08-13 11:06
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002707&type=bug
Notes
(0021489)
obones   
2018-07-18 15:42   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021572)
kgizmo   
2018-08-13 11:11   
Hi,
I uploaded zipped sources showing this as you asked. After running just expand combo and click somewhere else outside the combo, on form for example. Combo will collapse. Try expand again and you should get warnings.
(0021845)
mh   
2019-05-20 21:11   
Pull request created:
https://github.com/project-jedi/jvcl/pull/126


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5976 [JEDI VCL] 00 JVCL Components minor always 2012-08-31 17:44 2019-05-21 00:29
Reporter: Arioch Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: procedure TJvDockServer.CreateDockPanelAndSplitter; - time to clean ?
Description: procedure TJvDockServer.CreateDockPanelAndSplitter;

  function CreatePanel(AParent: TWinControl; Align: TAlign; Name: string): TJvDockPanel;
  begin
    if (FDockPanelClass <> nil) and
      (FDockPanelClass <> TJvDockPanelClass(ClassType)) then
    begin
      Result := FDockPanelClass.Create({Owner} Self);
      // (ahuser) Delphi 5's TComponent.Notification() will fail if Owner=Self.Owner
      Result.Parent := AParent; {ParentForm;}
Tags:
Steps To Reproduce: 1: since Delphi 5 is no more supported, i think the workaround should be removed.
It would be natural to make panels owned by the form, not by dock server.

2: this lines just makes me pull my hair.
(FDockPanelClass <> TJvDockPanelClass(ClassType))

Self.Classtype should be TJvDockServer or descendant.
It can never be TJvDockPanelClass
So why that hackers method to disable type checking ?

Even if needed won't more clean approach be
   (TClass(FDockPanelClass) <> TClass(ClassType)) ?

But i still think that is to be just removed. It seems liek some ugly hack with hardly to determine reasoning.
Additional Information:
Attached Files:
Notes
(0020355)
obones   
2013-01-15 15:27   
Yes, seems like it, please provide a patch file for it.
(0020812)
Arioch   
2013-12-13 12:26   
won't have time before February and also the hackerish code is dangerous to touch.

perhaps postpone it and then carefully evaluate why all that weird typecasts were needed ?
(0020864)
obones   
2013-12-16 13:24   
Take your time, there is no hurry
(0021846)
mh   
2019-05-20 21:26   
Any news on that one?
(0021848)
Arioch   
2019-05-21 00:29   
(Last edited: 2019-05-21 00:31)
i no more use Delphi 5 and no one picked the challenge when i quit

frankly, it is looooong time that Delphi does not support D5/BCB5

w.r.t. #2 - the "TJvDockPanelClass(ClassType)" is unsafe typecase, with about the same semantics as would be "pointer(ClassType)" or "integer(ClassType)".

unless Delphi (FPC?) optimizing compiler can totally remove this comparison, "evaluating" in compile-time basing upon data types alone, like it would remove "cardinal-var < 0" comparisons, the data type to me seemsdoing nothing at all.

w.r.t. 0000001 - i kind of thinkn that whatever be made wit hthe comment - the ahuser's comment better remain. It is of those pieces of knowledge that you only get when they byte you from behind, and because of that might be worth keeping despite D5 unsupported



View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6681 [JEDI VCL] 00 JVCL Components major always 2019-05-19 17:42 2019-05-19 17:42
Reporter: mh Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvRichEdit: programmatically set text selection not displayed
Description: In order to investigate Mantis issue 6395 I tried to develop a small test program. This program, when run in Rio, standard Windows VCL theme used in a Windows 10 VM and selecting some text via code (SelStart and SelLength) the text seems to be selected inside the JvRichEdit, but the selection is not drawn.

When clicking with the mouse in the area of the selected text the selection is shortly shown. When clicking with the mouse at some other text position nothing visible happens (maybe cursor is being placed there, but that's not what we're after).
Tags:
Steps To Reproduce:
Additional Information: Steps:

1. unzip attached demo app
2. run it
3. click the button

Exp.: parts of the 2nd word are drawn selected
Act.: nothing visually happens

4. click with mouse on the 2nd word of the text

Act.: the selected part of the text is shown selected for a moment, then the selection vanishes.

5. click with the mouse on some other part of the text

Exp.: nothing special happens
Act.: nothing special happens
Attached Files: JvRichEditSelection.zip (54,606 bytes) 2019-05-19 17:42
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002737&type=bug
There are no notes attached to this issue.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6395 [JEDI VCL] 00 JVCL Components minor always 2015-03-25 20:30 2019-05-19 16:44
Reporter: warmbooter Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TjvCaptionButton hides the caption text of the window
Description: When a form with a TjvCaptionButton becomes visible, the caption of form is not displayed. If you resize the window, the caption becomes visible. Tested with Delphi XE6 and Windows 8.1 Pro.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: CaptionButton1.PNG (9,369 bytes) 2019-05-19 11:13
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002734&type=bug
CaptionButtonTest.zip (54,330 bytes) 2019-05-19 11:17
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002735&type=bug
CaptionButtonTest2.zip (54,387 bytes) 2019-05-19 11:20
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002736&type=bug
Notes
(0021476)
obones   
2018-07-18 15:34   
Please provide the zipped sources of an application showing this.
(0021841)
mh   
2019-05-19 11:14   
I think this button component has even more issues. I can reproduce the issue described with Rio, but as my screenshot shows that when the button is not properly positioned (yet, I need to figure out how to do that), resizing leads to that nasty artifacts my screenshot shows.
(0021842)
mh   
2019-05-19 11:20   
Ok, I created a small demo now showing the issue. The caption text of the form not only becomes visible on resizing the form, but on clicking that button as well (I implemented a ShowMessage call in the OnClick handler).

Since I had another idea for testing right now I added another demo. The difference to the original one is, that it doesn't call ShowMessage (which will run the message loop), but only change the text of a label on the form.
If implemented like this, clicking the button no longer makes the form's caption visible. Only resize works then.
(0021843)
mh   
2019-05-19 11:30   
Another observation: if I enable themes, the text of the form's caption is visible right from the start!
(0021844)
mh   
2019-05-19 16:44   
Hm, during loading of the component the caption of the form's title bar is there, only afterwards it is being removed.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6481 [JEDI VCL] 00 JVCL Components minor always 2015-12-13 17:59 2019-05-19 11:03
Reporter: TomT Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvSpinEdit does not display properly when VCL Styles are enabled
Description: The up/down arrows do not display properly when a VCL Style is enabled and the buttonkind property is set to either bkclassis or bkstandard.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: with style.jpg (4,830 bytes) 2015-12-16 23:42
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002644&type=bug
SpinEditStyleTestRio.zip (120,980 bytes) 2019-05-19 11:01
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002732&type=bug
JvSpinEdit_Standard_Rio.PNG (3,854 bytes) 2019-05-19 11:03
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002733&type=bug
Notes
(0021257)
TomT   
2015-12-13 18:11   
It turns out that the issue only occurs when using the component in conjunction with VCL.Styles.Utils.Comctrls (part of the vlc-styles-utils library). I will see if the author of that library can sort it out. No need for changes on your end.
(0021259)
TomT   
2015-12-16 23:38   
Sorry -- initial report was correct after all -- up/down arrows have strange appearance when VCL Styles are enabled and buttonkind property is set to either bkclassis or bkstandard.
(0021480)
obones   
2018-07-18 15:37   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021840)
mh   
2019-05-19 11:03   
Using 10.3 Rio Update 1 I created a small test application but cannot reproduce your issue. See attached screenshot as well. Neither Standard nor Classic button style looks wrong for me. Attached screenshot is Standard button style.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6633 [JEDI VCL] 00 JVCL Components major always 2018-04-07 04:15 2019-05-14 22:02
Reporter: pyscripter Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: DSA Dialogs do not scale well in DPI-Aware applications (JvDSADialogs)
Description: If you use DSAMessageDlg in DPI-Aware applications and in a High-DPI screen the DSA checkbox is not shown correctly and it is partially hidden by the buttons at the bottom.
Tags:
Steps To Reproduce:
Additional Information: The attached JvDSADialogs.pas contains fixes for this issue.
Attached Files: JvDSADialogs.pas (93,170 bytes) 2019-05-12 20:16
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002730&type=bug
Notes
(0021551)
obones   
2018-07-18 16:06   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
If you have changes ready, please send them via a pull request at Github
(0021752)
mh   
2019-04-26 20:27   
Unfortunately I don't see any attached unit here...
(0021831)
pyscripter   
2019-05-12 20:17   
File uploaded.
(0021832)
mh   
2019-05-12 20:28   
Thanks! Will try to look at it in the next few days, but it can take a few days this week.
(0021837)
mh   
2019-05-14 22:02   
Created a pull request for it, hopefully it is good enough and doesn't break any things on older Delphi versions:
https://github.com/project-jedi/jvcl/pull/124


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6659 [JEDI VCL] 99 Other minor N/A 2018-12-30 11:44 2019-05-13 10:41
Reporter: dcabale Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Captcha v1 shutdown in JCL/JVCL news portal (http://newsportal.delphi-jedi.org/)
Description: Hi all,
the JCL/JVCL news portal (http://newsportal.delphi-jedi.org/) is unavailable for posting new posts, because the reCAPTCHA is shutdown.
Please reactivate.
Thanks
Tags:
Steps To Reproduce:
Additional Information: If this portal is now in read-only mode, what will be its replacer?
Attached Files: 13-05-2019 10-01-20.jpg (180,014 bytes) 2019-05-13 10:02
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002731&type=bug
Notes
(0021826)
mh   
2019-05-12 14:00   
The portal is not in read only mode! Only the web interface is.

If you use a NNTP based newsreader application like Mozilla Thunderbird or Xananews you can still post!
(0021834)
dcabale   
2019-05-13 10:04   
Then, why do you allow this page -> http://newsportal.delphi-jedi.org/post.php?newsgroups=jedi.jcl&type=new (13-05-2019 10-01-20.jpg) to make believe to the user, he can post?
(0021835)
datamystic   
2019-05-13 10:41   
To fix this issue, you just need to get a v2 captcha from google, get 2 new keys (one public, one private), and upload some new javascript.
  https://www.google.com/recaptcha/admin/create

You also need to specify the hostname of the sites you will use it on.

Client side (html) config:
  https://developers.google.com/recaptcha/docs/display

Server side config:
  https://developers.google.com/recaptcha/docs/verify

There is no cost to use it.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6678 [JEDI VCL] 00 JVCL Components major always 2019-05-08 15:43 2019-05-13 09:59
Reporter: Mistral Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvDBGrid raise EInvalidOperation double clicking on it
Description: With the GIT update 79f2c24fd8b978626e08cc2aed1b6fc7f997f86e on 5/5/2019 someone introduced changes on mouseup handling in the TJvDBGrid component.

With this changes I'm getting strange EInvalidOperation handling the grid dblclick event. I've reproduced a simple case (attached):

1. a main form with a button
2. clicking the main form button is opened a form with the grid and data
3. dblclick on a row (simulating something like a record selection that close the form) and the program raise the exception
Tags:
Steps To Reproduce:
Additional Information: To remove the problem I've to revert back the changes to previous version:

procedure TJvDBGrid.MouseUp(Button: TMouseButton; Shift: TShiftState;
  X, Y: Integer);
var
  Cell: TGridCoord;
  ACol: Longint;
  DoClick: Boolean;
  ALeftCol: Integer;
  OriginalScrollInfo: TScrollInfo;
begin
  Cell := MouseCoord(X, Y);
  if FTracking and (FPressedCol <> nil) then
  begin
    DoClick := PtInRect(Rect(0, 0, ClientWidth, ClientHeight), {Types.} Point(X, Y)) and
      (Cell.Y < TitleOffset) and
      (FPressedCol = GetMasterColumn(Cell.X, Cell.Y));
    StopTracking;
    if DoClick then
    begin
      ACol := Cell.X;
      if dgIndicator in Options then
        Dec(ACol, IndicatorOffset);
      if (DataLink <> nil) and DataLink.Active and (ACol >= 0) and
        (ACol < Columns.Count) then
        DoTitleClick(FPressedCol.Index, FPressedCol.Field);
    end;
  end
  else
  if FSwapButtons then
  begin
    StopTracking;
    FSwapButtons := False;
    MouseCapture := False;
    if Button = mbRight then
      Button := mbLeft;
  end;
  if (Button = mbLeft) and (FGridState = gsColSizing) and
    (FSizingIndex + Byte(not (dgIndicator in Options)) <= FixedCols) then
  begin
    ColWidths[FSizingIndex] := GetMinColWidth(X - FSizingOfs - CellRect(FSizingIndex, 0).Left);
    FGridState := gsNormal;
  end;

  if FTitleArrowDown and (Button = mbLeft) then
  begin
    FTitleArrowDown := False;
    if FTitleArrow and (dgTitles in Options) and (dgIndicator in Options) and
       (Cell.X = 0) and (Cell.Y = 0) and (Columns.Count > 0) then
      ShowSelectColumnClick; // Selection of columns
  end;

  if (Button = mbLeft) and (FGridState = gsColSizing) then
  begin
    ALeftCol := LeftCol;
    inherited MouseUp(Button, Shift, X, Y);
    if (dgRowSelect in Options) then
      LeftCol := ALeftCol;
    if Assigned(OnColumnResized) then
      OnColumnResized(Self, FSizingIndex + Byte(not (dgIndicator in Options)) - 1,
        ColWidths[FSizingIndex]);
  end
  else
  begin
// OriginalScrollInfo.cbSize := SizeOf(OriginalScrollInfo);
// OriginalScrollInfo.fMask := SIF_POS;
// // Store scrollbar position
// GetScrollInfo(Handle, SB_HORZ, OriginalScrollInfo); //
// LockWindowUpdate(Handle);
// try
      inherited MouseUp(Button, Shift, X, Y);
// Perform(WM_HSCROLL, MakeWParam(SB_THUMBPOSITION, OriginalScrollInfo.nPos), 0); //Repos
// finally
// LockWindowUpdate(0);
// end;
  end;
  DoAutoSizeColumns;

  { XP Theming }
  {$IFNDEF COMPILER14_UP}
  {$IFDEF JVCLThemesEnabled}
  if UseXPThemes and StyleServices.Enabled then
  begin
    FPaintInfo.ColSizing := False;
    FPaintInfo.ColMoving := False;
    FPaintInfo.ColPressedIdx := -1;
    Invalidate;
  end;
  {$ENDIF JVCLThemesEnabled}
  {$ENDIF ~COMPILER14_UP}
end;
Attached Files: TestDBGrid.zip (85,803 bytes) 2019-05-08 15:43
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002727&type=bug
Notes
(0021825)
mh   
2019-05-12 13:52   
I tried to reproduce the crash you saw by running your test application in Rio Update 1 and I cannot reproduce it. In my case double clicking on a row just closes the window.

So what's the difference between our systems:
- Windows 10 x64 in a VM Ware VM
- Delphi 10.3 Rio Update 1
- JCL and JVCL installed from a forked of the original Git repository,
  but that fork kept in sync with the original JEDI repository

Does anybody else see the crash?
(0021833)
Mistral   
2019-05-13 09:59   
My system:
- Windows 10 x64 (real machine)
- Delphi 10.2.3 Tokyo
- JCL and JVCL installed from original Git repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6461 [JEDI VCL] 00 JVCL Components major always 2015-10-20 18:37 2019-05-12 17:26
Reporter: mvalec Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvSpeedButton appearance when custom VCL style is activated
Description: When Caption is not empty, Glyph is painted on left edge.
Procedure TJvxButtonGlyph.CalcButtonLayout calls DrawGlassableText from JvThemes.pas to get TextBounds. (JvSpeedButton.pas, line 2178). Problem is on line 1396 of JvThemes.pas: DrawGlassableText calls deprecated version of procedure StyleServices.DrawText which can not return calculated text bounds.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021484)
obones   
2018-07-18 15:38   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021830)
mh   
2019-05-12 17:26   
Ok, there are other overloads of DrawText available which could be used at least in newer Delphi versions. From which version onwards? And: one of them has a parameter Flags:TTextFormat which is most likely what you want. But which of the many formats shall be used here? tfCalcRect?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6648 [JEDI VCL] 00 JVCL Components major always 2018-08-22 09:56 2019-05-12 17:10
Reporter: TheBlackfish Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvDateEdit CheckOnExit gives double error message
Description: When you have 2 TJvDateEdit components on a form, the CheckOnExit displays the error message twice when you click on the other TJvDateEdit.

Example:
- Put 2 TJvDateEdit components on a form (JvDateEditA and JvDateEditB)
- JvDateEditA has CheckOnEdix set to true
- Enter an invalid date like 54.98.2465 in JvDateEditA
- Click on JvDateEditB
- Get 2x error message '54.98.2465 is not a valid date.'

This only happens when you CLICK on JvDateEditB. If you use the TAB KEY to switch to JvDateEditB then you get the error messsage only once.
Tags:
Steps To Reproduce:
Additional Information: We use JEDI Visual Component Library 3.50
Attached Files: JvDateEditTestProject.zip (4,992 bytes) 2018-09-19 07:41
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002708&type=bug
Notes
(0021573)
obones   
2018-08-30 14:15   
Please provide the zipped sources of an application showing this.
(0021576)
TheBlackfish   
2018-09-19 07:42   
I have attached a very simple example that shows the problem as explained.
(0021829)
mh   
2019-05-12 17:10   
Some first analysis:

1. the provided test application doesn't work out of the box. The dpr needs to be modified like this, otherwise no form will be created:

program JvDateEditTestProject;

uses
  Vcl.Forms,
  JvDateEditTest in 'JvDateEditTest.pas' {Form1};

{$R *.res}

begin
  Application.Initialize;
  Application.MainFormOnTaskbar := True;
  Application.CreateForm(TForm1, Form1);
  Application.Run;
end.

2. There is a method CMExit in TJvCustomComboEdit which is triggered by a message CM_EXIT. It looks like this method is being triggered twice and there is the FInCMExit field which seems to be there to prevent double calls. Looks like the CM_EXIT message is not declared as completely processed. But why then doesn't this happen when using the keyboard instead of the mouse? There it only triggers this once.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6576 [JEDI VCL] 04 Feature Request feature N/A 2017-07-02 08:40 2019-05-12 16:45
Reporter: mh Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvTransparentButton: Make position of the image configurable
Description: TJvTransparentButton contains an Images property where one can assign image lists to various sub properties and select which image from the list to be displayed via the ImageIndex.

So far so good, but the image is always placed in the center of the button, which is quite inflexible and limiting. Can we please get either one alignment property for the image or individual alignment subproperties for all the different "situation" image lists?

The alignment should at minimum provide the following values:
- left
- right
- top
- bottom
- center
Tags:
Steps To Reproduce:
Additional Information: In the product version list here in Mantis versions newer than 3.48 are missing in the product version combobox.
Attached Files: JVCLStacktrace.txt (1,556 bytes) 2018-10-28 17:09
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002709&type=bug
Notes
(0021527)
obones   
2018-07-18 15:55   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021582)
mh   
2018-10-28 17:09   
I just downloaded the newest JCL and JVCL zip GitHub gave me and installed them into a Berlin update 2 installation.

Here my findings regarding this button:
1. I still see no alignment property for the state images I specify via
   the sub properties of the Images property. It has a general align
   property, but that's for the button itself.

2. I defined an ActivaImage and a GrayImage. Both different images.
   When I change FrameStyle from "Explorer" to "Dark" the form designer
   no longer displays the GrayImage but the ActiveImage. Changing this
   setting back changes the image back.

3. When clicking the elipsis button for the Glyph property I can select a png
   file in the file open dialog, but then I get a "invalid graphic format"
   failure message. I attached the stack trace the IDE gave me for this as a
   file.
(0021589)
nhakhoatphcm   
2018-11-10 03:32   
Nha Khoa Vi?t M? - Nha Khoa Th?m M? Hàng ??u Vi?t Nam
Tel 02837858989
?c: 1288 Hu?nh T?n Phát - Phú M? - Qu?n 7- TP H? Chí Minh
(0021590)
nhakhoatphcm   
2018-11-10 03:34   
Nha Khoa Viet My - Nha Khoa Tham My Hang Dau Viet Nam
Tel 02837858989
?c: 1288 Huynh Tan Phat - Phu My - Quan 7- TP Ho Chi Minh
(0021828)
mh   
2019-05-12 16:45   
This one can be closed, as the TextAlign property can already be used to achieve this glyph positioning.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6541 [JEDI VCL] 00 JVCL Components tweak always 2016-12-20 12:46 2019-05-12 14:13
Reporter: CDametto Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Disabled TabSheets in JvPageControl are accessible through the keyboard
Description: A disabled TabSheet in a JvPageControl is not accessible using the mouse, but it remains accessible through the keyboard using the left or right arrow when the focus is on the tab of the sheet.
I propose the following improvement: to deny access via the keyboard, or better, still in Delphi’s PageControl a disabled TabSheet is still accessible (even with mouse), to add a property to let the user choose the behavior it wants.
Thank you for your time
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: Demo.zip (53,427 bytes) 2019-01-25 11:28
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002714&type=bug
Notes
(0021506)
obones   
2018-07-18 15:48   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021602)
CDametto   
2019-01-25 11:27   
The issue is still present in jvcl 3.50 with Delphi 10.3 rio
(0021740)
mh   
2019-04-25 21:51   
Interestingly, the VCL itself with a normal TPageControl does not respect the Enabled property of any TTabSheet at all.

So question: I can reproduce your issue on 10.3 Rio Update 1 with your simple demo fine enough, but is this really as it should work or asked otherwise: is the VCL wrong by not respecting Enabled of any TTabSheet?
(0021756)
mh   
2019-04-27 13:36   
Ok, WMLButtonDown contains this code:

  if (RealIndex < PageCount) and (RealIndex >= 0) and
     ((hi.flags and TCHT_ONITEM) <> 0) then
    if not Pages[RealIndex].Enabled then
    begin
      Msg.Result := 0;
      Exit;
    end;

which makes clicking on a disabled tab a no-op.
Keyboard handling most likely uses TPageControl.FindNextPage, which does not check for enabled or not. But that one is public and not virtual, so we cannot simply override it. Now what to do, besides wishing EMBT to respect enabled property?
(0021757)
mh   
2019-04-27 13:41   
Ok, created this QP request:
https://quality.embarcadero.com/browse/RSP-24339

But it's unsure if it will help us...
=> what should be our solution?
(0021827)
mh   
2019-05-12 14:13   
It looks like keyboard handling is mostly done by TPageControl from VCL itsself. SO I guess if EMBT fixes the issue reported in the QP report listed above it would be fixed along with it.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6674 [JEDI VCL] 00 JVCL Components minor always 2019-04-27 14:58 2019-05-08 22:53
Reporter: mh Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvToolEdit uses deprecated symbol SInvalidFilename
Description: JvToolEdit uses deprecated symbol SInvalidFilename. The compiler suggests to use SInvalidKnownFilename.

If I find out in which Delphi version the new one first appeared I might actually fix this warning. Does anybody know this or how to find out as quick as possible without having all versions of Delphi installed?
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021799)
mh   
2019-05-03 19:11   
Pull request created:
https://github.com/project-jedi/jvcl/pull/117
(0021819)
mh   
2019-05-08 21:06   
Can be closed. Pull request has been merged.
(0021820)
jfudickar   
2019-05-08 22:53   
Fixed in Repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6677 [JEDI VCL] 04 Feature Request feature always 2019-05-08 13:42 2019-05-08 17:39
Reporter: mh Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvGifAnimator shall have a method for setting the ANimateInterval for all frames
Description: Currently one has to manualy set the AnimateInterval for each frame individually if one wants to change the animation speed.

It would be desirable to have a method looping through all the frames and set all of them to the same value.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021818)
mh   
2019-05-08 17:39   
Pull request with a suggested implementation created:
https://github.com/project-jedi/jvcl/pull/122


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6611 [JEDI VCL] 00 JVCL Components major always 2018-01-21 15:17 2019-05-05 12:16
Reporter: marcowobben Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Incorrect result in TJvTextAttributes.ConsistentAttributes
Description: Requesting TJvRichEdit.SelAttributes.ConsistentAttributes always returns the valid available attributes, not the actual consistent attributes themselves.
Tags:
Steps To Reproduce:
Additional Information: The function uses "dwMask" instead of "dwEffects":

function TJvTextAttributes.GetConsistentAttributes: TJvConsistentAttributes;

A fix would be:

[code]
function TJvTextAttributes.GetConsistentAttributes: TJvConsistentAttributes;
var
  Format: TCharFormat2;
begin
  Result := [];
  if FRichEdit.HandleAllocated and (FType <> atDefaultText) then
  begin
    InitFormat(Format);
    SendMessage(FRichEdit.Handle, EM_GETCHARFORMAT,
      AttrFlags[FType], LParam(@Format));
    with Format do
    begin
      if (dwEffects and CFM_BOLD) <> 0 then
        Include(Result, caBold);
      if (dwEffects and CFM_COLOR) <> 0 then
        Include(Result, caColor);
      if (dwEffects and CFM_FACE) <> 0 then
        Include(Result, caFace);
      if (dwEffects and CFM_ITALIC) <> 0 then
        Include(Result, caItalic);
      if (dwEffects and CFM_SIZE) <> 0 then
        Include(Result, caSize);
      if (dwEffects and CFM_STRIKEOUT) <> 0 then
        Include(Result, caStrikeOut);
      if (dwEffects and CFM_UNDERLINE) <> 0 then
        Include(Result, caUnderline);
      if (dwEffects and CFM_PROTECTED) <> 0 then
        Include(Result, caProtected);
      if (dwEffects and CFM_OFFSET) <> 0 then
        Include(Result, caOffset);
      if (dwEffects and CFM_HIDDEN) <> 0 then
        Include(Result, caHidden);
      if (dwEffects and CFM_CHARSET) <> 0 then
        Include(Result, caCharset);
      if RichEditVersion >= 2 then
      begin
        if (dwEffects and CFM_LINK) <> 0 then
          Include(Result, caLink);
        if (dwEffects and CFM_BACKCOLOR) <> 0 then
          Include(Result, caBackColor);
        if (dwEffects and CFM_DISABLED) <> 0 then
          Include(Result, caDisabled);
        if (dwEffects and CFM_WEIGHT) <> 0 then
          Include(Result, caWeight);
        if (dwEffects and CFM_SUBSCRIPT) <> 0 then
          Include(Result, caSubscript);
        if (dwEffects and CFM_REVAUTHOR) <> 0 then
          Include(Result, caRevAuthor);
      end;
    end;
  end;
end;

[/code]
Attached Files: RichEditTestAndFix.zip (51,268 bytes) 2019-05-05 12:12
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002726&type=bug
Notes
(0021545)
obones   
2018-07-18 16:04   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021762)
mh   
2019-04-27 14:14   
Made a pull request out of the proposed fix:
https://github.com/project-jedi/jvcl/pull/99
(0021778)
obones   
2019-04-30 15:59   
I disagree with this change, the documentation says this:

The dwMask member specifies which attributes are consistent throughout the entire selection

So clearly, a "GetConsistent" method should use the dwMask member.

See here:
https://docs.microsoft.com/en-us/windows/desktop/controls/em-getcharformat
(0021783)
mh   
2019-05-01 09:47   
After reading the MSDN documentation you linked to (I should have read it upfront) I'd agree with you. If the original creator of this issue doesn't provide more information about why he thinks the method is wrong we should close this issue as "won't do" or "no change required" -> test case error.

So could marcowobben please shed more light on why he thinks this method is implemented the wrong way?
(0021809)
marcowobben   
2019-05-04 22:49   
The documentation indeed states it returns the consistent attributes of the selection. However, in the my test case it doesn't work as documented.

Reading onward to the difference in dwMask and dwEffect, it clearly states the dwMask only specifies if the flags in dwEffect are valid. In other words the actual values are not found in dwMask but in dwEffect.

https://docs.microsoft.com/en-us/windows/desktop/api/Richedit/ns-richedit-_charformat

I'll attach a test case later this week.
(0021815)
marcowobben   
2019-05-05 12:16   
My initially siggested fix is not even completed. While reading back on the online microsoft documentation, building a test application, it showed that even my fix was incomplete.

I've uploaded the test application which contains the routines for:

- SelAttributes (returns the attributes at the caret)
- SelAttribute.ConsistentAttributes (appears to be unusable ...)
- SelAttributes.FixConsistentAttributes (which returns a true consistent set)


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6601 [JEDI VCL] 00 JVCL Components minor always 2017-10-25 20:39 2019-05-05 09:31
Reporter: tetardd Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvArrowButton - Glyph and caption not properly drawn when using Margin
Description: If you specify a margin > 0 in the properties (note: not the VCL Margins, the controls margin property) with a glyph and caption (button layout = glyph left and vert. align = centre), the glyph and caption are not well centered vertically.
Tags:
Steps To Reproduce:
Additional Information: Add TJvArrowButton, set height to 45 pixels
Set glyph to a 32 x 32 bitmap
Set a caption
Set margins to 10
Set layout to glyph left
Set vertical alignment to center

The glyph and text are clearly drawn too high.
Attached Files: Debug JvArrowButton.zip (83,731 bytes) 2017-10-27 08:42
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002687&type=bug
JvArrowButton.pas (46,223 bytes) 2017-10-27 08:43
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002688&type=bug
Notes
(0021438)
tetardd   
2017-10-27 08:44   
Attached is a test program to show the problem and my attempt at solving it. By the way, it also includes the changes proposed in issue 6600.
(0021813)
mh   
2019-05-05 09:31   
I tried to implement your suggestions from JvArrowButton.pas, but then I saw that you changed the public Draw method completely from its parameters.

While I can follow the introduction of these parameters as properties changing such a public method in that way is not really approved by the maintainers, as it breaks existing code of JVCL users.

Can you implement a variant which keeps the old Draw method and implements e.g. an overloaded one?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6352 [JEDI VCL] 00 JVCL Components tweak always 2014-11-09 15:40 2019-05-05 09:22
Reporter: DeathMAD Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvFormDesktopAlert. Improve message text showing
Description: Add some property setting to the internal label.
lblText.AutoSize := False;
lblText.TextEllipsis := teEndEllipsis;




constructor TJvFormDesktopAlert.Create(AOwner: TComponent);
begin
  inherited CreateNew(AOwner, 1);
.....
  lblText := TJvLabel.Create(Self);
  lblText.Parent := Self;
  lblText.AutoSize := False;
  lblText.SetBounds(56, 24, 67, 13);
  lblText.Transparent := True;
  lblText.WordWrap := True;
  lblText.Anchors := [akLeft..akBottom];
  lblText.TextEllipsis := teEndEllipsis;
...
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021069)
DeathMAD   
2014-11-11 20:34   
I was added pull request
(0021084)
obones   
2014-12-04 15:03   
Please provide the zipped sources of a sample application showing this.
(0021812)
mh   
2019-05-05 09:22   
I didn't find the code listed above and thus I really do not know what he wants us to do. I didn't see the mentioned label at all on a first look.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6263 [JEDI VCL] 00 JVCL Components minor always 2014-03-05 16:53 2019-05-05 09:20
Reporter: runfastman Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.45  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: No On change event call for DateTimePicker
Description: I added an function for the OnChange Event. This function never gets called when you type in the control and change the item. It works with the standard TDateTimePicker.

This would also be a great time to fix the known issues with the default TDateTimePicker where "What you see isn't what you get" if you have both the date and time displayed and you change values not all values get updated on the back side, only values associated with "Kind" property get updated.
Example
Kind = dtkDate
Format = 'MM/dd/yyyy hh:mm tt'
//modify the hour, then read the time in code and it isn't modified.

This can be fixed in the OnChange Event by updating the date/time value using the text property of the component.

At the very least, expose the .text property of the component so the user can do this manually.

Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JVCL_6263.zip (54,052 bytes) 2019-05-05 09:17
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002725&type=bug
Notes
(0021023)
obones   
2014-09-03 11:33   
Please provide the zipped sources of a sample application showing this
(0021811)
mh   
2019-05-05 09:20   
I created a demo project now. It shows two things:

1. the OnChange event is fired just fine in the current version
2. the thing with not changing the entered time internally when Kind is dtkDate is indeed the case, but I rather think this is as designed. or what would the Kind property be for otherwise? If Kind is dtkTime the entered time is really changed.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6350 [JEDI VCL] 00 JVCL Components minor always 2014-11-06 12:18 2019-05-05 08:56
Reporter: moore Platform: Delphi  
Assigned To: OS: Windows  
Priority: normal OS Version: 7  
Status: feedback Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvImage loses Transparent on state change
Description: When you change state of TJvImage or Change Enabled property value, Transparent is reset to False, even though it was to True.
Work around is set Transparent to False and then to True;

Thns for your help..
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JVCL6350.zip (65,422 bytes) 2019-05-05 08:55
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002724&type=bug
Notes
(0021082)
obones   
2014-12-04 15:02   
Please provide the zipped sources of a sample application showing this.
(0021810)
mh   
2019-05-05 08:56   
I attached a demo project trying to implement what the creator of this issue claims. But: with this demo I cannot reproduce the issue. Changing enabled or state of the image does preserve transparent property nowadays.

=> I think this issue can be closed as resolved.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6353 [JEDI VCL] 00 JVCL Components minor always 2014-11-09 18:33 2019-05-04 21:03
Reporter: HSerg Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Incomplete TJvWallpaperStyle (for Windows 7 and later)
Description: JvComputerInfoEx.pas
=== cut ===
...
TJvWallpaperStyle = (wsCenter, wsUnused, wsStretch);
...
Result := TJvWallpaperStyle(StrToInt(RegReadStringDef(HKCU, HKCU_CONTROL_PANEL_DESKTOP, 'WallpaperStyle', '0')));
...
RegWriteString(HKCU, HKCU_CONTROL_PANEL_DESKTOP, 'WallpaperStyle', IntToStr(Ord(Value)));
...
=== cut ===

http://msdn.microsoft.com/en-us/library/bb773190%28VS.85%29.aspx#desktop
=== cut ===
[Control Panel\Desktop]
Wallpaper=%WinDir%\web\wallpaper\Windows\img0.jpg
; The path to the wallpaper picture can point to a
; .bmp, .gif, .jpg, .png, or .tif file.

TileWallpaper=0
; 0: The wallpaper picture should not be tiled
; 1: The wallpaper picture should be tiled

WallpaperStyle=2
; 0: The image is centered if TileWallpaper=0 or tiled if TileWallpaper=1
; 2: The image is stretched to fill the screen
; 6: The image is resized to fit the screen while maintaining the aspect
      ratio. (Windows 7 and later)
; 10: The image is resized and cropped to fill the screen while maintaining
      the aspect ratio. (Windows 7 and later)
=== cut ===

As a result:
=== cut ===
GetEnumProp(JvMiscInfo, 'WallpaperStyle') >> ??? VDRegion @ XX? ?]? ??? NetBIOS @\>> 8`? ? ?
=== cut ===
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: example.zip (396 bytes) 2015-11-24 21:58
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002641&type=bug
Notes
(0021083)
obones   
2014-12-04 15:03   
Please provide the zipped sources of a sample application showing this.
(0021244)
HSerg   
2015-11-24 22:02   
:: desktop wallpaper - stretch
> example.exe
wsStretch

:: desktop wallpaper - fill the screen
> example.exe
S] ?TJvMiscInfo?R] DN] ? ?JvComputerInfoEx? ¶?@ ?b]
(0021803)
mh   
2019-05-04 16:35   
I tried to compile the attached demo program, but at least in Rio this fails as the unit Graphics, which is used by JvComputerInfoEx.pas is not found on my system.
(0021804)
mh   
2019-05-04 16:46   
Ok, I can compile it now in Rio: one needs to add VCL and VCL.Imaging as unit scope names to the project settings of the demo attached to this issue in order to be able to compile it.
(0021805)
mh   
2019-05-04 18:15   
Ok, running the provided example in 10.3 Rio update 1 on a Windows 10 VM gives a wsFill result for me.

Current definition of TJvWallpaperStyle is:
TJvWallpaperStyle = (wsCenter, wsStretch, wsFit, wsFill, wsUnknown);

So I don't see what's wrong with it. I guess it has been fixed in the meantime and thus the issue can be closed.
(0021808)
HSerg   
2019-05-04 21:03   
Agree. Fixed via https://github.com/project-jedi/jvcl/commit/5bbed962300ea0a8ddefd7dc0f4b8a57a3f069ce


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6382 [JEDI VCL] 00 JVCL Components minor always 2015-02-16 20:24 2019-05-04 18:20
Reporter: boerema1 Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvBalloonHint as Application Hint causes second form on taskbar to hide below first
Description: I would like to reopen issue 6333. Since I can't find a button to reopen that issue I'm adding this new one.
http://issuetracker.delphi-jedi.org/bug_view_advanced_page.php?bug_id=6333

Sorry for the late reply I didn't get a notice about a status change.
The suggested solution does not work on older versions of Delphi which as far as I know JVCL is still supporting.
According to the link below support for MainFormOnToolbar was added in Delphi 2007.
http://www.stevetrefethen.com/blog/the-new-vcl-property-tapplication-mainformontaskbar-in-delphi-2007
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021185)
obones   
2015-09-14 11:22   
Well, yes, we support them, but because they were created before Win7 was out, they can't support it fully and so can't we.
That is, unless you can come up with a viable solution and submit a pull request
(0021806)
mh   
2019-05-04 18:20   
Would it be possible to implement the solution which would work on newer Delphi versions put into such ifdefs that it will be used there only, so it is at least fixed for them?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6582 [JEDI VCL] 00 JVCL Components minor have not tried 2017-08-07 19:41 2019-05-04 11:43
Reporter: Kyle_Katarn Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvBitBtn wrong rendering when parent form has DoubleBuerring set to True
Description: TJvBitBtn wrong rendering when parent form has DoubleBuerring set to True
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: BitBtnTest.zip (53,801 bytes) 2019-04-22 19:54
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002720&type=bug
Notes
(0021433)
Kyle_Katarn   
2017-08-07 19:42   
DoubleBuerring => DoubleBuferring
(0021439)
Kyle_Katarn   
2017-10-29 15:22   
Do you need more details ?
(0021534)
obones   
2018-07-18 15:59   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021564)
Kyle_Katarn   
2018-07-19 22:26   
I'm using JCL v2.8 (6000) with JVCL daily from 2016-08-04 (> 3.49)
(0021583)
mh   
2018-10-28 17:14   
Hello Kyle,
the question was not which version you were using. it was whether it is still the case in the most current one (it may have been fixed meanwhile) and if it's not fixed you should please provide a small sample application.
Thanks!
(0021588)
Kyle_Katarn   
2018-10-28 17:45   
That's the version i'm using and problem occurs then.
(0021616)
mh   
2019-03-07 21:09   
Hello Kyle,
I got which version you are using just fine. The request was, that you should update your JCL/JVCL version to the current one in order to check if this issue still happens. Would you be so nice to do this?
(0021619)
Kyle_Katarn   
2019-03-07 21:23   
Isn't this the last release ? What are the current version number for JCL, JVCL ?
(0021718)
mh   
2019-04-17 22:55   
I don't know about the version number, but currently there is a little bit of fixing activity going on, so the Github repositiory got a few commits over the last few days.

That is no new release via GetIt yet or so, but sice you posted a version number back in September last year, that is surely not the newest one. For Rio a new one was issued I guess.
(0021719)
mh   
2019-04-17 22:56   
Another thing: do you have screenshots of correct rendering (without double buffering) and of incorrect rendering?
(0021724)
Kyle_Katarn   
2019-04-20 18:56   
I'll check next time I update JVCL and my test apps.
Can't you reproduce the problem ?
(0021727)
mh   
2019-04-22 19:57   
Hello,

I attached my test project now but I cannot reproduce your vaguely described issue. The JvBitBtn has ParentDoubleBuffered := false and neither toggling the DoubleBuffered property at runtime nor at design time (and then running the program) makes any difference. For simplicity matters I set the butoon kind to OK button.

My system is a Windows 10 64 Bit VM, running Rio 10.3 Update 1.
Anything my demo doesn't do as your application?
Can you please provide screenshots of a the correct and the wrong appearance of the same JvBitBtn?
(0021735)
mh   
2019-04-25 20:45   
Did you already check my test program? Does it show your error?
(0021800)
mh   
2019-05-04 11:43   
Kyle_Katarn, can you run my test program I attached and tell us whether it shows the issue or if not whether there are differences to your use case?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6570 [JEDI VCL] 00 JVCL Components crash always 2017-05-08 15:43 2019-05-03 11:10
Reporter: rarog Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvMemoryData easilly corrupts buffer when using many fields
Description: TJvMemoryData.InitFieldDefsFromFields can easily corrupt the buffer without throwing any error.

The problem root is in this line:
Inc(Offset, CalcFieldLen(DataType, Size) + 1);

It just increases the offset without checking, if it causes a cycle getting an overflow when reaching values over 65535.

To reproduce it, it should be enough to load a data with 22 WideString fields. Each of them is initialised by default to hold 1500 chars, each char takes 2 bytes.
So 1500 * 2 * 22 = 66000 resulting in the buffer to be in between and corrupt memory.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021531)
obones   
2018-07-18 15:57   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021587)
mh   
2018-10-28 17:34   
In the current version this line mentioned seems to have been changed to this one:
Inc(Offset, CalcFieldLen(FieldDefList[I].DataType, FieldDefList[I].Size) + 1);

While it looks different is still doesn't check if the offset variable (which is a Word) overflows.

There should be a if before actually incrementing offset ensuring that it is only incremented when it won't overflow. In case of an overflow raising an exception might be appropriate.
(0021742)
mh   
2019-04-25 22:22   
I just created a pull request with a proposed fix for this. See here:
https://github.com/project-jedi/jvcl/pull/92
(0021785)
mh   
2019-05-01 10:27   
Replaced pull request with this improved one:
https://github.com/project-jedi/jvcl/pull/114


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6675 [JEDI VCL] 02 Installation minor always 2019-04-30 16:22 2019-05-02 21:56
Reporter: bbordwell Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Install impossible with Delphi RIO Evaluation
Description: Greetings.

As I attempt to evaluate Delphi-RIO, I find it impossible to build the JVCL because it depends on the command line compiler (bcc32 not available in the eval version).
Additionally, the include files, like jedi.inc are conveniently missing when downloaded from Git-Hub. The process to build for RIO is challenging at best.

Question: are there any manual build instructions for the IDE, or a location I can get pre-compiled JVCL for Win32 Delphi-RIO?

Thanks in advance for any links to get me past the installation issues.

Bret


Tags:
Steps To Reproduce:
Additional Information: Also, sorry to post here, as the CAPTCHA is disabled in the Forum.
Attached Files:
Notes
(0021794)
bbordwell   
2019-05-02 15:08   
>>Question: are there any manual build instructions for the IDE, or a location I can get pre-compiled JVCL for Win32 Delphi-RIO?

Manual instructions found. Again, sorry to post here. Reminder: Captcha turned off in forums.
(0021795)
mh   
2019-05-02 17:59   
Captcha problem in forum and at least in wiki as well is a known issue. I already created a separate issue for that in the wiki project here in Mantis.
You can monitor it. Here's the link:

http://issuetracker.delphi-jedi.org/view.php?id=6676

(I'm none of the admins so I cannot fix it)
(0021796)
mh   
2019-05-02 21:22   
Can this issue bei closed AS you Manager to Install?
(0021797)
bbordwell   
2019-05-02 21:56   
Yes. Please close. All is well.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6579 [JEDI VCL] 00 JVCL Components minor always 2017-07-18 19:57 2019-05-02 08:33
Reporter: stjcottbus Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvTFGlance adds an annoying empty line in Hint if ShowSchedNamesInHint is False.
Description: In TJvTFCustomGlance.CheckApptHint is the variable ExtraDesc not initialized (may be unneeded) but is unconditionally expanded with CRLF.

It should more or less look like this:

procedure TJvTFCustomGlance.CheckApptHint(Info: TJvTFGlanceCoord);
var
  ExtraDesc: string;
  Handled: Boolean;
begin
  if Assigned(FViewer) and FViewer.ShowSchedNamesInHint then
  begin
    ExtraDesc := StringsToStr(SchedNames, ', ', False);
    ExtraDesc := ExtraDesc + 0000013#10;
  end else
    ExtraDesc := '';
  Handled := False;
  if Assigned(OnApptHint) then
    FOnApptHint(Self, Info.Appt, Handled);
  if not Handled then
    FHint.ApptHint(Info.Appt, Info.AbsX + 8, Info.AbsY + 8,
                   not Assigned(FViewer) or FViewer.ShowStartEndTimeInHint, True, False, ExtraDesc);
end;
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021524)
obones   
2018-07-18 15:54   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021764)
mh   
2019-04-27 14:35   
Pull request for this one created:
https://github.com/project-jedi/jvcl/pull/100
(0021793)
jfudickar   
2019-05-02 08:33   
Fixed in Repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6527 [JEDI VCL] 00 JVCL Components major always 2016-09-27 10:51 2019-05-02 08:33
Reporter: tas Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvHTMLParser
Description: Doesn't parse correct.

This is html example text:

<body>Paragraph</body>


The problem occurs when tags starting with the same symbol and one of them have length 1 (for example tag )
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021400)
tas   
2016-09-27 10:56   
Example html text:

<'body'><'b'>Paragraph<'/b'><'/body'>


The problem occurs when tags starting with the same symbol and one of them have length 1 (for example tag 'b')
(0021401)
tas   
2016-09-27 14:20   
fixed:

change
  J := StrFind(StartTag1, Str, J);

to

  if trim(StartTag2) = '' then
    J := StrFind(StartTag1, Str, J)
  else
  begin
    J1 := J;
    J := StrFind(StartTag1 + ' ', Str, J);
    if J = 0 then
    begin
     J := J1;
     J := StrFind(StartTag1 + '>', Str, J);
    end;
  end;
(0021497)
obones   
2018-07-18 15:45   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021774)
mh   
2019-04-28 10:59   
Pull request created:
https://github.com/project-jedi/jvcl/pull/108
(0021781)
mh   
2019-04-30 21:52   
Pull request superceeded by
https://github.com/project-jedi/jvcl/pull/112
(0021792)
jfudickar   
2019-05-02 08:33   
Fixed in Repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6504 [JEDI VCL] 00 JVCL Components minor always 2016-03-31 10:43 2019-05-02 08:33
Reporter: DanielTr Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Width of UpDown buttons in TJvCustomSpinEdit does not scale
Description: The buttons width is calculated as the systems scrollbar width but limited to 15px (hard coded) in JvSpin.DefBtnWidth. This applies to bkClassic and bkStandard.

This way the buttons become very narrow, when using a higher scale factor or an output device with high dpi.

Suggestions for a solution:
1. Remove the limitation in DefBtnWidth completely (except there is a use case where it is really necessary)
2. Make the limitation value variable with public/protected getter and setter and 15 as default value
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021490)
obones   
2018-07-18 15:42   
High DPI support is very poor in the VCL itself, so it's hard to make it work in the JVCL.
That being said, could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021644)
mh   
2019-03-11 22:54   
Is there a need for the 15 px limit?
(0021648)
mh   
2019-03-12 22:38   
Another suggestion for this: make 15px for 96 dpi and automaticaly scale the limit according to screen dpi? What to do in multi display scenarios? Use the dpi of the screen the control is on?
(0021722)
jfudickar   
2019-04-19 21:30   
Yes and yes :-)
(0021732)
mh   
2019-04-24 19:56   
I just created a pull request for a possible solution. I hope it is good enough.
(0021784)
mh   
2019-05-01 10:08   
New improved pull request created:
https://github.com/project-jedi/jvcl/pull/113
(0021791)
jfudickar   
2019-05-02 08:33   
Fixed in Repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6545 [JEDI VCL] 00 JVCL Components minor always 2017-02-12 15:39 2019-05-02 08:33
Reporter: mksjgj Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvInterpreterProgram does not support scientific notation
Description: TJvInterpreterProgram can not handle express with scientific notation, i.e.:

1.2e2+1

 
Tags:
Steps To Reproduce:
Additional Information: please check the attachment for modification, marked by //lht
Attached Files: bug.zip (7,820 bytes) 2017-02-12 15:39
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002671&type=bug
Test1.zip (57,896 bytes) 2018-07-19 04:21
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002702&type=bug
Notes
(0021519)
obones   
2018-07-18 15:51   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021561)
mksjgj   
2018-07-19 04:22   
i can not see any modification for this issue, so the bug is still here.
(0021743)
mh   
2019-04-25 22:25   
Ok, bug.zip contains a modified version of the relevant JVCL unit. If I find the time I might implement the suggestions and create a pull request for this.
(0021748)
mh   
2019-04-26 18:13   
Added pull request for this based on file modifications in bug.zip:
https://github.com/project-jedi/jvcl/pull/93
(0021786)
mh   
2019-05-01 13:44   
Revoked pull request 0000093 due to some formatting and naming issues and replaced it by this one:
https://github.com/project-jedi/jvcl/pull/115
(0021790)
jfudickar   
2019-05-02 08:33   
Fixed in Repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6548 [JEDI VCL] 00 JVCL Components minor always 2017-03-03 16:49 2019-05-02 08:32
Reporter: rmetzger Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvMainMenu and TJvPopupMenu do not use TScreen.MenuFont
Description: Hey,
TJvMainMenu (line 1258) and TJvPopupMenu (line 1839) use the font given by tagNONCLIENTMETRICS.lfMenuFont, but they should use TScreen.MenuFont instead.
BTW, both object correctly use TScreen.MenuFont for measuring menu item (line 1300 and 1881, respectively).
Workaround is simple, just replace SetDefaultMenuFont(Canvas.Font); with FCanvas.Font:=Screen.MenuFont on lines 1258 and 1839.
IMO, Function SetDefaultMenuFont is irrelevant here.
Best regards,
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021517)
obones   
2018-07-18 15:51   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021765)
mh   
2019-04-27 14:41   
Pull request for this created.
https://github.com/project-jedi/jvcl/pull/101
(0021779)
mh   
2019-04-30 21:23   
Pull request replaced by this one:
https://github.com/project-jedi/jvcl/pull/110
(0021789)
jfudickar   
2019-05-02 08:32   
Fixed in Repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6540 [JEDI VCL] 00 JVCL Components minor always 2016-12-09 14:24 2019-05-02 08:32
Reporter: CDametto Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Horizontal reset of dbgrid scrollbar by moving a column
Description: In a DBGrid with dgRowSelect in Options, TitleButton = True and TitleButtonAllowMove = True, whether the horizontal scrollbar is present and you move a column at the right end, the grid is repositioned to the start left.
Tags:
Steps To Reproduce:
Additional Information: This is my correction, in the file JvDBGrid.pas near the bottom of the MouseUp procedure...
Original block:

  if (Button = mbLeft) and (FGridState = gsColSizing) then
  begin
    ALeftCol := LeftCol;
    inherited MouseUp(Button, Shift, X, Y);
    if (dgRowSelect in Options) then
      LeftCol := ALeftCol;
    if Assigned(OnColumnResized) then
      OnColumnResized(Self, FSizingIndex + Byte(not (dgIndicator in Options)) - 1,
        ColWidths[FSizingIndex]);
  end
  else
    inherited MouseUp(Button, Shift, X, Y);
  DoAutoSizeColumns;


I just developed the penultimate row:

  if (Button = mbLeft) and (FGridState = gsColSizing) then
  begin
    ALeftCol := LeftCol;
    inherited MouseUp(Button, Shift, X, Y);
    if (dgRowSelect in Options) then
      LeftCol := ALeftCol;
    if Assigned(OnColumnResized) then
      OnColumnResized(Self, FSizingIndex + Byte(not (dgIndicator in Options)) - 1,
        ColWidths[FSizingIndex]);
  end
  else
  begin
    SI.cbSize := SizeOf(SI); //
    SI.fMask := SIF_POS; // Store scrollbar position
    GetScrollInfo(Handle, SB_HORZ, SI); //
    LockWindowUpdate(Handle);
    try
      inherited MouseUp(Button, Shift, X, Y);
      Perform(WM_HSCROLL, MakeWParam(SB_THUMBPOSITION, SI.nPos), 0); //Repos
    finally
      LockWindowUpdate(0);
    end;
  end;
  DoAutoSizeColumns;
Attached Files: Demo.zip (6,546 bytes) 2019-01-25 10:49
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002713&type=bug
Demo_corrected.zip (54,752 bytes) 2019-01-25 12:07
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002715&type=bug
Notes
(0021407)
CDametto   
2016-12-28 16:35   
The variable SI is declared locally in the procedure as SI: TScrollInfo;
(0021521)
obones   
2018-07-18 15:52   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021601)
CDametto   
2019-01-25 10:53   
The issue is still present in jvcl 3.50 with Delphi 10.3 rio
(0021741)
mh   
2019-04-25 22:14   
Made this pull request out of your proposed fix:
https://github.com/project-jedi/jvcl/pull/91
(0021787)
mh   
2019-05-01 13:51   
Pull request revoked and replaced by this improved one (better variable naming and commenting):
https://github.com/project-jedi/jvcl/pull/116
(0021788)
jfudickar   
2019-05-02 08:32   
Fixed in Repository


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6652 [JEDI VCL] 00 JVCL Components minor always 2018-10-08 10:44 2019-05-01 07:21
Reporter: Gerold Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvHidDeviceController LoadSetupApi returns false
Description: Hi

I have a program for a HID device using TJvHidDeviceController and the program works on most PC's but not on some machines. It turns out, that on these machines these two functions
- SetupDiInstallDeviceInterfaces
- SetupDiRegisterCoDeviceInstallers
are not available.

That means, that LoadSetupApi in JvSetupApi.pas is returning false.

These functions are not used in JvHidControllerClass.pas.

Only these 5 functions are required:
- SetupDiGetDeviceRegistryProperty
- SetupDiGetClassDevs
- SetupDiEnumDeviceInterfaces
- SetupDiGetDeviceInterfaceDetail
- SetupDiDestroyDeviceInfoList

In LoadSetupApi, more than 400 functions are dynamically linked (if case SETUPAPI_LINKONREQUEST is set) and if one fails, than the function returns FALSE.

I am wondering, if it is a good idea to use LoadSetupApi in TJvHidDeviceController. Why not write another function which is linking just the above functions?

Also, would it not be wise to have an overloaded function

function GetModuleSymbolEx(Module: TModuleHandle; SymbolName: string; var ErrorMsg: string): Pointer;

which returns in ErrorMsg the FIRST SymbolName where GetProcAddress failed?

In this case, LoadSetupApi could return, which of the more than 400 linked functions failed.

Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021734)
mh   
2019-04-25 20:43   
Issued pull request for a version which inplements a LoadAPI sort of function inside JvHIDControllerClass unit:

https://github.com/project-jedi/jvcl/pull/89

Please check it.
(0021777)
obones   
2019-04-30 15:31   
I don't like duplication of code, I'd rather have JvSetupApi modified to be able to tell it which of the 400 functions are to be loaded.

But I even think that there should not be any reason to change that because the MSDN documentation says that the two "missing" functions are available since Windows 2000.

So the real question is "On what version of Windows was this a problem?"
(0021780)
mh   
2019-04-30 21:41   
I can agree with the not liking of duplication of code. But I wonder why those two methods mentioned are not available on some machines even if they should be available since Windows 2000, an OS no longer supported by Microsoft since 2006.

Question to the original creator of this issue here: which OS do those machines where it fails run?
(0021782)
Gerold   
2019-05-01 07:21   
I received an answer from one person using my program (which uses TJvHidDeviceController) and he said, that he is using Linux and CrossOver. I did not know this. Maybe the other person is using Linux too with CrossOver (or Wine).

At the moment, my program is working on these machines, cause I created a new unit based on the JvHidController.pas and importing just these functions:

  SetupDiGetDeviceRegistryPropertyA: TSetupDiGetDeviceRegistryPropertyA;
  SetupDiGetDeviceRegistryPropertyW: TSetupDiGetDeviceRegistryPropertyW;
  SetupDiGetDeviceRegistryProperty: TSetupDiGetDeviceRegistryProperty;
  SetupDiGetClassDevsA: TSetupDiGetClassDevsA;
  SetupDiGetClassDevsW: TSetupDiGetClassDevsW;
  SetupDiGetClassDevs: TSetupDiGetClassDevs;
  SetupDiEnumDeviceInterfaces: TSetupDiEnumDeviceInterfaces;
  SetupDiGetDeviceInterfaceDetailA: TSetupDiGetDeviceInterfaceDetailA;
  SetupDiGetDeviceInterfaceDetailW: TSetupDiGetDeviceInterfaceDetailW;
  SetupDiGetDeviceInterfaceDetail: TSetupDiGetDeviceInterfaceDetail;
  SetupDiDestroyDeviceInfoList: TSetupDiDestroyDeviceInfoList;

In fact, almost like the modified JvHidControllerClass unit from above, but I do import 11 functions, not 10.

Anyway, I would like to have an idea, why "LoadSetupApi" returned false.

PS:
I just noticed, that the latest JVCL Daily packages are from 2019-04-30 08:32:24 UTC, but the latest JCL Daily packages are from 2018-04-29 06:27:35 UTC. Is this a bug and for the JCL it should be 2019 and not 2018 or is the JCL realy not updated since more than a year?

Or is my link old?
http://jcl.sourceforge.net/daily/


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6497 [JEDI VCL] 00 JVCL Components feature always 2016-02-24 15:06 2019-04-30 16:15
Reporter: dbedrenko Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Make TJvValidateEdit.Value return Cardinal for dfHex
Description: The type returned by the `TJvValidateEdit.Value` property depends on the chosen `TJvValidateEdit.DisplayFormat`.

I have some `TJvValidateEdit` elements with `DisplayFormat: dfHex` in which the user can enter a number that fits in a `Cardinal`, e.g. $FFFFFFFF. The problem is that in `TJvCustomValidateEdit.GetValue()`:

    dfHex:
      Result := StrToIntDef('$' + FEditText, 0);

You don't need to worry about supporting negative numbers because `dfHex` prevents the minus sign ("-") being entered.

Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021493)
obones   
2018-07-18 15:44   
Is this a feature request? If yes, please provide a pull request at Github containing the required changes
(0021775)
mh   
2019-04-28 11:07   
Pull request created:
https://github.com/project-jedi/jvcl/pull/109


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6518 [JEDI VCL] 00 JVCL Components minor always 2016-07-21 15:11 2019-04-30 16:14
Reporter: andreykorol Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvHidDeviceController - missed OnDeviceDataError handler setup
Description: TJvHidDevice.CtlCreate constructor is missing setting Controller.OnDeviceDataError to OnDataError. So, in this way TJvHidDeviceReadThread.DoDataError will never call Device.FDataError (user event).
fix patch:
-------------------------------------------------------------------------
diff --git a/JvHidControllerClass.pas b/JvHidControllerClass.pas
index b1f43b2..9264a6e 100644
--- a/JvHidControllerClass.pas
+++ b/JvHidControllerClass.pas
@@ -807,6 +807,7 @@ begin
   FDataThread := nil;
   OnData := Controller.OnDeviceData;
   OnUnplug := Controller.OnDeviceUnplug;
+ OnDataError := Controller.OnDeviceDataError;
 
   FHidFileHandle := CreateFile(PChar(PnPInfo.DevicePath), GENERIC_READ or GENERIC_WRITE,
     FILE_SHARE_READ or FILE_SHARE_WRITE, nil, OPEN_EXISTING, 0, 0);
-------------------------------------------------------------------------
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021504)
obones   
2018-07-18 15:47   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021772)
mh   
2019-04-28 10:45   
Created pull request for this:
https://github.com/project-jedi/jvcl/pull/107


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6538 [JEDI VCL] 00 JVCL Components minor always 2016-12-04 19:28 2019-04-30 16:13
Reporter: bflorac Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvHidControllerClass, BusType should be of type TGUID not string
Description: According to MS, SetupDiGetDeviceRegistryProperty with SPDRP_BUSTYPEGUID returns a 16 byte GUID not a string.

See function: TJvHidPnPInfo.Create()...
FBusType := GetRegistryPropertyString(APnPHandle, ADevData, SPDRP_BUSTYPEGUID);
Tags:
Steps To Reproduce:
Additional Information: To make it backward compatible, one could extract as TGUID and convert to string for the object.

New Function:

function TJvHidPnPInfo.GetRegistryPropertyGuid(PnPHandle: HDEVINFO;
  const DevData: TSPDevInfoData; Prop: DWORD): TGuid;
const
  GUID_NULL: TGUID = '{00000000-0000-0000-0000-000000000000}';
var
  BytesReturned: DWORD;
  RegDataType: DWORD;
begin
  BytesReturned := 0;
  RegDataType := 0;
  Result := GUID_NULL;
  SetupDiGetDeviceRegistryProperty(APnPHandle, ADevData, Prop, RegDataType, PByte(@Result), SizeOf(Result), BytesReturned);
end;

And then in TJvHidPnPInfo.Create():
  FBusType := GuidToString(GetRegistryPropertyString(APnPHandle, ADevData, SPDRP_BUSTYPEGUID));

Attached Files:
Notes
(0021507)
obones   
2018-07-18 15:48   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021770)
mh   
2019-04-28 09:06   
Created a pull request for it, implementing it without local GUID_NULL:
https://github.com/project-jedi/jvcl/pull/106


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6534 [JEDI VCL] 00 JVCL Components major always 2016-11-18 18:10 2019-04-30 16:08
Reporter: acgubamg Platform: RAD Studio berlin 10.1 up2  
Assigned To: obones OS: Windows  
Priority: normal OS Version: 10 Pro  
Status: resolved Product Version: Daily / GIT  
Product Build: 3.50 Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: DecimalPlaces, DecimalPlacesAlwaysShown
Description: The function below:

function TJvCustomNumEdit.GetEditFormat:String;
begin
  Result := ',0'; // must put the thousands separator by default to allow direct edit of value (paste for example)
  if FDecimalPlaces > 0 then
    if FDecimalPlacesAlwaysShown then
       Result := Result + '.' + MakeStr('0', FDecimalPlaces)
    else
       Result := Result + '.' + MakeStr('#', FDecimalPlaces);
end;


There could be changed to the code:
function TJvCustomNumEdit.GetEditFormat:String;
begin
  if FDecimalPlaces = 0 then
    Result := '0'
  else
  begin
    Result := ',0';
    if FDecimalPlacesAlwaysShown then
       Result := Result + '.' + MakeStr('0', FDecimalPlaces)
    else
       Result := Result + '.' + MakeStr('#', FDecimalPlaces);
  end;
end;

Thus if FDecimalPlaces is greater than zero, the separator shown, otherwise, it remains as an integer number. And when using the jvcalcedit1.text as integer, returns only numbers.



Tags:
Steps To Reproduce: Copy the value of a TJvCalcEdit component, with value grander than 1000.
Its will be copied as format: '1.000'

When user paste value on a TDBgrid, ocorrur a error.
See picture attached.
Additional Information:
System Description
Attached Files: erro.png (11,365 bytes) 2016-11-18 18:10
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002669&type=bug
Notes
(0021510)
obones   
2018-07-18 15:49   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021767)
mh   
2019-04-27 14:53   
Created this pull request containing the above proposed fix:
https://github.com/project-jedi/jvcl/pull/103


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6610 [JEDI VCL] 00 JVCL Components minor always 2018-01-14 23:39 2019-04-30 15:57
Reporter: pyscripter Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JVCreateProcess appears to be running forever.
Description: If not (coRedirect in ConsoleOptions) and WaitForTerminate = false no waiting thread is created and the state will stay forever as psRunning since HandleThreadTerminated will never be called and there is no way to reset the state to psReady. From that point the component will become unusable i.e. no other process can be created.

It is better in this case to set the state as Ready instead of Running.

So in TJvCreateProcess.Run

    if coRedirect in ConsoleOptions then
    begin
    end
    else
    if WaitForTerminate then
    begin
    end
    else
    begin
      { http://support.microsoft.com/default.aspx?scid=kb;en-us;124121 }
      WaitForInputIdle(FProcessInfo.hProcess, INFINITE);
      GoToReadyState; //GotoRunningState;
    end;


Tags:
Steps To Reproduce:
Additional Information: The attached file contains the modified code plus introduces a new flag for CREATE_NO_WINDOW
Attached Files: JvCreateProcess.pas (51,105 bytes) 2018-01-14 23:39
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002689&type=bug
Notes
(0021546)
obones   
2018-07-18 16:04   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021761)
mh   
2019-04-27 14:06   
Created this pull request for the issue:
https://github.com/project-jedi/jvcl/pull/98


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6501 [JEDI VCL] 00 JVCL Components minor always 2016-03-25 17:11 2019-04-30 15:18
Reporter: CDametto Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: In JvDBGrid, UseThemedHilighlighting leave out columns with checkbox
Description: Implementing OnCheckIfBooleanField in a JvDBGrid, the column with checkbox
looks as if UseThemedHilighlighting=False
Tags:
Steps To Reproduce:
Additional Information: I have solved adding three line in TJvDBGrid.DrawColumnCell routine:

[...]
  if DefaultDrawing then
  begin
    I := GetImageIndex(Field);
    if I >= 0 then
    begin
      Bmp := GetGridBitmap(TGridPicture(I));
      if Highlight then // <- LINE ADDED
        DrawThemedHighlighting(Canvas, Rect) // <- LINE ADDED
      else // <- LINE ADDED
      Canvas.FillRect(Rect);
      DrawBitmapTransparent(Canvas, (Rect.Left + Rect.Right + 1 - Bmp.Width) div 2,
        (Rect.Top + Rect.Bottom + 1 - Bmp.Height) div 2, Bmp, clOlive);
    end
    else
    begin
      DefaultDrawColumnCell(Rect, DataCol, Column, State);
    end;
  end;
[...]
Attached Files: Demo.zip (54,257 bytes) 2019-01-25 12:42
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002716&type=bug
Notes
(0021491)
obones   
2018-07-18 15:42   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021604)
CDametto   
2019-01-25 12:41   
The issue is still present in jvcl 3.50 with Delphi 10.3 rio
(0021749)
mh   
2019-04-26 20:15   
Pull request with your proposed fix created:
https://github.com/project-jedi/jvcl/pull/94


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6642 [JEDI VCL] 00 JVCL Components crash N/A 2018-07-05 17:59 2019-04-30 15:15
Reporter: swright Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvWaitingGradient/JvImagedrawThread deadlock condition
Description: Execute method calls EnterUnpausableSection

Execute method then calls Synchronize(Draw); which pauses the thread to execute the draw method in main thread.

In the main thread an event occurs that changes the Active property of the JvWaitingGradient to False before the draw event, this makes the main thread Acquire FPauseSection and both threads are deadlocked.

Possibly the Syncronise call should come after the thread releases FPauseSection.
Tags:
Steps To Reproduce:
Additional Information: Delphi 10.1 Berlin / JVCL-3.51 APR 2018 (installed via GetIt package manager)
Attached Files: WGTest.zip (5,340 bytes) 2018-07-18 17:38
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002698&type=bug
Notes
(0021548)
obones   
2018-07-18 16:05   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021555)
swright   
2018-07-18 17:39   
fix, move Synchronize(Draw); outside of TCriticalSection.

procedure TJvImageDrawThread.Execute;
begin
  NameThread(ThreadName);
  try
    while not Terminated do
    begin
      Sleep(FDelay);
      EnterUnpauseableSection;
      try
        if Terminated then
          Exit;


      finally
        LeaveUnpauseableSection;
        Synchronize(Draw);
      end;
    end;
  except
    // ignore exception
  end;
end;
(0021751)
mh   
2019-04-26 20:26   
Created a pull request for this one:
https://github.com/project-jedi/jvcl/pull/96


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6632 [JEDI VCL] 00 JVCL Components minor always 2018-04-05 15:50 2019-04-28 17:59
Reporter: Vojtisek Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: saving with JvSaveDialog
Description: We tried to use JvSaveDialog in our C++ project, but we got a issue:
In component we have checked Options -> ofOverwritePrompt.
When we tried to save the file with same name as one already in folder and we didn't get any message about overwriting of file then when we looked to folder file was overwritten.
So for us it seems that option ofOverwritePrompt doesn't work.

We use:
RAD Studio 10 Seattle update 1
JCL 2.8.0.5677
JVCL 3.50

additionally I am attaching the zipped file with example code and compiled exe
which demonstrates it.

Thanks in advance.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: test.7z (1,300,816 bytes) 2018-04-05 15:50
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002693&type=bug
Notes
(0021462)
korecek   
2018-04-05 18:34   
In addition ...
There is also problem with save button which is set to "Open" instead of "Save".
Default setting of title bar is also set to Open...???
It is major severity in my opinion.
(0021776)
mh   
2019-04-28 17:59   
About the wrong button captions and the title bar: could it be because TJvSaveDialog inherits from TJvOpenDialog which inherits from TOpenDialog?

What would happen, if we implemented TJvSaveDialog analog to TJvOpenDialog and inheritig from TSaveDialog then?

Or is there an easier way to fix this available?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6498 [JEDI VCL] Miscellanous minor always 2016-02-29 14:59 2019-04-28 10:48
Reporter: edijs Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Version 2.4  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvMemoryData and CopyStructure
Description: Shouldn't CopyStructure also copy field properties (Required, Visible, etc)?
If I set MyField.Required := False; and then do CopyStructure(), I field required property becomes required = true. Why? Is there any other method I should use?
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: example.pas (1,821 bytes) 2016-02-29 14:59
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002652&type=bug
Notes
(0021500)
obones   
2018-07-18 15:46   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021773)
mh   
2019-04-28 10:48   
As I understand the code, it currently only copies the FieldDefs from source. Now we would need to decide if that is what it shall do or if it shall copy other properties not directly derived from the field defs. if so, we'd need to decide which ones to copy.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6537 [JEDI VCL] 00 JVCL Components major always 2016-12-02 16:42 2019-04-28 10:41
Reporter: Milan Bacik Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvDBComboBox dosn't work corectly when Style = csDropDown
Description: When i set style to csDropDown on TJvDBComboBox:
1. It shows value of KeyField instead of DisplayField.
2. When I select any value from dropdown list, than exception raised, because TJvDBComboBox try insert value in DisplayField(instead of KeyField) to linked DataSource.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021508)
obones   
2018-07-18 15:48   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021771)
mh   
2019-04-28 10:41   
I fear without a demo we won't get much further. How is EnableValues defined in your case?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6554 [JEDI VCL] 00 JVCL Components major always 2017-03-23 16:58 2019-04-27 19:04
Reporter: JMStoorvogel Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: D7: JvTreeItemsEditorForm.dfm contains the property "AlignwithMargins" -> designtime error
Description: For Delphi 7, the jvcl-master\jvcl\design\JvTreeItemsEditorForm.dfm contains the property "AlignwithMargins" for some TCombobox, which doesn't exist in D7.

Therefore, runtime editing of the TreeView Items does not work.

Resolution:
1. edit the .dfm manually and remove the offending property
2. Rebuild jvcl
Tags: AlignwithMargins, Delphi 7.0, JvTreeItemsEditorForm
Steps To Reproduce:
Additional Information:
Attached Files: JvTreeItemsEditorForm.dfm (7,114 bytes) 2017-03-23 22:31
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002675&type=bug
Notes
(0021412)
JMStoorvogel   
2017-03-23 22:34   
Patch is supplied as attached file for the novice user.
(0021515)
obones   
2018-07-18 15:50   
Could you check if the issue is still present in the latest GIT content? If yes, please provide a pull request at Github.
(0021766)
mh   
2019-04-27 14:46   
Added pull request for this, even if I think we could drop D7 support finally. I know this would hurt some folks, but they should really consider upgrading, as there was simply added so much good stuff they miss when sticking to D7... ;-)

https://github.com/project-jedi/jvcl/pull/102


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6572 [JEDI VCL] 00 JVCL Components minor sometimes 2017-05-24 05:05 2019-04-27 15:45
Reporter: zsleo Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: The referenced/requested module is loaded
Description: The referenced/requested module is loaded using Intraweb and CentralGest
Tags:
Steps To Reproduce:
Additional Information: Exception class name: EComponentDesignerException
Exception message: Module "iwcgjqfrmAcctEnqPatient" references another module and cannot be saved until iwfrmMain is loaded
(00170A34){Jcl150.bpl } [48171A34] JclDebug.TJclStackInfoList.Create + $A8
(0017064A){Jcl150.bpl } [4817164A] JclDebug.JclCreateStackList + $1A
(00003783){JclBaseExpert150.bpl} [58004783] JclOtaExceptionForm.TJclExpertExceptionForm.ShowException + $13B
(0000A9AB){JclBaseExpert150.bpl} [5800B9AB] JclOtaUtils.JclExpertShowExceptionDialog + $33
(00004A6A){JclDebugExpert150.bpl} [58155A6A] JclDebugIdeImpl.TJclDebugExtension.BuildProject + $7A
(0004CB7F){designide150.bpl} [2107DB7F] ComponentDesigner.CheckNoFixups (Line 3890, "ComponentDesigner.pas" + 14) + $3E
(00009C1B){rtl150.bpl } [5003AC1B] System.TMonitor.Exit (Line 12537, "System.pas" + 2) + $7
(000006FE){exceptiondiag150.bpl} [516416FE] SysInit.@GetTls (Line 428, "SysInit.pas" + 23) + $0
(000738F8){exceptiondiag150.bpl} [516B48F8] JclHookExcept.DoExceptNotify (Line 267, "JclHookExcept.pas" + 27) + $0
(00006560){rtl150.bpl } [50037560] System.@FreeMem (Line 3768, "System.pas" + 20) + $0
(0000B0B0){rtl150.bpl } [5003C0B0] System.@UStrClr (Line 16968, "System.pas" + 14) + $0
(0000D31C){rtl150.bpl } [5003E31C] System.@FinalizeArray (Line 24131, "System.pas" + 70) + $0
(0009196D){rtl150.bpl } [500C296D] Contnrs.TObjectList.Notify (Line 331, "Contnrs.pas" + 3) + $6
(00009924){rtl150.bpl } [5003A924] System.TMonitor.Destroy (Line 12347, "System.pas" + 0) + $0
(00009193){rtl150.bpl } [5003A193] System.TObject.CleanupInstance (Line 11189, "System.pas" + 20) + $0
(00006560){rtl150.bpl } [50037560] System.@FreeMem (Line 3768, "System.pas" + 20) + $0
(000090D0){rtl150.bpl } [5003A0D0] System.TObject.FreeInstance (Line 11050, "System.pas" + 2) + $2
(0000979E){rtl150.bpl } [5003A79E] System.@ClassDestroy (Line 12163, "System.pas" + 0) + $2
(00009109){rtl150.bpl } [5003A109] System.TObject.Destroy (Line 11064, "System.pas" + 1) + $4
(00009118){rtl150.bpl } [5003A118] System.TObject.Free (Line 11069, "System.pas" + 1) + $4
(0009196D){rtl150.bpl } [500C296D] Contnrs.TObjectList.Notify (Line 331, "Contnrs.pas" + 3) + $6
(0006C534){rtl150.bpl } [5009D534] Classes.TList.SetCount (Line 3803, "Classes.pas" + 17) + $8
(00009E9B){rtl150.bpl } [5003AE9B] System.TMonitor.TryEnter (Line 12699, "System.pas" + 1) + $0
(00009A38){rtl150.bpl } [5003AA38] System.TMonitor.Enter (Line 12406, "System.pas" + 4) + $2
(000098F0){rtl150.bpl } [5003A8F0] System.TMonitor.CheckOwningThread (Line 12332, "System.pas" + 2) + $0
(00009BC6){rtl150.bpl } [5003ABC6] System.TMonitor.Exit (Line 12515, "System.pas" + 1) + $2
(0006C01C){rtl150.bpl } [5009D01C] Classes.TList.Clear (Line 3524, "Classes.pas" + 2) + $4
(00009924){rtl150.bpl } [5003A924] System.TMonitor.Destroy (Line 12347, "System.pas" + 0) + $0
(00009193){rtl150.bpl } [5003A193] System.TObject.CleanupInstance (Line 11189, "System.pas" + 20) + $0
(00006560){rtl150.bpl } [50037560] System.@FreeMem (Line 3768, "System.pas" + 20) + $0
(000090D0){rtl150.bpl } [5003A0D0] System.TObject.FreeInstance (Line 11050, "System.pas" + 2) + $2
(0000979E){rtl150.bpl } [5003A79E] System.@ClassDestroy (Line 12163, "System.pas" + 0) + $2
(000098F0){rtl150.bpl } [5003A8F0] System.TMonitor.CheckOwningThread (Line 12332, "System.pas" + 2) + $0
(00009BE2){rtl150.bpl } [5003ABE2] System.TMonitor.Exit (Line 12523, "System.pas" + 9) + $7
(00009C1B){rtl150.bpl } [5003AC1B] System.TMonitor.Exit (Line 12537, "System.pas" + 2) + $7
(0007E1EA){exceptiondiag150.bpl} [516BF1EA] JclDebug.TJclGlobalStackList.AddObject (Line 3727, "JclDebug.pas" + 12) + $6
(0007EB82){exceptiondiag150.bpl} [516BFB82] JclDebug.JclCreateStackList (Line 4044, "JclDebug.pas" + 2) + $7
(0007EA23){exceptiondiag150.bpl} [516BFA23] JclDebug.DoExceptionStackTrace (Line 3984, "JclDebug.pas" + 17) + $E
(0004CB7F){designide150.bpl} [2107DB7F] ComponentDesigner.CheckNoFixups (Line 3890, "ComponentDesigner.pas" + 14) + $3E
(00009C1B){rtl150.bpl } [5003AC1B] System.TMonitor.Exit (Line 12537, "System.pas" + 2) + $7
(000006FE){exceptiondiag150.bpl} [516416FE] SysInit.@GetTls (Line 428, "SysInit.pas" + 23) + $0
(000738F8){exceptiondiag150.bpl} [516B48F8] JclHookExcept.DoExceptNotify (Line 267, "JclHookExcept.pas" + 27) + $0
(0007395F){exceptiondiag150.bpl} [516B495F] JclHookExcept.HookedRaiseException (Line 287, "JclHookExcept.pas" + 6) + $7
(0004CB7F){designide150.bpl} [2107DB7F] ComponentDesigner.CheckNoFixups (Line 3890, "ComponentDesigner.pas" + 14) + $3E
(0004CD59){designide150.bpl} [2107DD59] ComponentDesigner.TComponentRoot.WriteRootStream (Line 3935, "ComponentDesigner.pas" + 1) + $7
(0000BFFC){IDEFixPack.dll} [0B69CFFC]
(00049F89){designide150.bpl} [2107AF89] ComponentDesigner.TComponentRoot.GetRootStream (Line 2763, "ComponentDesigner.pas" + 14) + $5
(0004EE0A){designide150.bpl} [2107FE0A] ComponentDesigner.TComponentRoot.Save (Line 4734, "ComponentDesigner.pas" + 1) + $2
(000AEB53){delphicoreide150.bpl} [21B8FB53] DelphiModule.TPascalCodeMgrModHandler.SaveFile (Line 1474, "DelphiModule.pas" + 2) + $8
(0016E488){coreide150.bpl} [208AF488] SourceModule.TCodeISourceModule.SaveFile (Line 1508, "SourceModule.pas" + 2) + $26
(0016BB30){coreide150.bpl} [208ACB30] SourceModule.TSourceModule.SaveFile (Line 653, "SourceModule.pas" + 3) + $23
(0033375A){coreide150.bpl} [20A7475A] DocModul.TDocModule.TheMalteseFalcon (Line 1422, "DocModul.pas" + 60) + $6
(001093F5){rtl150.bpl } [5013A3F5] Rtti.RawInvoke (Line 5538, "Rtti.pas" + 46) + $0
(0010975A){rtl150.bpl } [5013A75A] Rtti.Invoke (Line 5729, "Rtti.pas" + 38) + $6
(001025D9){rtl150.bpl } [501335D9] Rtti.TRttiInstanceMethodClassic.GetCallingConvention (Line 4103, "Rtti.pas" + 1) + $2
(00102F7F){rtl150.bpl } [50133F7F] Rtti.TRttiInstanceMethodEx.DispatchInvoke (Line 4408, "Rtti.pas" + 130) + $17
(00109BC0){rtl150.bpl } [5013ABC0] Rtti.TRttiMethod.Invoke (Line 5859, "Rtti.pas" + 1) + $11
(003333C6){coreide150.bpl} [20A743C6] DocModul.TDocModule.Save (Line 1346, "DocModul.pas" + 3) + $23
(0016CC4F){coreide150.bpl} [208ADC4F] SourceModule.TSourceModule.Save (Line 1002, "SourceModule.pas" + 13) + $B
(0000FA33){rtl150.bpl } [50040A33] System.TInterfacedObject._Release (Line 28243, "System.pas" + 1) + $3
(00338398){coreide150.bpl} [20A79398] DocModul.SaveModifiedModules (Line 3554, "DocModul.pas" + 57) + $7
(0009CDCF){coreide150.bpl} [207DDDCF] BuildHost.TBuildHost.Prepare (Line 427, "BuildHost.pas" + 4) + $0
(0009C335){coreide150.bpl} [207DD335] BuildHost.TBuildHost.Build (Line 185, "BuildHost.pas" + 9) + $3
(0009C0C0){coreide150.bpl} [207DD0C0] BuildHost.Build (Line 136, "BuildHost.pas" + 4) + $A
(000A9B79){coreide150.bpl} [207EAB79] ProjectGroupBuilder.BuildProjects (Line 139, "ProjectGroupBuilder.pas" + 1) + $17
(000D9ABB){coreide150.bpl} [2081AABB] ProjectGroup.TProjectGroup.CompileProjects (Line 847, "ProjectGroup.pas" + 1) + $23
(000D975D){coreide150.bpl} [2081A75D] ProjectGroup.TProjectGroup.CompileActive (Line 695, "ProjectGroup.pas" + 4) + $10
(000E035D){coreide150.bpl} [2082135D] ProjectGroup.TProjectGroupWrapper.CompileActive (Line 2792, "ProjectGroup.pas" + 0) + $5
(0002E54A){bds.exe } [0041F54A] Sanctuary.Util..TFileMutexImpl (Line 13, "Sanctuary.Util.pas" + 0) + $112E
(0002DC4B){bds.exe } [0041EC4B] Sanctuary.Util..ESlipException (Line 13, "Sanctuary.Util.pas" + 0) + $82F
(00004A28){JclDebugExpert150.bpl} [58155A28] JclDebugIdeImpl.TJclDebugExtension.BuildProject + $38
(0007DD6F){rtl150.bpl } [500AED6F] Classes.TBasicAction.Execute (Line 12988, "Classes.pas" + 3) + $7
(00019A15){vcl150.bpl } [5026AA15] ActnList.TContainedAction.Execute (Line 448, "ActnList.pas" + 8) + $2C
(0001A7F0){vcl150.bpl } [5026B7F0] ActnList.TCustomAction.Execute (Line 1094, "ActnList.pas" + 7) + $8
(00026FBA){IDEFixPack.dll} [0B6B7FBA] Unknown function at UnregisterChangeDirectoryNotifier + $18072
(0007DC33){rtl150.bpl } [500AEC33] Classes.TBasicActionLink.Execute (Line 12917, "Classes.pas" + 2) + $7
(00022505){vclactnband150.bpl} [21773505] ActnMenus.TCustomActionMenuBar.ExecAction (Line 1071, "ActnMenus.pas" + 6) + $D
(00023D5C){vclactnband150.bpl} [21774D5C] ActnMenus.TCustomActionMenuBar.TrackMenu (Line 1837, "ActnMenus.pas" + 19) + $15
(00027386){vclactnband150.bpl} [21778386] ActnMenus.TCustomActionMainMenuBar.TrackMenu (Line 3574, "ActnMenus.pas" + 5) + $3
(000220D6){vclactnband150.bpl} [217730D6] ActnMenus.TCustomActionMenuBar.CMEnterMenuLoop (Line 956, "ActnMenus.pas" + 0) + $2
(0002CF6C){vcl150.bpl } [5027DF6C] Controls.TControl.WndProc (Line 7074, "Controls.pas" + 91) + $6
(00009EBE){rtl150.bpl } [5003AEBE] System.TMonitor.TryEnter (Line 12708, "System.pas" + 10) + $0
(00009A38){rtl150.bpl } [5003AA38] System.TMonitor.Enter (Line 12406, "System.pas" + 4) + $2
(000098F0){rtl150.bpl } [5003A8F0] System.TMonitor.CheckOwningThread (Line 12332, "System.pas" + 2) + $0
(00009BE2){rtl150.bpl } [5003ABE2] System.TMonitor.Exit (Line 12523, "System.pas" + 9) + $7
(00009C1B){rtl150.bpl } [5003AC1B] System.TMonitor.Exit (Line 12537, "System.pas" + 2) + $7
(00011ECF){vcl150.bpl } [50262ECF] Graphics.FreeMemoryContexts (Line 7021, "Graphics.pas" + 12) + $8
(00030ED0){vcl150.bpl } [50281ED0] Controls.TWinControl.MainWndProc (Line 9552, "Controls.pas" + 3) + $6
(00030EE5){vcl150.bpl } [50281EE5] Controls.TWinControl.MainWndProc (Line 9555, "Controls.pas" + 6) + $0
(0007EA64){rtl150.bpl } [500AFA64] Classes.StdWndProc (Line 13491, "Classes.pas" + 8) + $0
(0004E6E9){CnWizards_DXE.dll} [0BB2F6E9]
(00031830){vcl150.bpl } [50282830] Controls.TWinControl.WndProc (Line 9831, "Controls.pas" + 144) + $6
(00009EBE){rtl150.bpl } [5003AEBE] System.TMonitor.TryEnter (Line 12708, "System.pas" + 10) + $0
(0004E6E9){CnWizards_DXE.dll} [0BB2F6E9]
(00023E72){vclactnband150.bpl} [21774E72] ActnMenus.TCustomActionMenuBar.WndProc (Line 1876, "ActnMenus.pas" + 25) + $4
(00030ED0){vcl150.bpl } [50281ED0] Controls.TWinControl.MainWndProc (Line 9552, "Controls.pas" + 3) + $6
(0007EA64){rtl150.bpl } [500AFA64] Classes.StdWndProc (Line 13491, "Classes.pas" + 8) + $0
(000CF21B){vclide150.bpl} [2121021B] IDEVirtualTrees.TVirtualTreeHintWindow.IsHintMsg (Line 7032, "IDEVirtualTrees.pas" + 7) + $13
(00107AF7){vcl150.bpl } [50358AF7] Forms.TApplication.ProcessMessage (Line 9760, "Forms.pas" + 23) + $1
(00107B3A){vcl150.bpl } [50358B3A] Forms.TApplication.HandleMessage (Line 9790, "Forms.pas" + 1) + $4
(00107E65){vcl150.bpl } [50358E65] Forms.TApplication.Run (Line 9927, "Forms.pas" + 26) + $3
Attached Files:
Notes
(0021529)
obones   
2018-07-18 15:56   
There is no mention of the JVCL here, I don't see how we could help
(0021763)
mh   
2019-04-27 14:15   
I'm for closing this one. It does mention JCL due to the stack trace generated by JCL, but that's not our problem.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6655 [JEDI VCL] 00 JVCL Components block always 2018-11-21 22:00 2019-04-27 15:44
Reporter: plipla1 Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Delphi 10.3 JVCL installation impossible
Description: Installing JCL is possible. But only when cloning from GIT. Downloading a ZIP from GIT and manually pasting jedi.inc won't work.

Here the major / blocking problem:
installing JVCL is completely impossible with Delphi 10.3

While the installer can get compiled and executed, clicking on Install (Win32 and W64) it stops compiling instantly with

...\lib\jvcl-2018\run\JvAppIniStorage.pas(248) Error: E2003 Undeclared Identifier: 'IndexOf'
...\lib\jvcl-2018\run\JvAppIniStorage.pas(257) Error: E2010 Incompatible types: 'TStringList' und 'TMemIniFile.TSections'

Needs a fix fast.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: jvcl-run.zip (53,354 bytes) 2018-11-23 04:15
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002710&type=bug
514.gz (10,334 bytes) 2018-12-04 13:55
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002711&type=bug
Notes
(0021591)
pka4916   
2018-11-22 03:28   
Same problem.
Downloaded from GitHub. Did stated that it was 10.3 Compatible.
(0021592)
cacofony   
2018-11-23 04:18   
I have attached some modified file, these changes allow me to compile on Rio. I have not tested any backwards compatibility.

Primary issues

DWL_MSGRESULT; not assigned in JvDialogs , so just changed to 0
procedure TJvOpenDialog.WndProc(var Msg: TMessage);
SetWindowLong(Handle, 0, Result);

TCollectionNotification prefix for cnAdded, cnExtracting,cnDeleting
in jvTabBar, jvSimScope, jvScheduledEvents, jvListComb, jvtimerList


Removal of all {$IFDEF DELPHI2009_UP} code in JvAppIniStorage
(0021593)
jfudickar   
2018-12-04 22:46   
Please do a complete fresh download and rebuild all sources.
I had no problem to install it into 10.3
(0021594)
jfudickar   
2018-12-04 22:46   
Please do a complete fresh download and rebuild all sources.
I had no problem to install it into 10.3
(0021599)
Markus34   
2018-12-17 12:55   
Please do a complete fresh download and rebuild all sources.
I also had no problem to install it into 10.3
__________
0006655 https://goo.gl/rEgccS
(0021615)
mh   
2019-03-07 21:03   
This one is a partial duplicate of this report, but the duplicate contains more in depth information about the JvAppIniStorage issue:
http://issuetracker.delphi-jedi.org/view.php?id=6665
(0021769)
jfudickar   
2019-04-27 15:44   
Seems to be duplicated


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6433 [JEDI VCL] 00 JVCL Components crash always 2015-08-21 12:28 2019-04-27 15:43
Reporter: Milan Bacik Platform:  
Assigned To: jfudickar OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvCheckedComboBox crash in destructor
Description: TJvCheckedComboBox crash when on MDIChild form. It need to be poped up and focused(just after clicked some checkbox). When in this moment form close, TJvCheckedComboBox crashed with this exception: EInvalidopearation with message 'Control 'JvCheckedComboBox1' has no parent window'.
Tags:
Steps To Reproduce:
Additional Information: Atached simple example in C++ Builder 2010. Just open child form with button. Than open popup in combo and click any checkbox. Now wait for timer which close form. Btw. In my real application form is closed by hitting Esc, which somehow bypased closing poppup first and is catched by button with ModalResult = mrCancel.
Attached Files: CheckedComboBox.zip (8,932 bytes) 2015-08-21 12:28
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002626&type=bug
CheckedComboBox_delphi.zip (64,339 bytes) 2015-09-14 16:14
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002628&type=bug
Notes
(0021202)
obones   
2015-09-14 16:17   
I have attached your sample along with Delphi files which makes for easier debugging.

To me this is an issue in the VCL and have reported it here:
https://quality.embarcadero.com/browse/RSP-12241
(0021754)
mh   
2019-04-26 20:47   
According to Embarcadero QP this is fixed in Rio and I ran the Delphi demo provided without crash in Rio Update 1.

I clicked the button, got the child form, opened the combo box dropdown and selected a car manufacturer. Waited until the MDI form was closed, closed the program and got no crash at all.

=> looks like this is fixed
(0021768)
jfudickar   
2019-04-27 15:43   
Fixed in Rio


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6641 [JEDI VCL] 00 JVCL Components minor always 2018-06-25 10:10 2019-04-27 14:00
Reporter: tstoicescu Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvDBTreeView - insert record
Description: /Jvcl/Run/JvDBTreeView.pas:
Bug: Editing items's parent in State = dsInsert, it do Post and (wrong) Insert again (a new item). Normally it should edit same item.
so: OldState isn't needed: it should never reinsert new item.
Stack:
TCustomTreeView.CNNotify ... TVN_SELCHANGEDA, TVN_SELCHANGEDW: ... Change
TJvCustomDBTreeView.Change ::
 case OldState of
      dsEdit:
        FDataLink.DataSet.Edit;
      dsInsert:
        FDataLink.DataSet.Insert; /// Edit
    end;
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021549)
obones   
2018-07-18 16:05   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021760)
mh   
2019-04-27 14:00   
I found the code snippet referenced above but it looks exactly like above. Question: what exactly shall be changed there? Shall in dsInsert also the Edit method be called? Or is the code as is already fixed?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6571 [JEDI VCL] 02 Installation block have not tried 2017-05-21 17:17 2019-04-27 13:50
Reporter: mariodosreis Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JVCL 3.49 (JVCLInstall.exe)
Description: When running/install JVCLInstall.exe i allways get this message:

"Access violation at Adress 772E8026 in module 'ntdll.dll'. Write of
address 50061FD8".
And it blocks here!
It started 5/10 days ago.
Can you help
Best Regards
Tags:
Steps To Reproduce:
Additional Information: It was working fine it just start after a normal reboot! I allways tried to
repair windows but it seams theris nothing to repair.
I also downloaded it again but the very same trouble!
Attached Files: AccessViolation772E8026-ntdll_dll.png (6,885 bytes) 2017-05-21 17:17
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002678&type=bug
Notes
(0021530)
obones   
2018-07-18 15:57   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021586)
mh   
2018-10-28 17:29   
Which version of Windows? At which point of the installer, at startup already?
(0021597)
chatinum   
2018-12-12 09:49   
https://www.chatinum.com
(0021637)
mh   
2019-03-11 22:07   
Which settings in the installer have been used?
(0021759)
mh   
2019-04-27 13:50   
Which version of Delphi?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6546 [JEDI VCL] 99 Other feature always 2017-02-20 23:01 2019-04-27 13:49
Reporter: raymondwk Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: MegaDemo does not compile: multiple errors
Description: AData variable needed to be changed from Cardinal to void. Forgot where.

fballs.pas requires a function for PointInEllipse, which I found in QWindows (in the archive folder).

However, QWindows requires QDialogs, but QDialogs.pas/dcu is not included in the distribution.

Some other bugs that I did not document.

Basically, the MegaDemo does not compile.
Tags:
Steps To Reproduce:
Additional Information: Using Delphi XE3.
Attached Files:
Notes
(0021409)
raymondwk   
2017-02-21 22:50   
Category should have been "Severe".
(0021518)
obones   
2018-07-18 15:51   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021642)
mh   
2019-03-11 22:39   
If this is still the case, the demo app already exists: the JEDI mega demo!
(0021758)
mh   
2019-04-27 13:49   
Where do I find the current version of the mega demo? I didn't spot it in Jvcl Github repository yet.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6549 [JEDI VCL] 00 JVCL Components crash always 2017-03-07 00:26 2019-04-27 13:26
Reporter: davedelage Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvHidDeviceController fails
Description: JVCL version actually 3.49 but problem exists in earlier version.
Compiling example SimpleHidWrite using Rad Studio 2010 on Windows 8.1 and it works as advertised. Copy SimpleHidWrite.exe to alternate machine running Windows 8.1 Pro or Windows 10 and executable fails during startup with exception "Device cannot be identified."

Specifically, in the 8.1 Pro machine, EControllerError in module SimpleHidWrite.exe at 000CBA49 Device cannot be identified.

Getting the same problem with my USB/HID code which works in 8.1 but not others. Attempting to trace leads to the idea that the problem is thread related. Compiled file attached.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: SimpleHIDWrite.exe (1,241,088 bytes) 2017-03-07 00:26
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002673&type=bug
Notes
(0021414)
obones   
2017-03-24 17:37   
Please use the latest GIT content, many changes have occurred in this area
(0021416)
davedelage   
2017-03-25 20:00   
Thank you. I downloaded the most recent source (JVCL3-Source-2017-03-25). Since the problem appears in the USB/HID application, I checked hid.pas, hidtoken.pas and hidusage.pas against the 3.49 release using WinMerge. It reports all the new files are identical to their older versions. Could it have been fixed somewhere else?
Dave
(0021423)
davedelage   
2017-04-18 18:41   
I found this info when looking at a separate issue, perhaps it will help someone smarter than me find the problem with the JvHidDeviceController component code.

"FPC [or other language] currently uses 32 bits (4 bytes) for integers, whether the machine is a 32-bit or 64-bit machine. This will cause code expecting an integer and a pointer to be the same size to fail as a 64bit machine uses 64-bit pointers."
(0021522)
obones   
2018-07-18 15:53   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021622)
mh   
2019-03-07 21:32   
Is this the same as this one?
http://issuetracker.delphi-jedi.org/view.php?id=6664
(0021652)
mh   
2019-03-19 20:02   
About this one:
"FPC [or other language] currently uses 32 bits (4 bytes) for integers, whether the machine is a 32-bit or 64-bit machine. This will cause code expecting an integer and a pointer to be the same size to fail as a 64bit machine uses 64-bit pointers."

Does FPC have NativeInt or NativePtr datatypes? If yes that might be a solution to this issue at least for newer Delphi versions.
(0021653)
obones   
2019-03-20 09:02   
Yes, FPC has NativeInt
And considering compatibility with older versions, the JvJCLUtils declares NativeInt properly for compiler versions where it is missing/bogus
(0021737)
mh   
2019-04-25 21:25   
So do you propose to switch the code of JvHidDeviceController to NativeInt or NativePtr where applicable?
(0021745)
obones   
2019-04-26 09:51   
I strongly believe that this has nothing to do with the issue at hand.
The 32/64 pointer size is only valid if the application itself is 64bits.
If the same application works on a computer, and not on another one, 32 versus 64 is definitely not an issue but rather an issue with drivers or windows version.

Now, if inside JvHidDeviceController there is code that casts pointers (or handles) to Cardinal/LongInt/Integer, then this is an issue that needs to be fixed by using a NativeInt cast instead.
(0021755)
mh   
2019-04-27 13:26   
I had a short look at this unit now and didn't spot any suspicious casts. So the issue seems to really originate from somewhere else.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6424 [JEDI VCL] 00 JVCL Components major always 2015-07-28 15:41 2019-04-26 20:34
Reporter: jkelley Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvValidateEdit only enforces min/max if losing focus
Description: TJvValidateEdit performs its min and max value validation as part of its FocusKilled (WM_KILLFOCUS) handler. However, as explained by Raymond Chen in http://blogs.msdn.com/b/oldnewthing/archive/2004/04/19/115912.aspx, this is the wrong place to do validation. In particular, pressing Enter to close a dialog with an OK button never triggers FocusKilled, so TJvValidateEdit.Value can have an invalid value if it's read during the OK button's Click event.

The best fix I can think of is for reading the Value property to trigger the same canonicalize-and-validate logic that FocusKilled does. This should only happen during normal runtime, so I believe this should only be done if ComponentState does not include csDesigning or csWriting.

Does this sound reasonable? Are there potential issues or complications that I'm missing? If so, I can submit a pull request.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JvValidateEdit.zip (4,995 bytes) 2015-09-14 22:14
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002629&type=bug
Notes
(0021196)
obones   
2015-09-14 11:27   
Please provide the zipped sources of a sample application showing this
(0021207)
jkelley   
2015-09-14 22:16   
1. Run the attached sample application.
2. Click the Test button to open the modal dialog.
3. Enter a value of -1, which is below the configured MinValue of 0.
4. *Click* the OK button. Note that the message box displays the correctly enforced minimum value of 0, and the edit is set back to 0.
5. Click the Test button again to reopen the modal dialog.
6. Reenter a value of -1.
7. Without clicking anywhere or changing the keyboard focus, *press Enter* to activate the default OK button. Note that the message box displays an invalid value of -1, although the edit is set back to 0.
(0021753)
mh   
2019-04-26 20:34   
I'd say your description and how you plan to fix it is worth a try! Please create that pull request suggested!


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6485 [JEDI VCL] 00 JVCL Components major always 2016-01-06 04:35 2019-04-26 20:24
Reporter: mator Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: jvInterpreter cannot handle repeated uses
Description: TestScript uses 'lib\Lib1' and 'lib\Lib2'
Lib1 uses 'lib\Lib2'

The jvInterpreter throws a duplicate identifier on whatever the first identifier is (constant, variable, or function) in Lib2.
Tags:
Steps To Reproduce:
Additional Information: This can be fixed by adding a single line of code to jvInterpreter.pas -> procedure TJvInterpreterUnit.ReadUnit (starting at line 7964):

procedure TJvInterpreterUnit.ReadUnit(const UnitName: string);
var
  OldUnitName: string;
  OldSource: string;
  S: string;
begin
  if FAdapter.UnitExists(UnitName) then
    Exit;
  FAdapter.AddSrcUnit(FCurUnitName, '', '');
  FAdapter.AddSrcUnit(UnitName, '', ''); // the line of code added
...


Adding this line of code simply prevents the jvInterpreter from attempting to call InterpretUnit on the same unit twice.
Attached Files:
Notes
(0021268)
mator   
2016-01-17 18:49   
I need to correct something here. The example I gave is actually a trivial example which can be resolved by changing the uses line to just

uses 'lib\Lib1';

A better example:

Lib1 uses Lib3
Lib2 uses Lib3

putting:

uses 'lib\Lib1', 'lib\Lib2';

Will always lead to a redeclared identifier error.
(0021478)
obones   
2018-07-18 15:36   
Please provide the zipped sources of an application showing this.
(0021558)
mator   
2018-07-18 19:29   
Hi obones,

Sorry but I've moved on from using Delphi/Jedi for development for my applications and won't be able to provide an example.

Regards,
- Mator
(0021750)
mh   
2019-04-26 20:24   
Created a pull request for this:
https://github.com/project-jedi/jvcl/pull/95


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6612 [JEDI VCL] 99 Other feature N/A 2018-01-21 15:19 2019-04-26 17:13
Reporter: marcowobben Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Please upgrade Mantis
Description: This ticket system is still running Mantis 1.1.6 while Mantis 2.x is available for a long time, with many fixes itself.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021544)
obones   
2018-07-18 16:04   
Yes, but it requires time to do the migration, which is a luxury that I don't have at the moment
(0021639)
mh   
2019-03-11 22:25   
Can somebody else with the relevant knowledge help out maybe?
(0021725)
Kyle_Katarn   
2019-04-20 18:57   
I did the migration for KC Softwares a few month ago : it was quite easy and straight foward.
(0021744)
obones   
2019-04-26 09:06   
This is being worked on, but we have no ETA just yet
(0021747)
mh   
2019-04-26 17:13   
More important would be to fix the uses of ReCaptchaV1 which is no longer supported by Google. They should be replaced by V2 or V3. Affected is at least the Newsgroup web interface and the wiki.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6445 [JEDI VCL] General API block always 2015-09-17 23:37 2019-04-25 21:37
Reporter: rbwinst Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvInterpreter_all won't compile on Delphi 10 Seattle
Description: When I try to install JVCL on Delphi 10 Seattle with the install, the installation fails because JvInterpreter_all.pas won't compile. The error message is D:\jedi\Jvcl_Git\jvcl\jvcl\run\JvInterpreter_all.pas(60) Fatal: F2613 Unit 'JvInterpreter_DBTables' not found.
Tags:
Steps To Reproduce:
Additional Information: Options used:
Build packages: no
IDE Registration: yes
Clear JVCL component palettes: yes
JVCL Developer installation: no
compile debug units: no
Generate Map files: yes
Link Map files in binaries: yes
Compress Map files to .jdbg: no
delete after linking/compression: yes
BPL Directory: C:\Users\Public\Documents\Embarcadero\Studio\17.0\Bpl
Register global design editors: yes
dxgettest support: no
Register JvGif for .gif: yes
Unit Versioning: no
Verbose compiler output: yes
Do not stop on errors: no
Add BPL Directory to PATH: no

Attached Files:
Notes
(0021501)
obones   
2018-07-18 15:46   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021563)
rbwinston   
2018-07-19 18:23   
I no longer have Delphi 10 Seattle installed.
(0021584)
mh   
2018-10-28 17:15   
Does this work in the Delphi version you have installed now?
If not, can you check if the JvInterpreter_DBTables.pas file is in your JVCL directories somewhere or not?
(0021618)
mh   
2019-03-07 21:18   
In my current cloned JVCL repository this file is there several times in several subfolders with several different sizes. Is this really necessary?
(0021739)
mh   
2019-04-25 21:37   
What to do with this report?
In the current version JvInterpreter_DBTables.pas is in the run directory, so it should compile (at least it did for me in Rio Update 1 GetIt JVCL installation)


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6487 [JEDI VCL] 00 JVCL Components major always 2016-01-15 03:05 2019-04-25 21:34
Reporter: cacofony Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvTrayIcon Animate to Tray component visibility issues
Description: http://stackoverflow.com/questions/8624094/delphi-jedi-trayicon-hides-all-frames-bug

When AnimateToTray is in Visibility options, it does not restore Application.ShowMainForm and Application.MainForm.Visible states. It shows the window but 'Visible' is still false for your form after you restore it. That leads any attempt for showing hidden controls to fail since their parent is seemingly not showing.

Placing the following on your code that makes the form visible. Eg TrayIconOnClick

Application.ShowMainForm := True;
Visible := True;

Or turn of AnimateToTray

Thanks Sertac Akyuz on Stack Overflow
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021479)
obones   
2018-07-18 15:36   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021646)
mh   
2019-03-11 23:09   
Where exactly in JVCL would we need to put the suggested fix?
(0021738)
mh   
2019-04-25 21:34   
ShowApplication does contain this if:

if Application.MainForm <> nil then
      Application.MainForm.Visible := True;

So if the MainForm exists it's visibility will be turned to true.
So if this is not enough, the failure is somewhere else. Right?
So if cacofony could shed some more light on this or provide a small demo showing this we might be able to fix it. The demo linked to in the StackOverflow entry is no longer accessible.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6558 [JEDI VCL] 00 JVCL Components minor always 2017-03-24 18:22 2019-04-25 21:23
Reporter: Wosi Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Interfaces with the same GUID
Description: The interfaces IJvDynControlDblClick and IJvDynControlPanel are using the same GUID.

The interface IPageList is declared in JvTabBar.pas AND JvPageList.pas with the same GUID.

The interface IUnit is declared in Packages.pas AND PDPackageLoader.pas with the same GUID. The two versions expose different sets of methods.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021514)
obones   
2018-07-18 15:50   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021623)
mh   
2019-03-07 21:40   
I checked this and as it still is the case I created a pull request:
https://github.com/project-jedi/jvcl/pull/62
Please apply it.
(0021626)
mh   
2019-03-10 10:40   
Replaced the pull request with this one, as my old one contained unrelated modifications as well (Git is still new for me):
https://github.com/project-jedi/jvcl/pull/68
(0021633)
obones   
2019-03-11 17:04   
The pull request is now merged in GIT, which fixes IJvDynControlDblClick
The other interfaces remain, though.
(0021635)
mh   
2019-03-11 21:56   
You mean there are further duplicate GUIIDs? Otherwise thus Report could bei closed.
(0021721)
mh   
2019-04-18 20:35   
Regarding those two which still have the same GUIIDs: what sense does it make to have these interfaces declared identically in two different units? Would it make sense to pull those out each in an interface only unit? If so, is there a naming convention for such units?

The interface IPageList is declared in JvTabBar.pas AND JvPageList.pas with the same GUID.

The interface IUnit is declared in Packages.pas AND PDPackageLoader.pas with the same GUID. The two versions expose different sets of methods.
(0021736)
mh   
2019-04-25 21:23   
What does this one mean:

The interface IUnit is declared in Packages.pas AND PDPackageLoader.pas with the same GUID. The two versions expose different sets of methods.

I didn't find the mentioned units in JVCL.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6673 [JEDI VCL] 00 JVCL Components minor always 2019-04-24 08:22 2019-04-25 20:09
Reporter: vtrhe Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Assigning empty TStrings to TJvSpinEdit.Items raises SListIndexError
Description: Create an empty TStringList and assign it to TJvSpinEdit.Items. This raises a SListIndexError exception.
Tags:
Steps To Reproduce:
Additional Information: procedure TForm1.Button1Click(Sender: TObject);
var
  MyStringList: TStringList;
begin
  MyStringList := TStringList.Create;
  try
    JvSpinEdit1.Items := MyStringList; //<-- raises Exception
  finally
    MyStringList.Free;
  end;
end;


  Possible Solution:
  Unit JvSpin.pas

 ...

  procedure TJvCustomSpinEdit.SetItems(const AValue: TStrings);
  begin
    FItems.Assign(AValue);
    Value := 0;
    if FItems.Count = 0 then // <-- Check for Num of Strings
      Text := ''
    else
      Text := FItems[0];
  end;

 ...

Attached Files: JvSpinEdit_Bug.zip (53,595 bytes) 2019-04-24 08:29
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002721&type=bug
Notes
(0021733)
mh   
2019-04-25 20:01   
Pull request with your fix created:
https://github.com/project-jedi/jvcl/pull/88


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6665 [JEDI VCL] 02 Installation block always 2019-03-03 10:05 2019-04-23 22:55
Reporter: mh Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: 10.3 Rio Update 1: Installer fails to compile JvAppIniStorage.pas
Description: Installer fails to compile the JvAppIniStorage.pas file as Rio made some changes to TMemIniFile JvAppIniStorage.pas needs to adapt to.

The reason is, that JvAppIniStorage.pas accesses the non public/protected FSection field from TMemIniFile via class helper which is no longer present in Rio.

At least between XE8 and Rio 10.3 Update 1 there was a change in TMemIniFile where the code of JVCL has not been completely adapted to.

The change was, that TMemIniFile is now based on TDictionary and the FSection StringList used in the old MemIni code is no longer there. Unfortunately JVCL has several places where it wants to access FSection.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021611)
mh   
2019-03-03 15:18   
Further investigation leads me to the suspiccion that the code path around line 251 which is for Rio and newer makes not much sense. It introduces a ClassHelper which introduces a FSections TStringList field, but this ins nowhere created nor freed and later on it is being accessed.

Shouldn't that code work with the FEsctions dictionary from TMemIniFile?
Another question: the original newsgroup poster's report pointed to line 251 which is in the pre Rio code path. If I'm not mistaken he talked about a Rio x64 isntallation. Why is the 64 bit compiler stepping into this path? Is there an issue with the RTL330_UP define in the 64 bit compiler?
(0021613)
mh   
2019-03-04 22:49   
Ok, looking at it again (after being pointed out that I didn't read it right the first time) I found out that this part of the code is for versions from D2009 to Tokyo, but not for Rio.

But this now leads to the question why the error messages posted by the original reporter of this in the JVCL newsgroup point to line 251 which is inside this block (at least in the JVCL version available via GetIt directly after installing Rio 10.3 Update 1)?

Here's the relevant excerpt from the original report from the newsgroup:

"[Compiling: JvCore260.bpl]
Embarcadero Delphi for Win64 compiler version 33.0
Copyright (c) 1983,2017 Embarcadero Technologies, Inc.

C:\ProgramData\Jvcl 201902Git\jvcl\run\JvAppIniStorage.pas(251) Erreur: E2003 Identificateur non déclaré : 'IndexOf'
C:\ProgramData\Jvcl 201902Git\jvcl\run\JvAppIniStorage.pas(251) Avertissement: W1023 Comparaison de types signés et non signés - opérandes élargis

C:\ProgramData\Jvcl 201902Git\jvcl\run\JvAppIniStorage.pas(260) Erreur: E2010 Types incompatibles : 'TStringList' et 'TMemIniFile.TSections'
JvCore.dpk(2501) Fatale: F2063 Impossible de compiler l'unité utilisée 'JvAppIniStorage.pas' "
(0021695)
jfudickar   
2019-04-14 13:13   
The interesting question for me is, where is this error coming from?
I'm compiling the current release without any problems with latest Rio Relase.
(0021723)
DidierL   
2019-04-20 17:52   
Same problem for me (+1 another one).
I'm also using a french version of Rio 10.3 update 1
[dcc32 Erreur] JvAppIniStorage.pas(251): E2003 Identificateur non déclaré : 'IndexOf'
[dcc32 Erreur] JvTimerList.pas(595): E2003 Identificateur non déclaré : 'cnAdded'

Looks like a problem with RTL330_UP define
(0021728)
DidierL   
2019-04-22 23:33   
I managed to do a clean manual install from GitHub.
But no success with Delphi GetIt utility.
(0021730)
mh   
2019-04-23 20:37   
Ok, if you could install by fetching the verasion from Github,but not the one delivered via GetIt my question would be: what's the difference between those two?
(0021731)
DidierL   
2019-04-23 22:55   
RTL330_UP wasn't defined when I installed with GetIt.
Probably a path issue with jedi.inc


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6369 [JEDI VCL] 02 Installation minor always 2014-12-11 01:07 2019-04-23 03:50
Reporter: Michal Mucha Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: installation issues in BCB 6 and XE7 compilers
Description: I downloaded latest versions of JCL and JVCL from git hub (on 06/12/2014).
I installed both packages in C++ Builder 6 ENT. and C++ Builder XE 7 ENT.
(it is worth mentioning that I do not have the Delphi "personality" - yes such species exists)

I followed the installation procedure as described in the Install instruction for both packages and both compilers. Installation and compilation went fine with some issues which I describe below. I hope these observations and suggestions will help the library developers/maintainers to master their excellent job. Other users may also find thet information useful.


The following issues appeared:

For BCB 6 the installation (ie. JediInstaller.exe and JVCLInstall.exe must be run in priviledged mode to be able to write in "forbidden" directories "c:\Program Files (x86)\Borland\CBuilder6\Projects\Bpl\",
"c:\Program Files (x86)\Borland\CBuilder6\Projects\lib\",
"c:\Program Files (x86)\Borland\CBuilder6\include".
The suggestion is that installation programs could detect system version and
use of forbidden directories and ask user for permission to run in the elevated mode. Obviously this can be done restarting the manually
using "run as administrator" . After component registration some icons (dcr) are missing on the components palette. otherwise for BCB 6 everything went fine.

During the installatin in the XE 7 environment (both 32 and 64 bit version)
JediInstaller.exe (JCL), when option of checking generation of hpp files is
checked it searches for the hhp files in
$(BDSCOMMONDIR)\hpp directory (installer propsed default), not in the one specified by user, although the hpp fies are copied to the user specified directory. JediInstaller does not preservr the dcu and obj files.
The bpl, bpi, dcp, lib are copied to the directories specified in the program.

The JVCLInstall program copies the bpl hpp files to the apropriate directories
but it does not copy the bpi, dcp, lib to the specified directory
$(BDSCOMMONDIR)\dcp but leaves them in the installation program default
in my case "c:\pgms\jedi\jvcl\lib\d21\$(Platform)"
For brieviety I use here $(...) directories macro names used in compiler
environmet variables, but in the installer programs they are fully expanded.

After the registration of components in the IDE, at least one does not
appear on the palette list. In my case it is TJvFormStorage. All
project files seem to be OK, the JvFormPlacement unit, where it is defined is compiled, dcu exists, it exists on the list of RegisterComponent function in
JvSystemReg.pas but it is missing from the palette list.
I do not know if there are more cases like this one.

Can someone give me a hint why that happened, what might be the cause of
the problem?

Regards.
Tags:
Steps To Reproduce:
Additional Information: I posted this mail also on newsportal.delphi-jedi.org
Attached Files:
Notes
(0021477)
obones   
2018-07-18 15:35   
Could you please try again with the latest GIT content?
(0021699)
jfudickar   
2019-04-14 17:14   
I would suggest to close this request.
(0021729)
Michal Mucha   
2019-04-23 03:50   
Unfortunately, I cannot verify the installation procedure at the moment. My hardware/software configuration has changed since the time I reported the problem.
Thank you for the effort.
Regards


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6535 [JEDI VCL] 00 JVCL Components major always 2016-11-24 10:55 2019-04-20 18:59
Reporter: djsmith9 Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Delphi 7 sp 1 on Windows 7 sp 1 JEDI VCL version 3.49 (why not listed in dropdown?)
Description: JVTabPainter doesn't work. Connected TabPainter to JVPageCongtrol and JVTabControl and neither control gets tabs painted at design-time or run-time. switch ownerdraw = false and both controls paint fine. It works on my XP system and I recently installed D7 with JEDI 3.49 on a new Windows 7 so this seems to be related to Windows 7. My installation of JEDI JCL and JVCL on Windows 7 went flawlessly.
Tags:
Steps To Reproduce:
Additional Information: Supplied project shows JVTabcontrol and JVPageControl with JVTabPainter hooked up. When form loads the tabs aren't painted because TabPainter is connected (they paint when it's not connected). The speedbutton then turns ownerdraw on and off and you see the tabs paint and unpaint, only painting when ownerdraw = false.
Attached Files: JVTabPainter.zip (410,177 bytes) 2016-11-24 10:55
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002670&type=bug
Notes
(0021726)
Kyle_Katarn   
2019-04-20 18:59   
"Summary" of this issue to be modified !


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6671 [JEDI VCL] 00 JVCL Components crash always 2019-04-15 14:57 2019-04-17 16:40
Reporter: mh Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Changing TJvDialButton Frequency, Min or Max at runtime leads to exception
Description: Trying to set frequency, min or max property of a TJvDialButton, which had been created at runtime in code, crashes with access violation. The crash is in Unit Vcl.Graphics in the if of this function:

function TBitmap.GetCanvas: TCanvas;
begin
  if FCanvas = nil then

The crash happens after the parent of the TJvDialButton instance had been set. It does not crash if the new value is the default value or if the assignment of the value is before setting the parent.

Tags:
Steps To Reproduce:
Additional Information:
Attached Files: CrashExample.zip (53,631 bytes) 2019-04-15 15:12
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002719&type=bug
Notes
(0021703)
mh   
2019-04-15 22:22   
While I have the question why the Rio Debugger doesn't properly let me debug JVCL (\run directory is in the search path, optimization is off), I land in CPU view and breakpoints inside JvDialButton unit are not honored I managed to find out, that the TBitmap.GetCanvas call which fails fails, because the TBitMap object is nil and the call is in this method:

procedure TJvCustomDialButton.SetTick(Value: Integer; Length: TJvTickLength);
const
  Lengths: array [TJvTickLength] of Byte =
    (tlShortLen, tlMiddleLen, tlLongLen);
var
  P: PTick;
  I: Integer;
begin
  if (Value < FMin) or (Value > FMax) then
    raise EInvalidOperation.CreateResFmt(@SOutOfRange, [FMin, FMax]);
  for I := 0 to FTicks.Count - 1 do
  begin
    P := FTicks.Items[I];
    if P^.Value = Value then
    begin
      if P^.Length <> Lengths[Length] then
      begin
        P^.Length := Lengths[Length];
        P^.Changed := True;
        Invalidate;
      end;
      Exit;
    end;
  end;
  New(P);
  P^.Value := Value;
  P^.Length := Lengths[Length];
  P^.Changed := True;
  P^.Color := clBtnText;
  FTicks.Add(P);
  if HandleAllocated then
  begin
    DrawTick(FBitmap.Canvas, P^);
    DrawTick(Canvas, P^);
  end;
end;

I suspect it is the DrawTick(FBitmap.Canvas, P^); call.
(0021704)
mh   
2019-04-15 22:54   
Further investigation result: FBitmap is being created in the BitmapNeeded method, which is called in two places:

- Paint method
- DrawBorder method.

Ok, FBitmap is not created if we create the component at runtime in code and set Max before it had any chance to get itsself painted.

=> BitmapNeeded method must be called "earlier", but that one contains calls to DrawButton and DrawTicks.
(0021705)
mh   
2019-04-15 23:00   
I tried to place a call to BitmapNeeded as first call in SetMax method to test what happens, but it looks like it never got called.

I created a public method in TJvDialButton which simply calls Bitmap needed, but the compiler says he cannot find this method. But I did save the JVCL unit, did a clean of the demo (the one in the zip of this issue) and checked if I altered the right copy of JvDialButton.pas. What did I do wrong?
(0021706)
mh   
2019-04-15 23:01   
Did another test, altered the Unit1.pas of the attached zip file like this and found out by this, that it works then:

unit Unit1;

interface

uses
  Winapi.Windows, Winapi.Messages, System.SysUtils, System.Variants, System.Classes, Vcl.Graphics,
  Vcl.Controls, Vcl.Forms, Vcl.Dialogs, Vcl.ComCtrls, Vcl.ExtCtrls, Vcl.ToolWin,
  Vcl.StdCtrls, JvDialButton;

type
  TMyDialButton = class(TJvDialButton)
  public
    procedure DoBitmapNeeded;
  end;

  TForm1 = class(TForm)
    FlowPanel1: TFlowPanel;
    CrashButton: TButton;
    procedure CrashButtonClick(Sender: TObject);
  private
// TestDialButton : TJvDialButton;
    TestDialButton : TMyDialButton;
    procedure CreateJvDialogButton;
  public
    { Public-Deklarationen }
  end;

var
  Form1: TForm1;

implementation

{$R *.dfm}

{ TForm1 }

procedure TForm1.CrashButtonClick(Sender: TObject);
begin
  CreateJVDialogButton;
end;

procedure TForm1.CreateJvDialogButton;
begin
// TestDialButton := TJvDialButton.Create(FlowPanel1);
  TestDialButton := TMyDialButton.Create(FlowPanel1);
  TestDialButton.Parent := FlowPanel1;
  TestDialButton.DoBitmapNeeded;
  TestDialButton.Max := 200;
end;

{ TMyDialButton }

procedure TMyDialButton.DoBitmapNeeded;
begin
  BitmapNeeded;
end;

end.
(0021707)
Talkbaze   
2019-04-16 17:35   
https://talkbaze.com/
(0021708)
mh   
2019-04-16 19:25   
Proposed a fix via pull request:
https://github.com/project-jedi/jvcl/pull/76
(0021716)
AHUser   
2019-04-17 16:40   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6544 [JEDI VCL] 00 JVCL Components minor always 2017-01-26 15:42 2019-04-13 15:39
Reporter: akalwa Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvCustomComboEdit (and descendants) ignore the user's caret width setting
Description: Windows allows users to change the caret width (text cursor width) to more than the default 1 pixel. While all contols derived from TCustomEdit work as expected, TJvCustomComboEdit and descendants ignore the user's setting.

The bug is in TJvCustomComboEdit.SetShowCaret().
Here the caret size is set as either 1 or 2 pixel, depending on the font's bold style. But that is not Windows' behaviour. Caret is usually not changed on font style. Instead the caret width should be read from the system settings:

procedure TJvCustomComboEdit.SetShowCaret;
var
  CaretWidth : Integer;
begin
  if not SystemParametersInfo(SPI_GETCARETWIDTH, 0, @CaretWidth, 0) then
  begin
    CaretWidth := 1;
    if fsBold in Font.Style then
      Inc(CaretWidth);
  end;
  CreateCaret(Handle, 0, CaretWidth, GetTextHeight);
  ShowCaret(Handle);
end;
Tags:
Steps To Reproduce:
Additional Information: Control Panel -> Ease of Access Center -> Make the computer easier to see ->
Set the thickness of the blinking cursor
Change the default width from 1 to 3 pixel and apply the changes.

https://techjourney.net/increase-the-thickness-of-blinking-cursor-in-windows/
Attached Files: CaretWidth.zip (1,491 bytes) 2018-07-18 22:18
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002700&type=bug
JvToolEdit.pas.patch (668 bytes) 2018-07-18 22:22
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002701&type=bug
Notes
(0021520)
obones   
2018-07-18 15:52   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021559)
akalwa   
2018-07-18 22:22   
The bug is still there in current git revision. The code in JvToolEdit.pas TJvCustomComboEdit.SetShowCaret() has not been changed.

I've attached a small demo application.
Compile and run the application; open Windows caret settings and change caret with to 4 or higher.
Switch back to the demo application and put focus to the TEdit box; the new caret width will be used. Put focus to the TJvComboEdit box; caret width is still 1.

Please apply attached patch to fix this bug (Sorry, no pull request; still using TortoiseSVN to access the master repository).
(0021560)
akalwa   
2018-07-18 22:23   
On Windows 10, just type "Caret" into the start menu to open the settings.
(0021600)
akalwa   
2018-12-18 18:59   
Any news on this?
Please someone grab the attached patch from 2018-07-18 and apply it the current source code. TIA
(0021679)
AHUser   
2019-04-13 15:39   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6555 [JEDI VCL] 00 JVCL Components major always 2017-03-23 17:43 2019-03-27 16:15
Reporter: hbannw Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: XE8 Jvcl3.49 JvCalcEdit on JvCaptionPanel shows the background behind the JvCaptionPanel
Description: on a form with some components, place a JvCaptionPanel and a JvCalEdit on the panel

increase the height of the edit and the background of the panel is displayed as if the panel becomes transparent

It has the same behaviour on design and runtime
Tags:
Steps To Reproduce:
Additional Information: here is the code from a test unit

test.pas
unit Unit2;

interface

uses
  Winapi.Windows, Winapi.Messages, System.SysUtils, System.Variants, System.Classes, Vcl.Graphics,
  Vcl.Controls, Vcl.Forms, Vcl.Dialogs;

type
  TForm2 = class(TForm)
    Button1: TButton;
    JvCaptionPanel1: TJvCaptionPanel;
    JvCalcEdit1: TJvCalcEdit;
  private
    { Déclarations privées }
  public
    { Déclarations publiques }
  end;

var
  Form2: TForm2;

implementation

{$R *.dfm}

end.

Test.dfm
object Form2: TForm2
  Left = 0
  Top = 0
  Caption = 'Form2'
  ClientHeight = 163
  ClientWidth = 333
  Color = clBtnFace
  Font.Charset = DEFAULT_CHARSET
  Font.Color = clWindowText
  Font.Height = -11
  Font.Name = 'Tahoma'
  Font.Style = []
  OldCreateOrder = False
  PixelsPerInch = 96
  TextHeight = 13
  object Button1: TButton
    Left = 48
    Top = 71
    Width = 217
    Height = 33
    Caption = 'This is a button that should be hidden'
    TabOrder = 0
  end
  object JvCaptionPanel1: TJvCaptionPanel
    Left = 80
    Top = 8
    Width = 185
    Height = 105
    Buttons = []
    Caption = ''
    CaptionFont.Charset = DEFAULT_CHARSET
    CaptionFont.Color = clWhite
    CaptionFont.Height = -13
    CaptionFont.Name = 'Tahoma'
    CaptionFont.Style = [fsBold]
    OutlookLook = False
    TabOrder = 1
    object JvCalcEdit1: TJvCalcEdit
      Left = 32
      Top = 24
      Width = 137
      Height = 57
      TabOrder = 0
      DecimalPlacesAlwaysShown = False
    end
  end
end

Attached Files:
Notes
(0021516)
obones   
2018-07-18 15:51   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021654)
am010157   
2019-03-27 16:15   
There is a problem with the jvCalcEdit and the transparency.
Try the code below and you will see the strange backgroundcolor behaviour of the jvCalcEdit.
I used version 2019-03-25.

object Form1: TForm1
  Left = 0
  Top = 0
  Caption = 'Form1'
  ClientHeight = 203
  ClientWidth = 308
  Color = clBtnFace
  Font.Charset = DEFAULT_CHARSET
  Font.Color = clWindowText
  Font.Height = -11
  Font.Name = 'Tahoma'
  Font.Style = []
  OldCreateOrder = False
  PixelsPerInch = 96
  TextHeight = 13
  object JvXPContainer1: TJvXPContainer
    Left = 0
    Top = 0
    Width = 308
    Height = 203
    BoundColor = clBlue
    BoundLines = [blLeft, blTop, blRight, blBottom]
    Caption = 'JvXPContainer1'
    Color = clRed
    ParentColor = False
    Align = alClient
    ExplicitLeft = 8
    ExplicitWidth = 635
    ExplicitHeight = 336
    object Button1: TButton
      Left = 72
      Top = 104
      Width = 75
      Height = 25
      Caption = 'Button1'
      TabOrder = 0
    end
    object JvCalcEdit2: TJvCalcEdit
      Left = 120
      Top = 106
      Width = 121
      Height = 21
      TabOrder = 1
      DecimalPlacesAlwaysShown = False
    end
  end
end


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6666 [JEDI VCL] 03 Donations minor N/A 2019-03-03 14:41 2019-03-20 08:57
Reporter: mh Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Updated JVCL.PO file for German Language
Description: Attached is a somewhat updated JVCL.PO file for the German language. Replaced some translations which were clearly faulty and added some.

Can you please replace the file with my new version (after a short check maybe)?
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: jvcl.po (420,737 bytes) 2019-03-03 14:41
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002717&type=bug
Notes
(0021614)
mh   
2019-03-07 20:59   
This can be closed as it's already in via pull request.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6564 [JEDI VCL] 00 JVCL Components major always 2017-04-09 11:42 2019-03-20 08:55
Reporter: sender Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvDBImage shows "Bitmap image is not valid" to some kind of jpeg image.
Description: Some kind of jpeg image does not has the "JFIF" or "Exif" signature at stream offset 6 as procedure GraphicSignaturesNeeded expected.
Tags:
Steps To Reproduce: The attached picture is the header dump of the jpeg file. The jpeg picture is private so I can't upload it.
Additional Information: Simple workaround is to add:

    RegisterGraphicSignature([$FF, $D8], 0 , TJPEGImage);

to

procedure GraphicSignaturesNeeded;

But I think we should add file ending signature examination since a valid jpeg file is always ended with 0xFF, 0xD9. (According to https://en.wikipedia.org/wiki/JPEG)
Attached Files: file header.png (42,399 bytes) 2017-04-09 11:42
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002676&type=bug
header.jpg (28,773 bytes) 2017-07-10 02:57
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002681&type=bug
JvDBImageInvalidImage.7z (129,355 bytes) 2018-07-25 05:58
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002705&type=bug
Notes
(0021429)
mh   
2017-07-02 08:44   
1. can this particular JPEG file provided for further analysis?
2. what do other image processing applications say when you try to load this image in them?
(0021432)
sender   
2017-07-10 03:02   
I have uploaded the jpeg file, please check the attached file "header.jpg".

I have tried lots of graphic processing applications, including IrfanView, Paint.net, GIMP, Corel PaintShop pro, Adobe Photoshop. They all can open this file without problem.
(0021526)
obones   
2018-07-18 15:55   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021567)
sender   
2018-07-25 06:07   
The problem is still there.

I have uploaded demo source package which contains 2 demo programs. The one which includes my patched JvJVCLUtils.pas can show the jpeg file in mdb. The unpatched one will show "Unsupported stream format".

To use the demo program, just compile and run, then pressed the "open db" button.
(0021638)
mh   
2019-03-11 22:14   
So you know how to put your modification into a GitHub pull request? If yes, can you do this?
(0021649)
sender   
2019-03-15 06:35   
Pull request is created. Please check GitHub for it.
(0021651)
mh   
2019-03-19 19:57   
It already has been merged in, but I don't have permission to change the status of this mantis issue. Otherwise I would declare this as resolved. Thanks for creating the pull request.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6448 [JEDI VCL] 00 JVCL Components minor have not tried 2015-09-21 05:10 2019-03-12 22:33
Reporter: beckmi Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvDBGrid set as default AutoSizeColums=True (Index -1),
Description: Reported by user from Germany, Uli Schütte:

- Umstieg mit einer Anwendung von XE8/JVCL 3.48 auf 10 Seattle/JVCL 3.49

- Auswirkungen auf TJvDBGrid: Alle Grids laufen jetzt wohl grundsätzlich mit AutoSizeColums=True (Index -1), obwohl dies nicht aktiviert ist, die für die einzelnen Spalten gewählten Größen werden ignoriert, alle Spaltenbreiten sind gleich groß.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021487)
obones   
2018-07-18 15:40   
I'm sorry, but a translation to English would be most welcome
(0021645)
mh   
2019-03-11 23:01   
Switched an application from
XE8/JVCL 3.48 auf 10 Seattle/JVCL 3.49.

It looks like TJvDBGrid now uses AutoSizeColums = true (Index -1), even when not activated. The sizes set for individual colums are ignored so all have the same width.
(0021647)
mh   
2019-03-12 22:33   
My post from yesterday is the requested translation


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6528 [JEDI VCL] 00 JVCL Components major always 2016-09-29 15:16 2019-03-11 22:45
Reporter: Michael Tieke Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvDBGrid Rowsheight out of Range
Description: Drop a JvDBGrid/JvDBUltimGrid on a form, set AutoSizeRows to false. After starting the program you get a RowsHeight error: argument out of range.

Problem started with Delphi 10.1 Berlin Update 1
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021402)
ealanach   
2016-10-19 00:16   
See RAD Studio issue RSP-15872.
A workaround is given there (Dmitry Arefiev 18/10/2016):

<quote>
This issue is major regression in Berlin 10.1 Update 1. The persistent fix will be included into Update 2 (time frame is not known at this moment). As a workaround at run-time please do the following:

    open Vcl.DBGrids.pas
    locate there TCustomDBGrid.CanEditShow method
    replace it code with:

    function TCustomDBGrid.CanEditShow: Boolean;

    begin

      Result := (LayoutLock = 0) and inherited CanEditShow;

    end;

add path to <RAD Studio run-time sources path>\Data\vclctrls to your IDE Delphi Library Path. It is the path where Vcl.DBGrids.pas is located. Is it ?
recompile your application.
<\quote>

I had to use wordpad to save the edited file but after this both TDBGrid and the decendent TjvDBGrid worked again.
(0021512)
obones   
2018-07-18 15:49   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021643)
mh   
2019-03-11 22:45   
Has it been fixed in Berlin update 2? If yes is there still a need to change this?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6580 [JEDI VCL] 00 JVCL Components feature N/A 2017-07-18 20:07 2019-03-11 22:36
Reporter: stjcottbus Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TimeFramework Hint handling
Description: Usage of Description and DisplayText of an appointment is not consistent.

Description is is used as popup-hintbut also in TJvTFWeeks and TJvTFMonths as displayed text in the control. This makes a formatted description useless as both components strips CRLF in displaying the popup-hint.

There should be a clear differentiation between

- DisplayText: Shown if not editable; Single Line, CRLF stripped.
- Description: Shown if editable; Formatted or not according Option.
- HintText: Always shown as hint; Formatted as given.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021523)
obones   
2018-07-18 15:54   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021641)
mh   
2019-03-11 22:36   
If it is still an issue can you make concrete suggestions how to modify the source code?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6567 [JEDI VCL] 00 JVCL Components major always 2017-04-28 11:52 2019-03-11 22:31
Reporter: moore Platform: Windows  
Assigned To: OS: Windows  
Priority: normal OS Version: Windows 10  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvHLEditor and TJvWideHLEditor truncate large line
Description: TJvHLEditor (and TJvWideHLEditor) truncates large line if is has more than 1024 chars, however the Lines property si correct if you save to file. It is evident when you delete chars inside the line, the hidden chars beyond 1024 appear as you are deleting, see attachement..
Tags:
Steps To Reproduce: Insert a line more than 1024 chars
Additional Information:
Attached Files: ErrHL1.jpg (25,078 bytes) 2017-04-28 11:52
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002677&type=bug
Notes
(0021427)
moore   
2017-06-02 11:11   
Any news..
(0021528)
obones   
2018-07-18 15:56   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021640)
mh   
2019-03-11 22:31   
Can you please provide a sample application showing this issue?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6664 [JEDI VCL] 00 JVCL Components crash always 2019-03-01 12:04 2019-03-11 21:58
Reporter: AlexP Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvHidDeviceController does not work on Windows 10 1809
Description: "CreateFile over USB HID device fails with Access Denied (5) since Windows 10 1809" link: https://stackoverflow.com/questions/53761417/createfile-over-usb-hid-device-fails-with-access-denied-5-since-windows-10-180
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021607)
mh   
2019-03-02 11:35   
Another more Delphi centric discussion of this topic (albeit in German) can be found here:

https://www.delphipraxis.net/199904-jvhidcontrollerclass-unter-windows-10-1809-a-post1426788.html

It might even contain a workaround for JEDI. I'm no expert in this area, but imho it should be checked if the proposed change should be adapted to JEDI or if there is a better way for this.
(0021621)
mh   
2019-03-07 21:32   
Is this the same as this one?
https://github.com/project-jedi/jvcl/pull/61
(0021636)
mh   
2019-03-11 21:58   
A pull request with a proposed fix exists. Can it get checked and possibly merged in?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6620 [JEDI VCL] 00 JVCL Components major always 2018-02-19 22:14 2019-03-11 17:06
Reporter: dougwoodrow Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvDBLookupCombo.IgnoreCase property is applied to the key lookup
Description: According to the wiki the TJvDBLookupCombo.IgnoreCase property specifies the case-sensitivity of the incremental search:
http://wiki.delphi-jedi.org/wiki/JVCL_Help:TJvDBLookupCombo.IgnoreCase

In the current implementation this property is applied to the key LookupField as well as to the LookupDisplay field.

In my opinion this is a bug, as it can cause the wrong record to be displayed when the key field is case-sensitive.

For instance, with the following example table, a single character key field 'a' will be incorrectly displayed as "Item one" instead of "Item three" when the IgnoreCase property is set to True.

|Key|Description|
|---|-----------|
| A |Item one |
| B |Item two |
| a |Item three |
Tags:
Steps To Reproduce:
Additional Information: Example (quick-and-dirty) fix:

function TJvLookupControl.Locate(const SearchField: TField;
  const AValue: string; Exact: Boolean): Boolean;
var
  IsDisplayField: Boolean;
  CaseSensitive: Boolean;
begin
  FLocate.IndexSwitch := FIndexSwitch;
  Result := False;
  try
    if not ValueIsEmpty(AValue) and (SearchField <> nil) then
    begin
      IsDisplayField := (SearchField = FDisplayField);
      if IsDisplayField then
        // respect lookup property
        CaseSensitive := not IgnoreCase
      else
        // not display, so this is the key field, do a case-sensitive locate
        CaseSensitive := True;
      Result := FLocate.Locate(SearchField.FieldName, AValue, Exact, CaseSensitive, True, RightTrimmedLookup);
      if Result then
      begin
        if IsDisplayField then
          FValue := FKeyField.AsString;
        UpdateDisplayValue;
      end;
    end;
  except
  end;
end;
Attached Files: LookupIgnoreCase.zip (1,756 bytes) 2018-07-19 18:05
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002703&type=bug
Capture1.jpg (39,438 bytes) 2018-07-19 18:08
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002704&type=bug
Notes
(0021543)
obones   
2018-07-18 16:03   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021562)
dougwoodrow   
2018-07-19 18:14   
Hi Olivier, thanks for looking into this.
I've attached an application illustrating the problem (LookupIgnoreCase.zip).

Note that the actual value of the FDisplayField that is displayed depends on what record is currently slected when the locate() is performed.
So when IgnoreCase is true, either the 'a' lookup or the 'A' lookup may be wrong, as shown in Capture1.jpg.
(0021625)
mh   
2019-03-09 18:19   
I took the liberty to create a pull request for it:
https://github.com/project-jedi/jvcl/pull/64
(0021627)
mh   
2019-03-10 10:41   
Replaced the pull request with this one, as my old one contained unrelated modifications as well (Git is still new for me):
https://github.com/project-jedi/jvcl/pull/69
(0021634)
obones   
2019-03-11 17:06   
Thanks, this is now fixed in GIT


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6578 [JEDI VCL] 00 JVCL Components trivial always 2017-07-18 19:44 2019-03-11 17:02
Reporter: stjcottbus Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Default property in JvTFGlance.TJvTFGlanceViewer not initially set.
Description: In JvTFGlance is in TJvTFGlanceViewer

property ShowStartEndTimeInHint: Boolean
  read FShowStartEndTimeInHint write SetShowStartEndTimeInHint default True;

but it's not initialized to True in TJvTFGlanceViewer.Create.

This makes the property useless for design-time.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021525)
obones   
2018-07-18 15:54   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021620)
mh   
2019-03-07 21:30   
It is still present, but I created a pull request about it now:
https://github.com/project-jedi/jvcl/pull/61
(0021628)
mh   
2019-03-10 10:41   
Replaced the pull request with this one, as my old one contained unrelated modifications as well (Git is still new for me):
https://github.com/project-jedi/jvcl/pull/67
(0021632)
obones   
2019-03-11 17:02   
Thanks, this is now merged in GIT


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6595 [JEDI VCL] 00 JVCL Components block random 2017-09-08 13:28 2019-03-11 17:02
Reporter: vaniusrb Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvTFDays testing wrong integer object typecast test
Description: Function TJvTFApptMap.HasAppt was testing if FData has object with ">0"
instead "<> 0". Object with integer typecast can returns negative values
(it happened with Delphi 10.2 Tokyo build, causing infinity loop)

This line
      if Test > 0 then

must be
      if Test <> 0 then
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021538)
obones   
2018-07-18 16:00   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021585)
mh   
2018-10-28 17:26   
That code line is still there and Test is a NativeInt var so it could get negative:

function TJvTFApptMap.HasAppt(Appt: TJvTFAppt): Boolean;
var
  MapRow, MapCol, StartRow, EndRow, ApptsExamined: Integer;
  Test: NativeInt;
  ApptGrid: TJvTFDays;
begin
  FGridCol.CalcStartEndRows(Appt, StartRow, EndRow);

  StartRow := Greater(StartRow, 0);

  ApptGrid := FGridCol.ColCollection.ApptGrid;
  if Assigned(ApptGrid) then
    EndRow := Lesser(EndRow, ApptGrid.RowCount - 1)
  else
    EndRow := Lesser(EndRow, FGridCol.ColCollection.Printer.RowCount - 1);

  MapRow := 0;
  Result := False;
  while (MapRow <= EndRow) and not Result do
  begin
    MapCol := 1;
    ApptsExamined := 0;
    while (ApptsExamined < FData[MapRow, -1]) and not Result do
    begin
      Test := FData[MapRow, MapCol];
      if Test > 0 then
      begin
        Inc(ApptsExamined);
        if Test = NativeInt(Appt) then
          Result := True;
      end;

      Inc(MapCol);
    end;

    Inc(MapRow);
  end;
end;

The FData var is a sparse mag which contains NativeInt values so they could get negative. I don't know this component, but I guess the author of this report is right about changing the comparison as otherwise the while loop could really become an endless loop!
(0021617)
mh   
2019-03-07 21:16   
I made your small change from
if Test > 0 then to
if Test <> 0 then
in a branch and created this pull request for it:

https://github.com/project-jedi/jvcl/pull/60

Hopefully it will get included soon.
(0021629)
mh   
2019-03-10 10:42   
Replaced the pull request with this one, as my old one contained unrelated modifications as well (Git is still new for me):
https://github.com/project-jedi/jvcl/pull/66
(0021631)
obones   
2019-03-11 17:02   
Thanks, this is now merged in GIT


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6522 [JEDI VCL] Miscellanous minor have not tried 2016-08-12 01:19 2019-03-09 18:40
Reporter: wojiaohaoyaping Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvApplicationHotKey not works on Windows 10 .
Description: I just installed the newest Windows 10 Enterprise (Version 10.0.14393), My older project with TJvApplicationHotKey does not work for many shortcuts.Like 'Alt + Up"
'Alt + Down', 'Alt+BkSp', 'Ctrl+Shift+T'... Why it not works on Windows 10, but works on Windows 7 ? Hope it solved in newer version of JVCL . Thanks a lot.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021422)
misv   
2017-04-17 14:21   
Just want to confirm the issue - I can reproduce it on my Delphi 2010 + Delphi XE4 using newest JVCL
(0021513)
obones   
2018-07-18 15:50   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021598)
misv   
2018-12-13 00:48   
I tested - and seems it is now working :)
(0021624)
mh   
2019-03-09 18:08   
I tested it as well and can confirm that it works, in contrast to the JEDI Wiki, which uses a no longer supported captcha method which prevents me documenting anything in the wiki as I cannot save it.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6542 [JEDI VCL] 00 JVCL Components minor always 2016-12-28 16:32 2019-03-06 09:45
Reporter: CDametto Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: unable to reproduce  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Horizontal reset of dbgrid scrollbar at line click when no indicator
Description: In a DBGrid with dgRowSelect=true and dgIndicator=false in Options, whether the horizontal scrollbar is present, if you are at right end and you click on a row, the grid is repositioned to the start left.
Tags:
Steps To Reproduce:
Additional Information: This is my correction, in the file JvDBGrid.pas, in the middle of the MouseDown procedure...
Original block:

//-------------------------------------------------------------------------------
// Prevents the grid from going back to the first column when dgRowSelect is True
// Does not work if there's no indicator column
//-------------------------------------------------------------------------------
if (dgRowSelect in Options) and (Cell.Y >= TitleOffset) then
begin
  // Why do we always have to work around the VCL. If we use the original X the
  // Grid will scroll back to the first column. But if we don't use the original X
  // and goRowSizing is enabled, the user can start resizing rows in the wild.
  WasRowResizing := goRowSizing in TCustomGridAccess(Self).Options;
  try
    // Disable goRowSizing without all the code that SetOptions executes.
    TGridOptions(Pointer(@TCustomGridAccess(Self).Options)^) := TCustomGridAccess(Self).Options - [goRowSizing];
    inherited MouseDown(Button, Shift, 1, Y);
    InheritedCalled := True;
  finally
    if WasRowResizing then
      TGridOptions(Pointer(@TCustomGridAccess(Self).Options)^) := TCustomGridAccess(Self).Options + [goRowSizing];
  end;
end

I declared in the procedure var SI: TScrollInfo;
block with my correction:

//-------------------------------------------------------------------------------
// Prevents the grid from going back to the first column when dgRowSelect is True
// Does not work if there's no indicator column
//-------------------------------------------------------------------------------
if (dgRowSelect in Options) and (Cell.Y >= TitleOffset) then
begin
  // Why do we always have to work around the VCL. If we use the original X the
  // Grid will scroll back to the first column. But if we don't use the original X
  // and goRowSizing is enabled, the user can start resizing rows in the wild.
  WasRowResizing := goRowSizing in TCustomGridAccess(Self).Options;
  try
    // Disable goRowSizing without all the code that SetOptions executes.
    TGridOptions(Pointer(@TCustomGridAccess(Self).Options)^) := TCustomGridAccess(Self).Options - [goRowSizing];

    SI.cbSize := SizeOf(SI); //ADDED
    SI.fMask := SIF_POS; //ADDED
    GetScrollInfo(Handle, SB_HORZ, SI); //ADDED
    LockWindowUpdate(Handle); //ADDED
    try //ADDED
    
      inherited MouseDown(Button, Shift, 1, Y);
    
    Perform(WM_HSCROLL, MakeWParam(SB_THUMBPOSITION, SI.nPos), 0); //ADDED
    finally //ADDED
      LockWindowUpdate(0); //ADDED
    end; //ADDED

    InheritedCalled := True;
  finally
    if WasRowResizing then
      TGridOptions(Pointer(@TCustomGridAccess(Self).Options)^) := TCustomGridAccess(Self).Options + [goRowSizing];
  end;
end
Attached Files:
Notes
(0021505)
obones   
2018-07-18 15:47   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021603)
CDametto   
2019-01-25 12:20   
Now it seems to work. Thank you.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6661 [JEDI VCL] 00 JVCL Components minor have not tried 2019-02-04 12:21 2019-02-04 12:21
Reporter: avdam Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: new Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: AV in an expert of the JCL
Description: The default setting "Insert JDBG data into the binary" is : "Disabled by default"

When I select the JCL Debug expert to insert debug data into 1 project I get the Access violation. I use Delphi 10 Seatlle Windows on a Windows 10 Enterprise machine (version 1803 OS build 17134.523)

Additional question how can I select the setting to include the JDBG Data into the binary in an automated build ?
Tags:
Steps To Reproduce:
Additional Information: Exception class name: EAccessViolation
Exception message: Access violation at address 21EECE3F in module 'delphicoreide230.bpl'. Read of address 00000044
(0017AFE8){Jcl230.bpl } [4817BFE8] Jcldebug.TJclStackInfoList + $A8
(0017AC0E){Jcl230.bpl } [4817BC0E] Jcldebug.JclCreateStackList + $1A
(00003D47){JclBaseExpert230.bpl} [58004D47] Jclotaexceptionform.TJclExpertExceptionForm.ShowException + $13B
(0000ADC3){JclBaseExpert230.bpl} [5800BDC3] Jclotautils.JclExpertShowExceptionDialog + $33
(00006828){JclDebugExpert230.bpl} [18137828] Jcldebugideimpl.TJclDebugExtension.InsertJdbgSubMenuClick + $84
(0018BE3A){delphicoreide230.bpl} [21EECE3A] EditorStructuralHighlight.TStructuralHighlighter.EvQuery (Line 363, "EditorStructuralHighlight.pas" + 0) + $E
(00172514){vcl230.bpl } [50AD3514] Vcl.Forms.TCustomForm.WndProc (Line 4459, "Vcl.Forms.pas" + 206) + $5
(00031E38){vcl230.bpl } [50992E38] Vcl.Controls.TControl.Perform (Line 7027, "Vcl.Controls.pas" + 10) + $8
(0017D78F){vcl230.bpl } [50ADE78F] Vcl.Forms.TApplication.DispatchAction (Line 11642, "Vcl.Forms.pas" + 2) + $D
(002FBFD4){coreide230.bpl} [2077CFD4] EditorBuffer.FindEditWindowAndView (Line 6097, "EditorBuffer.pas" + 28) + $11
(002FC0B1){coreide230.bpl} [2077D0B1] EditorBuffer.FindEditWindow (Line 6127, "EditorBuffer.pas" + 1) + $2
(0018BE3A){delphicoreide230.bpl} [21EECE3A] EditorStructuralHighlight.TStructuralHighlighter.EvQuery (Line 363, "EditorStructuralHighlight.pas" + 0) + $E
(002FB53F){coreide230.bpl} [2077C53F] EditorBuffer.TEvQueryEditEvent.Send (Line 5837, "EditorBuffer.pas" + 3) + $6
(002F4C53){coreide230.bpl} [20775C53] EditorBuffer.QueryEventHandler (Line 2323, "EditorBuffer.pas" + 1) + $9
(002CDBE2){coreide230.bpl} [2074EBE2] EdProcs.SafeEkEval (Line 361, "EdProcs.pas" + 2) + $4
(002CC4DC){coreide230.bpl} [2074D4DC] EdKrnl.EkEval (Line 3556, "EdKrnl.pas" + 0) + $0
(002CB647){coreide230.bpl} [2074C647] EdKrnl.InsertBlock (Line 2076, "EdKrnl.pas" + 7) + $0
(002F38C6){coreide230.bpl} [207748C6] EditorBuffer.TEditWriter.Insert (Line 1684, "EditorBuffer.pas" + 13) + $5
(0000B94C){JclBaseExpert230.bpl} [5800C94C] Jclotautils.SetProjectProperties + $2AC
(00006C70){JclDebugExpert230.bpl} [18137C70] Jcldebugideimpl.TJclDebugExtension.SetProjectState + $164
(000067FB){JclDebugExpert230.bpl} [181377FB] Jcldebugideimpl.TJclDebugExtension.InsertJdbgSubMenuClick + $57
(001204B7){rtl230.bpl } [501714B7] System.Classes.TBasicAction.Execute (Line 16382, "System.Classes.pas" + 3) + $7
(0001B6FA){vcl230.bpl } [5097C6FA] Vcl.ActnList.TCustomAction.Execute (Line 259, "Vcl.ActnList.pas" + 19) + $35
(0012030F){rtl230.bpl } [5017130F] System.Classes.TBasicActionLink.Execute (Line 16293, "System.Classes.pas" + 2) + $7
(0002411D){vclactnband230.bpl} [2198511D] Vcl.ActnMenus.TCustomActionMenuBar.ExecAction (Line 1077, "Vcl.ActnMenus.pas" + 6) + $D
(000259C0){vclactnband230.bpl} [219869C0] Vcl.ActnMenus.TCustomActionMenuBar.TrackMenu (Line 1843, "Vcl.ActnMenus.pas" + 19) + $15
(000293DA){vclactnband230.bpl} [2198A3DA] Vcl.ActnMenus.TCustomActionMainMenuBar.TrackMenu (Line 3637, "Vcl.ActnMenus.pas" + 5) + $3
(00023CC8){vclactnband230.bpl} [21984CC8] Vcl.ActnMenus.TCustomActionMenuBar.CMItemClicked (Line 955, "Vcl.ActnMenus.pas" + 2) + $11
(00023CD1){vclactnband230.bpl} [21984CD1] Vcl.ActnMenus.TCustomActionMenuBar.CMItemClicked (Line 956, "Vcl.ActnMenus.pas" + 3) + $4
(000321FD){vcl230.bpl } [509931FD] Vcl.Controls.TControl.WndProc (Line 7249, "Vcl.Controls.pas" + 91) + $6
(00031E38){vcl230.bpl } [50992E38] Vcl.Controls.TControl.Perform (Line 7027, "Vcl.Controls.pas" + 10) + $8
(00036452){vcl230.bpl } [50997452] Vcl.Controls.GetControlAtPos (Line 9809, "Vcl.Controls.pas" + 4) + $75
(00036BE5){vcl230.bpl } [50997BE5] Vcl.Controls.TWinControl.WndProc (Line 10031, "Vcl.Controls.pas" + 110) + $1D
(00036D3D){vcl230.bpl } [50997D3D] Vcl.Controls.TWinControl.WndProc (Line 10079, "Vcl.Controls.pas" + 158) + $6
(0000F708){rtl230.bpl } [50060708] System.TMonitor.TryEnter (Line 18154, "System.pas" + 10) + $0
(0000F288){rtl230.bpl } [50060288] System.TMonitor.Enter (Line 17847, "System.pas" + 4) + $2
(0000F10C){rtl230.bpl } [5006010C] System.TMonitor.CheckOwningThread (Line 17765, "System.pas" + 2) + $0
(0000F416){rtl230.bpl } [50060416] System.TMonitor.Exit (Line 17951, "System.pas" + 1) + $2
(00025AD6){vclactnband230.bpl} [21986AD6] Vcl.ActnMenus.TCustomActionMenuBar.WndProc (Line 1882, "Vcl.ActnMenus.pas" + 25) + $4
(0003635C){vcl230.bpl } [5099735C] Vcl.Controls.TWinControl.MainWndProc (Line 9786, "Vcl.Controls.pas" + 3) + $6
(00121214){rtl230.bpl } [50172214] System.Classes.StdWndProc (Line 16886, "System.Classes.pas" + 8) + $0
(0017BB6F){vcl230.bpl } [50ADCB6F] Vcl.Forms.TApplication.ProcessMessage (Line 10443, "Vcl.Forms.pas" + 23) + $1
(0017BBB2){vcl230.bpl } [50ADCBB2] Vcl.Forms.TApplication.HandleMessage (Line 10473, "Vcl.Forms.pas" + 1) + $4
(0017BEE5){vcl230.bpl } [50ADCEE5] Vcl.Forms.TApplication.Run (Line 10611, "Vcl.Forms.pas" + 26) + $3
Attached Files:
There are no notes attached to this issue.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6597 [JEDI VCL] 00 JVCL Components major always 2017-10-11 20:50 2018-12-10 07:37
Reporter: ljstudio Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvDesktopAlert doesn't drag
Description: The component TJvDesktopAlert does doesn't the drag, so the alert is displayed in the initial position and has no way to move it.
Tags: Alert, Delphi 10, Delphi 10 Seattle, Delphi Seattle, Drag, TJvDesktopAlert
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021436)
ljstudio   
2017-10-11 20:52   
It works on delphi 7.
I've tested on Delphi 10 Seattle and doesn't work.
(0021536)
obones   
2018-07-18 16:00   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021595)
themeheart   
2018-12-10 07:37   
https://www.themeheart.com


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6634 [JEDI VCL] 00 JVCL Components minor always 2018-04-17 14:39 2018-10-02 09:22
Reporter: tstoicescu Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Access violation in Jedi/Jvcl/Run/JvclUtils.pas
Description: Access violation in Jedi/Jvcl/Run/JvclUtils.pas
in: GetWordOnPos2(s = '', P>0)..
in: if CharInSet(S[P], Separators) and ((P < 1) or CharInSet(S[P - 1], Separators)) then

from: Jedi/Jvcl/Run/JvEditor.Pas
TJvCompletion.FindSelItem
 S := GetWordOnPos2(Ed.FLines[Ed.CaretY], Ed.CaretX, iBeg, iEnd)
where Ed.FLines[Ed.CaretY] = EmptyStr and Ed.CaretX > 0,
because a line ' 22 ' edit in runtime, after deleting '22'.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021463)
tstoicescu   
2018-04-17 14:57   
0I think may be like in GetWordOnPos

....
if (P > Length(S)) or (P < 1) then
    Exit;
...

not only

....
if (P < 1) then
    Exit;
.....
(0021553)
obones   
2018-07-18 16:07   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021579)
AHUser   
2018-10-02 09:22   
Fixed in git master


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6532 [JEDI VCL] 00 JVCL Components minor always 2016-11-11 11:38 2018-10-02 09:16
Reporter: vbartosh Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: PError is incompatible with modern Delphi versions
Description: PError supposes that SOSError has two substitute parameters, like in Delphi7, but in modern Delphi's it has three:
  SOSError = 'System Error. Code: %d.'+sLineBreak+'%s%s';
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JediBug.zip (426 bytes) 2018-07-18 17:38
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002697&type=bug
JediBug2.zip (523 bytes) 2018-07-18 18:01
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002699&type=bug
Notes
(0021511)
obones   
2018-07-18 15:49   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021554)
vbartosh   
2018-07-18 17:39   
It's still there
(0021556)
vbartosh   
2018-07-18 17:48   
arrgh, mea culpa, ignore that one, i'll reupload
(0021557)
vbartosh   
2018-07-18 18:01   
here you go (JediBug2.zip)
(0021578)
AHUser   
2018-10-02 09:16   
Fixed in git master


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6651 [JEDI VCL] 00 JVCL Components minor always 2018-09-27 11:41 2018-10-01 21:57
Reporter: ggoelles Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Not all German special characters are accepted through EditControls in TJvDBGrid
Description: 'ü' and capital special characters like 'Ü', 'Ö', 'Ä' are not accepted with a German keyboard
Tags:
Steps To Reproduce:
Additional Information: Found the bug in JvDBGrid.pas in the constructor.

constructor TJvDBGrid.Create(AOwner: TComponent);

// Note to users: the second line may not compile on non western european
// systems, in which case you should simply remove it and recompile.
FCharList :=
    ['A'..'Z', 'a'..'z', ' ', '-', '+', '0'..'9', '.', ',', Backspace,
     'é', 'è', 'ê', 'ë', 'ô', 'ö', 'û', 'ù', 'â', 'à', 'ä', 'î', 'ï', 'ç'];

use this instead:
    ['A'..'Z', 'a'..'z', ' ', '-', '+', '0'..'9', '.', ',', Backspace,
     'é', 'è', 'ê', 'ë', 'ô', 'ö', 'Ö', 'û', 'ù', 'ü', 'Ü', 'â', 'à', 'ä', 'Ä', 'î', 'ï', 'ç'];
Attached Files:
Notes
(0021577)
AHUser   
2018-10-01 21:57   
Fixed by removing the public CharList property and using TCharacter.IsLetterOrDigit instead of it.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6645 [JEDI VCL] 00 JVCL Components crash always 2018-07-30 17:03 2018-08-30 14:18
Reporter: srjfrl Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvRichEdit.Lines.SaveToStream error, only Win10 1803
Description: English:

We paste the doc-file through JvRichEdit.InsertObjectDialog
It is inserted without errors.
If you then call the JvRichEdit.Lines.SaveToStrem method, an error occurs:
1) Invalid floating point operation
2) Access violation at address 73AD75E1 in module 'RICHED20.dll'
The error occurs in Windows 10 1803. In Windows 8, Windows 7 - there is no problem.

?? ???????:

????????? ? JvRichEdit doc-???? ????? JvRichEdit.InsertObjectDialog.
??????????? ??? ??????.
???? ????? ??????? JvRichEdit.Lines.SaveToStrem ??????????? ??????:
Invalid floating point operation, ????? access violation at address 73AD75E1 in module 'RICHED20.dll'

?????? ????????? ? Windows 10 1803. ? Windows 8, 7, Vista, Server 2008 ? ??. - ?????? ???.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021568)
srjfrl   
2018-07-30 17:05   
Russian:

????????? ? JvRichEdit doc-???? ????? JvRichEdit.InsertObjectDialog.
??????????? ??? ??????.
???? ????? ??????? JvRichEdit.Lines.SaveToStrem ??????????? ??????:
Invalid floating point operation, ????? access violation at address 73AD75E1 in module 'RICHED20.dll'

?????? ????????? ? Windows 10 1803. ? Windows 8, 7, Vista, Server 2008 ? ??. - ?????? ???.
(0021569)
srjfrl   
2018-07-30 17:06   
?? ???????:

????????? ? JvRichEdit doc-???? ????? JvRichEdit.InsertObjectDialog.
??????????? ??? ??????.
???? ????? ??????? JvRichEdit.Lines.SaveToStrem ??????????? ??????:
Invalid floating point operation, ????? access violation at address 73AD75E1 in module 'RICHED20.dll'

?????? ????????? ? Windows 10 1803. ? Windows 8, 7, Vista, Server 2008 ? ??. - ?????? ???.
(0021574)
obones   
2018-08-30 14:18   
Well, I think it is an issue from Windows 10 version of the RichEdit control.
And I believe this will be fixed by an upcoming windows update patch.

That being said, could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6463 [JEDI VCL] 00 JVCL Components minor always 2015-10-23 15:26 2018-08-30 14:12
Reporter: Gerold Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: no change required  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: HTTPS support in TJvHttpUrlGrabber
Description: I guess there is one error in class function TJvHttpsUrlGrabber.CanGrab.

class function TJvHttpsUrlGrabber.CanGrab(const Url: string): Boolean;
begin
  Result := LowerCase(Copy(Url, 1, 7)) = cHTTPsPrefix;
end;

cHTTPsPrefix has a length of 8 characters. So the function will always return false. Should be:

Result := LowerCase(Copy(Url, 1, 8)) = cHTTPsPrefix;

But even if I change it, it does not download.


Tags:
Steps To Reproduce:
Additional Information: Daily: 2015-10-21
Attached Files:
Notes
(0021482)
obones   
2018-07-18 15:38   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021570)
Gerold   
2018-08-03 10:20   
Solved


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6628 [JEDI VCL] 00 JVCL Components major always 2018-03-20 16:33 2018-08-16 09:52
Reporter: Marvi62 Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: no change required  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: jvDBRichEdit does not show formatted texto and accept pasted Images
Description: I am trying to use jvDBRichEdit (JCL 2.8.0.5677 JVCL 3.50) on Rad Studio 10.2 ( tested even on XE8 and Berlin 10.1), Connected to Microsoft Access *.accdb ( Windows 10 64 Bits)

- The connection ( FireDAC ) works fine, but instead of showing Formatted Text , BOLD, Underlined, Italic, so on , it shows:

{\rtf1\ansi\ansicpg1252\deff0{\fonttbl{\f0\froman\fcharset0 Times New Roman;}}
\viewkind4\uc1\pard\lang1046\f0\fs24 Exemplos\par
\par
- "You can share my sandwich - I've got enough and to spare."\par
\par

and I couldn't paste *.bmp or others images formats on it

I am not an expert and I don't know how to fix this. I do need to solve that because this components is vital on my App.

Please, could you help me?

Thanks a lot

Marcus Vinicius
Tags: jvdbrichedit
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021460)
Marvi62   
2018-03-21 12:24   
Please, consider: jvDBRichEdit does not show formatted texto and DOES NOT accept pasted Images
(0021552)
obones   
2018-07-18 16:06   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.
(0021571)
Marvi62   
2018-08-10 02:12   
- First of all : I apologise for my bad english.

- I spent a lot of time trying to set Firedac and Access database in order to work correctly with jvDBRichEdit.

- I almost gave up but, as this component is crucial in my apps, I insisted and could finally succeeded.

- So, there is not wrong with jvDBRichEdit .
- Case Resolved.
- Thank for your attention and best regards to all.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6515 [JEDI VCL] 00 JVCL Components major unable to reproduce 2016-05-27 13:54 2018-07-23 17:14
Reporter: acgubamg Platform: intel  
Assigned To: obones OS: Windows  
Priority: normal OS Version: 10  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: no change required  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvCalcEdit/tjvdbcalcedit as int64 ?
Description: TJvCalcEdit or tjvdbcalcedit as int64 ? it is possible?

JvCalcEdit.AsInteger and JvCalcEdit.AsInt64 ?
Tags:
Steps To Reproduce: I can´t type a number as 201600000000020 in jvcalcedit or tjvdbcalcedit.
Additional Information: Here in brazil, the number of invoice is made as 15 digits... And change this to string isn´t fine.
System Description
Attached Files:
Notes
(0021291)
acgubamg   
2016-06-03 02:15   
Como posso ajudar no projeto ?
How can I help in the project?
(0021488)
obones   
2018-07-18 15:41   
Could you check if the issue is still present in the latest GIT content? If yes, please provide a pull request at Github with the required changes
(0021565)
acgubamg   
2018-07-21 17:07   
please close it.
I solved with .Value property
(0021566)
obones   
2018-07-23 17:14   
Thanks for the feedback


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6409 [JEDI VCL] 00 JVCL Components crash always 2015-05-23 07:37 2018-07-18 16:08
Reporter: cacofony Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvTFDays - Map column not found for appointment on refresh if mouse if hovered over controls
Description: Under certain conditions TJvFDays will raise EJvTFDaysError.CreateRes(@RsEMapColNotFoundForAppointment) within
procedure TJvTFDays.WMSetCursor(var Msg: TWMSetCursor) during a slower refresh and if the mouse is moved over appointments because appointment might be in the process of being removed.
Tags:
Steps To Reproduce:
Additional Information: Perhaps not an ideal resolution but this try / except fixes it.

procedure TJvTFDays.WMSetCursor(var Msg: TWMSetCursor);
var
  Cur: HCURSOR;
  Coord: TJvTFDaysCoord;
begin
  Cur := 0;
  try
    with Msg do
      if HitTest = HTCLIENT then
      begin
        // Exception happens here during a refresh of appointments and mouse movement
        Coord := PtToCell(FHitTest.X, FHitTest.Y);
        case CanDragWhat(Coord) of
          agsSizeCol, agsSizeRowHdr:
            Cur := Screen.Cursors[crHSplit];
          agsSizeRow, agsSizeColHdr:
            Cur := Screen.Cursors[crVSplit];
          agsSizeAppt:
            Cur := Screen.Cursors[crSizeNS];
          agsMoveAppt:
            Cur := Screen.Cursors[crDrag];
        end;
      end;
  except
    Cur := 0;
  end;

  if Cur <> 0 then
    SetCursor(Cur)
  else
    inherited;
end;
Attached Files: 0006409 - JvFTDays.patch (1,359 bytes) 2015-06-12 09:05
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002618&type=bug
PhotoOp.zip (73,276 bytes) 2018-07-06 05:54
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002694&type=bug
PhotoOp-Exe.zip (1,383,088 bytes) 2018-07-06 05:55
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002695&type=bug
Notes
(0021169)
cacofony   
2015-06-12 09:05   
Uploaded batch for latest GIT version of JvTFDays
(0021192)
obones   
2015-09-14 11:25   
Please provide the zipped sources of a sample application showing this
(0021473)
cacofony   
2018-07-06 05:54   
While still a slight hack this probably has a better overall effect.

function TJvTFDays.PtToCell(X, Y: Integer): TJvTFDaysCoord;
var
  ColNum, RowNum, AdjX, AdjY, Temp, TotalWidth, SegCount, MapCol: Integer;
  Done: Boolean;
  ApptRect: TRect;
begin
  try
    with Result do
    begin
      Col := gcUndef;
      Row := gcUndef;
      CellX := -100;
      CellY := -100;
      AbsX := X;
      AbsY := Y;
      Schedule := nil;
      Appt := nil;
    end;

    if X < CalcBlockHdrWidth then
    begin
      // POSSIBLE BUG!!
      // Result.Row := gcGroupHdr; // WRONG CODE
      Result.Col := gcGroupHdr; // UNTESTED - CORRECT CODE
      Result.CellX := X;
    end
    // block if X < RowHdrWidth then
    else if X < CalcBlockRowHdrsWidth then
    begin
      Result.Col := gcHdr;
      Result.CellX := X - CalcBlockHdrWidth;
    end
    else if LeftCol > -1 then
    begin
      // Find the col that PtX falls in
      ColNum := LeftCol;
      // block AdjX := X - RowHdrWidth;
      AdjX := X - CalcBlockRowHdrsWidth;
      Done := False;
      Temp := 0;

      while (ColNum < Cols.Count) and not Done do
      begin
        Inc(Temp, Cols[ColNum].Width);
        if AdjX < Temp then
        begin
          Done := True;
          Result.Col := ColNum;
          Result.CellX := AdjX - (Temp - Cols[ColNum].Width);
        end
        else
          Inc(ColNum);
      end;
      if not Done then
      begin
        Result.Col := Cols.Count - 1;
        Result.CellX := AdjX - (Temp - Cols[Cols.Count - 1].Width);
      end;
    end;

    if Y < CalcGroupHdrHeight then
    begin
      Result.Row := gcGroupHdr;
      Result.CellY := Y;
    end
    // else if Y < ColHdrHeight then
    else if Y < CalcGroupColHdrsHeight then
    begin
      Result.Row := gcHdr;
      Result.CellY := Y - CalcGroupHdrHeight;
    end
    else if TopRow > -1 then
    begin
      RowNum := TopRow;
      // group AdjY := Y - ColHdrHeight;
      AdjY := Y - CalcGroupColHdrsHeight;
      Done := False;
      Temp := 0;

      while (RowNum < RowCount) and not Done do
      begin
        Inc(Temp, RowHeight);
        if AdjY < Temp then
        begin
          Done := True;
          Result.Row := RowNum;
          Result.CellY := AdjY - (Temp - RowHeight);
        end
        else
          Inc(RowNum);
      end;
      if not Done then
      begin
        Result.Row := RowCount - 1;
        Result.CellY := AdjY - (Temp - RowHeight);
      end;
    end;

    if Result.Col > gcHdr then
    begin
      Result.Schedule := Cols[Result.Col].Schedule;

      // move grab handles
      if PtInTopHandle(Point(X, Y), Result.Col, SelAppt) then
        Result.Appt := SelAppt
      else if PtInBottomHandle(Point(X, Y), Result.Col, SelAppt) then
        Result.Appt := SelAppt
      else if (Result.Row > gcHdr) and Assigned(Result.Schedule) then
      begin
        TotalWidth := Cols[Result.Col].Width;
        SegCount := Cols[Result.Col].MapColCount(Result.Row);
        if SegCount > 0 then
        begin
          MapCol := LocateDivCol(Result.CellX, TotalWidth, SegCount);
          Result.Appt := Cols[Result.Col].MapLocation(MapCol, Result.Row);

          ApptRect := GetApptRect(Result.Col, Result.Appt);
          if not Windows.PtInRect(ApptRect, Point(X, Y)) then
            Result.Appt := nil;
        end;
      end;
    end;

    Result.DragAccept := (Result.Row > gcHdr) and (Result.Col > gcHdr);
  except
    with Result do
    begin
      Col := gcUndef;
      Row := gcUndef;
      CellX := -100;
      CellY := -100;
      AbsX := X;
      AbsY := Y;
      Schedule := nil;
      Appt := nil;
      DragAccept := False;
    end;
  end;
end;
(0021474)
cacofony   
2018-07-06 05:59   
I have uploaded a modified version of the PhotoOp example in both source and exe version

1.) The example could replace the current version that relies on DBX as it now uses the JVCL CSV dataset

2.) To force a simulation of the issue in PtToCell; click the new "refresh" button this will load the data slow. Now you can either keep moving the mouse around Appt and hope to get it (can take a while) or just move an appt during a refresh.

I know it's not a perfect real world example but it's the easiest way to demonstrate the issue


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6630 [JEDI VCL] 00 JVCL Components major always 2018-03-29 16:37 2018-07-18 16:07
Reporter: CDametto Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: A TJvDBLookupCombo on a TJvWizard page does not show the dropdown button
Description: A TJvDBLookupCombo on TJvWizard page looks like a TEdit


Tags:
Steps To Reproduce:
Additional Information: A workaround is setting JvDBLookupCombo.DoubleBuffer := False;
Attached Files:
Notes
(0021461)
AHUser   
2018-03-30 20:39   
This bug was fixed on 18.01.2018 in the master branch (9a3837f2680e639c0a92e12fa384808f6f1e13c5)

The TJvDBLookupCombo.CMDoublebufferedchanged handler (Delphi 2009 and newer) automatically reverts DoubleBuffer to False.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6639 [JEDI VCL] 00 JVCL Components major sometimes 2018-06-15 22:41 2018-07-18 16:06
Reporter: WZellner Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Unexpected exception when compiling in C++ Builder.
Description: Occurred when compiling C++ project (...CutPlanner.exe). After the message was dismissed, the compile continued but the application and C++ Builder (10.2.3) hung when run under debug (had to kill the process). JCL 2.8.0.5677
Tags:
Steps To Reproduce:
Additional Information: Exception class name: EFOpenError
Exception message: Cannot open file "C:\Users\wzellner\CutPlanner\Branch\10.2\CutPlanner\Win32\Debug\CutPlanner.exe". The process cannot access the file because it is being used by another process
(0017EDFC){Jcl250.bpl } [4817FDFC] JclDebug.TJclStackInfoList.Create + $A8
(0017EA12){Jcl250.bpl } [4817FA12] JclDebug.JclCreateStackList + $1A
(000046A7){JclBaseExpert250.bpl} [580056A7] JclOtaExceptionForm.TJclExpertExceptionForm.ShowException + $13B
(0000BAB3){JclBaseExpert250.bpl} [5800CAB3] JclOtaUtils.JclExpertShowExceptionDialog + $33
(000087A4){JclDebugExpert250.bpl} [581597A4] JclDebugIdeImpl.TIdeNotifier.AfterCompile + $4C
(00108626){rtl250.bpl } [50159626] System.Classes.TFileStream.Create (Line 8854, "System.Classes.pas" + 21) + $3
(00000756){exceptiondiag250.bpl} [52131756] SysInit.@GetTls (Line 802, "SysInit.pas" + 23) + $0
(0007727C){exceptiondiag250.bpl} [521A827C] JclHookExcept.DoExceptNotify (Line 267, "JclHookExcept.pas" + 27) + $0
(0000F039){rtl250.bpl } [50060039] System.@AfterConstruction (Line 18304, "System.pas" + 2) + $5
(003459D9){rtl250.bpl } [503969D9] System.Contnrs.TObjectList.Insert (Line 330, "System.Contnrs.pas" + 0) + $1
(00100C4A){rtl250.bpl } [50151C4A] System.Classes.TList.Add (Line 4609, "System.Classes.pas" + 8) + $5
(00345848){rtl250.bpl } [50396848] System.Contnrs..TIntegerBucketList + $1CC
(0007C5D2){exceptiondiag250.bpl} [521AD5D2] JclDebug.TJclModuleInfoList.CreateItemForAddress (Line 994, "JclDebug.pas" + 19) + $4
(00009247){rtl250.bpl } [5005A247] System.@ReallocMem (Line 4950, "System.pas" + 91) + $0
(00014674){rtl250.bpl } [50065674] System.DynArraySetLength (Line 35048, "System.pas" + 97) + $13
(00014715){rtl250.bpl } [50065715] System.@DynArraySetLength (Line 35119, "System.pas" + 3) + $0
(001010DA){rtl250.bpl } [501520DA] System.Classes.TList.SetCapacity (Line 4855, "System.Classes.pas" + 6) + $0
(0000F258){rtl250.bpl } [50060258] System.TMonitor.CheckOwningThread (Line 18510, "System.pas" + 2) + $0
(0000F566){rtl250.bpl } [50060566] System.TMonitor.Exit (Line 18700, "System.pas" + 1) + $2
(0000F5B7){rtl250.bpl } [500605B7] System.TMonitor.Exit (Line 18722, "System.pas" + 2) + $7
(00101A57){rtl250.bpl } [50152A57] System.Classes.TThreadList.UnlockList (Line 5136, "System.Classes.pas" + 1) + $3
(000820BC){exceptiondiag250.bpl} [521B30BC] JclDebug.TJclGlobalStackList.AddObject (Line 3727, "JclDebug.pas" + 12) + $3
(00082A2A){exceptiondiag250.bpl} [521B3A2A] JclDebug.JclCreateStackList (Line 4044, "JclDebug.pas" + 2) + $7
(000828CB){exceptiondiag250.bpl} [521B38CB] JclDebug.DoExceptionStackTrace (Line 3984, "JclDebug.pas" + 17) + $E
(000828D4){exceptiondiag250.bpl} [521B38D4] JclDebug.DoExceptionStackTrace (Line 3984, "JclDebug.pas" + 17) + $17
(00108626){rtl250.bpl } [50159626] System.Classes.TFileStream.Create (Line 8854, "System.Classes.pas" + 21) + $3
(00000756){exceptiondiag250.bpl} [52131756] SysInit.@GetTls (Line 802, "SysInit.pas" + 23) + $0
(0007727C){exceptiondiag250.bpl} [521A827C] JclHookExcept.DoExceptNotify (Line 267, "JclHookExcept.pas" + 27) + $0
(000772E3){exceptiondiag250.bpl} [521A82E3] JclHookExcept.HookedRaiseException (Line 287, "JclHookExcept.pas" + 6) + $7
(00108626){rtl250.bpl } [50159626] System.Classes.TFileStream.Create (Line 8854, "System.Classes.pas" + 21) + $3
(001084DC){rtl250.bpl } [501594DC] System.Classes.TFileStream.Create (Line 8828, "System.Classes.pas" + 6) + $3
(0017713B){Jcl250.bpl } [4817813B] JclDebug.InsertDebugDataIntoExecutableFile + $BF
(00012E0C){rtl250.bpl } [50063E0C] System.@FinalizeRecord (Line 31861, "System.pas" + 25) + $0
(00012EE8){rtl250.bpl } [50063EE8] System.@FinalizeArray (Line 32095, "System.pas" + 80) + $0
(000091F4){rtl250.bpl } [5005A1F4] System.@FreeMem (Line 4806, "System.pas" + 20) + $0
(00010B5C){rtl250.bpl } [50061B5C] System.@UStrClr (Line 24870, "System.pas" + 14) + $0
(00012EE8){rtl250.bpl } [50063EE8] System.@FinalizeArray (Line 32095, "System.pas" + 80) + $0
(00012E0C){rtl250.bpl } [50063E0C] System.@FinalizeRecord (Line 31861, "System.pas" + 25) + $0
(00012F40){rtl250.bpl } [50063F40] System.@FinalizeArray (Line 32154, "System.pas" + 139) + $0
(00012E0C){rtl250.bpl } [50063E0C] System.@FinalizeRecord (Line 31861, "System.pas" + 25) + $0
(0000F2C8){rtl250.bpl } [500602C8] System.TMonitor.Destroy (Line 18532, "System.pas" + 0) + $0
(0000E94D){rtl250.bpl } [5005F94D] System.TObject.CleanupInstance (Line 17168, "System.pas" + 37) + $0
(000091F4){rtl250.bpl } [5005A1F4] System.@FreeMem (Line 4806, "System.pas" + 20) + $0
(0000E72C){rtl250.bpl } [5005F72C] System.TObject.FreeInstance (Line 16931, "System.pas" + 2) + $2
(0000F016){rtl250.bpl } [50060016] System.@ClassDestroy (Line 18298, "System.pas" + 0) + $2
(00182A1A){Jcl250.bpl } [48183A1A] JclDebug.{System.Generics.Collections}TDictionary<System.string,System.Integer>.Destroy + $36
(000091F4){rtl250.bpl } [5005A1F4] System.@FreeMem (Line 4806, "System.pas" + 20) + $0
(00010BC1){rtl250.bpl } [50061BC1] System.@UStrArrayClr (Line 25019, "System.pas" + 16) + $0
(00177F7D){Jcl250.bpl } [48178F7D] JclDebug.TJclBinDebugGenerator.CreateData + $5A1
(0000F039){rtl250.bpl } [50060039] System.@AfterConstruction (Line 18304, "System.pas" + 2) + $5
(001776D7){Jcl250.bpl } [481786D7] JclDebug.TJclBinDebugGenerator.Create + $53
(00176B7E){Jcl250.bpl } [48177B7E] JclDebug.InsertDebugDataIntoExecutableFile + $56
(00005204){JclDebugExpert250.bpl} [58156204] JclDebugIdeImpl.TJclDebugExtension.AfterCompile + $248
(00008775){JclDebugExpert250.bpl} [58159775] JclDebugIdeImpl.TIdeNotifier.AfterCompile + $1D
(003F6157){coreide250.bpl} [208A7157] IDEServices.AfterCompile (Line 5303, "IDEServices.pas" + 11) + $21
(0009346F){coreide250.bpl} [2054446F] ProjectGroupBuilder.TProjectGroupBuilder.NotifyAfterCompile (Line 370, "ProjectGroupBuilder.pas" + 8) + $B
(0011A670){rtl250.bpl } [5016B670] System.Classes.TThread.Synchronize (Line 15502, "System.Classes.pas" + 5) + $0
(00012E0C){rtl250.bpl } [50063E0C] System.@FinalizeRecord (Line 31861, "System.pas" + 25) + $0
(0011A891){rtl250.bpl } [5016B891] System.Classes.TThread.Synchronize (Line 15558, "System.Classes.pas" + 6) + $3
(00086574){coreide250.bpl} [20537574] BuildHost.TBuildHost.Synchronize (Line 446, "BuildHost.pas" + 1) + $D
(000931F6){coreide250.bpl} [205441F6] ProjectGroupBuilder.TProjectGroupBuilder.MakeThingsHappen (Line 334, "ProjectGroupBuilder.pas" + 134) + $11
(000A5131){rtl250.bpl } [500F6131] System.Rtti.RawInvoke (Line 7760, "System.Rtti.pas" + 47) + $1
(000A5533){rtl250.bpl } [500F6533] System.Rtti.Invoke (Line 7981, "System.Rtti.pas" + 79) + $A
(0009C3C4){rtl250.bpl } [500ED3C4] System.Rtti.TRttiInstanceMethodEx.DispatchInvoke (Line 5892, "System.Rtti.pas" + 101) + $24
(000A59CC){rtl250.bpl } [500F69CC] System.Rtti.TRttiMethod.Invoke (Line 9232, "System.Rtti.pas" + 2) + $1
(000C78A0){bds.exe } [004C88A0] SanctuaryChecker.TLicenseManager.TryAction (Line 1594, "SanctuaryChecker.pas" + 14) + $10
(00092CF3){coreide250.bpl} [20543CF3] ProjectGroupBuilder.TProjectGroupBuilder.DoBuild (Line 186, "ProjectGroupBuilder.pas" + 2) + $2B
(00086160){coreide250.bpl} [20537160] BuildHost.TBuildHost.Perform (Line 369, "BuildHost.pas" + 19) + $8
(00073A46){coreide250.bpl} [20524A46] ComPrgrs.TProgressForm.StartCompile (Line 209, "ComPrgrs.pas" + 8) + $C
(00074336){coreide250.bpl} [20525336] ComPrgrs.TProgressForm.HandleCompileMessage (Line 362, "ComPrgrs.pas" + 0) + $2
(00033C5E){vcl250.bpl } [50AE4C5E] Vcl.Controls.TControl.WndProc (Line 7338, "Vcl.Controls.pas" + 91) + $6
(00038843){vcl250.bpl } [50AE9843] Vcl.Controls.TWinControl.WndProc (Line 10209, "Vcl.Controls.pas" + 166) + $6
(0000F884){rtl250.bpl } [50060884] System.TMonitor.TryEnter (Line 18935, "System.pas" + 10) + $0
(0000F3D8){rtl250.bpl } [500603D8] System.TMonitor.Enter (Line 18596, "System.pas" + 4) + $2
(0000F258){rtl250.bpl } [50060258] System.TMonitor.CheckOwningThread (Line 18510, "System.pas" + 2) + $0
(0000F566){rtl250.bpl } [50060566] System.TMonitor.Exit (Line 18700, "System.pas" + 1) + $2
(0000F5B7){rtl250.bpl } [500605B7] System.TMonitor.Exit (Line 18722, "System.pas" + 2) + $7
(000154AF){vcl250.bpl } [50AC64AF] Vcl.Graphics.FreeMemoryContexts (Line 7129, "Vcl.Graphics.pas" + 12) + $8
(00037E10){vcl250.bpl } [50AE8E10] Vcl.Controls.TWinControl.MainWndProc (Line 9908, "Vcl.Controls.pas" + 3) + $6
(00037E25){vcl250.bpl } [50AE8E25] Vcl.Controls.TWinControl.MainWndProc (Line 9911, "Vcl.Controls.pas" + 6) + $0
(00038843){vcl250.bpl } [50AE9843] Vcl.Controls.TWinControl.WndProc (Line 10209, "Vcl.Controls.pas" + 166) + $6
(0011DBCC){rtl250.bpl } [5016EBCC] System.Classes.StdWndProc (Line 17408, "System.Classes.pas" + 11) + $2
(00177469){vcl250.bpl } [50C28469] Vcl.Forms.TCustomForm.WndProc (Line 4572, "Vcl.Forms.pas" + 209) + $5
(00037E10){vcl250.bpl } [50AE8E10] Vcl.Controls.TWinControl.MainWndProc (Line 9908, "Vcl.Controls.pas" + 3) + $6
(0011DBCC){rtl250.bpl } [5016EBCC] System.Classes.StdWndProc (Line 17408, "System.Classes.pas" + 11) + $2
(0002E802){vcl250.bpl } [50ADF802] Vcl.Controls.FindControl (Line 3604, "Vcl.Controls.pas" + 6) + $9
(00180E1F){vcl250.bpl } [50C31E1F] Vcl.Forms.TApplication.ProcessMessage (Line 10641, "Vcl.Forms.pas" + 23) + $1
(00180E62){vcl250.bpl } [50C31E62] Vcl.Forms.TApplication.HandleMessage (Line 10671, "Vcl.Forms.pas" + 1) + $4
(0017C21E){vcl250.bpl } [50C2D21E] Vcl.Forms.TCustomForm.ShowModal (Line 7393, "Vcl.Forms.pas" + 33) + $5
(00085BAE){coreide250.bpl} [20536BAE] BuildHost.TBuildHost.Build (Line 231, "BuildHost.pas" + 55) + $9
(0008575C){coreide250.bpl} [2053675C] BuildHost.Build (Line 136, "BuildHost.pas" + 4) + $A
(00092B05){coreide250.bpl} [20543B05] ProjectGroupBuilder.BuildProjects (Line 146, "ProjectGroupBuilder.pas" + 1) + $17
(000D02D7){coreide250.bpl} [205812D7] ProjectGroup.TProjectGroup.CompileProjects (Line 805, "ProjectGroup.pas" + 1) + $23
(000CFFEE){coreide250.bpl} [20580FEE] ProjectGroup.TProjectGroup.CompileActive (Line 754, "ProjectGroup.pas" + 20) + $13
(000D7181){coreide250.bpl} [20588181] ProjectGroup.TProjectGroupWrapper.CompileActive (Line 2865, "ProjectGroup.pas" + 0) + $5
(000A2566){bds.exe } [004A3566] AppMain.TAppBuilder.Compile (Line 3484, "AppMain.pas" + 1) + $9
(0009C9CD){bds.exe } [0049D9CD] AppMain.TBorlandIDE.Compile (Line 1137, "AppMain.pas" + 2) + $2
(0038F23E){coreide250.bpl} [2084023E] DebuggerMgr.TDebuggerMgr.MakeCurrentProject (Line 1520, "DebuggerMgr.pas" + 108) + $D
(003909DD){coreide250.bpl} [208419DD] DebuggerMgr.TDebuggerMgr.Run (Line 2048, "DebuggerMgr.pas" + 2) + $2
(000A1CE7){bds.exe } [004A2CE7] AppMain.TAppBuilder.RunRun (Line 3257, "AppMain.pas" + 0) + $7
(0011CE67){rtl250.bpl } [5016DE67] System.Classes.TBasicAction.Execute (Line 16904, "System.Classes.pas" + 6) + $1
(0001CD82){vcl250.bpl } [50ACDD82] Vcl.ActnList.TCustomAction.Execute (Line 260, "Vcl.ActnList.pas" + 19) + $35
(0009D4B2){bds.exe } [0049E4B2] AppMain.TBorlandIDE.ExecCommand (Line 1579, "AppMain.pas" + 8) + $6
(0009CF31){bds.exe } [0049DF31] AppMain.TBorlandIDE.RunRunItemClick (Line 1354, "AppMain.pas" + 0) + $5
(0033723A){coreide250.bpl} [207E823A] EditorForm.TEditWindow.CMWindowCommand (Line 3218, "EditorForm.pas" + 15) + $9
(00033C5E){vcl250.bpl } [50AE4C5E] Vcl.Controls.TControl.WndProc (Line 7338, "Vcl.Controls.pas" + 91) + $6
(00038843){vcl250.bpl } [50AE9843] Vcl.Controls.TWinControl.WndProc (Line 10209, "Vcl.Controls.pas" + 166) + $6
(0000F884){rtl250.bpl } [50060884] System.TMonitor.TryEnter (Line 18935, "System.pas" + 10) + $0
(0000F3D8){rtl250.bpl } [500603D8] System.TMonitor.Enter (Line 18596, "System.pas" + 4) + $2
(0000F258){rtl250.bpl } [50060258] System.TMonitor.CheckOwningThread (Line 18510, "System.pas" + 2) + $0
(0000F566){rtl250.bpl } [50060566] System.TMonitor.Exit (Line 18700, "System.pas" + 1) + $2
(0000F5B7){rtl250.bpl } [500605B7] System.TMonitor.Exit (Line 18722, "System.pas" + 2) + $7
(000154AF){vcl250.bpl } [50AC64AF] Vcl.Graphics.FreeMemoryContexts (Line 7129, "Vcl.Graphics.pas" + 12) + $8
(00037E10){vcl250.bpl } [50AE8E10] Vcl.Controls.TWinControl.MainWndProc (Line 9908, "Vcl.Controls.pas" + 3) + $6
(00037E25){vcl250.bpl } [50AE8E25] Vcl.Controls.TWinControl.MainWndProc (Line 9911, "Vcl.Controls.pas" + 6) + $0
(0011DBCC){rtl250.bpl } [5016EBCC] System.Classes.StdWndProc (Line 17408, "System.Classes.pas" + 11) + $2
(00038843){vcl250.bpl } [50AE9843] Vcl.Controls.TWinControl.WndProc (Line 10209, "Vcl.Controls.pas" + 166) + $6
(00177469){vcl250.bpl } [50C28469] Vcl.Forms.TCustomForm.WndProc (Line 4572, "Vcl.Forms.pas" + 209) + $5
(00037E10){vcl250.bpl } [50AE8E10] Vcl.Controls.TWinControl.MainWndProc (Line 9908, "Vcl.Controls.pas" + 3) + $6
(0011DBCC){rtl250.bpl } [5016EBCC] System.Classes.StdWndProc (Line 17408, "System.Classes.pas" + 11) + $2
(0002E802){vcl250.bpl } [50ADF802] Vcl.Controls.FindControl (Line 3604, "Vcl.Controls.pas" + 6) + $9
(00180E1F){vcl250.bpl } [50C31E1F] Vcl.Forms.TApplication.ProcessMessage (Line 10641, "Vcl.Forms.pas" + 23) + $1
(00180E62){vcl250.bpl } [50C31E62] Vcl.Forms.TApplication.HandleMessage (Line 10671, "Vcl.Forms.pas" + 1) + $4
(00181195){vcl250.bpl } [50C32195] Vcl.Forms.TApplication.Run (Line 10809, "Vcl.Forms.pas" + 26) + $3
(001078F2){bds.exe } [005088F2] bds.bds (Line 212, "" + 7) + $7
Attached Files:
Notes
(0021550)
obones   
2018-07-18 16:06   
I don't see how this is related to the JVCL at all.
I mean, something accesses the exe file, most likely the antivirus, and that is out of our control


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6609 [JEDI VCL] 00 JVCL Components major always 2018-01-05 00:48 2018-07-18 16:04
Reporter: Marvi62 Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvDBRichEdit does not show formated text
Description: I installed JEDI 3.50 on Delphi XE8, using Windows 10 64 Bits.
The installation occured normally.
I connected the componente to Access *.accdb using Firedac, also without
 problem.

But the component shows the text as, for example:

{\\rtf1\\ansi\\deff0{\\fonttbl{\\f0\\fnil\\fcharset0 Times New Roman;}}
{\\colortbl ;\\red0\\green0\\blue0;}
\\viewkind4\\uc1\\pard\\cf1\\lang1046\\f0\\fs22 Exemplos\\par
\\par
He has the exciting ability to dribble past defender.\\par
}


If I use DBRichEdit from Delphi Data Controls palette everything works fine.

Exemplos

He has the exciting ability to dribble past defender.
Tags:
Steps To Reproduce:
Additional Information: The same Hapens to RxLib TRxDBRichEdit
Attached Files:
Notes
(0021547)
obones   
2018-07-18 16:04   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6623 [JEDI VCL] 00 JVCL Components minor have not tried 2018-03-11 13:25 2018-07-18 16:03
Reporter: dummzeuch Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: won't fix  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Replace use of sl.ClassType <> TStringList in TGnuGettextInstance.TranslateStrings with sl is TStringList
Description: Line 2169:
              if sl.ClassType <> TStringList then
                for I := 0 to sl.Count - 1 do
                  sl.Objects[I] := nil;

I think this should not just check for TStringList but for descendants too, so it should be:

              if sl.ClassType is TStringList then
                for I := 0 to sl.Count - 1 do
                  sl.Objects[I] := nil;
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021542)
obones   
2018-07-18 16:03   
Please report this to the GnuGettext project


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6624 [JEDI VCL] 00 JVCL Components minor have not tried 2018-03-11 13:29 2018-07-18 16:02
Reporter: dummzeuch Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: won't fix  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TGnuGettextInstance.Getdomain uses parameter CurLan which conflicts with a field of the class
Description: function TGnuGettextInstance.Getdomain(const domain:DomainString; const DefaultDomainDirectory:FilenameString; const CurLang: LanguageString): TDomain;

The parameter CurLang conflicts with a field curlang of the class. It should be renamed.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021541)
obones   
2018-07-18 16:02   
Please report this to the GnuGettext project


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6625 [JEDI VCL] 00 JVCL Components minor have not tried 2018-03-11 13:31 2018-07-18 16:02
Reporter: dummzeuch Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: no change required  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TGnuGettextInstance.LoadResString has exit and else
Description: In the second "if" statement in TGnuGettextInstance.LoadResString the "then" branch ends with an "exit". The "else" and "begin"..."end" afterwards is not necessary in that case.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021540)
obones   
2018-07-18 16:02   
Exit only applies to the "True" branch, so the else branche will run.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6626 [JEDI VCL] 00 JVCL Components minor have not tried 2018-03-11 13:36 2018-07-18 16:01
Reporter: dummzeuch Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: won't fix  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TFileLocator.Destroy unnecessarily moves the list entries
Description: JvGnuGettext.pas Line 2838:

  while filelist.count<>0 do begin
    filelist.Objects[0].Free;
    filelist.Delete (0);
  end;
  FreeAndNil (filelist);

Removes entries from the front of the list, which means they will moved for every while loop.

  for Idx := filelist.Count-1 downto 0 do
    FileList.Objects[Idx].Free;
  FreeAndNil (filelist);

Would be a bit more efficient.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021456)
dummzeuch   
2018-03-11 13:55   
Actually, I see no reason to free the objects from the end, so it could simply be

for Idx := 0 to FileList.Count-1 do
  FileList.Objects[Idx].Free;
(0021539)
obones   
2018-07-18 16:01   
Please report this to the GnuGettext project


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6622 [JEDI VCL] 00 JVCL Components minor have not tried 2018-03-11 13:22 2018-07-18 16:01
Reporter: dummzeuch Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: won't fix  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: wrong use of {$ifdef DELPHI2009OROLDER} in JvGnuGettext
Description: In TGnuGettextInstance.TranslateStrings there are various places where the {$ifdef DELPHI2009OROLDER} is used. TStringList.OwnsObjects was introduced in later versions, so it should actually be $ifndef:

line 2122:
  {$ifdef DELPHI2009OROLDER}
  originalOwnsObjects: Boolean;
  {$endif}

Line 2132:
    {$ifdef DELPHI2009OROLDER}
    originalOwnsObjects := False; // avoid warning
    {$endif}

Line 2157:
        {$ifdef DELPHI2009OROLDER}
        if Assigned(slAsTStringList) then begin
          originalOwnsObjects := slAsTStringList.OwnsObjects;
          slAsTStringList.OwnsObjects := False;
        end;
        {$endif}

Line 2183:
          {$ifdef DELPHI2009OROLDER}
          if Assigned(slAsTStringList) then
            slAsTStringList.OwnsObjects := originalOwnsObjects;
          {$endif}
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021457)
pyscripter   
2018-03-12 03:38   
Actually the problem is the misnaming of the conditionals.
DELPHI2009OROLDER means newer!!

See
http://issuetracker.delphi-jedi.org/view.php?id=6607
(0021458)
pyscripter   
2018-03-12 04:49   
In other words it works correctly but it so confusing.
(0021459)
AHUser   
2018-03-15 21:51   
(Last edited: 2018-03-15 21:52)
The JvGnugettext unit is a copy of the dxgettext project ( http://dxgettext.po.dk ). The unit was once adjusted to the JEDI code style but that made it impossible to update the unit. The current version of the unit is the code of the original project from 2012 with some minor bugfixes.



View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6596 [JEDI VCL] 00 JVCL Components feature N/A 2017-09-27 18:07 2018-07-18 16:00
Reporter: Caneschi Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: AddFunction of JvInterpreterAdapter
Description: Good morning,

The function below has one parameters with default value, is possible to use the function AddFunction of JvInterpreterAdapter spending quantity dinamic parameters accepting one or two parameters?

IncMilliSecond(const AValue: TDateTime;
  const ANumberOfMilliSeconds: Int64 = 1): TDateTime;
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021537)
obones   
2018-07-18 16:00   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6598 [JEDI VCL] 00 JVCL Components major always 2017-10-11 20:56 2018-07-18 16:00
Reporter: ljstudio Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Can't click on TJvDesktopAlert after open another form as Modal
Description: On Delphi 10 Seattle, I Can't click on TJvDesktopAlert after open another form as Modal, so we cannot close the alert for example. The click only works if only the owner form is opened.
Tags: Alert, Delphi 10, Delphi 10 Seattle, Delphi Seattle, Drag, TJvDesktopAlert
Steps To Reproduce:
Additional Information: This issue doesn't happen on Delphi 7.
Attached Files:
Notes
(0021535)
obones   
2018-07-18 16:00   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6600 [JEDI VCL] 00 JVCL Components feature N/A 2017-10-21 15:57 2018-07-18 15:59
Reporter: tetardd Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Changed to TJvArrowButton to make it easy to ownerdraw
Description: I have made some changes to the JvArrowButton unit (quite trivial ones) to allow a descendant of TJvArrowButton to be owner drawn (caption and glyph).

The changes are all marked with my name "David Tetard" and some explanation why I made these changes are included in the uploaded file.

Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JvArrayButton.pas (19,650 bytes) 2017-10-21 15:57
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002686&type=bug
Notes
(0021437)
tetardd   
2017-10-21 16:01   
I forgot to add, now to owner draw, simply create a descendant of TGlyphButton and override the DrawText and/or DrawGlyph methods (now made protected and virtual) and override the new procedure CreateGlyphButton to use:

FGlyphButton := TMyGlyphButton.Create(Self).

Here is an example:

===================================================
unit Unit4;

interface

uses
  Winapi.Windows, Winapi.Messages, System.SysUtils, System.Variants, System.Classes, Vcl.Graphics,
  Vcl.Controls, Vcl.Forms, Vcl.Dialogs, Vcl.Buttons, JvExControls, JvArrowButton;

type
  TDTButtonGlyph = Class(TButtonGlyph)
  Protected
       procedure DrawButtonText(Canvas: TCanvas; const Caption: string;
      TextBounds: TRect; State: TButtonState; Alignment: TAlignment;
      VerticalAlignment: TVerticalAlignment); Override;
  End;

  TDTArrowButton = Class(TJvArrowButton)
  Protected
       Procedure CreateButtonGlyph; Override;
  End;

  TForm4 = class(TForm)
    procedure FormCreate(Sender: TObject);
  private
    id_DTArrowButton : TDTArrowButton;
  public
    { Public declarations }
  end;

var
  Form4: TForm4;

implementation

Uses JvJCLUtils;

{$R *.dfm}

procedure TForm4.FormCreate(Sender: TObject);
begin
     id_DTArrowButton := TDTArrowButton.Create(Self);
     id_DTArrowButton.Parent := Self;
     id_DTArrowButton.SetBounds(10, 10, 300, 50);

     id_DTArrowButton.Caption := Blah Blah Blah;
end;

{ TDTArrowButton }

procedure TDTArrowButton.CreateButtonGlyph;
begin
     FGlyph := TDTButtonGlyph.Create(Self);
end;

{ TDTButtonGlyph }

procedure TDTButtonGlyph.DrawButtonText(Canvas: TCanvas; const Caption: string; TextBounds: TRect;
  State: TButtonState; Alignment: TAlignment; VerticalAlignment: TVerticalAlignment);
const
  AlignFlags: array[TAlignment] of Integer = (DT_LEFT, DT_RIGHT, DT_CENTER);
  VerticalAlignFlags: array[TVerticalAlignment] of Integer = (DT_TOP, DT_BOTTOM, DT_VCENTER);
var
  S: string;
begin
  S := Caption;
  with Canvas do
  begin
    Brush.Style := bsClear;
    
    // Just to test that it works, all captions will be drawn in blue:
    Font.Color := clBlue;

    if State = bsDisabled then
    begin
      OffsetRect(TextBounds, 1, 1);

      DrawText(Canvas, S, -1, TextBounds, AlignFlags[Alignment] or VerticalAlignFlags[VerticalAlignment] or DT_SINGLELINE);
      OffsetRect(TextBounds, -1, -1);
      Font.Color := clBtnShadow;
      DrawText(Canvas, S, -1, TextBounds, AlignFlags[Alignment] or VerticalAlignFlags[VerticalAlignment] or DT_SINGLELINE);
    end
    else
    begin
      DrawText(Canvas, S, -1, TextBounds, AlignFlags[Alignment] or VerticalAlignFlags[VerticalAlignment] or DT_SINGLELINE);
    end;
  end;
end;


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6605 [JEDI VCL] 02 Installation minor always 2017-11-19 17:46 2018-07-18 15:58
Reporter: beluco Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: unable to reproduce  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Install - Many error messages appear because the JCL version are not compatible
Description: This message is available for Delphi 10 2 1 "Getit" installation - Tokyo (Embarcadero® Delphi 10.2 Version 25.0.27659.1188) and Windows 10 pro 64 (version 1709 - build 16299.64). Both compiling 32 and 64:

Compiler Messages
Many error messages appear because the JCL version are not compatible. Please keep in mind that you need the correct JCL version.
"C:\Users\xxx\Documents\Embarcadero\Studio\19.0\CatalogRepository\JEDIVisualComponentLibraryJVCL-3.5\run\JvgCrossTable.pas(10Waring: W1037-Loop variable '1' may be undefined" after loop

And after you install, when you build a project that contains SysCommons.pas it displays a "[dcc32 Warning] SynCommons.pas(49701): W1073 Combining signed type and unsigned 64-bit type - treated as an unsigned type" message.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021441)
AHUser   
2017-11-19 23:29   
The GetIt integration was done by Embarcadero itself, not by the JEDI Team.
I recommend to use the JCL and JVCL git repository instead.

https://github.com/project-jedi/jcl
https://github.com/project-jedi/jvcl

Or you use a daily build:
http://jcl.sourceforge.net/daily/
http://jvcl.sourceforge.net/daily/


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6599 [JEDI VCL] 00 JVCL Components minor always 2017-10-14 23:35 2018-07-18 15:58
Reporter: Luciano_f Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: no change required  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: How to install only one component without having to install the entire JVCL ?
Description:  I would like to know if it is possible to use only this component "JclCompression"
without having to install all the Classes that are very extensive.
I just need the "JclCompression"
how do you just use it ?

   It would be interesting to leave the library more modular without as many dependencies as it is done with the TMS components
https://www.tmssoftware.com
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021443)
AHUser   
2017-11-19 23:31   
The JclCompression unit is part of the JCL not JVCL. So you only need the JCL and no JVCL.
(0021444)
Luciano_f   
2017-11-20 14:30   
Yes however the JCL is very large how could I do to just use "JclCompression" without so many dependencies ?
(0021533)
obones   
2018-07-18 15:58   
You could simply add the unit to your project, compile and see what's missing. You should get down to three or four units.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6607 [JEDI VCL] 00 JVCL Components feature always 2017-12-24 13:25 2018-07-18 15:58
Reporter: pyscripter Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: no change required  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Please remove unnnecessary IFDEFs in JvGnugettext
Description: In JvGnugettext there are about 70 lines of IFDEFs such as the following:
{$ifdef VER200}
  // Delphi 2009 with Unicode
  {$DEFINE DELPHI2009OROLDER}
{$endif}

which are not only unnecessary but confusing.

For example in TGnuGettextInstance.TranslateStrings we have the code:

        {$ifdef DELPHI2009OROLDER}
        if Assigned(slAsTStringList) then begin
          originalOwnsObjects := slAsTStringList.OwnsObjects;
          slAsTStringList.OwnsObjects := False;
        end;
        {$endif}

In fact DELPHI2009OROLDER actually means Delphi 2009 or newer!

Since the unit includes JEDI.inc, the above can be replaced with DELPHI12_UP etc.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021532)
obones   
2018-07-18 15:58   
This will not be changed as the unit comes from a third party project that has its own life.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6543 [JEDI VCL] 00 JVCL Components major always 2017-01-12 06:55 2018-07-18 15:52
Reporter: gmdobson Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.00  
Product Build: Resolution: unable to reproduce  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Error Reading Form
Description: I am running RAD Studio - Delphi XE4.
When I attempt to open a form I get the message :

Error Reading Form: frmCashpay.
Class TJvPageControl not found.

I have checked the source and set-up of RAD Studio and cannot find any problem.


Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021408)
wprins   
2017-01-16 12:48   
The error message implies you've not got the JVCL components installed in your Delphi environment.

Re-run the installer in the "install.bat" file in teh "jvcl/jvcl" folder. Afterwards, run Delphi, create a new project with a new form, and drop a TJvPageControl onto the form to prove that the component is properly installed.

Once that succeeds you ought to be able to open your project.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6536 [JEDI VCL] 00 JVCL Components major always 2016-12-02 16:32 2018-07-18 15:48
Reporter: Milan Bacik Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Changing value in OnChange event is not reflected by TJvDBComboBox
Description: I have TJvDBComboBox conected to field. This field have OnChange event defined. In this event I change value of this field (ie validation against another inputs). When I select value1 in combo and event change it to value2 TJvDBComboBox still shows value1. TDBComboBox shows value2.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021509)
obones   
2018-07-18 15:48   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5939 [JEDI VCL] common major always 2012-07-27 15:47 2018-07-18 15:47
Reporter: Lagout Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.0  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: FOnActivate does not occur for individual forms in TJvDockTabHostForm when a form is Pinned from autohide mode.
Description: So as the title says, When two forms are within a TJvDockTabHostForm I've noticed that an OnActive event is triggered for relevant forms within the TJvDockTabHostForm on events e.g. mouseover form name triggers not only an OnActive event for the TJVDockTabHostForm but also for the Form that is being shown on the mouseover. However when pinning the TJvDockTabHostForm only an OnActive Event is triggered for that TJvDockTabHostForm, not the individual Forms contained within. The reason why this is needed is that when writing XML documents to a DockingForm it needs to be refreshed each time an action is performed upon the Window for it be viewable.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021503)
obones   
2018-07-18 15:47   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6344 [JEDI VCL] General API minor have not tried 2014-10-24 07:03 2018-07-18 15:47
Reporter: inprosis Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: tjvstringgrid error rightalign entry numeric field
Description: tjvstringgrid show a bad color and make this enty centered
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021502)
obones   
2018-07-18 15:47   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6468 [JEDI VCL] 02 Installation crash always 2015-11-02 10:03 2018-07-18 15:46
Reporter: Gerold Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: no change required  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Install with option "Compile debug untis" enabled failed
Description: Can not install the JVCL with above option enabled. Did NOT enable the option "JVCL Developper Installation" !!!

Found this error in the log file "C:\Delphi\JVCL\bin\jvcl_install_d7.log":

C:\Delphi\JVCL\Common\jvcl.inc (26) - Fatal: File not found: 'jedi\jedi.inc'

The only JEDI.INC file I found was in
C:\Delphi\JVCL\devtools\common
and contains only the following line:
{$I ..\..\common\jedi\jedi.inc}

There is no subdir "jedi" in the "common" subdir.

So something is missing here.
Tags:
Steps To Reproduce:
Additional Information: D7 Ent
JCL: Daily: 2015-10-21
JVCL: Daily: 2015-10-21


When I copy the following subdir "JEDI" from the JCL
C:\Delphi\JCL\source\include\jedi
to
C:\Delphi\JVCL\common\jedi
there is no error.
Attached Files:
Notes
(0021333)
AHUser   
2016-08-04 21:16   
The jedi.inc file in the devtools\common directory doesn't exist anymore as it was from a time when the JVCL came with its own common\jedi\jedi.inc file. The jedi.inc file now comes from the JCL\source\include\jedi\jedi.inc and the JVCL requires the JCL\source\include directory to be in the include/library search path (the JCL Installer adds the directory)
(0021379)
Kyle_Katarn   
2016-08-09 23:31   
typo : "Compile debug untis" > "Compile debug units"


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6525 [JEDI VCL] 00 JVCL Components trivial always 2016-09-07 00:21 2018-07-18 15:45
Reporter: alirezalink Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: jvdbgrid in BiDiMode=RightToLeft does not show data and column headers
Description: hi,
when set bidimode property of jvdbgrid to righttoleft value, data of the table does not show and column hesaders become like "a..." ,in execution time and
even in design time when binded dataset is active.
thanks.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021499)
obones   
2018-07-18 15:45   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6526 [JEDI VCL] 00 JVCL Components minor always 2016-09-14 18:06 2018-07-18 15:45
Reporter: leonardo_pmascarenhas Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvNavigationPane doen't repaint it's items when using the splitter
Description: When adding JvNavPanelPage dynamically to the JvNavigationPane it not render properly the component and it's also impossible to do it manually.
JvNavigationPane.Refresh or JvNavigationPane.Repaint
Tags:
Steps To Reproduce:
Additional Information: l_PluginBarPanel := TJvNavPanelPage.Create(Self);
l_PluginBarPanel.Parent := nvpPlugins; //TJvNavigationPane
l_PluginBarPanel.PageList := nvpPlugins;
Attached Files: Capture.PNG (2,967 bytes) 2016-09-14 18:19
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002667&type=bug
Notes
(0021397)
leonardo_pmascarenhas   
2016-09-14 18:22   
Step by Step:
- Insert manually a new TJvNavigationPane
- Insert manually more than one TJvNavPanelPage
- Inside one of TJvNavPanelPage, create a TListView and put some content on it
- In runtime select the one that you put the TListView
- Try to use the splitter

You should see problems in the render
Even trying to repaint / refresh using the event OnResize, doen't fix it

Delphi 10 Seattle
(0021398)
leonardo_pmascarenhas   
2016-09-14 20:27   
A workaround to this issue is change the ActivePageIndex on the OnResize event of JvNavigationPane.
It seams that an internal refresh helps someway
NavigationPane.ActivePageIndex := 1;
NavigationPane.ActivePageIndex := 0;
(0021399)
leonardo_pmascarenhas   
2016-09-14 20:34   
Sorry, the event that I mean was OnSlitterPaint not OnResize as I said
(0021498)
obones   
2018-07-18 15:45   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6490 [JEDI VCL] 00 JVCL Components major always 2016-01-21 12:11 2018-07-18 15:45
Reporter: php4pro Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Right to left on TJvDBLookupCombo
Description: there is a bug on JvDBLookupCombo with right to left when i choose right to left the arrow disappear see attached screenshot
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: Untitled.jpg (78,598 bytes) 2016-01-21 12:11
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002647&type=bug
Notes
(0021496)
obones   
2018-07-18 15:45   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6491 [JEDI VCL] 00 JVCL Components major always 2016-01-22 11:15 2018-07-18 15:45
Reporter: HpW Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvFormMagnet does not deal with Vista...Win10 borders
Description:
Requires to deal with the related MS Windows releases as Vista...Win10 borders...
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021495)
obones   
2018-07-18 15:45   
Please provide a pull request at Gitbug with the required changes


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6496 [JEDI VCL] 00 JVCL Components feature always 2016-02-15 10:17 2018-07-18 15:44
Reporter: moore Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvCalculator copy paste customize caption
Description: It would be very nice if in TJvCalculator the popup items of copy paste may customize their caption in case of applications woth language different from English..
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021494)
obones   
2018-07-18 15:44   
AFAIK, those captions come from Windows itself and so are translated by the OS.
If I'm wrong, then use GnuGettext to translate them.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6500 [JEDI VCL] 04 Feature Request feature always 2016-03-12 20:07 2018-07-18 15:43
Reporter: GNGisNotGNU Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.37  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Jedi Interpreter, compile multiple units
Description: Is it possible to compile (or interpret) multiple source units with the Jedi interpreter? I see how you can run one unit with a main function, but what about interpreting unit1, unit2, unit3? The documentation for the interpreter is lacking.

Is it possible to have multiple units, and to put these units in the uses clause? if so, how? If not, is this a feature that was planned?

I'm trying to figure out what the AddSrcUnit function does if this has anything to do with it.
Tags:
Steps To Reproduce:
Additional Information: if there is a way to do this, it's not a feature request because the feature may already exist. However I could not figure it out, and the documentation needs to be improved.
Attached Files:
Notes
(0021492)
obones   
2018-07-18 15:43   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6454 [JEDI VCL] 00 JVCL Components major always 2015-10-02 08:45 2018-07-18 15:40
Reporter: ZENsan Platform:  
Assigned To: OS: Windows  
Priority: normal OS Version: 7  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: UseThemedSelection breaks existing CustomDraw code
Description: UseThemedSelection breaks existing CustomDraw code.
See attached sample project. Once the UseThemedSelection is set the drawing behavior for the selected row is bad..
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: UseThemedSelection.zip (2,137 bytes) 2015-10-02 08:45
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002634&type=bug
2015-10-02_9-45-59.jpg (26,835 bytes) 2015-10-02 08:46
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002635&type=bug
Notes
(0021486)
obones   
2018-07-18 15:40   
To me, either you custom draw and you get what you want, or you use themes and you can't get custom draw to function properly


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6459 [JEDI VCL] 00 JVCL Components major always 2015-10-12 23:46 2018-07-18 15:39
Reporter: jaridmo Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: RadStudio 10 Seattle and TJvHidDeviceController "Device cannot be identified" error
Description: Drop a TJvHIDDeviceController component on a form and get error "Device cannot be identified". It doesn't break builder or anything, but the error shows up whenever opening the project or opening the form.

I can reproduce this easily by creating a blank project and adding a TJvHidDeviceController to the form. The error shows on adding the component.
Tags:
Steps To Reproduce:
Additional Information: I have installed the version from GetIt Package Manager and when I drop a TJvHIDController on a form it gives the error: "Device cannot be identified". So I uninstalled the GetIt versions and downloaded the daily build "latest full" zip "2015-10-12 08:32:52 UTC" to see if it had the same problem. Yes, it shows the same error message. I also tried the latest stable build from sourceforge and it has the same error.

This is a Windows 10 Enterprise inside a VMWare Workstation Virtual Machine RAD Studio 10 Seattle Enterprise
Attached Files: VMWare Virtual USB Sensors Information.png (21,426 bytes) 2015-10-15 23:34
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002638&type=bug
Notes
(0021243)
jaridmo   
2015-10-15 23:34   
After further debugging I find the issue is when VMWare installs the VMWare Virtual USB Sensors and turns those on. Disabling those causes this error to go away...
These were on by default when we created a Windows 10 VM in VMWare Workstation 12.

I will add an image of what the VMware Virtual USB Sensor Settings are (found through USBDeview).


The workaround is to turn off the USB Sensor support in VMWare:

VMWare Workstation - Edit Virutal Machine Settings - Options - Guest Isolation - Shared Sensor Input - Uncheck the 3 options.
(0021485)
obones   
2018-07-18 15:39   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6467 [JEDI VCL] 00 JVCL Components major always 2015-10-27 09:29 2018-07-18 15:37
Reporter: MrBugIssue Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version: 3.48  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: TJvBalloonHint flickering problems on Windows 7 and higher
Description: Before the TJvBalloonHint will shown the background rectangle of the balloon hint flickers up first shortly. It's really annoying and looks ugly. But this only happens when the Visual Effect "Fade or slide ToolTips into view" inside the "Windows performance options" dialog is checked (turned on). Everything is fine when it's unchecked (turned off). So maybe someone can help me to find a workaround for this behaviour?

Windows performance options dialog:
http://www.eightforums.com/attachments/tutorials/20074d1365897332-advanced-tools-open-windows-7-windows-8-a-performance_options.jpg

Tags:
Steps To Reproduce:
Additional Information:
Attached Files: Rectangle flickering.png (32,658 bytes) 2015-10-27 09:29
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002640&type=bug
Notes
(0021481)
obones   
2018-07-18 15:37   
Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6636 [JEDI VCL] 02 Installation crash always 2018-05-24 19:10 2018-07-18 15:32
Reporter: xxxFALKORxxx Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: feedback Product Version:  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Error installing JVCL349CompleteJCL27-Build5676
Description: Hi;

ive trying to install this version for several days without luck....

i searched on internet for solution and nothing seems to work;

I use
Delphi 7 Enterprise
Windows 10

i was able to run installers (JCL and JVCL) everything runs ok; but when i try to star delphi i got this kind of errors for every JVCL package...

entry point not found @jclstringconversions@initialization$qqrv in JvCoreDesign70.bpl




Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021475)
obones   
2018-07-18 15:32   
It looks like it is loading an old version of the JCL. Please make sure you don't have anything old somewhere on your hard drive


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6629 [JEDI VCL] 00 JVCL Components crash always 2018-03-28 18:57 2018-07-18 15:31
Reporter: vez Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JVCL can't be download form http://jvcl.sourceforge.net/daily/
Description: JVCL can't be download form http://jvcl.sourceforge.net/daily/

The length alwasy is equal to 32.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021467)
vez   
2018-05-25 22:49   
Again last JCL is only from 29.04.2018!


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6631 [JEDI VCL] 00 JVCL Components minor always 2018-03-31 09:18 2018-06-09 16:35
Reporter: nyburner Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Drag and Drop
Description: Drag and drop for the TjvDragDrop component will not work under Windows 10
unless the EXE is run as privileged user -AND- some extra code is run to enable
messages to be passed correctly. See attached code unit below;

Suggestion: add the code included below to JVCL so drag and drop functions
             correctly;

Thanks;

Bruce
Tags:
Steps To Reproduce:
Additional Information: {***********************************************************************
* *
* wsUpdateDragDropPrivileges.pas *
* *
* *
* Modification *
* ============ *
* *
***********************************************************************}

Unit wsUpdateDragDropPrivileges ;

interface

  Procedure UpdateDragDropPrivileges ;

Implementation
  Uses
    Windows , Messages ;

// function ChangeWindowMessageFilter(Message: UINT; dwFlag: DWORD): BOOL; stdcall;

{***********************************************************************
* *
* UpdateDragDropPrivileges *
* *
* Modification *
* ============ *
* *
***********************************************************************}

Procedure UpdateDragDropPrivileges ;
  Begin { UpdateDragDropPrivileges }
    ChangeWindowMessageFilter(WM_DROPFILES , MSGFLT_ADD) ;
    ChangeWindowMessageFilter(WM_COPYDATA , MSGFLT_ADD) ;
    ChangeWindowMessageFilter(WM_COPYGLOBALDATA , MSGFLT_ADD) ;
  End ; { UpdateDragDropPrivileges }

Initialization
  UpdateDragDropPrivileges ;
End.
Attached Files: wsUpdateDragDropPrivileges.pas (1,857 bytes) 2018-03-31 09:18
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002692&type=bug
Notes
(0021471)
AHUser   
2018-06-09 16:35   
Added property "AllowDropElevation: Boolean default False" to TJvDragDrop. By enabling it (Windows 7 and newer required) the "Drag" can come from an application with a lower privilege than the "Drop" window.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6616 [JEDI VCL] 00 JVCL Components minor always 2018-02-01 05:38 2018-06-09 15:24
Reporter: pyscripter Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvCreateProcess - CloseWrite should be made public
Description: When you redirect input to the created process, the standard way to indicate that input is finished is to close the hstdin handle. See for example (https://msdn.microsoft.com/en-us/library/windows/desktop/ms682499(v=vs.85).aspx, the WriteToPipe function).

In the past I got away by writing a #26 character (EOF ^Z) to the input. That for example worked with Python 2.x, but it does not work with Python 3.x, which keeps on waiting for input. CloseWrite, needs to made public so that the caller of JvCreateProcess can indicate that there is no more input to provide.
Tags:
Steps To Reproduce:
Additional Information: The attached modified file does this (as well as dealing with separate issue 6610).
Attached Files: JvCreateProcess.pas (51,184 bytes) 2018-02-01 05:38
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002691&type=bug
Notes
(0021470)
AHUser   
2018-06-09 15:24   
CloseWrite is now public in the master branch


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6638 [JEDI VCL] 00 JVCL Components tweak always 2018-06-08 12:46 2018-06-09 15:08
Reporter: AlexB Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvThread Wait functions can not be used in background threads (solution)
Description: TJvThread.WaitFor and ExecuteThreadAndWait call Application.HandleMessage which is valid only in context of main thread.

To avoid this problem I propose changes as follows:
https://github.com/BugsDigger/jvcl/blob/master/jvcl/run/JvThread.pas
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021469)
AHUser   
2018-06-09 15:08   
Fix in master branch.

A pull request would have been easier.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6635 [JEDI VCL] Miscellanous major have not tried 2018-05-24 10:14 2018-06-08 11:11
Reporter: DmitryBelkevich Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Some fixes
Description: It's need to make some fixes into different files.
Tags:
Steps To Reproduce:
Additional Information: 1. 64 bits compatiblity

a) Change Pointer(Cardinal to Pointer(NativeUInt
Files JvAddPrinter.pas, JvThemes.pas
b) Longint(Self) to NativeUInt(Self)
Files JvBDEFilter.pas, JvBDEProgress.pas
c) In file JvDataProvider.pas:
change Result := Pointer(Cardinal(RAPI.GetProc) and $00FFFFFF + Cardinal(Self) + 4);
to Result := Pointer(NativeUInt(RAPI.GetProc) and $00FFFFFF + NativeUInt(Self) + 4);

2. Add CheckAll method to the TJvCheckTreeView class:

procedure TJvCheckTreeView.CheckAll(CheckState: boolean);
var
  I: Integer;
begin
  for I := 0 to Items.Count - 1 do
    TJvTreeNode(Items[i]).Checked := CheckState;
end;

3. Modify TJvPropertyStoreEditorControl.SetPropertyStore method:

procedure TJvPropertyStoreEditorControl.SetPropertyStore(const Value: TComponent);
begin
  if csDestroying in Componentstate then
    Exit;

Attached Files:
Notes
(0021468)
AHUser   
2018-06-08 11:11   
Fixed in master branch.

The BDE Units are not fixed because there is no 64 bit BDE and the expected function parameter is "Longint"


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6615 [JEDI VCL] 00 JVCL Components minor always 2018-01-29 00:40 2018-01-30 18:52
Reporter: pyscripter Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvProgramVersionCheck and JvParameterList are not DPI aware
Description: As per title. These components are unusable in DPI aware Delphi applications with High DPI screens.

The attached zip file contains modified versions of three files to make the components DPI aware.
JvProgramVersionCheck.pas
JvParameterList.pas and
JvParameterListParameters.pas
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JvProgramVersionCheck.zip (38,426 bytes) 2018-01-29 00:40
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002690&type=bug
Notes
(0021453)
AHUser   
2018-01-29 20:47   
Is that "Application.ProcessMessages" call in TJvProgramVersionCheck.DownloadThreadOnFinishAll really neccessary?
(0021454)
pyscripter   
2018-01-29 20:53   
I found that without it the program gets stucked. I am not sure why, but it works with Application.ProcessMessages and it cannot do any harm.
(0021455)
AHUser   
2018-01-30 18:52   
Applied to master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6613 [JEDI VCL] 02 Installation crash always 2018-01-25 18:28 2018-01-26 20:49
Reporter: joseh Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Crash compiling JvDB70 JvDBlookup (using JVCL install)
Description: Error compiling in to D7

[Compiling: JvDB70.bpl]
Borland Delphi Version 15.0
Copyright (c) 1983,2002 Borland Software Corporation

C:\Users\joseh\dev\comp\jedi\jvcl\run\JvDBLookup.pas(421) Error: Undeclared identifier: 'CM_DOUBLEBUFFEREDCHANGED'
C:\Users\joseh\dev\comp\jedi\jvcl\run\JvDBLookup.pas(421) Error: Illegal message method index
JvDB.dpk(106) Fatal: Could not compile used unit '..\..\run\JvDBLookup.pas'
Tags: CMDoublebufferedchanged, JVCL, JvDbLookupCombo
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021452)
AHUser   
2018-01-26 20:49   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6563 [JEDI VCL] 02 Installation minor have not tried 2017-04-01 10:53 2017-12-19 20:26
Reporter: SH3 Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Installation problem - Cannot access private symbol
Description: When i try to install JVCL in Delphi 10.1, i get this message:

C:\Meus Documentos\Instaladores\Delphi\jvcl-master\jvcl\run\JvAppIniStorage.pas(261) Error: E2361 Cannot access private symbol TMemIniFile.FSections
C:\Meus Documentos\Instaladores\Delphi\jvcl-master\jvcl\run\JvAppIniStorage.pas(261) Warning: W1023 Comparing signed and unsigned types - widened both operands
C:\Meus Documentos\Instaladores\Delphi\jvcl-master\jvcl\run\JvAppIniStorage.pas(261) Error: E2014 Statement expected, but expression of type 'Boolean' found
C:\Meus Documentos\Instaladores\Delphi\jvcl-master\jvcl\run\JvAppIniStorage.pas(274) Error: E2361 Cannot access private symbol TMemIniFile.FSections
JvCore.dpk(2384) Fatal: F2063 Could not compile used unit 'JvAppIniStorage.pas'
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021448)
AHUser   
2017-12-19 20:26   
You had/have an outdated jedi.inc.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6603 [JEDI VCL] 00 JVCL Components minor always 2017-11-08 16:50 2017-11-19 23:30
Reporter: mpuppe_jam Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Buttons in JvWizard do not scale correctly for high screen resolutions
Description: Buttons in JvWizard do not scale correctly for high PPI screen resolutions.

I already reported this over at Github. You can find the pull request at https://github.com/project-jedi/jvcl/pull/45
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021442)
AHUser   
2017-11-19 23:30   
Merged into master


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6160 [JEDI VCL] 00 JVCL Components major always 2013-07-06 16:54 2017-04-20 11:19
Reporter: Delphi86 Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: confirmed Product Version: 3.47  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvNTEventLog shows wrong properties
Description: Hello,
I'm new to this and not an Delphi expert, but I have found an Issue. This is some kind of unprofessional code, but shows the issue:

--- Delphi Code ---
  JvLog.Server := 'localhost';
  JvLog.Source := 'Security'; // System, Application
  JvLog.Open;
  JvLog.Last;
  ShowMessage(IntToStr(JvLog.EventRecord.ID) + ' | ' +
    JvLog.EventRecord.EventType + ' | ' + JvLog.EventRecord.Source + ' | ' +
    JvLog.EventRecord.Computer + ' | ' +
    IntToStr(JvLog.EventRecord.RecordNumber) + ' | ' +
    DateTimeToStr(JvLog.EventRecord.DateTime));
--- Delphi Code End ---

I just wanted to show some properties of the EventLog in a ShowMessage, but for the 3 logs Application, System and Security I got different properties. For Example "JvLog.EventRecord.Computer" shows the Computer name only in the Security log. In the other Logs the Source propertie holds my Computer name and in the System Log the name is cut off (Lukas-PC --> s-PC).It's hard to describe but I added a picture which should underline what I mean.

Thank you,
Lukas
Tags:
Steps To Reproduce:
Additional Information: I don't know if there is an issue, but I had to covert the ID of the System and Application Log into hey code to cut off the flag and than convert it back to become the real ID. But sometimes the ID comes without a flag. So if I watch the EventLog and get the Event ID 1014 everything is okay. But when I get 1073748860 I have to convert it into hey code 40001B7C, cut off the flag (4000) and then convert it back 1B7C --> 7036. But how to make a difference between them, so Delphi knows which ID has a flag and which not. My first thought was to use the amount of digits but that's unsafe and I don't know how many flags exists and how long they are.
Attached Files: Issues.bmp (455,382 bytes) 2013-07-06 16:54
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002462&type=bug
JvNTEventLog Demo.rar (632,239 bytes) 2013-09-01 00:19
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002486&type=bug
0001-6160-TJvNTEventLog.patch (140,770 bytes) 2013-09-02 14:16
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002488&type=bug
0002-6160-fixed-obtaining-user-name-and-SID.patch (1,749 bytes) 2013-09-02 14:47
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002489&type=bug
JvNTEventLog Updated.7z (93,350 bytes) 2013-09-02 14:49
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002490&type=bug
0003-jvcl_NTEventLog_Win32-only.patch (2,432 bytes) 2013-10-08 17:11
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002504&type=bug
Notes
(0020614)
Arioch   
2013-08-31 04:16   
Attach demo project please

Also, there is no such version as "Delphi86" - that is something bogus

PS. to post screenshots, better use PNG or GIF formats

> to cut off the flag and than convert it back to become the real ID

why do you think those were some flags (which flags? what do they mean, what do they describe?) and not real IDs (large ? yes, there are large numbers in computers...)

> first thought was to use the amount of digits but that's unsafe

True. You'd better read about binary operations.

For example you can use something like IntToStr(ID and not $F0000000) - but i also don't have a clue if that is correct or how many flags or if there are any flags at all.

See bitwise operators at http://docwiki.embarcadero.com/RADStudio/XE4/en/Expressions_(Delphi)#Logical_.28Bitwise.29_Operators

See also http://en.wikipedia.org/wiki/Binary_number
That is the basis of programming, unless some exotic ternary computers used
(0020618)
Delphi86   
2013-09-01 00:19   
> Attach demo project please

Done!

> Also, there is no such version as "Delphi86" - that is something bogus

Ops, where have I mentioned "Delphi86" as version? It's my username here, my Delphi Version is Rad Studio XE2, JVCL Version mentioned above.

> For example you can use something like IntToStr(ID and not $F0000000) - but i also don't have a clue if that is correct or how many flags or if there are any flags at all.

Works, thanks, my fault!



Still UserName/Computername does not work properly.
(0020619)
Delphi86   
2013-09-01 00:24   
Btw: OS: Win7 Prof. 64bit
(0020620)
Arioch   
2013-09-01 12:52   
(Last edited: 2013-09-01 12:53)
Well, at work i also use w7x64 and xe2u4hf1
I also try to keep JVCL at git-master, so it maybe somewhat more recent than 3.47

OTOH this month would be very busy for me, so i cannot promise anything, but trying your demo project on my box

(0020621)
Arioch   
2013-09-01 12:58   
A bit of offtopic:

ShowMessage(IntToStr(JvLog.EventRecord.ID) + ' | ' +
     JvLog.EventRecord.EventType + ' | ' + JvLog.EventRecord.Source + ' | ' +
     JvLog.EventRecord.Computer + ' | ' +
     IntToStr(JvLog.EventRecord.RecordNumber) + ' | ' +
     DateTimeToStr(JvLog.EventRecord.DateTime));

i wonder if this would do the same but with easier to read (IMHO) code :-)

ShowMessage(
  JclStringsList.Add( [
     JvLog.EventRecord.ID, JvLog.EventRecord.EventType, JvLog.EventRecord.Source,
     JvLog.EventRecord.Computer, JvLog.EventRecord.RecordNumber, JvLog.EventRecord.DateTime
  ]).Join(' | ')
);
(0020625)
jfudickar   
2013-09-01 21:46   
Looks better!
Interesting type of code, The option would be to use Format
(0020626)
Arioch   
2013-09-02 14:07   
(Last edited: 2013-09-02 14:50)
This god-forgotten component could easily blow the stack ever since Delphi 2009

It does not support new rich event sources introduce by Vista and Win2008 Server

It only partially supports classic Win2K/XP event messages.

Messages are not supported on Win64

Should rather it be just removed from JVCL ? This component is a kind of whit elephant (a little one, but still). Or perhaps "handle-less suitcase".

(0020627)
Arioch   
2013-09-02 14:11   
(Last edited: 2013-09-02 14:51)
Delphi86 - try new code.

And yes, those were not flags but an integral part of IDs.
Event ID is not a plain integer but a structure.

So "ID and not $F0000000:" that you show is not ID at all.

http://msdn.microsoft.com/en-us/library/aa363651(v=vs.85).aspx

(0020628)
Arioch   
2013-09-02 14:16   
Cannot make pull request due to Git CR/LF issues.
Please, someone, apply the patch.
(0020656)
Arioch   
2013-10-08 16:46   
Delphi86, did you tried this ? Do you still have problems ?
(0020658)
Delphi86   
2013-10-09 21:35   
No, I haven't tried this yet. I'm currently working on an exam over a longer period of time and had no time. I solved my problem using WMI. But I will try this in the next two weeks, WMI isn't a good solution.
(0020681)
Delphi86   
2013-10-22 23:19   
Finished my stuff. Can work on this problem. So... What shall I do exactly. Tried it with the latest development snapshot (3.48). Still the same issue. Sorry, but I haven't worked with Delphi in the last months. I'm totally out of practice :(
(0020682)
Arioch   
2013-10-23 08:27   
This was not merged into trunk, at least not until something would really test it. Sincerely i don't know if jfudickar is part of the team. If not, then maybe none of the team read this yet.

There i think nothing changed in this regard in dailies. You can compare JvNTEvents.pas of this daily and your prior one. Or even easier, right-click on JvNTEvents.pas and go menu Tortoise Git -> history and see if any changes were made since day you registered this ticker.

Somewhat reworked module and demo are attached to this ticket, either in format of patches or as 7z blob. Take what suits you best and try them.
(0020683)
Delphi86   
2013-10-23 19:15   
Ah, I havent's seen that there have been added attachments. This is my first ticket, so I'm not familiar with this.

But yes, your updated JvNTEvents.pas worked for me. But how to use the patches? Neber worked with such files.
(0020685)
Arioch   
2013-10-24 08:18   
Well, those patch-files were created by Git and contain references to Git history, so i don't actually know if you can apply them automatically without having Git installed. Maybe tools like KDiff3, WinMerge, DiffMerge and similar can be used to some extent. Or you just can read those patch files yourselves and see the changes, which then you'd manually apply.
(0021424)
Pannier   
2017-04-20 11:19   
Hello, I had the same problem. JvNTEventLog Updated.7z worked except the MessageText is wrong.
This changes are not in the latest repo. Is this right?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6556 [JEDI VCL] 02 Installation minor always 2017-03-23 21:24 2017-03-24 17:36
Reporter: RHoek Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Compiler 'Warnings' when installing JVCL for Delphi 10.2 Tokyo
Description: I've update my local repo and installed JCL en JVCL for Delphi 10.2 Tokyo base on the latest branch/commits.

When installing JCVL I get 4 warning about private fields that need to be checked...
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: Warnings.png (11,613 bytes) 2017-03-23 21:24
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002674&type=bug
Notes
(0021413)
obones   
2017-03-24 17:36   
Thanks, changes have just been pushed


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6415 [JEDI VCL] 00 JVCL Components major always 2015-06-29 20:22 2016-08-26 21:27
Reporter: dcraposo Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Invisible buttons on TJvOutlookBar with Windows Server 2008
Description: Buttons on the TJvOutlookBar stay invisble on bottom of the component, when the project is compiled with Delphi XE5 or newer. The problem appears to surface only when the application is running under Windows Server 2008 environment.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: 1.png (8,700 bytes) 2016-02-03 18:46
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002649&type=bug
2.jpg (28,585 bytes) 2016-02-03 18:47
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002650&type=bug
Menu.zip (838,759 bytes) 2016-02-03 18:49
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002651&type=bug
Notes
(0021193)
obones   
2015-09-14 11:25   
Please provide the zipped sources of a sample application showing this
(0021272)
brenooandrade   
2016-02-03 18:46   
Any news about this issue?
I have the same problem when I run the component JvOutlookBar on Windows XP. (Using Delphi Seattle 10).
When I use the application on Windows 7 or newer the problem doesn't occurs.

I've provided a demo and some print screen.
(0021387)
lomo74   
2016-08-26 18:00   
To solve the issue:
edit file JvOutlookBar.pas
around line 0001000:0002259, you find the following block of code:
      if Rgn <> 0 then
      begin
        SelectClipRgn(Canvas.Handle, Rgn);
        DeleteObject(Rgn);
      end;

change to:

      if Rgn <> 0 then
      begin
        SelectClipRgn(Canvas.Handle, 0);
        DeleteObject(Rgn);
      end;
(0021388)
lomo74   
2016-08-26 18:01   
I meant "around line 2259"
(0021390)
AHUser   
2016-08-26 21:00   
This may break DrawThemedBackground for other controls as it removes the clip region and doesn't restore the original clip region.

The actual fix may be to check the return value of GetClipRgn and delete the Rgn region if it returns that there is no clip region.

...
case GetClipRgn(Canvas.Handle, Rgn) of
  0, -1:
    begin
      DeleteObject(Rgn);
      Rgn := 0;
    end;
end;
...
(0021391)
AHUser   
2016-08-26 21:27   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6523 [JEDI VCL] 02 Installation minor always 2016-08-20 18:57 2016-08-23 16:34
Reporter: myarmor Platform: Windows  
Assigned To: AHUser OS: W7 x64  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: 3.50 2016/08/20 Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Installer: Delphi Berlin 10.1 Pro identified as "10.1 Pers"?
Description: On the "Select Packages" the installer identifies Delphi 10.1 Professional as RAD Studio 10.1 Personal (Iow, "Pers").
Tags:
Steps To Reproduce: Start the installer with Delphi 10.1 Professional installed.
Additional Information:
Attached Files:
Notes
(0021381)
AHUser   
2016-08-20 19:21   
'Pers' is used for the edition string if the "Edition" entry is missing from the registry key HKLM\Software\WOW6432Node\Embarcadero\BDS\18.0.

This means your Delphi installation registry key has missing entries. Did you use the Delphi ISO installer or the new Get-It web installer? If it is the web installer, you could create a quality central bug report for the missing registry value. (Who knows what else is missing).
(0021384)
myarmor   
2016-08-23 01:42   
Oh? This was a surprise.. I installed Delphi with Windows 32/64 personalities using the web installer. No complaints from the program nor the platform and extensions manager, nor do any of them behaved erratically.

In the About box:
Product License Status: Registered
Professional

Maybe it still is a reason for a qc report, but I don't really know
what to report, considering everything seem to work as expected.

This is in the root of that registry key, which looks complete but
with a "Compatible=-1", "RegMergeLevel=0", and no Edition setting.
[HKEY_CURRENT_USER\Software\Embarcadero\BDS\18.0]
"App"="c:\\program files (x86)\\embarcadero\\studio\\18.0\\bin\\bds.exe"
"Compatible"="-1"
"InstallLanguage"="EN"
"LastUpdateTime"="8-14-2014 9|16|18"
"ProductVersion"="24"
"RegCompany"=""
"RegMergeLevel"=dword:00000000
"RegMergeTimeStamp"="9-8-2014 14|07|53"
"RegOwner"=""
"RootDir"="C:\\Program Files (x86)\\Embarcadero\\Studio\\18.0\\"
"ShowProjectOutputs"="False"
"UseSharedFiles"="TRUE"
(0021385)
myarmor   
2016-08-23 01:57   
I just added the missing Edition value, so I JVCL displays it as expected, although Delphi itself don't seem to care.
(0021386)
AHUser   
2016-08-23 16:34   
I changed the default in the installer to be empty instead of using a wrong edition.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6480 [JEDI VCL] 00 JVCL Components crash have not tried 2015-12-10 21:45 2016-08-23 00:23
Reporter: Kyle_Katarn Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Error: Runtime error 217 at 011789DA
Description: Following the following upgrade, one of my user get a Error: Runtime error 217 at 011789DA

JCL v2.4 -> v2.7
JVCL v3.39 -> v3.49

Cause confirmed : JxCL incompatible with Embedded edition of windows 8

http://www.wilderssecurity.com/threads/sumo-keep-your-software-up-to-date.314623/page-60#post-2547752
Tags:
Steps To Reproduce:
Additional Information: Duplicate from http://issuetracker.delphi-jedi.org/view.php?id=6477 as i don't know if it is JCL or JVCL that crashes.
Attached Files:
Notes
(0021262)
Kyle_Katarn   
2015-12-20 11:13   
up !
(0021273)
Kyle_Katarn   
2016-03-23 20:49   
Any chance to get this fixed or analysed ?
(0021290)
Kyle_Katarn   
2016-05-23 20:56   
Another occurence here : http://www.nsaneforums.com/topic/269294-sumo-4314317/?do=findComment&comment=1092498
(0021319)
AHUser   
2016-08-03 21:29   
It may be related to Mantis 0006489
http://issuetracker.delphi-jedi.org/view.php?id=6489

The code that is mentioned in 0006489 is only executed for Windows 8 and if a registry key doesn't exist or is not a valid integer.


Otherwise, there is not much the JCL/JVCL team can do here.
(0021320)
Kyle_Katarn   
2016-08-03 22:04   
Looks like you're right !
When is this supposed to be integrated in an official release so that i can test ?
(0021322)
AHUser   
2016-08-04 13:26   
Official versions are usually only released if there is a new Delphi version. And with EMBT switching back to a yearly release cycle, you may be better of using a daily snapshot, or merge the JclSysInfo changes into your code base by hand.
(0021323)
Kyle_Katarn   
2016-08-04 14:01   
So I can mix daily JCL / JVCL without expecting issues ?
(0021324)
AHUser   
2016-08-04 16:57   
The daily versions of JCL and JVCL shouldn't be too far away, but because the development speed is very slow at the moment there shouldn't be any incompatibilities between the two. But daily builds may be contain bugs if somebody is working on it and nobody tested the code yet.
(0021327)
Kyle_Katarn   
2016-08-04 19:24   
I've compiled SUMo again with these new daily build
Now waiting for user feedback :
http://www.wilderssecurity.com/threads/sumo-keep-your-software-up-to-date.314623/page-68#post-2607369
http://www.nsaneforums.com/topic/269294-sumo-4314317/?do=findComment&comment=1119139
(0021348)
AHUser   
2016-08-06 12:41   
What daily build did you use? The one made before I fixed the bug or did you use the git master branch?
(0021371)
Kyle_Katarn   
2016-08-07 16:55   
I'm using the one with
Result := StrToIntDef(Copy(Ver, 1, Pos('.', Ver) - 1), 2); // don't use StrBefore because it uses StrCaseMap that may not be initialized yet

Is that correct ?
Does anybody uses Win8.1 Embedded and could try my test build in order to confirm that this was the cause of the problem ?
(0021375)
AHUser   
2016-08-07 19:10   
That the correct one.

Nobody uses Win 8.1 Embedded, especially not at home.
(0021376)
Kyle_Katarn   
2016-08-07 23:12   
OK good news.

Regarding Win 8.1 Embedded @ Home, that also what i thought until 2 users reported the Error 217 regression :-(
(0021377)
Kyle_Katarn   
2016-08-07 23:12   
I'd suggest to close this issue + duplicates and i'll reopen a new ticket if still reported by users.
(0021378)
Kyle_Katarn   
2016-08-09 23:30   
@AHUser are you OK with my proposal ?

I've found one user with Windows Embedded. He should give me more feedback on the fix in a few days.
(0021382)
Kyle_Katarn   
2016-08-22 16:24   
No feedback from user so far. I propose to close this one and i'll reopen a new ticket if still reported by users.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6371 [JEDI VCL] General API minor always 2014-12-13 04:51 2016-08-07 16:19
Reporter: Michal Mucha Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Installation issues. Concerns all XE6 and XE7 compilers
Description: In my previous issue report (0006369) I indicated missing component in XE7 IDE.
Actually, as I found later there were more missing components
from 'Jv Persistence' tab on the components palette/list.
I did not check the other components tabs.
All the missing ones were registered in the same function call

RegisterComponents(RsPalettePersistence, [TJvFormStorage,
  TJvFormStorageSelectList, TJvAppXMLFileStorage]);

in the JvSystemReg.pas.
My conjecture was that something must be wrong or missing in project
files so the linker or component installer in the IDE does not "see"
the necessary files.
During the search found that all dproj files for XE6 (d20) and XE7 (d21)
packages have wrong paths in sections

    <PropertyGroup Condition="'$(Cfg_1)'!=''">
        <DCC_LocalDebugSymbols>false</DCC_LocalDebugSymbols>
        <DCC_Define>RELEASE;$(DCC_Define)</DCC_Define>
        <DCC_DebugInformation>0</DCC_DebugInformation>
        <DCC_UnitSearchPath>..\..\lib\d19\win32;$(DCC_UnitSearchPath)</DCC_UnitSearchPath>
        <DCC_DcpOutput>..\..\lib\d19\win32</DCC_DcpOutput>
        <DCC_DcuOutput>..\..\lib\d19\win32</DCC_DcuOutput>
        <DCC_Namespace>System;System.Win;WinApi;Vcl;Vcl.Imaging;Data;Data.Win;$(DCC_Namespace)</DCC_Namespace>
    </PropertyGroup>
    <PropertyGroup Condition="'$(Cfg_2)'!=''">
        <DCC_Define>DEBUG;$(DCC_Define)</DCC_Define>
        <DCC_SymbolReferenceInfo>2</DCC_SymbolReferenceInfo>
        <DCC_UnitSearchPath>..\..\lib\d19\win32\debug;$(DCC_UnitSearchPath)</DCC_UnitSearchPath>
        <DCC_DcpOutput>..\..\lib\d19\win32\debug</DCC_DcpOutput>
        <DCC_DcuOutput>..\..\lib\d19\win32\debug</DCC_DcuOutput>
        <DCC_Namespace>System;System.Win;WinApi;Vcl;Vcl.Imaging;Data;Data.Win;$(DCC_Namespace)</DCC_Namespace>
    </PropertyGroup>
Obviously, one would expect it to be \lib\d20 and \lib\d21 for XE6 and XE7 respectively.
I traced the problem to template.dproj files for these packages. Most probably the wrong
directories were propagated from templates to all other projects by the package generator
program (pg.exe) which uses the templates.

I am not sure if the JVCLInstall.exe makes use of the directories declared in the dproj files
since in my case all the dcu, bpi, dcp, lib files were in the ... \lib\d21\ ... directory.
But in case it does use the information in some place then the problem shoud be addressed
as soon as possible.

I did not manage to rerun the package generator, and the installation procedure yet, so
at the moment I cannot tell if this helped in case of components missing from the palette.

Anyway even if the path \lib\dxx information is irrelevant for the JVCLInstall
it would be a departure from the scheme adopted for earlier versions. I would appreciate
comments from maintainers.

Regards
Michal Mucha
Tags: Install
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021135)
Michal Mucha   
2014-12-13 18:29   
At the moment when I added this issue I could not select proper category.
I should go to JEDI JVCL Install.
(0021352)
AHUser   
2016-08-06 14:06   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6262 [JEDI VCL] 00 JVCL Components minor always 2014-03-05 16:08 2016-08-07 01:48
Reporter: leobruno Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TjvPageListTreeView & TjvStandardPage Enabled = False
Description: I have 4 nodes on a TjvPageListTreeView linked to 4 pages of a TjvStandardPage.

Let´s say that I need to block the access to the page linked to the nodeindex 1.

tv1.Items.Item[1].Enabled := false;

After the compilation the node apears in grey collor indicating that the node is disabled, but when clicking on it, the page linked to it is normally displayed.

Is it a bug or I should use a different aproach to block the page from beaind displayed ?
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0020932)
leo_burns   
2014-03-27 01:47   
I was able to solve my problem by implementing this code on the OnChanging Event of the TjvPageListTreeView:

procedure Tfrm1.tv1Changing(Sender: TObject; Node: TTreeNode;
  var AllowChange: Boolean);
begin
  AllowChange := Node.Enabled;
end;

But I really think that a disabled item on the TreeView, should make the Page linked to it unnavaiable.

If Jedi Project believes that this should not be implemented, I think that this example should be added to the demo projects.

Thanx ...
(0021027)
obones   
2014-09-03 11:34   
Please provide the zipped sources of a sample application showing this
(0021362)
AHUser   
2016-08-07 01:48   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6391 [JEDI VCL] 00 JVCL Components crash always 2015-03-18 06:26 2016-08-07 00:11
Reporter: lightrock Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvAviCapture - ALT key issue
Description: Delphi XE2 - I can consistently get the jvavicapture to crash/halt/hang a program simply by pressing the alt key. The camera does NOT have to be running or connected. Something about the windows proc, the fact that the component exists on the form at all. The compiled application, examples, run OUTSIDE of the debugging environment - MIGHT NOT - exhibit the issue. IT WILL in the debugger. Any application no matter how simple, form, button jvavicapture, no wiring up of anything just RUN - ALT key will hang it - for me, even run the .exe straight outside the debugger. Confused on how to try to fix it, tried a few things. Somehow the jvavicapture gets in front of everything.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021152)
lightrock   
2015-03-21 20:30   
Oh crap. It must be allergy season or something, today, the keypreview of the form is working right and I can block the ALT key from messing it up. Spooky. Maybe I have some crapware installed or something. Can anybody see the same exact thing ? Is it just me ? Anyway I think it was my fault, ... somehow.
(0021153)
lightrock   
2015-03-22 08:40   
jvavicapture.pas

customwndproc

I changed this line to look like this

    if (Msg <> WM_NCHITTEST) and (Msg <> WM_UPDATEUISTATE) then
      PostMessage(TWinControl(SelfObj).Handle, Msg, wParam, lParam);

It is happier now that is also skips the WM_UPDATEUISTATE

- This was also affecting the Delphi XE2 IDE, the fact that this is simply even a design time component appearing on a form... heaven forbid touch the Alt key...

Windows messages are not my forte, I get "good" at such things only if I have to. This is not good ( yet ). Just is, seems to work.
(0021154)
AHUser   
2015-03-22 13:52   
Wouldn't it be better to only post the messages to the SelfObj control that it is interested in (WM_SIZE, WM_SIZING, WM_MOVE, WM_MOVING, WM_WINDOWPOSCHANGING, WM_WINDOWPOSCHANGED) instead of posting all except those that are problematic and must be found by trail&error for every new Windows version?
(0021155)
lightrock   
2015-03-22 15:55   
@AHUser: I don't know if you are "right" but you are certainly not wrong.
         Works just as well and like you were saying might be smarter

    // try it this way
    // if ( Msg in [... WM_SIZING, ... ] )
    // generates "constant expression violates subrange bounds"
    // therefore:
    // ----------------------------------------------------------
    case Msg of
      WM_SIZE, WM_SIZING, WM_MOVE, WM_MOVING, WM_WINDOWPOSCHANGING, WM_WINDOWPOSCHANGED:
      PostMessage(TWinControl(SelfObj).Handle, Msg, wParam, lParam);
    end;
(0021184)
obones   
2015-09-14 11:12   
Well, when I first wrote that component, I did something similar, but there are heaps of (undocumented) messages that get sent when sizing or moving a window.
As a result, I did not want to filter them out just in case they were needed.
(0021361)
AHUser   
2016-08-07 00:11   
Fixed in master branch.

By changing the control handle creation to not create a child capture window but to *be* the capture window, the whole PostMessage and MoveWindow code isn't necessary anymore.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6444 [JEDI VCL] General API major always 2015-09-17 23:29 2016-08-06 13:44
Reporter: rbwinst Platform:  
Assigned To: ChristianWimmer OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JvToolEdit won't compile on Rad Studio XE2
Description: when installing JVCL from the installer without JVCL Themes, JvToolEdit won't compile on Rad Studio XE2.
Tags:
Steps To Reproduce:
Additional Information: I was able to get around this by the following
JvtoolEdit
Line 1476 change
  {$IFDEF COMPILER16_UP}
to
  {$IFDEF HAS_UNIT_VCL_THEMES}

Line 1479 change
  {$ENDIF COMPILER16_UP}
to
  {$ENDIF HAS_UNIT_VCL_THEMES}

Line 1557 change
          {$IFDEF COMPILER16_UP}
to

Line 1564 change
          {$ENDIF COMPILER16_UP}
to
          {$ENDIF HAS_UNIT_VCL_THEMES}

Line 1573 change
        {$IFDEF COMPILER16_UP}
to
        {$IFDEF HAS_UNIT_VCL_THEMES}

Line 1580, change
        {$ENDIF COMPILER16_UP}
to
        {$ENDIF HAS_UNIT_VCL_THEMES}
Attached Files:
Notes
(0021340)
AHUser   
2016-08-06 00:03   
Fixed.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6509 [JEDI VCL] General API block always 2016-04-25 15:14 2016-08-06 13:42
Reporter: acgubamg Platform: Microsoft  
Assigned To: AHUser OS: Windows  
Priority: normal OS Version: 10  
Status: resolved Product Version:  
Product Build: 0 Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: procedure TJvDBComboEdit.DataChange(Sender: TObject);
Description: Rad Studio XE2

On procedure below:

in line:

if (FDataLink.Field.DataType = ftString) and (MaxLength = 0) then

I think that correct is: with "ftWideString"

      if (FDataLink.Field.DataType in [ftString, ftWideString]) and (MaxLength = 0) then
**********************************************************************
---- See the procedure from last buil 2016-04-25 08:32:42 UTC

procedure TJvDBComboEdit.DataChange(Sender: TObject);
begin
  if FDataLink.Field <> nil then
  begin
    if Alignment <> FDataLink.Field.Alignment then
    begin
      EditText := ''; {forces update}
      Alignment := FDataLink.Field.Alignment;
    end;
    EditMask := FDataLink.Field.EditMask;
    if not (csDesigning in ComponentState) then
      if (FDataLink.Field.DataType = ftString) and (MaxLength = 0) then
        MaxLength := FDataLink.Field.Size;
    if FFocused and FDataLink.CanModify then
      Text := FDataLink.Field.Text
    else
    begin
      EditText := FDataLink.Field.DisplayText;
      {if FDataLink.Editing then Modified := True;}
    end;
  end
  else
  begin
    Alignment := taLeftJustify;
    EditMask := '';
    if csDesigning in ComponentState then
      EditText := Name
    else
      EditText := '';
  end;
end;
Tags:
Steps To Reproduce: see source code
Additional Information:
System Description
Attached Files:
Notes
(0021349)
AHUser   
2016-08-06 13:41   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6266 [JEDI VCL] 00 JVCL Components block always 2014-03-14 09:08 2016-08-06 00:56
Reporter: altaveron Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: MouseDownEvent doesn't work any more
Description: The new condition 'not InheritedCalled' on the following code blocks OnMouseDown event. The issue is critical.

      if Assigned(MouseDownEvent) and not InheritedCalled then
        MouseDownEvent(Self, Button, Shift, X, Y);
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021025)
obones   
2014-09-03 11:34   
Please provide the zipped sources of a sample application showing this
(0021346)
AHUser   
2016-08-06 00:56   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6456 [JEDI VCL] 00 JVCL Components major always 2015-10-07 01:14 2016-08-05 22:31
Reporter: leobruno Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TjvStandardPage / TjvPagelistTreeview BUGs
Description: The pagelist edit box on TjvStandardPage are not working propperly.
After adding a page, the edit box cannot be closed, unless closing delphi IDE.

Also, the add, remove buttons are not working.

After creating between TjvPagelistTreeview and TjvStandardPage, if a new page or new treeview node is added, the previous list is lost.

This is very annoying when a large number of links nodes were previously created because you have to do it all again.

Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021236)
AHUser   
2015-10-07 12:25   
(Last edited: 2015-10-07 12:25)
The JvPageList page editor bug is now fixed.

I can't reproduce your TJvPagelistTreeview bug. The page links don't vanish for me.

(0021237)
leobruno   
2015-10-07 13:26   
To reproduce the bug reported:

1 - Create about 6 items at tree view and 5 pages.
2 - Create the links between the first 5 treeview nodes and the 5 pages.
3 - Edit the treeview nodes removing the last one.
4 - enter the links editor and the nodes will not be linked anymore.
(0021238)
AHUser   
2015-10-07 15:16   
I now can reproduce this. Unfortunately this is a problem in the IDE's TreeView NodeEditor that we can't change.
It copies the TJvPageIndexNode into a TTreeNode loosing the assigned PageIndex. And if you press "OK" it copies the TTreeNode back to the TJvPageIndexNode.

I see no way without "hacking" the IDE to fix this. A workaround would be to add the nodes by code instead of the visual designer.
(0021239)
leobruno   
2015-10-08 02:10   
I assume that the buttons that should change the position of the nodes will also impossible to fix.

Is that right ?

This is very anoying as well.
(0021240)
AHUser   
2015-10-08 15:18   
The whole TreeNodes Editor is the problem. The moment you click the "OK" button, all information is lost. The only solution would be to write an own TreeNodes Editor for TJvPagelistTreeView.
(0021269)
leobruno   
2016-01-25 13:43   
This issue simply makes the use of this component impossible.
I´ll seek for the information needed to acomplish this task.
I have little knoledge on component writing, but creating my own design time editor is a thing that I don´t know how to do.
(0021270)
leobruno   
2016-01-25 13:45   
We have this component with more than 50 nodes on the tree view.
Every time a new page is added we have to link the pages wth the nodes all over again.

Sucks ...

rsrsrs
(0021336)
AHUser   
2016-08-05 22:31   
Fixed in master branch.

The component now uses an own JVCL property editor for the nodes that doesn't deletes the PageList links.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6492 [JEDI VCL] 02 Installation trivial always 2016-01-22 15:22 2016-08-05 20:56
Reporter: Xerkar Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: JVCL can not be installed
Description: ich wollte JediLib und unsere Software unter Delphi 10 Seattle testen.
But I can not install JVCL. JCL can be installed without any problems. Every time I try to install I get JVCL following message:
C:\ew\fremdkomponenten\Jedi\jvcl\run\JvInterpreter_all.pas(60) Schwerwiegend: F2613 Unit 'JvInterpreter_DBTables' not found.

Since this is my second attempt I had in between BDE installed and uninstalled again this could so hang together?
Tags:
Steps To Reproduce:
Additional Information: [Compiling: JvPascalInterpreter230.bpl]
Embarcadero Delphi for Win32 compiler version 30.0
Copyright (c) 1983,2015 Embarcadero Technologies, Inc.

C:\ew\fremdkomponenten\Jedi\jvcl\run\JvInterpreter_all.pas(60) Schwerwiegend: F2613 Unit 'JvInterpreter_DBTables' nicht gefunden.
Attached Files: logs.txt (14,028 bytes) 2016-01-22 15:22
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002648&type=bug
Notes
(0021271)
Xerkar   
2016-01-27 11:02   
I could solve the problem. I have uninstalled everything (Delphi + all components), then I adjusted the Registrie and semptliche bpls and all units away from the system. Then I newly installed Delphi 10 Seattle and could insatall JCL + JVCL.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6241 [JEDI VCL] Donation crash always 2013-12-23 16:27 2016-08-04 21:18
Reporter: CubicDesign Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Version 2.4  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Range check error in JvPaintFX.pas
Description: There is a problem with the code donated by Jan (JvPaintFX.pas).
In the original code there was a {$R-} directive.
After the code was donated somebody removed that directive and now 'procedure Stretch' fails with a 'Range check error'.
That {$R-} was supposed to be there. The code is pre-Delphi 4 and it uses some some nasty trick to get the job done. This article (see post by Rob Kenedy) explains why the $R- must be there!!! http://stackoverflow.com/questions/628965/delphi-accessing-data-from-dynamic-array-that-is-populated-from-an-untyped-poi

Tags:
Steps To Reproduce:
Additional Information: The code is really really bad. Needs massive improvement.
Things like this:

 TCListList = array[0..0] of TCList;
 PCListList = ^TCListList;

must be replaced with 'normal' arrays. This will make the nasty GemMem go away and SetLength will be used instead.

Also, things like this can be improved for speed:

       RGB.R := 0;
       RGB.G := 0;
       RGB.B := 0;

___________________


Attached Files:
Notes
(0021031)
obones   
2014-09-03 11:37   
Please provide the zipped sources of a sample application showing this
(0021220)
AHUser   
2015-09-27 16:42   
The $R- is in the jedi.inc, so it is still there.
(0021225)
CubicDesign   
2015-09-28 11:29   
I did a search for '$R' in jedi.inc but cannot find it
(0021226)
CubicDesign   
2015-09-28 11:29   
Is this the file?

\jcl\source\include\jedi\jedi.inc
(0021227)
CubicDesign   
2015-09-28 11:34   
Sorry... found it as: {$IFOPT R+} {$DEFINE RANGECHECKS_ON} {$ENDIF}
(0021228)
CubicDesign   
2015-09-28 11:38   
This means that Jedi library was never ran with $R+ ? $R+ helps the programmer discover bugs. But in this case, if you activate RangeChecking, then the code in JvPaintFX will fail. RangeChecking need to be locally disabled in that file, as it was in the original JanFX file.
(0021229)
AHUser   
2015-09-28 15:29   
It's in the jvcl.inc the line "{$A+,B-,C+,D+,E-,F-,G+,H+,I+,J-,K-,L+,M-,N+,O+,P+,Q-,R-,S-,T-,U-,V+,W-,X+,Y+,Z1}"

The JVCL never used $R+. Sure it would be nice to check for range errors but enabling it for the JVCL would require a lot of code to be changed and there aren't enough developers left for this.
(0021334)
AHUser   
2016-08-04 21:18   
Fixed in master branch


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6502 [JEDI VCL] 00 JVCL Components tweak N/A 2016-03-25 17:32 2016-08-04 21:05
Reporter: CDametto Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Request to make TJvDBGrid.DrawThemedHighlighting a virtual method
Description: I would need TJvDBGrid.DrawThemedHighlighting declared virtual because
I would use the style thHeaderItemHot instead of tmPopupItemHot that is too light.
Thank you
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021332)
AHUser   
2016-08-04 21:05   
Added "virtual" to master branch


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6505 [JEDI VCL] 00 JVCL Components feature N/A 2016-03-31 15:12 2016-08-04 21:00
Reporter: fschenckel Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Update for TjvCharMap
Description: I've slightly enhanced the TjvCharmap component. This can be of interest for other people.

I've added the following properties:

- ShowASCIISymboles
     Shows the ASCII symboles instead of the char iself (NUL, SOH, STX etc...) for the char range 0..31
- ShowASCIISymbolsDescription
     Shows an associated description in the zoom panel.
- AutoHidePanel
     Zoom panel was not automatically hidden when component loses the focus. This property hides it automatically when focus is lost.
Tags:
Steps To Reproduce:
Additional Information: I have uploaded the following files:

The modified jvCharmap.pas unit.
An sample project using the new properties.
A picture of the sample project in action
Attached Files: CharMap.png (42,019 bytes) 2016-03-31 15:12
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002653&type=bug
CharMap.zip (8,671 bytes) 2016-03-31 15:12
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002654&type=bug
JvCharMap.pas (49,729 bytes) 2016-03-31 15:13
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002655&type=bug
JvCharMap_New.pas (52,502 bytes) 2016-04-01 11:48
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002656&type=bug
CharMap_New.zip (21,568 bytes) 2016-04-01 11:48
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002657&type=bug
JvCharMap_New2.pas (52,631 bytes) 2016-04-04 10:21
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002660&type=bug
Notes
(0021278)
fschenckel   
2016-04-01 11:51   
Further changes by adding a custom range where it's possible to define our own range but also decide what will be displayed for this range.

jvCharmap.pas and sample project updated.
Sorry I couldn't delete the old one, so the last ones has the _New suffix.
(0021281)
fschenckel   
2016-04-04 10:21   
Sorry for thes iteration, but I found a bug when displaying customRange ==> last char was missing.

jvCharmap_New2 is the newest file...
(0021331)
AHUser   
2016-08-04 21:00   
Added to master branch.

https://github.com/project-jedi/jvcl/commit/6a212f390d1784f43e397605dc71f4508fadef9b


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6510 [JEDI VCL] 00 JVCL Components minor always 2016-04-28 17:02 2016-08-04 20:55
Reporter: CDametto Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: The selected item appearance in lookup list of TJvDBLookupCombo is not themed
Description: See attached screenshot obtained by setting the theme Amethyst Kamry in Project->Options->Application->Appearance->Default style
Tags:
Steps To Reproduce:
Additional Information: I solved adding few lines in procedure TJvDBLookupList.Paint of file JvDBLookup.pas
See attachments
Attached Files: CorrectAspect.jpg (111,776 bytes) 2016-04-28 17:02
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002662&type=bug
Patch.txt (5,141 bytes) 2016-04-28 17:03
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002663&type=bug
Notes
(0021330)
AHUser   
2016-08-04 20:55   
Added to master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6520 [JEDI VCL] 02 Installation minor have not tried 2016-08-04 19:14 2016-08-04 20:41
Reporter: Kyle_Katarn Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Installer crashes due to CSIDL_COMMON_DOCUMENTS not defined
Description: Installer crashes due to CSIDL_COMMON_DOCUMENTS not defined

Line :
    if not SHGetSpecialFolderPath(0, Buffer, CSIDL_COMMON_DOCUMENTS, False) then

in Doc32FileAgePatch

Vista, Delphi 7

Manually replacing by $002E fixes the issue.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021329)
AHUser   
2016-08-04 20:41   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6474 [JEDI VCL] 00 JVCL Components major always 2015-11-30 17:08 2016-08-04 19:37
Reporter: RalfNegt Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvDBGrid OnMouseDown won't be called
Description: Actually i cannot start a drag action with an OnMouseDown event handler.

Have a look at the method "TJvDBGrid.MouseDown" below and
especially the flag "InheritedCalled".
There are three conditions setting the flag.
The event OnMouseDown will only be called if the flag isn't set.

When i assign an event handler i want it to be called.
But here the component itself decides whether or not to do so.
Please remove the flag "InheritedCalled".
By the way the variable "MouseDownEvent" is unnecessary.
It can be replace by "OnMouseDown".

procedure TJvDBGrid.MouseDown(Button: TMouseButton; Shift: TShiftState; X, Y: Integer);
var
  ...
  MouseDownEvent: TMouseEvent;
  ...
  InheritedCalled: Boolean;
begin
  ...
      InheritedCalled := False;
  ...
          if dgIndicator in Options then
          begin
            inherited MouseDown(Button, Shift, 1, Y);
            InheritedCalled := True;
          end
  ...
            if (dgRowSelect in Options) and (Cell.Y >= TitleOffset) then
            begin
              // Why do we always have to work around the VCL. If we use the original X the
              // Grid will scroll back to the first column. But if we don't use the original X
              // and goRowSizing is enabled, the user can start resizing rows in the wild.
              WasRowResizing := goRowSizing in TCustomGridAccess(Self).Options;
              try
                // Disable goRowSizing without all the code that SetOptions executes.
                TGridOptions(Pointer(@TCustomGridAccess(Self).Options)^) := TCustomGridAccess(Self).Options - [goRowSizing];
                inherited MouseDown(Button, Shift, 1, Y);
                InheritedCalled := True;
              finally
                if WasRowResizing then
                  TGridOptions(Pointer(@TCustomGridAccess(Self).Options)^) := TCustomGridAccess(Self).Options + [goRowSizing];
              end;
            end
            else
            begin
              inherited MouseDown(Button, Shift, X, Y);
              InheritedCalled := True;
            end;
  ...
      MouseDownEvent := OnMouseDown;
      if Assigned(MouseDownEvent) and not InheritedCalled then
        MouseDownEvent(Self, Button, Shift, X, Y);
  ...
end;
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: DBGridOnMouseDownFailure.zip (1,702 bytes) 2016-04-12 11:03
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002661&type=bug
Notes
(0021283)
dougwoodrow   
2016-04-11 11:37   
This appears to have been introduced by an attempt to fix a situation with OnMouseDown being called twice.

see commit by obones Dec 16 2013 "Mantis 5915: Do not call OnMouseDown twice"

https://github.com/project-jedi/jvcl/commit/b6b42daa3350c35ccf0040bd8201c40edd58d28b
(0021284)
dougwoodrow   
2016-04-11 12:09   
This bug results in the OnMouseDown event not being called when the mouse is over a data record, it is called when the mouse is over the title buttons or outside the data records.
(0021285)
dougwoodrow   
2016-04-12 11:07   
I've attached a sample Delphi 7 application (copied from Mantis 5915) to demonstrate the problem.

Note that with RalfNegt's proposed solution the TJvUltimGrid still has problems, but TJvDBGrid seems ok.

http://issuetracker.delphi-jedi.org/view.php?id=5915
(0021286)
dougwoodrow   
2016-04-12 11:30   
(Sorry, please remove mad* from Project1.dpr).

Note also this problem is still present in JVCL version 3.49.
(0021328)
AHUser   
2016-08-04 19:37   
Fixed in master branch.

OnMouseDown is now called even if there was a call to "inherited MouseDown" that didn't call "TControl.MouseDown".

I also added a OnBeforeMouseDown and OnAfterMouseDown event, so you also get notified if the user clicks on a header cell.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6514 [JEDI VCL] 00 JVCL Components minor always 2016-05-26 11:04 2016-08-04 17:59
Reporter: kqha Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: Change TJvRichEdit.Alignment at runtime does not work
Description: The summary pretty much describe the bug. To reproduce it, one can follow:
1. Put a TJvRichEditand a simple button on a form.
2. The onclick event of the button set to JvRichEdit1.Alignment := taRightJustify; (as the default is taLeftJustify)
3. Run the project
4. Type something into the richedit
5. Click the button, and the alignment wont change unlike any other memo/edit components do
Tags:
Steps To Reproduce:
Additional Information: Borland Delphi XE7
JVCL 3.48
Windows 10
Attached Files:
Notes
(0021326)
AHUser   
2016-08-04 17:59   
The RichEdit.Alignment is only used by the RichEdit Windows control for the initial alignment. If you want to change the alignment of the current paragraph, you have to use

    JvRichEdit1.Paragraph.Alignment := paRightJustify;


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6484 [JEDI VCL] 00 JVCL Components minor always 2016-01-04 13:59 2016-08-04 17:45
Reporter: lloydbates Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvFilenameEdit, paint issue when disabled and placed on JvWizard page
Description: # Delphi XE
# JVCL 3.49 (Git)

When placing a TJvFielnameEdit on a TJvWizard page, it will be painted incorrectly when said edit is disabled.

To reproduce:

# create a new VCL Forms Application
# add a TJvWizard, create two Interior Pages
# on page 1, add a TEdit at 0, 0 (Left, Top)
# on page 2, add a TJvFilenameEdit at 5, 5 (Left, Top)
# set Enabled to False for the TJvFilenameEdit
# compile and run the application

When switching between page 1 and page 2, the background of the TJvFilenameEdit is incorrectly drawn.

The error was introduced in Git commit 65884f6cb031e98bb2b60101d35180bff9c7b289 ( https://github.com/project-jedi/jvcl/commit/65884f6cb031e98bb2b60101d35180bff9c7b289 ) in TJvCustomComboEdit.DoEraseBackground at line 2252.

The checking for DisabledColor to be clNone, clDefault or clWindow if the component is not enabled is the culprit.

The intention behind this change was the for XE2 and up to support custom styles, but it broke the drawing of disabled, SystemStyle on a TJvWizard page.

Even after removing the check for DisabledColor, the behaviour of Delphi XE and Delphi 10 Seattle were the same and in 10 Seattle with VCL styles it was as expected.

Proposed fix:

Remove the check for DisabledColor at line 2522
Tags:
Steps To Reproduce:
Additional Information: Attached a Short, Self Contained, Correct (Compilable), Example.
Attached Files: SSCCE.zip (86,255 bytes) 2016-01-04 13:59
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002645&type=bug
Notes
(0021287)
akalwa   
2016-04-19 20:29   
Also affected: TJvComboEdit (and probably all other components derived from TJvCustomComboEdit) on a plain TPageControl/TTabSheet: If the edit component is disabled, it does not paint correctly.
(0021325)
AHUser   
2016-08-04 17:45   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6513 [JEDI VCL] 02 Installation major always 2016-05-17 23:51 2016-08-03 21:25
Reporter: Xavi Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version:  
    Target Version:  
Summary: unable to install into delphi 10.1 berlin
Description: I can't install jcl/jvcl in Delphi 10.1 Berlin, due to an unsupported delphi version. when we will be able to download the supported version?
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021293)
thomasvoelker   
2016-06-14 17:36   
Managed to install JCL 2.7.0.5676 on Delphi Berlin 10.1 with the following changes:

source\windows\JclICL.pas: Compile error @ line 674, incompatible types. Changed DumpIL(Options: ... to DumpIL(Options_: ... at line 200, 619 and 674.

source\common\JclIDEUtils.pas:
changed line 89 to: SupportedDelphiVersions = [5, 6, 7, 8, 9, 10, 11, 12, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24];

changed line 943 to: Supported: True),
added @ line 944:
    (
      Name: @RsRSName;
      VersionStr: '10.1';
      DCCVersion: 31.0;
      IDEPkgVersion: 24;
      PkgVersion: 24;
      CoreIdeVersion: '240';
      Supported: True)

source\install\JclIDEUtils.pas:
changed line 3300 to: or (Target.VersionNumber in [3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 14, 15, 16, 17, 18]);

then I copied:
packages\d23 ==> packages\d24 (directory)
JclPackagesD230.groupproj ==> JclPackagesD240.groupproj (file, still referenced d23-contents, so first step might not be necessary)
lib/d23 ==> lib/d24

After that the installer complained that bcc32.exe could not be found - which is right because I only have delphi. the installer itself issued in the log, it also had found c++ builder 32bit. So I took a look on the detection routines and found that HKLM\Software\WOW6432Node\Embarcadero\BDS\18.0\Personalities also listet BCB and also HKCU\Software\Embarcadero\BDS\18.0\Personalities did. I deleted both Keys and the installation succeeded.
(0021295)
GroePaZ   
2016-06-24 17:44   
Hi Thomas,
I can install JCL now with your help, but not the JVCL. Can you or anybody send me the changes on the files for JVCL?
(0021296)
GroePaZ   
2016-06-24 18:09   
Problem is, that JVCLInstaller does'nt recognizes Delphi 10.1. Berlin, only XE7 and older. Compiling JVCLInstaller fails because missing Jedi\Jedi.inc and further errors.
(0021297)
GroePaZ   
2016-06-25 13:52   
I have now changed JVCLInstaller to recognize Delphi 10.1. Berlin, but compiling JVCore ends immediately with errors (JVCore must recompile,...).
Compiling project JVCore about Delphi end with syntax errors :-(
Any ideas?
(0021318)
AHUser   
2016-08-03 21:25   
JCL 2.7.0.5676 is from 2015. No wonder it doesn't know a Delphi version from 2016.

Current JCL source:
https://github.com/project-jedi/jcl

Current JVCL source:
https://github.com/project-jedi/jvcl


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6436 [JEDI VCL] JclGraphics crash always 2015-09-08 09:47 2016-08-03 20:23
Reporter: CubicDesign Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Version 2.5 (Subversion repository/Daily zips)  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Crash in JvPaintFX.pas
Description: The person that added JanFX library to JEDI removed a {$R-} directive without really understanding what it is doing.
Without this directive the code crashes.
Tags: bug, janfx, JvPaintFX, resampler, stretch
Steps To Reproduce:
Additional Information: The problem is

class procedure TJvPaintFX.Stretch(Src, Dst: TBitmap; Filter: TFilterProc; AWidth: Single);
begin
...
    GetMem(Contrib, DstWidth * SizeOf(TCList));
    // Horizontal sub-sampling
    // Scales from bigger to smaller Width
    {$R-} <------------------ THIS WAS REMOVED!!!!!
    if (xscale < 1.0) then
...
end;


This will explain why that range check should be disabled:
http://stackoverflow.com/questions/628965/delphi-accessing-data-from-dynamic-array-that-is-populated-from-an-untyped-poi
Attached Files:
Notes
(0021206)
CubicDesign   
2015-09-14 21:21   
To reproduce it, simply call TJvPaintFX.Stretch.
It is amazing that nobody reported this until now.
(0021307)
AHUser   
2016-08-02 19:23   
All JVCL files are compiled with $R- (first compiler directive in jvcl.inc). So I don't see how that code could be compiled with $R+ unless you copy that part into your own unit.
(0021309)
CubicDesign   
2016-08-02 20:00   
> are compiled with $R-
That is BAAAAD! During debugging and testing Range Checking should ALWAYS be on.


> unless you copy that part into your own unit
Yes. This is what I do (and I know for sure at least 3 friends that are doing the same). I don't like having the whole Jedi installed because it is too big, so I only use what I need from it.
Any person that will use ONLY that piece of code will have the same problem.


If in the future Jedi will (hopefully) change the R- to R+ that code will fail also in Jedi. So, why deleting that single line of code if it does NO harm when it is there and LOT of harm when is removed?
(0021316)
AHUser   
2016-08-03 17:23   
My guess it that the person who integrated TJvPaintFX thought that due to the global $R- that it isn't necessary.


I found some more "array[0..0] of T" type declaration in the JCL/JVCL. The Delphi RTL changed them years ago to "array[0..MaxInt div SizeOf(T) - 1] of T". That's what I'm going to do to fix this.



BTW: Why is TJvPaintFX a component anyway, it should be moved to the JCL and made an abstract class. But I guess it is a bit too late for that, especially with nobody actively working on the JCL/JVCL.
(0021317)
AHUser   
2016-08-03 20:23   
Fixed in master branch.

I also moved the JvResample.pas to \archive because all its code is a copy of JvPaintFX (with some style guide changes).


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5909 [JEDI VCL] 00 JVCL Components minor always 2012-06-14 14:00 2016-04-01 19:19
Reporter: Arioch Platform:  
Assigned To: OS:  
Priority: normal OS Version:  
Status: acknowledged Product Version: Daily / GIT  
Product Build: Resolution: open  
Projection: none      
ETA: none Fixed in Version:  
    Target Version: Daily / GIT  
Summary: RegExpr-validator is broken
Description: D:\DelphiProjects\Libs\JediVCL\jvcl\run\JvValidators.pas

However introduced/copied/commited the change quoted below replaced RegExpr search with DOS file mask search.

JvValidators demo is broken, but of course, who runs demo and who would use RegExpr anyway :-)

The change below should be undone. It gets a bit beyond mere simplification
Tags:
Steps To Reproduce:
Additional Information:  589 7454 15.06.2004 9:39:36 marquardt //=== { TJvRegularExpressionValidator } ======================================
   590 2083 22.06.2003 14:09:41 peter3
   591 11893 10.09.2008 0:45:14 obones function MatchesMask(const Filename, Mask: string{;
   592 11893 10.09.2008 0:45:14 obones const SearchFlags: TSearchFlags = [sfCaseSensitive]}): Boolean;
   593 6489 19.04.2004 3:55:47 ahuser {var
   594 2083 22.06.2003 14:09:41 peter3 URE: TURESearch;
   595 6489 19.04.2004 3:55:47 ahuser SL: TWideStringList;}
   596 2083 22.06.2003 14:09:41 peter3 begin
   597 6448 16.04.2004 21:28:30 peter3 Result := Masks.MatchesMask(Filename, Mask);
   598 6448 16.04.2004 21:28:30 peter3 (*
   599 2083 22.06.2003 14:09:41 peter3 // use the regexp engine in JclUnicode
   600 2083 22.06.2003 14:09:41 peter3 SL := TWideStringList.Create;
   601 2083 22.06.2003 14:09:41 peter3 try
   602 2083 22.06.2003 14:09:41 peter3 URE := TURESearch.Create(SL);
   603 2083 22.06.2003 14:09:41 peter3 try
   604 2083 22.06.2003 14:09:41 peter3 URE.FindPrepare(Mask, SearchFlags);
   605 2083 22.06.2003 14:09:41 peter3 // this could be overkill for long strings and many matches,
   606 2083 22.06.2003 14:09:41 peter3 // but it's a lot simpler than calling FindFirst...
   607 2083 22.06.2003 14:09:41 peter3 Result := URE.FindAll(Filename);
   608 2083 22.06.2003 14:09:41 peter3 finally
   609 2083 22.06.2003 14:09:41 peter3 URE.Free;
   610 2083 22.06.2003 14:09:41 peter3 end;
   611 2083 22.06.2003 14:09:41 peter3 finally
   612 2083 22.06.2003 14:09:41 peter3 SL.Free;
   613 2083 22.06.2003 14:09:41 peter3 end;
   614 6448 16.04.2004 21:28:30 peter3 *)
   615 2083 22.06.2003 14:09:41 peter3 end;
Attached Files: JvValidators.pas.patch (1,030 bytes) 2016-04-01 19:17
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002658&type=bug
Notes
(0021279)
wprins   
2016-04-01 18:12   
Still present as of this writing 2016-04-01. (Wasted time today trying to use a regular expression validator for the first time. Why is this component not disabled until it's fixed?)
(0021280)
wprins   
2016-04-01 19:19   
Uploaded simple fix with JclPCRE.TJclAnsiRegEx, which fixes the component for my use case. Probably needs more testing/review.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6499 [JEDI VCL] 00 JVCL Components major always 2016-03-11 10:34 2016-03-11 15:55
Reporter: fschenckel Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: jvGnuGetText does not work in 64bit with runtime packages
Description: By calling HookIntoResourceStrings(True, True) we get an C00000005 Access violation exception.

Error happens in unit jvGnuGetText, procedure THook.Reset, line 3089:
    patchPosition := pansiChar(Pointer(pointer(patchPosition)^)^);

Offset calculation is the same between win32 and win64 and I think this is wrong, but I'm not much aware in ASM, so I'm not of a big help... Sorry !
Tags:
Steps To Reproduce:
Additional Information: It works as expected in Win32
Attached Files:
There are no notes attached to this issue.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6476 [JEDI VCL] 02 Installation major always 2015-12-08 05:50 2015-12-12 14:31
Reporter: Steve009 Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Unable to compile with XP Theming enabled
Description: Hello support,

IDE/Compiler: Borland C++ Builder 6, running under Windows 7 Ultimate x64

Installed JCL version: Release 2.5 Build 4572
Installing JVCL version: 3.49.0.0
Both the above are from JCL/JVCL Official Release installation file: JVCL349CompleteJCL27-Build5676.zip at: http://sourceforge.net/projects/jvcl/files/JVCL%203/JVCL%203.49/

I'm getting a compile error when running the JVCL installer with the XP Theming enabled.
The errors are in module: JvThemes.pas(1493)
Undeclared Identifier: TThemeSize'
Undeclared identifier: TS_MIN'
Undeclared identifier: TS_DRAW
Undeclared identifier: 'GetThemePartSize'
See attached image of the actual installer output screen.

With XP Theming disabled the compile/link/component install is perfect.

I have XP theming enabled in a much older, 2008, version of JEDI. So I would be very appreciative if you could point me in the right direction in order to get up to date.

As I'm compiling with BCB 6, I have successfully followed Carmelo Viavattene's instructions to produce the DCP files.

But the instruction to:
"Open jvcl.inc with a text editor and remove the dot in {.$DEFINE JVCLThemesEnabled} before building the jvcl packages"
cannot be done because {.$DEFINE JVCLThemesEnabled} doesn't exist in jvcl.inc. The only reference to this define is on line 319:
{$IFDEF COMPILER7_UP}
 {$DEFINE JVCLThemesEnabled}

So I ignored this instruction.

Thank you.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: JVCL Install Log.PNG (24,225 bytes) 2015-12-08 05:50
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002643&type=bug
Notes
(0021256)
AHUser   
2015-12-12 14:31   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6457 [JEDI VCL] 00 JVCL Components major always 2015-10-07 16:52 2015-12-12 13:24
Reporter: jkelley Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvSpinEdit handles minus sign incorrectly
Description: If a TJvSpinEdit has a positive MinValue set, then pressing the minus sign causes the value to change to negative MinValue.

This is apparently a regression introduced by http://issuetracker.delphi-jedi.org/view.php?id=4572; in that bug, trying to type a negative number resulted in the number being temporarily "-0", so it was reset to 0. The fix involved explicitly tracking the minus sign outside of the current value, but that fix means that trying to type a negative value can result in the minus sign being applied to the (positive) minimum value.
Tags:
Steps To Reproduce:
Additional Information: To demonstrate, run the sample project, set the cursor to the beginning of the spin edit, and press '-'. The minimum value should be 0.5, but the value shown is -0.5.
Attached Files: JvSpinEditBug.zip (79,233 bytes) 2015-10-07 16:52
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002637&type=bug
Notes
(0021255)
AHUser   
2015-12-12 13:24   
Fix in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6473 [JEDI VCL] 00 JVCL Components block have not tried 2015-11-28 16:48 2015-12-12 13:00
Reporter: Kyle_Katarn Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.48  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvCPUUsage no longer in JVCL !
Description: After installing 3.49, Delphi 6 is no longer finding JvCPUUsage.dcu

PS : in Mantis product version, "3.49" is not listed in the dropdown "Product version"
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021245)
Kyle_Katarn   
2015-11-28 23:22   
My mistake, in fact "%PATH%\jvcl\run" had to be added to the libraries paths (not automatic)
(0021246)
Kyle_Katarn   
2015-12-09 09:20   
To be closed or modified in order to fix the installer to complete the lib path
(0021254)
AHUser   
2015-12-12 13:00   
Fixed in master branch.

JvCpuUsage is now part of the JvCmp package.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6464 [JEDI VCL] 00 JVCL Components feature always 2015-10-23 17:07 2015-12-10 22:09
Reporter: bullock Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Patch to customize Hint of the JvOutlookBar to whichever TAction the mouse is over
Description: This modifies jvcl/run/JvOutlookBar.pas to show a custom hint over the JvOutlookBar, depending on which TAction therein the mouse is moving over.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: 0001-Show-a-custom-hint-over-the-JvOutlookBar-depending-o.patch (1,456 bytes) 2015-10-23 17:07
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002639&type=bug
Notes
(0021253)
AHUser   
2015-12-10 22:09   
Added to master branch.

The code uses CM_HINTSHOW instead of playing with the Hint property.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6470 [JEDI VCL] 00 JVCL Components major always 2015-11-19 10:07 2015-12-10 20:57
Reporter: cadsky Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.00  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: TJvLinkLabel Out of system resources
Description: When set MarginHeight then error occurs Out of system resources.
Tags:
Steps To Reproduce:
Additional Information: procedure TForm16.FormCreate(Sender: TObject);
var
  JvLinkLabel: TJvLinkLabel;
begin
  Height := 200;
  JvLinkLabel := TJvLinkLabel.Create(self);
  JvLinkLabel.Parent := self;
  JvLinkLabel.Align := alClient;
  JvLinkLabel.MarginHeight := 100;
end;
Attached Files:
Notes
(0021251)
AHUser   
2015-12-10 20:57   
Fixed in master branch


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6478 [JEDI VCL] 00 JVCL Components major always 2015-12-09 12:51 2015-12-10 20:44
Reporter: ZENsan Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: JvDebugHandler generates the stack trace information with a spelling error!!!
Description: ExceptionStringList method of TJvDebugHandler generates the text with spelling error in word "occured"!

It is not occuRed - it is occuRRed!

:)

P.S. So many years.. and noone noticed that...
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021250)
AHUser   
2015-12-10 20:44   
Fixed in master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6479 [JEDI VCL] 00 JVCL Components major always 2015-12-10 15:26 2015-12-10 19:34
Reporter: Arioch Platform: XE2  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version: Daily / GIT  
Summary: Crash in TDataSet due to bug in TJvDbGrid
Description: i somewhat frozen at 2013 GIT version with few fixes.
But for what i can see there was no change for it.

In some conditions JvDbGrid might cause AV in TDataSet

Bug is attempt to recreate the control when there is none and when the dataset is in process of being closed.

Line 4115 TJvDBGrid.DoAutoSizeColumns
https://github.com/project-jedi/jvcl/blob/master/jvcl/run/JvDBGrid.pas

Proposed fix: insert there: "if WindowHandle = 0 then exit;"
Tags:
Steps To Reproduce: XE2 Win32, UnifiedIB (UIBDataSet) -> DataSource -> TJvDBUltimGrid

TJvDBUltimGrid.OnUserSort:
   UibDataSet.Close;
   UibDataSet.SQL := .... with ORDER BY
   UibDataSet.Open;

TForm.CMVisibleChanged
   read saved sort order
   UibDataSet.Open;
   JvDBUltimGrid.Sort ( saved sorted fields )

    ....from there it goes into OnUserSort and closes the dataset.
    ....from there it goes into TJvDBGrid.DoAutoSizeColumns
    ....the 7th line of the procedure is "AvailableWidth := ClientWidth;"
    ....it calls "VCL.TControl.HandleNeeded" // while WindowHandle=0 !!!
    ....it calls RecreateWnd
    ....it calls re-enter into Auto-Width-Columns sequence when TDataset is half-closed ( Datalink.Active = true but DataSet.Active = false !!! )
    ....it makes fetching fields and their values
    ....it calls TDataSet.ActiveRecord when FBuffers dyn-array is nil -> AV


Additional Information: The proposed fix avoids fitting columns until the grid is visualized normal way.
And anyway, there is just no point to o on with complex and heavy autofitting when there is no real window created yet!
Attached Files:
Notes
(0021249)
AHUser   
2015-12-10 19:34   
Fixed in master branch.

I added that while csLoading is set, the method is also skipped, what reduces the amount of unnecessary work.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6452 [JEDI VCL] 02 Installation block always 2015-09-27 17:28 2015-09-27 21:28
Reporter: RandomHavoc Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Install 32-bit still fails in Delphi10Seattle with BDE installed.
Description: 2015-9-27 daily now gets error:
Fatal: jvcl\design\JvPascalInterpreterReg.pas: F2613 Unit 'JvInterpreter_DBTables' not found.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021222)
AHUser   
2015-09-27 19:21   
The daily snapshots aren't updated yet. They are only built every 24 hours, what means that you have to wait at least till 2015-09-28 8:35 UTC.

The changes to fix this are only in the git repository for now.
(0021223)
RandomHavoc   
2015-09-27 20:00   
I downloaded the .zip from
https://github.com/project-jedi/jvcl
this morning.
(0021224)
AHUser   
2015-09-27 21:28   
My fault. I only committed the file in the run directory. Now the file in the design directory is also updated.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6372 [JEDI VCL] 00 JVCL Components feature always 2015-01-05 12:08 2015-09-27 17:15
Reporter: CDametto Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Jvrollout appearance with vcl styles
Description: I added two properties to jvRollOut to paint it with the current style (if enabled): ButtonStyle and UseGroupBoxCaptionColor.
The first allows you to choose the style as a header or as a button, the second sets the color of the caption like the object GroupBox.
I added a third property to not hide objects on the title when the panel is collapsed: CollapseCtrlsOnButton. This does not work very well because it presents some refreshing problems.
I would appreciate if you would like to implement the option to have these settings in the component.
Thank You
Tags:
Steps To Reproduce:
Additional Information: I am attaching my modified sources and a little test program.
Attached Files: JvRollOut.pas (49,395 bytes) 2015-01-05 12:08
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002604&type=bug
Test.zip (3,439,399 bytes) 2015-01-05 12:09
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002605&type=bug
Notes
(0021221)
AHUser   
2015-09-27 17:15   
Applied to git master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6451 [JEDI VCL] 02 Installation block always 2015-09-26 23:16 2015-09-27 16:38
Reporter: RandomHavoc Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: Install 32-bit fails in Delphi10Seattle with BDE installed.
Description: 64-bit w/o BDE installs.
Tags:
Steps To Reproduce:
Additional Information: Fails in 3.49 too.
Attached Files:
Notes
(0021218)
RandomHavoc   
2015-09-26 23:21   
Fatal: jvcl\JvInterpreter_all.pas: F2613 Unit 'JvInterpreter_DBTables' not found.
(0021219)
AHUser   
2015-09-27 16:38   
JvInterpreter_DBTables isn't used by JvInterpreter_All now for Delphi XE8 or newer.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6312 [JEDI VCL] 00 JVCL Components block always 2014-07-31 21:46 2015-09-21 20:28
Reporter: altaveron Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: Daily / GIT  
    Target Version:  
Summary: The correct support for x64 platform
Description: Please add the correct support for x64 platform. I can provide you required changes. The first block on each source file is a set of original lines. The second block is a set of correct lines. Official documentation can be found here: docwiki.embarcadero.com/RADStudio/XE4/en/Converting_32-bit_Delphi_Applications_to_64-bit_Windows
Tags:
Steps To Reproduce:
Additional Information: *** JCL ***

1. JediGUIInstall.pas

    SetWindowLong(FFormCompile.Handle, GWL_HWNDPARENT, Handle);

    SetWindowLongPtr(FFormCompile.Handle, GWLP_HWNDPARENT, Handle);

2.JclSysInfo.pas

    ExStyle := GetWindowLongPtr(Wnd, GWL_EXSTYLE);

    ExStyle := GetWindowLong(Wnd, GWL_EXSTYLE);

3. JclOpenDialogHooks.pas

  SetString(Result, Path, SendMessage(FParentWnd, CDM_GETFOLDERPATH, SizeOf(Path), Integer(@Path)));

  SetString(Result, Path, SendMessage(FParentWnd, CDM_GETFOLDERPATH, SizeOf(Path), LPARAM(@Path)));

*** JVCL ***

1. JvVCLUtils.pas

  Result := GetWindowLong(Wnd, GWL_HWNDPARENT);

  Result := GetWindowLongPtr(Wnd, GWLP_HWNDPARENT);

2. AHCompBrowseFolderDlg.pas

    TBrowseFolderDialog(Data).FDefWndProc := Pointer(SetWindowLong(wnd, GWL_WNDPROC,

    TBrowseFolderDialog(Data).FDefWndProc := Pointer(SetWindowLongPtr(wnd, GWLP_WNDPROC,

3. JvAVICapture.pas

  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWL_USERDATA));
  SetWindowLongPtr(FHWnd, GWL_USERDATA, LONG_PTR(Self));
  FPreviousWndProc := Pointer(GetWindowLongPtr(FHWnd, GWL_WNDPROC));
  SetWindowLongPtr(FHWnd, GWL_WNDPROC, LONG_PTR(@CustomWndProc));
  SetWindowLongPtr(FHWnd, GWL_WNDPROC, LONG_PTR(FPreviousWndProc));

  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SelfObj := TJvAVICapture(GetWindowLongPtr(hWnd, GWLP_USERDATA));
  SetWindowLongPtr(FHWnd, GWLP_USERDATA, LONG_PTR(Self));
  FPreviousWndProc := Pointer(GetWindowLongPtr(FHWnd, GWLP_WNDPROC));
  SetWindowLongPtr(FHWnd, GWLP_WNDPROC, LONG_PTR(@CustomWndProc));
  SetWindowLongPtr(FHWnd, GWLP_WNDPROC, LONG_PTR(FPreviousWndProc));

4. JvBDEFilter.pas

          Longint(Self), FPriority, False,
  Check(DbiAddFilter((FDataLink.DataSet as TBDEDataSet).Handle, Longint(Self),

          NativeInt(Self), FPriority, False,
  Check(DbiAddFilter((FDataLink.DataSet as TBDEDataSet).Handle, NativeInt(Self),

5. JvBDEProgress.pas

    Check(DbiRegisterCallback(nil, FCBType, Longint(Self), FCBBufLen,

    Check(DbiRegisterCallback(nil, FCBType, NativeInt(Self), FCBBufLen,

6. JvBackgrounds.pas

      FPrevWndProc := Pointer(SetWindowLongPtr(ClientHandle, GWL_WNDPROC, LONG_PTR(FNewWndProc)));
        if (FNewWndProc <> Pointer(SetWindowLongPtr(ClientHandle, GWL_WNDPROC, LONG_PTR(FPrevWndProc)))) and


      FPrevWndProc := Pointer(SetWindowLongPtr(ClientHandle, GWLP_WNDPROC, LONG_PTR(FNewWndProc)));
        if (FNewWndProc <> Pointer(SetWindowLongPtr(ClientHandle, GWLP_WNDPROC, LONG_PTR(FPrevWndProc)))) and

7. JvBaseDBDialog.pas

    SetWindowLongPtr(Result.Handle, GWL_HWNDPARENT, LONG_PTR(FParentWnd));

    SetWindowLongPtr(Result.Handle, GWLP_HWNDPARENT, LONG_PTR(FParentWnd));

8. JvBrowseFolder.pas

    FDefWndProc := Pointer(SetWindowLongPtr(FDialogWindow, GWL_WNDPROC, LONG_PTR(FObjectInstance)));

    FDefWndProc := Pointer(SetWindowLongPtr(FDialogWindow, GWLP_WNDPROC, LONG_PTR(FObjectInstance)));

9. JvColorCombo.pas

  Result := Integer(Item1) - Integer(Item2);

  Result := Integer(NativeInt(Item1) - NativeInt(Item2))

10. JvComCtrls.pas

      SetWindowLongPtr(FHandle, GWL_WNDPROC, LONG_PTR(FOrgWndProc));
      FOrgWndProc := Pointer(SetWindowLongPtr(FHandle, GWL_WNDPROC, LONG_PTR(FInstance)));

      SetWindowLongPtr(FHandle, GWLP_WNDPROC, LONG_PTR(FOrgWndProc));
      FOrgWndProc := Pointer(SetWindowLongPtr(FHandle, GWLP_WNDPROC, LONG_PTR(FInstance)));

11. JvComponent.pas

      if HWND(GetWindowLong(Handle, GWL_HWNDPARENT)) <> NewParent then
        SetWindowLong(Handle, GWL_HWNDPARENT, Longint(NewParent));
        if HWND(GetWindowLong(Handle, GWL_HWNDPARENT)) <> NewParent then
          SetWindowLong(Handle, GWL_HWNDPARENT, Longint(NewParent));

      if HWND(GetWindowLongPtr(Handle, GWLP_HWNDPARENT)) <> NewParent then
        SetWindowLongPtr(Handle, GWLP_HWNDPARENT, LONG_PTR(NewParent));
        if HWND(GetWindowLongPtr(Handle, GWLP_HWNDPARENT)) <> NewParent then
          SetWindowLongPtr(Handle, GWLP_HWNDPARENT, LONG_PTR(NewParent));

12. JvCreateProcess.pas

  Result := THandle(GetWindowLongPtr(AHandle, GWL_HINSTANCE)) = WinSrvHandle;

  Result := THandle(GetWindowLongPtr(AHandle, GWLP_HINSTANCE)) = WinSrvHandle;

13. JvDialogs.pas

    FOldParentWndInstance := Pointer(SetWindowLongPtr(FParentWnd, GWL_WNDPROC, LONG_PTR(FParentWndInstance)));

    FOldParentWndInstance := Pointer(SetWindowLongPtr(FParentWnd, GWLP_WNDPROC, LONG_PTR(FParentWndInstance)));

14. JvGnugettext.pas

  offset:=integer(NewProc)-integer(pointer(patchPosition))-5;
  p:=pointer((integer(p) + PAGESIZE-1) and not (PAGESIZE-1) - pageSize);

  offset:=Integer(NativeInt(NewProc)-NativeInt(pointer(patchPosition))-5);
  p:=pointer((NativeInt(p) + PAGESIZE-1) and not (PAGESIZE-1) - pageSize);

15. JvID3v2Base.pas

    FController.ID3Event(ideFrameChange, Longint(Self));

    FController.ID3Event(ideFrameChange, NativeInt(Self));

16. JvJCLUtils.pas

  Result := THandle(GetWindowLongPtr(Wnd, GWL_HWNDPARENT));

  Result := THandle(GetWindowLongPtr(Wnd, GWLP_HWNDPARENT));

17. JvJVCLUtils.pas

    SetWindowLongPtr(Result, GWL_WNDPROC, LONG_PTR(@StdWndProc));

    SetWindowLongPtr(Result, GWLP_WNDPROC, LONG_PTR(@StdWndProc));

18. JvMenus.pas

        DefProc := Pointer(GetWindowLongPtr(CanvasWindow, GWL_WNDPROC));
  SetWindowLongPtr(AHandle, GWL_WNDPROC, LONG_PTR(NewProc));
    SetWindowLongPtr(AHandle, GWL_WNDPROC, LONG_PTR(FPrevProcList[Index]));

        DefProc := Pointer(GetWindowLongPtr(CanvasWindow, GWLP_WNDPROC));
  SetWindowLongPtr(AHandle, GWLP_WNDPROC, LONG_PTR(NewProc));
    SetWindowLongPtr(AHandle, GWLP_WNDPROC, LONG_PTR(FPrevProcList[Index]));

19. JvPageSetup.pas

      Pointer(SetWindowLongPtr(Wnd, GWL_WNDPROC, LONG_PTR(THackCommonDialog(CreationControl).FObjectInstance)));

      Pointer(SetWindowLongPtr(Wnd, GWLP_WNDPROC, LONG_PTR(THackCommonDialog(CreationControl).FObjectInstance)));

20. JvPageSetupTitled.pas

    Application.HelpCommand(HELP_SETPOPUP_POS, Longint(Pt));

    Application.HelpCommand(HELP_SETPOPUP_POS, Integer(Pt));

21. JvPlaylist.pas

    Items.Delete(Longint(Msg.WParam));

    Items.Delete(NativeInt(Msg.WParam));

22. JvRichEdit.pas

  // ????????? x64: ????? ??????????? ? ?????????? x64

23. JvTFDays.pas

  Col, MapCols, ApptVal: Integer;
  ApptVal := Integer(Appt);

  Col, MapCols: Integer;
  ApptVal: NativeInt;
  ApptVal := NativeInt(Appt);

24. JvWndProcHook.pas

    FOldWndProcHandle := TFarProc(SetWindowLongPtr(FHandle, GWL_WNDPROC, LONG_PTR(MakeObjectInstance(WindowProc))));
    Ptr := TFarProc(SetWindowLongPtr(FHandle, GWL_WNDPROC, LONG_PTR(FOldWndProcHandle)));

    FOldWndProcHandle := TFarProc(SetWindowLongPtr(FHandle, GWLP_WNDPROC, LONG_PTR(MakeObjectInstance(WindowProc))));
    Ptr := TFarProc(SetWindowLongPtr(FHandle, GWLP_WNDPROC, LONG_PTR(FOldWndProcHandle)));

25. JvgCaption.pas

  P := Pointer(GetWindowLongPtr(TForm(Owner).Handle, GWL_WNDPROC));
    SetWindowLongPtr(TForm(Owner).Handle, GWL_WNDPROC, LONG_PTR(FNewWndProc));
    (Pointer(GetWindowLongPtr(TForm(Owner).Handle, GWL_WNDPROC)) = FNewWndProc) then
    SetWindowLongPtr(TForm(Owner).Handle, GWL_WNDPROC, LONG_PTR(FPrevWndProc));

  P := Pointer(GetWindowLongPtr(TForm(Owner).Handle, GWLP_WNDPROC));
    SetWindowLongPtr(TForm(Owner).Handle, GWLP_WNDPROC, LONG_PTR(FNewWndProc));
    (Pointer(GetWindowLongPtr(TForm(Owner).Handle, GWLP_WNDPROC)) = FNewWndProc) then
    SetWindowLongPtr(TForm(Owner).Handle, GWLP_WNDPROC, LONG_PTR(FPrevWndProc));

26. JvgCheckBox.pas

  P := Pointer(GetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC));
    SetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC, LONG_PTR(FNewWndProc));
    (Pointer(GetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC)) = FNewWndProc) then
    SetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC, LONG_PTR(FPrevWndProc));

  P := Pointer(GetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC));
    SetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC, LONG_PTR(FNewWndProc));
    (Pointer(GetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC)) = FNewWndProc) then
    SetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC, LONG_PTR(FPrevWndProc));

27. JvgLabel.pas

  P := Pointer(GetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC));
    SetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC, LONG_PTR(FNewWndProc));
    (Pointer(GetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC)) = FNewWndProc) then
    SetWindowLongPtr(FocusControl.Handle, GWL_WNDPROC, LONG_PTR(FPrevWndProc));

  P := Pointer(GetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC));
    SetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC, LONG_PTR(FNewWndProc));
    (Pointer(GetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC)) = FNewWndProc) then
    SetWindowLongPtr(FocusControl.Handle, GWLP_WNDPROC, LONG_PTR(FPrevWndProc));
Attached Files:
Notes
(0021011)
altaveron   
2014-07-31 21:48   
Module JvRichEdit.pas has class TOleUILinkInfo that doesn't support x64 platform at all.
(0021017)
obones   
2014-08-31 22:37   
Could you please create pull requests at github for all these changes?
(0021020)
altaveron   
2014-09-01 13:10   
I never did pull request. Please make all required changes without pull request if it's possible.
(0021021)
obones   
2014-09-01 15:31   
I'm sorry, but it's too much hassle for us to go through when you obviously already have made the changes.
Patch files would be nice if you can't/don't want to work with git and github.
(0021214)
AHUser   
2015-09-21 20:28   
Win64 correctness applied to git master.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5980 [JEDI VCL] 02 Installation trivial always 2012-09-03 13:30 2015-09-21 17:47
Reporter: Arioch Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: redundant loop body
Description: D:\DelphiProjects\Libs\JediVCL\jvcl\install\JVCLInstall\Utils.pas

procedure AddPaths(List: TStrings; Add: Boolean; const Dir: string;
  const Paths: array of string);


1st loop is re-calculating Path local var when it did not changed.


Additionally, either to use hardcoded '\' or x-platform PathDelim;
Tags:
Steps To Reproduce: Current code:

  for j := 0 to High(Paths) do
    for i := List.Count - 1 downto 0 do
      if Paths[j] <> '' then
      begin
        Path := Paths[j];
        if (Pos(':', Path) = 0) and (Path[1] <> '$') then
          Path := PathDelim + ExtractFileName(Dir) + PathDelim + Paths[j];
        if EndsWith(List[i], Path, True) then
          List.Delete(i)
        else if EndsWith(List[i], Path + '\', True) then
          List.Delete(i);
      end;
Additional Information: Better code :

  for j := 0 to High(Paths) do begin
    Path := Paths[j];
    if Path <> '' then
    begin
      if (Pos(':', Path) = 0) and (Path[1] <> '$') then
        Path := PathDelim + ExtractFileName(Dir) + PathDelim + Paths[j];
      for i := List.Count - 1 downto 0 do begin
          if EndsWith(List[i], Path, True) then
            List.Delete(i)
          else if EndsWith(List[i], Path + PathDelim, True) then
            List.Delete(i);
      end;
     end;
    end;
Attached Files:
Notes
(0020357)
obones   
2013-01-15 15:29   
Please check with latest SVN content, Andreas may have changed it already.
(0020398)
Arioch   
2013-01-16 11:07   
no, this both issues remain and file header still claims
// $Id: Utils.pas 13148 2011-11-05 17:27:59Z ahuser $
(0020511)
AHUser   
2013-05-25 16:02   
Corrected in svn revision 13524.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5969 [JEDI VCL] 00 JVCL Components major always 2012-08-28 16:13 2015-09-21 17:47
Reporter: dummzeuch Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: Reading a readonly property raises an exception
Description: When reading a readonly property from a TJvPropertyStorage, an access violation occurs. This AV does not surface because the reading code is surrounded with a try ... except which swallows it, but it should be avoided nonetheless.

I think the problem can be solved by changing the method as follows:

procedure TJvPropertyStorage.LoadAnyProperty(PropInfo: PPropInfo);
begin
  try
    if (PropInfo <> nil) and (PropInfo.SetProc <> nil) then
      ReadProperty (AppStoragePath, GetItemName(PropInfo.Name), TPersistent(FObject), PropInfo.Name);
  except
    { ignore any exception }
  end;
end;

(The check PropInfo <> nil is new.)

I could have checked in the change myself, but I am not 100% sure whether it is correct, so I'd like somebody else have a look first.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0020350)
obones   
2013-01-15 15:23   
Please provide the zipped sources of a sample application showing this.
(0020516)
AHUser   
2013-05-25 17:49   
Applied in svn revision 13527.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5942 [JEDI VCL] 00 JVCL Components major always 2012-08-01 13:20 2015-09-21 17:47
Reporter: JoeyM Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.45  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: TJvCustomOfficeColorButton show dropdown window at wrong position on second monitor
Description: On the second monitor the dropdown window is always displayed on the very right side of the screen.

Solution: In JvOfficeColorButton.TJvCustomOfficeColorButton.AdjustColorForm():
Replace Screen.Width with Screen.DesktopWidth
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0020315)
JoeyM   
2012-12-18 11:31   
Is no one taking care of this matter although the fix is already there? What can I do to get this fix in the trunk?


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5937 [JEDI VCL] 00 JVCL Components tweak always 2012-07-24 12:31 2015-09-21 17:47
Reporter: moore Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: TJvComboEdit unpublished properties NumbersOnly and TexhHint
Description: TJvComboEdit derives from TCustomEdit as TEdit, but does not publish in the object inspector some properties like NumbersOnly, TextHint, Touch..
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0020201)
moore   
2012-09-23 11:57   
Is is dificult to add these properties to the published part?
(0020206)
AHUser   
2012-09-24 13:04   
It is not difficult, but if nobody makes the changes, then the changes won't be made. There are not many left in the JCL/JVCL team. And those who are, don't spend all their spare time on the JCL/JVCL (anymore).
(0020207)
AHUser   
2012-09-24 13:48   
The properties are now published in svn revision 13437.

TextHint is now also supported for non-themed applications (the VCL only supports WinXP+Themed)


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5926 [JEDI VCL] Miscellanous major always 2012-06-29 19:24 2015-09-21 17:47
Reporter: Mark- Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: TJvHidDeviceController memory leak.
Description: Hello,

I am not sure on the version. It came from JVCL345CompleteJCL231-Build4197

I have a TJvHidDeviceController on a window. When a USB device is plugged in,
TJvHidDevice.Create is called 6 times and TJvHidDevice.Destroy is called 4 times.

All is good.

The window is still open.

When I unplug the device TJvHidDevice.Destroy is not called 2 times causing the memory leak when the program terminates.

I have not been able to locate a call to free the TJvHidDevice objects. They appear to be dangling. They are not in the FList of TJvHidDeviceController.

In TJvHidDeviceController.DeviceChange they are removed from the FList but the objects are not freed. I do not see where they had been or are added to another list.

Thanks for any help.

Ciao,

Mark
Tags:
Steps To Reproduce:
Additional Information:
cHidControllerClassVersion = '1.0.35';

UnitVersioning: TUnitVersionInfo = (
 RCSfile: '$URL: https://jvcl.svn.sourceforge.net/svnroot/jvcl/tags/JVCL3_45/run/JvHidControllerClass.pas $';
    Revision: '$Revision: 13102 $';
    Date: '$Date: 2011-09-07 07:46:34 +0200 (mer., 07 sept. 2011) $';
    LogPath: 'JVCL\run'
  );
Attached Files:
Notes
(0020045)
Mark-   
2012-07-01 15:27   
I made a change and so far all is good.

In JvHidControllerClass, TJvHidDeviceController.DeviceChange;

I changed:

if not HidDev.IsCheckedOut then
 FList.Delete(I);

to:

if not HidDev.IsCheckedOut then
 begin
  FList.Delete(I);
  HidDev.Free;
 end;
(0020345)
obones   
2013-01-15 15:20   
This is now fixed in SVN


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5923 [JEDI VCL] 00 JVCL Components major sometimes 2012-06-28 15:09 2015-09-21 17:47
Reporter: tetardd Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.45  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: TJvCustomURLGrabber can save a file of 0 size if internet connection not available.
Description: If you don't have an internet connection, TJvCustomURLGrabber can still save a file/stream of size 0, which is not right as no internet connection means no file downloaded (compared to a genuine downloaded file that's empty).

Proposed fix:

TJvCustomURLGrabber = Class(...)
private
   ...
   FHasStartedGrabbing : Boolean;
   ...
End;


Constructor TJvCustomURLGrabber.Create(...);
Begin
    ...
    FHasStartedGrabbing := False;
End;

Procedure TJvCustomURLGrabber.DoEnded;
Begin
     // If the DoEnded is called and we did not start grabbing, do no handle
     // unexisting file/stream as empty ones!!!
     If Not FHasStartedGrabbing Then
          Exit;

     ...
End;

Procedure TJvCustomURLGrabberThread.SetGrabberStatus(Status : ...);
Begin
     ...
     If Status = gsGrabbing Then
          FGrabber.FhasStartedGrabbing := True;
End;
Tags:
Steps To Reproduce:
Additional Information: Sorry, I can't give the full modified file, I have made extensive changes for my use and I just want to submit some key changes one by one for approval.
Attached Files:
Notes
(0020340)
obones   
2013-01-15 15:09   
Use the demo to reproduce
(0020518)
AHUser   
2013-05-25 18:01   
Added in svn revision 13529.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5920 [JEDI VCL] 00 JVCL Components major always 2012-06-27 13:14 2015-09-21 17:47
Reporter: Arioch Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: jvcolorbutton rendering broken on Enabled toggling
Description: I've found small problem with this gadget:
 - I change status Enebled to False.
 - I change status Enabled to True.
 - I change color - Showing color is wrong....

 I've fixed it for my copy:
 part of procedure TJvColorButton.Paint:


 if Enabled then
     Frame3D(Canvas, Rec, cl3DDkShadow, cl3DDkShadow, 1)
 else
 begin
     Frame3D(Canvas, Rec, clBtnShadow, clBtnHighLight, 1);
     Canvas.Brush.Style := bsBDiagonal;
 end;

 I've changed to:

     if Enabled then
     begin
       Frame3D(Canvas, Rec, cl3DDkShadow, cl3DDkShadow, 1);
       Canvas.Brush.Style := bsSolid;
     end
     else
     begin
       Frame3D(Canvas, Rec, clBtnShadow, clBtnHighLight, 1);
       Canvas.Brush.Style := bsBDiagonal;
     end;
Tags:
Steps To Reproduce: take demo from 0005695

Buttons 1 and 2 should revert each over, but they do not.


 PS. Frankly, diagonal style of "Disabled" button brush is not obvious solution. IT might be bright black stripes over bright black background for example.
 The overall "disabled" style should be rethought or maybe even made customized.
Additional Information:
Attached Files:
Notes
(0020517)
AHUser   
2013-05-25 17:53   
Fixed in svn revision 13528.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5894 [JEDI VCL] 00 JVCL Components major random 2012-06-02 00:15 2015-09-21 17:47
Reporter: Melloware Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.45  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: HID EControllerError: Device cannot be opened
Description: Users report for some its random another guy can reproduce it every time. For one user it is when he plugs in a specific USB device "Virgin Health Miles GoZone pedometer".

Another user it is every time he Logs and and Logs off the machine. From looking at the source code this error is in the HIDDevice create and it must be returning a INVALID_HANDLE for the device in certain scenarios.

I have only ever had it happen to me once and I could not reproduce it. I was hoping you could take another look where that error is thrown and see what possible causes might be?

This post the user gets the error regularly: http://forum.melloware.com/viewtopic.php?f=1&t=9839

Tags:
Steps To Reproduce:
Additional Information:
Attached Files: hidtester.zip (90,339 bytes) 2012-06-06 14:59
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002329&type=bug
HIDTester-bin-obones.zip (2,524,576 bytes) 2012-06-06 15:52
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002330&type=bug
econtroller-error.txt (13,405 bytes) 2012-06-11 15:52
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002333&type=bug
HIDTester-bin-jdbg.zip (3,166,070 bytes) 2012-06-11 17:02
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002334&type=bug
Notes
(0019802)
Melloware   
2012-06-06 15:02   
Attached is HidTester project. It attaches to all HID devices so if you press buttons on your remote you should see HID output.

Where the Tivo Slide has issues is possibly two areas.

1. Press the Force button to force reloading of the USB devices we have seen increased CPU Usage and possibly EControllerError Device cannot be opened when the Machine Wakes from Sleep or upon Logout of User.

2. If that doesn't work try leaving the app running for a while letting your Tivo Remote go to sleep. This seems to cause the Bluetooth stack to trigger a "Devices Have Changed..." event and the USB devices reload and we see increased CPU Usage or EControllerError.
(0019803)
obones   
2012-06-06 15:54   
(Last edited: 2012-06-06 15:54)
I have attached the exe file compiled here with the very latest sources (the content one can get in SVN) and I cannot see the CPU usage that you talk about.

I tried option 1 and option 2 (10 minutes of leaving the remote idle) and no high CPU usage.

The only way to get high CPU usage that I saw was to not use the changes I just made in the SVN version

(0019804)
Melloware   
2012-06-06 17:21   
I will have some of my users having Tivo Slide issues try this.
(0019808)
Melloware   
2012-06-08 15:12   
OK so good news and bad news.

Good news: I did a full JVCL Clean and Rebuild and I think your patch just never got compiled the first time. The Tivo Slide users are reporting 0% CPU utilization so that is excellent.

Bad News: A few of my users are still getting EControllerError: Device could not be opened when they plug in certain devices or Log off the computer. Is there an elegant way I can handle this situation?

I think since this Exception is thrown on from two places, when the devices change or potentially in TJvHidDevice.Destroy. The problem is there is no place for me to catch this error and handle it gracefully. My ideal I guess would be if a Device could not be opened I could log an error but allow the rest of the devices to continue to be checked out as Normal. Almost like an OnDeviceError callback???
(0019816)
obones   
2012-06-11 15:45   
Do you have the stack trace when this happens? I mean you could use JclDebug, MadExcept or EurekaLog to get this and as a result you could see where the call is coming from and add an appropriate try..except block around it.
(0019817)
Melloware   
2012-06-11 15:51   
I have attached what the JCLExceptionDialog catches. I think the problem is the Device Unplug and Plug in is running in a background thread of JVHidController that is outside of any execution context of my app to surround with a try catch.

So if you just plug in a device it gets the exception but there is nothing for my app to catch and it is bubbling all the way out the JCLExceptionDialog.
(0019818)
obones   
2012-06-11 16:27   
Well, thanks for the attached log, but it does not show any stack information. Are you sure you activated the stack information and that you deployed the map file (or the jdbg, compressed version of it) ?
As it is, this file is not usable.
(0019820)
Melloware   
2012-06-11 16:39   
the same user can get it with your HID tester attached above. Is there something I can retrieve from it so I can attach it here?
(0019821)
obones   
2012-06-11 17:03   
I attached a new version of the tester that uses JclDebug to get a full stack trace, it would be nice if I could see the details when the exception occurs.
(0019823)
Melloware   
2012-06-11 17:08   
OK I will get back to you thanks!
(0020262)
Melloware   
2012-10-13 17:09   
OK I learned more about this. I have a private USB stick which requires a license to communicate with it.

In TJvHidDevice.CtlCreate if it can't open a device it throws this Exception.

else
   raise EControllerError.CreateRes(@RsEDeviceCannotBeOpened);

However I don't want this to stop processing the rest of the USB devices but this does. So I simply commented out this error and my code goes on its merry way.

Is there some switch that can be added to ignore this error if we don't care?
(0020295)
obones   
2012-11-05 10:33   
I have added the OnDeviceCreateError event in revision 13468, it should be sufficient for your needs.
(0020297)
Melloware   
2012-11-05 12:30   
Thank you!
(0020309)
yury_a   
2012-12-13 15:04   
Hello obones,

we have the same issue on a TabletPC computer and tried your solution with OnDeviceCreateError. It seems to contain a problem. Although the handler is called and Handled is set to True in it, there comes endless loop of errors.

I guess the lines

if Assigned(HidDev) then
begin
  NewList.Add(HidDev);
  Inc(Devn);
end;

should be replaced with

if Assigned(HidDev) then
  NewList.Add(HidDev);
Inc(Devn);

We've tried -- it works.

Thank you!
(0020324)
Melloware   
2012-12-27 19:43   
Nice post yury_a. Hopefully this will get incorporated
(0020334)
obones   
2013-01-15 14:57   
I went a bit further than that, it should cover other cases as well.
Sorry for the delay.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
5850 [JEDI VCL] 00 JVCL Components crash always 2012-04-12 16:43 2015-09-21 17:47
Reporter: altaveron Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: Incorrect fix of the issue "Mantis 5818" in JvDBGrid.pas
Description: The is a fix in JvDBGrid.pas:

  // Mantis 5818: the inherited code sometimes gives an invalid index for the column
  if Index > FirstVisibleColumn + VisibleColCount then
    Index := FirstVisibleColumn + VisibleColCount;

But this code doesn't help me. The working code is:

  // Store the column index to resize.
  FResizeColumnIndex := Index;
  if dgIndicator in Options then
    FResizeColumnIndex := FResizeColumnIndex - 1;

Please correct the issue fix.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0019848)
obones   
2012-06-11 17:26   
Please provide the zipped sources of a sample application showing this.
(0020444)
altaveron   
2013-02-25 01:13   
Please just fix it. Our application have millions lines of code. The issue presents on the last version.
(0020445)
altaveron   
2013-02-25 01:25   
The following line:

  FResizeColumnIndex := Index - 1;

Should be replaced by:

  // Store the column index to resize.
  FResizeColumnIndex := Index;
  if dgIndicator in Options then
    FResizeColumnIndex := FResizeColumnIndex - 1;
(0020456)
altaveron   
2013-03-27 18:41   
Why the issue has 'feedback' status and no answers?
(0020507)
AHUser   
2013-05-25 15:25   
Fixed in svn revision 13517.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6423 [JEDI VCL] 00 JVCL Components minor sometimes 2015-07-23 11:03 2015-09-21 17:47
Reporter: bhe Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: TJvCsvStream: Wrong type in GetFileSizeEx() declaration
Description: TJvCsvStream: Wrong type in GetFileSizeEx() declaration
Tags:
Steps To Reproduce:
Additional Information:  jvcl/run/JvCsvData.pas | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/jvcl/run/JvCsvData.pas b/jvcl/run/JvCsvData.pas
index e3e5b60..8794a92 100644
--- a/jvcl/run/JvCsvData.pas
+++ b/jvcl/run/JvCsvData.pas
@@ -1078,7 +1078,7 @@ end;
 //-------------------------------------------------------------------------
 // TJvCsvStream METHODS
 //-------------------------------------------------------------------------
-function GetFileSizeEx(h: HFILE; FileSize: PULargeInteger): BOOL; stdcall;
+function GetFileSizeEx(h: THandle; FileSize: PULargeInteger): BOOL; stdcall;
   external Kernel32;
 
 procedure TJvCsvStream.Append;
Attached Files: TJvCsvStream.diff (645 bytes) 2015-07-23 11:03
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002623&type=bug
Notes
(0021175)
AHUser   
2015-07-23 23:41   
Fixed in the master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6421 [JEDI VCL] 00 JVCL Components crash sometimes 2015-07-23 10:45 2015-09-21 17:47
Reporter: bhe Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: JclCompression: Wrong type declaration (Crash on x64 with bound check enabled)
Description: Wrong type declaration (Crash on x64 with bound check enabled)
Tags:
Steps To Reproduce:
Additional Information:  jcl/source/common/JclCompression.pas | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/jcl/source/common/JclCompression.pas b/jcl/source/common/JclCompression.pas
index c3d60b9..7b1dc6c 100644
--- a/jcl/source/common/JclCompression.pas
+++ b/jcl/source/common/JclCompression.pas
@@ -4285,7 +4285,7 @@ function TJclCompressionItem.UpdateFileTimes: Boolean;
 const
   FILE_WRITE_ATTRIBUTES = $00000100;
 var
- FileHandle: HFILE;
+ FileHandle: THandle;
   ACreationTime, ALastAccessTime, ALastWriteTime: PFileTime;
 begin
   ReleaseStream;
Attached Files: JclCompression_x64_issue.diff (558 bytes) 2015-07-23 10:45
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002622&type=bug
Notes
(0021173)
AHUser   
2015-07-23 23:35   
Fixed in the master branch.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6412 [JEDI VCL] 00 JVCL Components minor always 2015-06-05 02:22 2015-09-21 17:47
Reporter: sambo Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: TJvSpinEdit bound exception when using vtString
Description: Hello,

I'm using the new feature you added for us into the spin edits whereby you can load TStrings and set the ValueType to vtString. Thanks for that!

I did notice a couple easy to reproduce (and seemingly easy to fix) issues:
(In both cases, I'm referring speficially to cases when vtString is in use.)

1) When clicking Up/Down, the value isn't checked against either MaxValue/MinValue nor the item count of the Items field.

2) Setting a MaxValue and loading a shorter list of Items doesn't do anything for the MaxValue.
Tags:
Steps To Reproduce:
Additional Information: I've included a trivial sample project. (I happen to build on XE8, so the project file may or may not load in previous versions of Delphi RAD Studio, but a new project file can be trivially created.)

Possible fixes as follows:

Issue 1: Add a call to CheckValue to the vtString case in TJvSpinEdit.SetValue().

Issue 2: Add a code to adjust the MaxValue in TJvCustomSpinEdit.SetItems(). Something like this, perhaps:
FMaxValue := Math.Max(FMaxValue, FItems.Count-1);


p.s., for a more severe crash (as in crash during form creation) related to issue 0000001, set the MinValue property of JvSpinEdit1 to 1, for instance. I believe that the potential solution above will address this crash as well.
Attached Files: spinbug.zip (58,491 bytes) 2015-06-05 02:22
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002617&type=bug
Notes
(0021168)
sambo   
2015-06-05 02:25   
Hmm... my last p.s. comment was incorrectly formatted because I used a hash sign instead of the word "number". So, the text should actually read:

.... related to issue number 1, set the MinValue property....


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6408 [JEDI VCL] 00 JVCL Components minor always 2015-05-15 17:55 2015-09-21 17:47
Reporter: JamesBrown Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: JVCL 3.48 Installer fails with JCL version error
Description: Installer fails with message: Many errors appear because JCL and JVCL version are not compatible.
I have JCL 2.7 installed from Zip download
Tags:
Steps To Reproduce:
Additional Information: 96090 lines, 1.09 seconds, 306656 bytes code, 3348 bytes data.
[Compiling: JvDB220.bpl]
Embarcadero Delphi for Win32 compiler version 29.0
Copyright (c) 1983,2015 Embarcadero Technologies, Inc.

C:\JEDI\jvcl\jvcl\run\JvDBGrid.pas(704) Error: E2029 ',' or ':' expected but ':=' found
C:\JEDI\jvcl\jvcl\run\JvDBGrid.pas(704) Error: E2029 ',' or ':' expected but ';' found
Attached Files:
Notes
(0021166)
AHUser   
2015-05-15 19:29   
The syntax error is now fixed.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6406 [JEDI VCL] 00 JVCL Components major always 2015-05-15 15:18 2015-09-21 17:47
Reporter: mksjgj Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: TJvInterpreterProgram can not handle xor correctly
Description: the fellowing code will get a exception:
    
  JvInterpreterProgram1.Source := 'begin Result:=1 xor 2; end;';
  JvInterpreterProgram1.Run;

reason:
  the PaTokenizeTag(...) in JvInterpreterParser.pas can NOT recognize the token 'xor'. PaTokenizeTag('xor') will get -1 (P_UNKNOWN).
Tags:
Steps To Reproduce:
Additional Information: how to resolve:
change AssoIndices and AssoValues, help PaTokenizeTag recognize xor correctly.

   AssoIndices: array [0..31] of Integer = ( //lht: this one has no collisions
        { 0 1 2 3 4 5 6 7 8 9 }
    {00} 50, 80, 25, 13, 92, 71, 87, 61, 91, 99,
    {10} 73, 95, 27, 7, 16, 1, 96, 41, 91, 99,
    {20} 19, 15, 72, 1, 50, 30, 9, 6, 45, 27, //change 71 to 1,
    {30} 79, 61);

AssoValues: array [0..255] of Integer = ( //changeed according to AssoIndices
        { 0 1 2 3 4 5 6 7 8 9 }
    {00} -1, -1, -1, -1, -1, -1, 44, 10, -1, -1,
    {10} 37, -1, -1, -1, -1, 7, -1, -1, -1, -1,
    {20} -1, -1, -1, 27, -1, -1, -1, -1, -1, -1,
    {30} -1, 41, 26, -1, -1, 20, -1, -1, -1, 28,
    {40} -1, 30, 39, -1, -1, -1, -1, 13, -1, -1,
    {50} -1, -1, -1, -1, -1, -1, -1, 1, -1, -1,
    {60} -1, -1, -1, -1, -1, 12, -1, -1, -1, -1,
    {70} -1, -1, 6, -1, -1, -1, -1, -1, -1, -1,
    {80} 34, -1, -1, -1, -1, -1, 3, -1, -1, 49,
    {90} -1, -1, 45, -1, -1, -1, -1, -1, -1, -1,
    {100} 2, -1, 51, -1, -1, -1, -1, 46, -1, -1,
    {110}-1, -1, 17, -1, -1, -1, 36, -1, 11, -1,
    {120}-1, -1, 35, 48, -1, -1, -1, -1, 8, -1,
    {130}-1, 32, -1, 19, -1, -1, -1, 5, -1, -1,
    {140}40, -1, -1, -1, -1, -1, -1, -1, 21, -1,
    {150}22, -1, 31, -1, -1, -1, -1, -1, -1, 16,
    {160}43, -1, -1, -1, -1, -1, -1, -1, -1, -1,
    {170}-1, -1, 18, -1, -1, -1, -1, 47, -1, -1,
    {180}-1, -1, -1, -1, -1, -1, -1, 42, -1, -1,
    {190}-1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
    {200}-1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
    {210}-1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
    {220}29, -1, -1, 25, 4, 15, 24, -1, -1, -1,
    {230}-1, -1, 33, -1, -1, 9, -1, 50, -1, 14,
    {240}-1, -1, -1, 23, -1, -1, 38, -1, -1, -1,
    {250}-1, -1, -1, -1, -1, 0);
Attached Files:
There are no notes attached to this issue.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6390 [JEDI VCL] 00 JVCL Components minor always 2015-03-15 00:35 2015-09-21 17:47
Reporter: tecnobyte Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version:  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: JVCL 3.48 - DWORD_PTR type problem with Delphi 7
Description: On unit TJvRichEditStrings.pas:

dwCookie := DWORD_PTR(AConverter);

and

dwCookie := DWORD_PTR(Cookie);

The DWORD_PTR not found in Delphi7.

Solve:

dwCookie := {$IFDEF COMPILER19_UP}DWORD_PTR{$ELSE}Longint{$ENDIF}(AConverter);

and

dwCookie := {$IFDEF COMPILER19_UP}DWORD_PTR{$ELSE}Longint{$ENDIF}(Cookie);

Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021150)
AHUser   
2015-03-15 11:03   
Already fixed (2014-05-08)
13a6de00518eac11b24696cef1af0ae4b8c38aef


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6389 [JEDI VCL] 00 JVCL Components crash always 2015-03-11 00:41 2015-09-21 17:47
Reporter: btt Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: JvGroupBox crashes when checkable, unchecked and navigating with shift+tab
Description: Given a JvGroupBox that has the checkable property enabled and the checked property False, navigating with the keyboard forwards (TAB) is fine. Navigating backwards (SHIFT+TAB) will crash when entering the groupbox.
Tags:
Steps To Reproduce:
Additional Information: The pas file just has the basic boilerplate:

unit JvGroupBoxCrash;

interface

uses
  Winapi.Windows, Winapi.Messages, System.SysUtils, System.Variants, System.Classes, Vcl.Graphics,
  Vcl.Controls, Vcl.Forms, Vcl.Dialogs, Vcl.StdCtrls, JvExStdCtrls, JvGroupBox;

type
  TForm1 = class(TForm)
    JvGroupBox1: TJvGroupBox;
    Edit1: TEdit;
    Edit2: TEdit;
    Button1: TButton;
    Button2: TButton;
    Button3: TButton;
  private
    { Private declarations }
  public
    { Public declarations }
  end;

var
  Form1: TForm1;

implementation

{$R *.dfm}

end.
Attached Files: JvGroupBoxCrash.dfm (1,313 bytes) 2015-03-11 00:41
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002611&type=bug
Notes
(0021148)
AHUser   
2015-03-11 19:37   
Fixed. The problem was the code in TJvCheckBox.SetFocus that redirected the focus what caused an endless recursion.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6387 [JEDI VCL] 00 JVCL Components block always 2015-03-01 16:30 2015-09-21 17:47
Reporter: sender Platform:  
Assigned To: AHUser OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: JvHidControllerClass compile failed with Delphi 7
Description: JvHidControllerClass compile failed with Delphi 7:
Error: JvHidControllerClass.pas(1661): Invalid typecast

line 1661:
Create(AOwner, TJvHidDeviceCreateError(nil)); // work around compiler issue with method overloading and method pointers

The compiler of Delphi 7 doesn't allow cast nil to "procedure of object".
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
Notes
(0021145)
sender   
2015-03-01 16:55   
here is my simple solution to this issue:

constructor TJvHidDeviceController.Create(AOwner: TComponent);
var
  a: TJvHidDeviceCreateError;
  b: TNotifyEvent;
begin
  a := nil;
  b := nil;
  TJvHidDeviceController.Create(AOwner, a, b);
end;
(0021149)
AHUser   
2015-03-11 19:39   
This was fixed in 61374bf805c827e53cd75163cc6ebbe1487df45a


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6379 [JEDI VCL] 04 Feature Request feature always 2015-01-29 13:46 2015-09-21 17:47
Reporter: npravdin Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: Select Encoding in LoadFromCSV & SaveToCSV functions
Description: There is no unicode support in LoadFromCSV & SaveToCSV functions. I wrote an unit that extends TJvStringGrid class:

type
  TJvStringGridMod = class(TJvStringGrid)
  public
    procedure LoadFromCSV(const FileName: string{$IFDEF UNICODE};
      Encoding: TEncoding{$ENDIF}; Separator: Char = ';'; QuoteChar: Char = '"';
      StripQuotes: Boolean = True);
    procedure SaveToCSV(const FileName: string{$IFDEF UNICODE};
      Encoding: TEncoding{$ENDIF}; Separator: Char = ';'; QuoteChar: Char = '"');
  end;

Please see the attachment.
Tags:
Steps To Reproduce:
Additional Information:
Attached Files: uJVStringGridMod.pas (3,955 bytes) 2015-01-29 13:46
https://issuetracker.delphi-jedi.org/file_download.php?file_id=0002607&type=bug
There are no notes attached to this issue.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6378 [JEDI VCL] 00 JVCL Components minor always 2015-01-25 12:24 2015-09-21 17:47
Reporter: Ernst Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: 3.47  
Product Build: Resolution: unable to reproduce  
Projection: none      
ETA: none Fixed in Version: 3.49  
    Target Version:  
Summary: Error in TJvRichEdit
Description: Delphi 7 does not know DWORD_PTR
Delphi 7 does not recognize

 {$IFDEF COMPILER19_UP}DWORD_PTR{$ELSE}Longint{$ENDIF}

ocurrence:
line: 1800
function StreamSave(dwCookie: {$IFDEF COMPILER19_UP}DWORD_PTR{$ELSE}Longint{$ENDIF}; pbBuff: PByte;
  cb: Longint; var pcb: Longint): Longint; stdcall;

line 1960:
function StreamLoad(dwCookie: {$IFDEF COMPILER19_UP}DWORD_PTR{$ELSE}Longint{$ENDIF}; pbBuff: PByte;
  cb: Longint; var pcb: Longint): Longint; stdcall;

line 1971:
function StreamLoadW(dwCookie: {$IFDEF COMPILER19_UP}DWORD_PTR{$ELSE}Longint{$ENDIF}; pbBuff: PByte;
  cb: Longint; var pcb: Longint): Longint; stdcall;

Delphi 7 cannot compile
dwCookie := DWORD_PTR(AConverter)
in line 6013
in procedure TJvRichEditStrings.DoExport(AConverter: TJvConversion);

in line 6065
in procedure TJvRichEditStrings.DoImport(AConverter: TJvConversion);
Tags:
Steps To Reproduce:
Additional Information:
Attached Files:
There are no notes attached to this issue.


View Issue Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
6377 [JEDI VCL] 00 JVCL Components major always 2015-01-23 11:46 2015-09-21 17:47
Reporter: CDametto Platform:  
Assigned To: obones OS:  
Priority: normal OS Version:  
Status: resolved Product Version: Daily / GIT  
Product Build: Resolution: fixed  
Projection: none      
E