View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002194 | JEDI VCL | 00 JVCL Components | public | 2004-10-04 09:36 | 2004-10-05 11:33 |
| Reporter | anonymous | Assigned To | user72 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.00 BETA 2 | ||||
| Target Version | Fixed in Version | 3.00 RC 1 | |||
| Summary | 0002194: TJvgSpeedButton creates its own TCanvas | ||||
| Description | TJvgSpeedButton inherits from TGraphicControl; thus, it inherits the TControlCanvas allocated there. However, it allocates its own TControlCanvas anyway, and uses it for painting. By using its own canvas, the canvas does not get the DC handle set by TGraphicControl.WMPaint, which means, among other things, it does not paint correctly if the owning control uses DoubleBuffered = true. | ||||
| Tags | No tags attached. | ||||
|
|
- Remove the FCanvas:TCanvas field in the class - Remove the GetCanvas function - change "property Canvas:TCanvas read GetCanvas;" to "property Canvas:TCanvas;" - Remove the FCanvas := TControlCanvas.Create etc from the constructor - Remove FCanvas.Free from the destructor - Rename all "FCanvas" to "Canvas" Does it work as before? |
|
|
No -- which is a good thing. It now renders correctly when placed on a DoubleBuffered panel. Otherwise, I don't notice any changes. By the way, you have: - change "property Canvas:TCanvas read GetCanvas;" to "property Canvas:TCanvas;" I changed that to "property Canvas;" -- without type or accessors, just made it public, which seems more idiomatic to me (does a typed redeclaration without accessors allow access to the property?) Also, I am the original reporter (I forgot to log in). |
|
|
>I changed that to "property Canvas;" Sorry, that was what I meant. |
|
|
Updated in CVS |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2004-10-04 09:36 | anonymous | New Issue | |
| 2004-10-04 23:41 |
|
Note Added: 0005298 | |
| 2004-10-04 23:41 |
|
Status | new => feedback |
| 2004-10-05 06:02 | glchapman | Note Added: 0005308 | |
| 2004-10-05 11:22 |
|
Note Added: 0005314 | |
| 2004-10-05 11:33 |
|
Status | feedback => resolved |
| 2004-10-05 11:33 |
|
Resolution | open => fixed |
| 2004-10-05 11:33 |
|
Assigned To | => user72 |
| 2004-10-05 11:33 |
|
Note Added: 0005319 |
