View Issue Details

IDProjectCategoryView StatusLast Update
0002493JEDI VCL00 JVCL Componentspublic2005-04-12 05:25
Reporterralf.kaiserAssigned Toremkobonte 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version3.00 
Summary0002493: jvEdit.Flat inside a frame does not work
DescriptionWhen a TjvEdit is used inside a TFrame with "Flat=true" the flat style is gone at runtime. At designtime it looks OK.
Steps To Reproducesample project and screenshots included
TagsNo tags attached.

Activities

2005-01-10 06:06

 

Screenshot_designtime.bmp (36,754 bytes)
Screenshot_designtime.bmp (36,754 bytes)

2005-01-10 06:07

 

Screenshot_runtime.bmp (36,754 bytes)
Screenshot_runtime.bmp (36,754 bytes)

2005-01-10 06:07

 

Testproject.zip (1,915 bytes)

user72

2005-01-12 05:43

  ~0006128

Seems Ctrl3D is default true in a form, but default false in a frame. Probably has to do with dfm reading vs. creation order. This fixes it, AFAICS:

procedure TJvCustomEdit.SetFlat(Value: Boolean);
begin
  if Value <> FFlat then
  begin
    FFlat := Value;
    {$IFDEF VCL}
    Ctl3D := FFlat; // NEW
    Ctl3D := not FFlat;
    {$ENDIF VCL}
    {$IFDEF VisualCLX}
    if FFlat then
      BorderStyle := bsNone
    else
      BorderStyle := bsSingle;
    Invalidate;
    {$ENDIF VisualCLX}
  end;
end;

obones

2005-01-17 03:05

administrator   ~0006165

Following on the messages in jedi.vcl, can we consider this resolved?

remkobonte

2005-01-17 12:25

developer   ~0006187

IMO ParentCtl3D should be republished to truely fix the problem.

ralf.kaiser

2005-01-22 07:14

reporter   ~0006250

It has been discussed in the newsgroup that these changes would make TjvEdit.Flat work again (i have tested it on my local installtion) but it seems that this change has not been integrated into the source yet (just made a checkout to check it)

obones

2005-01-22 10:01

administrator   ~0006255

This is now fixed in CVS and will be in JVCL 3.00 Stable

ralf.kaiser

2005-02-14 01:12

reporter   ~0006492

jvEdit.Flat is working now but all maskedit type controls (e.g. TJvCustomComboEdit) still have the same problem that "Flat" is not correct displayed at runtime when the controls are placed in a frame.

user72

2005-02-21 15:54

  ~0006542

>IMO ParentCtl3D should be republished to truely fix the problem.
And so should Ctl3D. The silliness of renaming Ctl3D to Flat just to look more "modern" is what caused this in the first place.

remkobonte

2005-03-06 15:54

developer   ~0006644

I've added the ParentClt3D property to all controls that have a Flat property and reworked the storage logic of the Flat property a bit.

Please check if it works now.

obones

2005-04-12 05:25

administrator   ~0006938

No answers for more than a month, this is considered to be resolved

Issue History

Date Modified Username Field Change
2005-01-10 06:05 ralf.kaiser New Issue
2005-01-10 06:06 ralf.kaiser File Added: Screenshot_designtime.bmp
2005-01-10 06:07 ralf.kaiser File Added: Screenshot_runtime.bmp
2005-01-10 06:07 ralf.kaiser File Added: Testproject.zip
2005-01-12 05:43 user72 Note Added: 0006128
2005-01-12 05:43 user72 Status new => feedback
2005-01-17 03:05 obones Note Added: 0006165
2005-01-17 12:25 remkobonte Note Added: 0006187
2005-01-22 07:14 ralf.kaiser Note Added: 0006250
2005-01-22 10:01 obones Status feedback => resolved
2005-01-22 10:01 obones Fixed in Version => 3.00
2005-01-22 10:01 obones Resolution open => fixed
2005-01-22 10:01 obones Assigned To => obones
2005-01-22 10:01 obones Note Added: 0006255
2005-02-14 01:12 ralf.kaiser Assigned To obones =>
2005-02-14 01:12 ralf.kaiser Status resolved => feedback
2005-02-14 01:12 ralf.kaiser Resolution fixed => reopened
2005-02-14 01:12 ralf.kaiser Note Added: 0006492
2005-02-21 15:54 user72 Note Added: 0006542
2005-03-04 10:22 remkobonte Status feedback => assigned
2005-03-04 10:22 remkobonte Assigned To => remkobonte
2005-03-06 15:54 remkobonte Note Added: 0006644
2005-03-06 15:54 remkobonte Status assigned => feedback
2005-04-12 05:25 obones Status feedback => resolved
2005-04-12 05:25 obones Resolution reopened => fixed
2005-04-12 05:25 obones Note Added: 0006938