View Issue Details

IDProjectCategoryView StatusLast Update
0002667JEDI VCL00 JVCL Componentspublic2005-04-22 07:38
ReportervrtaregAssigned Toobones 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.00 BETA 2 
Target VersionFixed in Version3.10 
Summary0002667: Errors in qrun\JvQSpin.pas and run\JvSpin.pas
DescriptionI found errors in qrun\JvQSpin.pas and run\JvSpin.pas files.

When i put to Form TJvSpin edit and set spin type to Standard, i cant increase the value of this SpinEdit, because in JvQSpin.pas(procedure TJvUpDown.Click(Button: TUDBtnType); line 1756, file version 1.56) and JvSpin.pas(procedure TJvUpDown.Click(Button: TUDBtnType); line 2008, file version 1.68) calls Click procedure with the same "btPrev" parameter.
TagsNo tags attached.

Activities

obones

2005-04-12 06:42

administrator   ~0006954

As this is VisualClx code, I require your feedback.
Could you confirm it works fine when setting the second btPrev to btNext so that it is used when Pos >= 0
Thanks for your help

vrtareg

2005-04-12 06:58

reporter   ~0006956

i change the following code in both sources VCL and CLX
and after that jvSpin edit start works correctly.

-----------------
procedure TJvUpDown.Click(Button: TUDBtnType);
var
  Pos: Integer;
begin
  if not FChanging then
  begin
    FChanging := True;
    try
      Pos := Position;
      UpdatePosition(0);
    finally
      FChanging := False;
    end;
    if Pos < 0 then
      inherited Click(btPrev)
    else
!!!!!!!!!!!!!!!!!!!!!!
      inherited Click(btPrev) -> inherited Click(btNext)
!!!!!!!!!!!!!!!!!!!!!!
  end;
end;

-----------------

obones

2005-04-22 07:38

administrator   ~0007047

Thanks, this is now fixed in CVS.

Issue History

Date Modified Username Field Change
2005-02-21 00:24 vrtareg New Issue
2005-04-12 06:42 obones Note Added: 0006954
2005-04-12 06:42 obones Status new => feedback
2005-04-12 06:58 vrtareg Note Added: 0006956
2005-04-22 07:38 obones Status feedback => resolved
2005-04-22 07:38 obones Resolution open => fixed
2005-04-22 07:38 obones Assigned To => obones
2005-04-22 07:38 obones Note Added: 0007047