View Issue Details

IDProjectCategoryView StatusLast Update
0002871JEDI VCL00 JVCL Componentspublic2005-04-23 01:19
ReporteranonymousAssigned ToAHUser 
Status resolvedResolutionfixed 
Product Version3.00 
Target VersionFixed in Version3.10 
Summary0002871: TJvCustomGraphicButton.Click calls inherited in the wrong order
DescriptionTJvCustomGraphicButton.Click currently calls "inherited Click" at the top of the procedure. I think it should be at the bottom.

Rationale: This procedure mainly changes the state of the button's Down flag, while the inherited procedure mainly calls any registered OnClick handlers. It's more usual to expect that an OnXX event is called *after* the class has provided default behavior than vice versa. In this particular case, it's natural to implement an OnClick handler that sets the Down property itself according to app-specific logic; you can't do that, though, because TJvCustomGraphicButton.Click will then reverse the state of the down property afterwards.
TagsNo tags attached.



2005-04-13 12:21

reporter   ~0007000

Sorry, didn't think to make an account first. I'm the reporter.


2005-04-23 01:19

developer   ~0007052

Fixed in CVS.

Issue History

Date Modified Username Field Change
2005-04-13 12:17 anonymous New Issue
2005-04-13 12:21 teejaydub Note Added: 0007000
2005-04-23 01:19 AHUser Status new => resolved
2005-04-23 01:19 AHUser Resolution open => fixed
2005-04-23 01:19 AHUser Assigned To => AHUser
2005-04-23 01:19 AHUser Note Added: 0007052