View Issue Details

IDProjectCategoryView StatusLast Update
0003097JEDI VCL00 JVCL Componentspublic2005-08-09 03:45
ReporterwaskolAssigned Toobones 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.00 
Target VersionFixed in Version3.10 
Summary0003097: Fix for TJvCustomGraphicButton and descendants --> Button remains "down"
DescriptionHere the fix from Bogdan Ribic reported on the web news group :
- Link : http://delphi.newswhat.com/geoxml/forumgetthread?groupname=jedi.vcl&messageid=dbhoii$cf7$1@talkto.net&displaymode=all

- His Fix and comments :
Hi everyone,

   I noticed a problem with JvTransparentButton, namely if you click it
and an exception occurs in event handler, button remains "down" as if I
was still holding the mouse button. It will return to normal after it
receives another mosue down event.

   Now, this makes my program look really unprofessional :) , so I
hacked the source code a little and came up with this:

procedure TJvCustomGraphicButton.Click;
begin
   try
     inherited Click;
   finally
     if GroupIndex <> 0 then
     begin
       if AllowAllUp then
         Down := not Down
       else
         Down := True;
     end;
     Exclude(FStates, bsMouseDown);
     RepaintBackground;
   end;
end;


   This is in file JvButton.pas, line 638. Only Exclude and
RepaintBackground lines are new, and exception block, but they solve the
problem.

   Anyway, I'm too lazy to go through Mantis and formally submit this,
so if you guys like it, please put this little fix into code base.

   Btw, thanx for all the great code.

Boban.
Additional InformationIt works nicely.
TagsNo tags attached.

Activities

obones

2005-07-27 01:19

administrator   ~0007626

This needs to be confirmed by someone. When it is, please push the issue to "Confirmed" state.

obones

2005-08-09 03:45

administrator   ~0007705

This is now in CVS.

Issue History

Date Modified Username Field Change
2005-07-19 01:19 waskol New Issue
2005-07-27 01:19 obones Note Added: 0007626
2005-07-27 01:19 obones Status new => acknowledged
2005-08-09 03:45 obones Status acknowledged => resolved
2005-08-09 03:45 obones Resolution open => fixed
2005-08-09 03:45 obones Assigned To => obones
2005-08-09 03:45 obones Note Added: 0007705