View Issue Details

IDProjectCategoryView StatusLast Update
0003417JEDI VCL00 JVCL Componentspublic2006-01-23 11:15
ReporterelahnAssigned Toelahn 
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version3.20 
Summary0003417: TJvLabel causes TComboBox to close up
DescriptionWhen a TComboBox is DroppedDown, moving the mouse over TJvLabel causes it to close up.

This is due to the MouseCapture code in TJvCustomLabel.MouseEnter & MouseLeave. The attached patch file removes this code.

I haven't committed the changes, as I can't see why this code was put there in the first place. If there are no objections within the next week, I'll commit it.
TagsNo tags attached.


2006-01-05 09:52


JvLabel.pas.patch (741 bytes)
Index: run/JvLabel.pas
RCS file: /cvsroot/jvcl/dev/JVCL3/run/JvLabel.pas,v
retrieving revision 1.82
diff -u -r1.82 JvLabel.pas
--- run/JvLabel.pas	28 Oct 2005 08:37:23 -0000	1.82
+++ run/JvLabel.pas	5 Jan 2006 16:59:32 -0000
@@ -1321,9 +1321,6 @@
   if csDesigning in ComponentState then
-  if IsForegroundTask then
-    MouseCapture := True;  //Capture for MouseUp event
   if not MouseOver and Enabled and IsForegroundTask then
     OtherDragging :=
@@ -1358,7 +1355,6 @@
   if csDesigning in ComponentState then
-  MouseCapture := False;
   if  MouseOver and Enabled then
     OtherDragging :=
JvLabel.pas.patch (741 bytes)


2006-01-08 09:02

administrator   ~0008338

I think it has to do with the Drag and Drop modes. Please investigate in this area.


2006-01-08 12:07

developer   ~0008345

Last edited: 2006-01-11 02:55

It was introduced in v1.77 along with the implementation of IJvHotTrack, which you committed for Dejoy Den (Mantis 0003107).

I don't know much about drag & drop, but if MouseCapture is needed for that then shouldn't it be set/unset in MouseDown/MouseUp, not in MouseEnter/MouseLeave?

From what I can see (in D7 on Win2k) removing this code actually improves the HotTrack handling when dragging occurs. With the code (current in CVS) if you drag the label and drop somewhere else on the form, then move the mouse back over the label, it doesn't hottrack. Removing the code (as per the patch) fixes this behaviour.


2006-01-23 11:15

developer   ~0008430

Now in CVS.

Issue History

Date Modified Username Field Change
2006-01-05 09:52 elahn New Issue
2006-01-05 09:52 elahn File Added: JvLabel.pas.patch
2006-01-08 09:02 obones Note Added: 0008338
2006-01-08 09:02 obones Status new => feedback
2006-01-08 12:07 elahn Note Added: 0008345
2006-01-11 02:55 elahn Note Edited: 0008345
2006-01-23 11:15 elahn Status feedback => resolved
2006-01-23 11:15 elahn Resolution open => fixed
2006-01-23 11:15 elahn Assigned To => elahn
2006-01-23 11:15 elahn Note Added: 0008430