View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003467JEDI VCL02 Installationpublic2006-01-25 03:482006-01-26 11:46
Reporterivan_raAssigned ToAHUser 
PrioritynormalSeverityblockReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.10 
Target VersionFixed in Version3.20 
Summary0003467: Install fails when JCL installed in non-standart path (with decision)
DescriptionI have jcl 1.96 installed in non-standart path:
C:\Borland\BDS\3.0\Projects\Bpl
In BDS IDE macros $(BDSPROJECTDIR) redeclared as "$(BDS)\Projects".
But JVCL installer cant recognize it and assumes what JCL is not installed (look at screenshot).
JVCL 3.0 has not this problem.
Additional InformationThe cause of problem is code of function TCompileTarget.ReadBDSProjectsDir (delphidata.pas).

This code does not recognize redeclared 'bdsprojectsdir' macros and always returns standart path. But it can be readed from registry:
"HCU\Software\Borland\BDS\3.0\Environment Variables\BDSPROJECTDIR"
(can be expanded from TCompileTarget.FHKLMRegistryKey or TCompileTarget.FRegistryKey)
TagsNo tags attached.

Relationships

related to 0003384 resolvedAHUser Installation of JVCL for Delphi 2005 

Activities

2006-01-25 03:49

 

JVCLInstall.JPG (41,033 bytes)
JVCLInstall.JPG (41,033 bytes)

ivan_ra

2006-01-25 03:57

developer   ~0008450

Last edited: 2006-01-25 03:59

 Sorry, the key is
HCU\Software\Borland\BDS\3.0\Environment Variables\BDSPROJECTSDIR
,and in other places BDSPROJECTSDIR too (lost "S")

ivan_ra

2006-01-25 12:53

developer   ~0008454

I think issue 0003384 is the same

ivan_ra

2006-01-26 05:00

developer   ~0008460

This is patch and screenshots of successfully install

2006-01-26 05:00

 

DelphiData.pas.patch (839 bytes) 
Index: install/JVCLInstall/DelphiData.pas
===================================================================
RCS file: /cvsroot/jvcl/dev/JVCL3/install/JVCLInstall/DelphiData.pas,v
retrieving revision 1.22
diff -u -r1.22 DelphiData.pas
--- install/JVCLInstall/DelphiData.pas	4 Dec 2005 10:22:50 -0000	1.22
+++ install/JVCLInstall/DelphiData.pas	26 Jan 2006 12:05:50 -0000
@@ -562,6 +562,13 @@
 
     Reg.RootKey := HKEY_CURRENT_USER;
 
+    if IsBDS and Reg.OpenKeyReadOnly(HKLMRegistryKey+'\Environment Variables') then // do not localize
+    begin
+      if Reg.ValueExists('BDSPROJECTSDIR') then
+        FBDSProjectsDir := ExpandDirMacros(Reg.ReadString('BDSPROJECTSDIR')); // do not localize
+      Reg.CloseKey;
+    end;
+
     if Reg.OpenKeyReadOnly(RegistryKey) then
     begin
      // obtain updates state
DelphiData.pas.patch (839 bytes)

2006-01-26 05:00

 

JVCLInstall1.JPG (40,440 bytes)
JVCLInstall1.JPG (40,440 bytes)

2006-01-26 05:01

 

JVCLInstall2.JPG (60,450 bytes)
JVCLInstall2.JPG (60,450 bytes)

2006-01-26 05:21

 

Success.JPG (52,415 bytes)
Success.JPG (52,415 bytes)

AHUser

2006-01-26 11:46

developer   ~0008467

Fixed in CVS.

Issue History

Date Modified Username Field Change
2006-01-25 03:48 ivan_ra New Issue
2006-01-25 03:49 ivan_ra File Added: JVCLInstall.JPG
2006-01-25 03:57 ivan_ra Note Added: 0008450
2006-01-25 03:59 ivan_ra Note Edited: 0008450
2006-01-25 12:53 ivan_ra Note Added: 0008454
2006-01-26 05:00 ivan_ra Note Added: 0008460
2006-01-26 05:00 ivan_ra File Added: DelphiData.pas.patch
2006-01-26 05:00 ivan_ra File Added: JVCLInstall1.JPG
2006-01-26 05:01 ivan_ra File Added: JVCLInstall2.JPG
2006-01-26 05:21 ivan_ra File Added: Success.JPG
2006-01-26 06:04 obones Relationship added related to 0003384
2006-01-26 11:46 AHUser Status new => resolved
2006-01-26 11:46 AHUser Resolution open => fixed
2006-01-26 11:46 AHUser Assigned To => AHUser
2006-01-26 11:46 AHUser Note Added: 0008467