View Issue Details

IDProjectCategoryView StatusLast Update
0005000JEDI VCL00 JVCL Componentspublic2009-10-29 20:00
ReporterCyrusAssigned ToAHUser 
PrioritynormalSeverityblockReproducibilityalways
Status resolvedResolutionfixed 
Product VersionDaily / GIT 
Target VersionFixed in Version3.39 
Summary0005000: SVN Revision 12583 fails to install properly.
DescriptionWhen trying to install JEDI VCL components using its own installer, these errors occur:

[Compiling: JvAppFrmD7R.bpl]
"\Borland\Delphi 7\Bin\dcc32.exe" JvAppFrmD7R.dpk
Borland Delphi Version 15.0
Copyright (c) 1983,2002 Borland Software Corporation
\delphi\jvcl\run\JvAppEvent.pas(294) Error: Undeclared identifier: 'OnModalBegin'
\delphi\jvcl\run\JvAppEvent.pas(294) Error: Not enough actual parameters
\delphi\jvcl\run\JvAppEvent.pas(295) Error: Undeclared identifier: 'OnModalEnd'
\delphi\jvcl\run\JvAppEvent.pas(295) Error: Not enough actual parameters
JvAppFrmD7R.dpk(63) Fatal: Could not compile used unit '..\..\run\JvAppEvent.pas'
TagsNo tags attached.

Activities

Cyrus

2009-10-29 10:02

reporter   ~0016844

Looks like that TApplicationEvents does have OnModalBegin/OnModalEnd but they are protected class members.

2009-10-29 10:19

 

JvAppEvent.pas.diff (612 bytes)
--- JvAppEvent.pas	Thu Oct 29 08:18:31 2009
+++ JvAppEvent.pas	Thu Oct 29 11:10:08 2009
@@ -191,14 +191,23 @@
 
 implementation
 
 uses
   AppEvnts;
 
 type
+  TApplicationEvents = class(AppEvnts.TApplicationEvents)
+    published
+    {$IFDEF COMPILER7_UP}
+      property OnModalBegin;
+      property OnModalEnd;
+    {$ENDIF COMPILER7_UP}  
+  end;
+
+type
   TJvAppEventList = class(TComponent)
   private
     FApplicationEvents: TApplicationEvents;
     FAppEvents: TList;
     FHooked: Boolean;
     FOnActiveControlChange: TNotifyEvent;
     FOnActiveFormChange: TNotifyEvent;
JvAppEvent.pas.diff (612 bytes)

Cyrus

2009-10-29 10:21

reporter   ~0016845

I have attached patch which will fix this problem. This needs testing, thought.

AHUser

2009-10-29 20:00

developer   ~0016847

Fixed in SVN.

Issue History

Date Modified Username Field Change
2009-10-29 08:26 Cyrus New Issue
2009-10-29 10:02 Cyrus Note Added: 0016844
2009-10-29 10:19 Cyrus File Added: JvAppEvent.pas.diff
2009-10-29 10:21 Cyrus Note Added: 0016845
2009-10-29 20:00 AHUser Note Added: 0016847
2009-10-29 20:00 AHUser Status new => resolved
2009-10-29 20:00 AHUser Fixed in Version => Daily / SVN
2009-10-29 20:00 AHUser Resolution open => fixed
2009-10-29 20:00 AHUser Assigned To => AHUser