View Issue Details

IDProjectCategoryView StatusLast Update
0005025JEDI VCL00 JVCL Componentspublic2009-12-18 11:55
Reporterjb144Assigned Tojfudickar 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionDaily / GIT 
Target Version3.40Fixed in Version3.40 
Summary0005025: FormStorage does not restore Form to maximized
DescriptionSince revision 12560 JvFormStorage does not restore a Form to maximized state. Tested with Delphi 2007 and Delphi 2009. I switched back and forth twice. With revision 12559 it's ok, but with revision 12560 and also 12607 it's not. For me the changes in JvJVCLUtils.pas from 12559 to 12560 seems only relevant to Delphi 2010 or not relevant for the WindowState.
TagsNo tags attached.

Activities

jb144

2009-11-18 12:09

reporter   ~0016895

So I compiled the developer installation and debugged InternalRestoreFormPlacement. It's seems that the else branch to set Form.WindowState is missing for Delphi before 2010.

2009-11-18 12:09

 

JvJVCLUtils.patch (502 bytes)
*** C:/Dokumente und Einstellungen/busseju/Lokale Einstellungen/Temp/JvJVCLUtils.pas-revBASE.svn000.tmp.pas	Wed Nov 18 12:01:54 2009
--- U:/Proj/Delphi/jvcl/run/JvJVCLUtils.pas	Wed Nov 18 11:57:14 2009
***************
*** 4150,4155 ****
--- 4150,4156 ----
      if Form.FormStyle in [fsMDIChild, fsMDIForm] then
        TWindowState(Pointer(@Form.WindowState)^) := WinState
      else
+       Form.WindowState := WinState;
      {$ELSE}
        Form.WindowState := WinState;
      {$ENDIF}
JvJVCLUtils.patch (502 bytes)

obones

2009-12-04 15:26

administrator   ~0016941

Thanks for this, we will review it

jfudickar

2009-12-06 21:39

developer   ~0016971

Fixed in Revision 12614

Thanks for the hint. It was my fault :-(

Issue History

Date Modified Username Field Change
2009-11-18 11:26 jb144 New Issue
2009-11-18 12:09 jb144 Note Added: 0016895
2009-11-18 12:09 jb144 File Added: JvJVCLUtils.patch
2009-12-04 15:26 obones Note Added: 0016941
2009-12-04 15:26 obones Status new => acknowledged
2009-12-06 21:39 jfudickar Note Added: 0016971
2009-12-06 21:39 jfudickar Status acknowledged => resolved
2009-12-06 21:39 jfudickar Fixed in Version => 3.40 - not yet released
2009-12-06 21:39 jfudickar Resolution open => fixed
2009-12-06 21:39 jfudickar Assigned To => jfudickar
2009-12-18 11:55 obones Target Version => 3.40 - not yet released