View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005460JEDI VCL00 JVCL Componentspublic2011-01-17 22:152011-01-28 01:15
ReportergrubsteAssigned Tojfudickar 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionDaily / GIT 
Target VersionFixed in Version 
Summary0005460: Warning W1058 for all calls to NameThread(ThreadName)
DescriptionAfter recent changes (probably) to code regarding thread handling, all calls in all JVCL components to "NameThread(ThreadName)" raise warning W1058 "implicit string to ansistring conversion with possible data loss".
Steps To ReproduceUse the full JVCL daily revision package and the installer und compile under unicode aware IDE (D2009+).
Additional InformationFor all occurrences see screenshot.
TagsNo tags attached.

Activities

2011-01-17 22:15

 

2011-01-17_215906.png (20,336 bytes)
2011-01-17_215906.png (20,336 bytes)

grubste

2011-01-17 22:25

reporter   ~0018302

The source of the evil might be in JvTypes.pas and the definition of the methods and properties of the class procedure TJvCustomThread:

type
  TJvCustomThread = class(TThread)
  private
    FThreadName: String;
    function GetThreadName: String; virtual;
    procedure SetThreadName(const Value: String); virtual;
  public
    {$IFNDEF DELPHI2010_UP}
    procedure NameThreadForDebugging(AThreadName: AnsiString; AThreadID: LongWord = $FFFFFFFF);
    {$ENDIF}
    procedure NameThread(AThreadName: AnsiString; AThreadID: LongWord = $FFFFFFFF); virtual;
    property ThreadName: String read GetThreadName write SetThreadName;
  end;

We have a wild mixture of strings and ansistrings here.

jfudickar

2011-01-28 01:15

developer   ~0018322

Changed in SubVersion.

Sorry that I had overseen this.

Regards
Jens

Issue History

Date Modified Username Field Change
2011-01-17 22:15 grubste New Issue
2011-01-17 22:15 grubste File Added: 2011-01-17_215906.png
2011-01-17 22:25 grubste Note Added: 0018302
2011-01-22 12:21 jfudickar Assigned To => jfudickar
2011-01-22 12:21 jfudickar Status new => acknowledged
2011-01-28 01:15 jfudickar Note Added: 0018322
2011-01-28 01:15 jfudickar Status acknowledged => resolved
2011-01-28 01:15 jfudickar Resolution open => fixed