View Issue Details

IDProjectCategoryView StatusLast Update
0005586JEDI VCL00 JVCL Componentspublic2012-06-11 17:10
ReportertetarddAssigned Toobones 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionsuspended 
Product Version3.40 
Target VersionFixed in Version 
Summary0005586: TJvTreeView.OnNodeCheckedChange triggered when moving tree node
DescriptionIf you have a tree view with CheckBoxes set to True and you move a tree node calling TJvTreeNode.MoveTo(xxx, naInsert), for example to change their ordering, the OnNodeCheckedChange event is triggered.

See attached example: Click on the button 3-4 times, and see the memo show the event triggered.

This seems to be contrary to logical expectations, changing a node position have nothing to do with changing its checked state.

Additionally, you'll also notice in the sample that the event is triggered only twice (clicking the first 2 times trigger the event, then the 3rd, 4th click do not trigger it any longer), so there's underlying flaws that make that behaviour really inconsistent.
TagsNo tags attached.

Activities

2011-05-28 09:06

 

Bug JvTreeView.zip (619,578 bytes)

obones

2011-06-08 16:20

administrator   ~0018688

It's a bit more subtle than simply moving. The items are deleted, then readded. This means their check state has to be updated

tetardd

2011-06-15 09:07

reporter   ~0018766

Correct, but as this is an unexpected event (illogical), maybe the firing of the event should be prevented by a simple locking mechanism.

obones

2011-09-21 11:45

administrator   ~0018920

Might be yes. If you could provide a patch, that would be even better

2011-11-09 10:23

 

JvComCtrls.zip (22,235 bytes)

tetardd

2011-11-09 10:25

reporter   ~0019102

Attached is my proposed fix (please review and inform me if that seems acceptable to you), see where I marked the code with "David Tetard". I have only fixed the OnNodeCheckedChange event for now. I'll test other events and submit a fuller fix soon.

tetardd

2011-11-09 10:30

reporter   ~0019103

OK, I tested two other events, OnAddition and OnDeletion and they are not triggered unduly so I guess my proposed fix, if accepted by you will close that bug.

obones

2012-02-24 16:23

administrator   ~0019538

Please try latest SVN content (revision 13227 or newer), I can't reproduce the issue with it

obones

2012-06-11 17:10

administrator   ~0019824

No answers, suspending the issue

Issue History

Date Modified Username Field Change
2011-05-28 09:06 tetardd New Issue
2011-05-28 09:06 tetardd File Added: Bug JvTreeView.zip
2011-06-07 18:01 obones Status new => acknowledged
2011-06-08 16:20 obones Note Added: 0018688
2011-06-08 16:20 obones Status acknowledged => feedback
2011-06-15 09:07 tetardd Note Added: 0018766
2011-09-21 11:45 obones Note Added: 0018920
2011-11-09 10:23 tetardd File Added: JvComCtrls.zip
2011-11-09 10:25 tetardd Note Added: 0019102
2011-11-09 10:30 tetardd Note Added: 0019103
2012-02-22 14:46 obones Assigned To => obones
2012-02-22 14:46 obones Status feedback => acknowledged
2012-02-24 16:23 obones Note Added: 0019538
2012-02-24 16:23 obones Status acknowledged => feedback
2012-06-11 17:10 obones Note Added: 0019824
2012-06-11 17:10 obones Status feedback => resolved
2012-06-11 17:10 obones Resolution open => suspended