View Issue Details

IDProjectCategoryView StatusLast Update
0005607JEDI VCL99 Otherpublic2012-09-10 14:15
ReporterMoritz BeutelAssigned Toobones 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionDaily / GIT 
Target VersionFixed in Version3.46 
Summary0005607: Packages Generator: GetRelativePath() fails if Destination is above Orgin
DescriptionThe attached test case (FileUtilsProblem.pas) exhibits the problem. This is the output it yields:
// -----
Orig: jvcl\packages\d15
Dest: jvcl\run
ExpDiff: ..\..\run
Diff: ..\..\run

Orig: E:\jvcl\packages\d15
Dest: E:\jvcl\run\windows
ExpDiff: ..\..\run\windows
Diff: ..\..\run\windows

Orig: dcf\src\packages\d15
Dest: dcf\src
ExpDiff: ..\..
EStringListError: Listenindex ³berschreitet das Maximum (2)

FAIL
// -----

This is why the package generator currently doesn't work for directory layouts which fall into this category.

The attached fix makes GetRelativePath() work correctly (and also fixes a potential AV).
TagsNo tags attached.

Activities

2011-06-26 02:21

 

FileUtilsProblem.zip (1,327 bytes)

obones

2011-09-21 14:07

administrator   ~0018952

This is now in SVN.
Note that the "potential AV" is a non issue, if one occurs in the constructor of TStringList, the rest of the program is doomed anyway.

Issue History

Date Modified Username Field Change
2011-06-26 02:21 Moritz Beutel New Issue
2011-06-26 02:21 Moritz Beutel File Added: FileUtilsProblem.zip
2011-09-21 11:49 obones Assigned To => obones
2011-09-21 11:49 obones Status new => acknowledged
2011-09-21 14:07 obones Note Added: 0018952
2011-09-21 14:07 obones Status acknowledged => resolved
2011-09-21 14:07 obones Fixed in Version => Daily / SVN
2011-09-21 14:07 obones Resolution open => fixed
2012-09-10 14:15 obones Fixed in Version Daily / SVN => 3.46