View Issue Details

IDProjectCategoryView StatusLast Update
0005624JEDI VCL00 JVCL Componentspublic2012-02-23 12:27
Reporterdjsmith9Assigned Toobones 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionunable to reproduce 
Product Version3.38 
Target VersionFixed in Version 
Summary0005624: JVCL338CompleteJCL201-Build3449
DescriptionTDateEdit component, based on old RXLibrary component has always had the annoying and ugly "feature" of 3 letter Day names all scrunched together at the top. I replaced these 3 letter Day Names with 1 or two letter where necessary - now it looks useable!

The updated file uploaded is for D7 Enterprise.
Additional InformationVery simple and straightforward modification of JVPickDate.pas:

Defined a new array constant:

ExShortDayNames: array[1..7] of string = ('Su', 'M', 'T', 'W', 'Th', 'F', 'Sa');

and placed it at line 143, right below another constant
PopupCalendarSize: TPoint = (X: 187; Y: 124);

Then referenced this constant instead of ShortDayNames[1..7]. located in SysUtils.pas at line 372:

function TJvCalendar.GetCellText(ACol, ARow: Integer): string;
  DayNum: Integer;
  if ARow = 0 then { day names at tops of columns }
    Result := ExShortDayNames[(Ord(StartOfWeek) + ACol) mod 7 + 1] <- line 382
    DayNum := FMonthOffset + ACol + (ARow - 1) * 7;
    if (DayNum < 1) or (DayNum > DaysThisMonth) then
      Result := ''
      Result := IntToStr(DayNum);

TagsNo tags attached.


2011-07-26 06:30


JvPickDate.pas (47,839 bytes)


2011-09-21 11:57

administrator   ~0018938

Please provide the zipped sources of a sample application showing this


2011-09-21 16:35

reporter   ~0018966

I've already modified my source code to implement the changes. You can easily see what I'm talking about by starting a new project and dropping the aforementioned JVPickDate component onto the form however! The above file explains how to implement the changes to improve the appearance of the component. If you don't want to do it, that's perfectly fine with with me - I was just trying to help the project!


2011-09-22 11:32

administrator   ~0018970

It's not that I don't want to do it, it's just that having an existing project reduces the time it takes me to test to the minimum.
I don't have that much time to work on the JVCL and the less time I waste, the better for everyone


2011-09-22 16:43

reporter   ~0018973

I'm not really clear on what it's supposed to show. You want a sample source APP (I.E. an EXE with a form with component on it) showing the scrunched up date titles, or an APP EXE showing the new 1-2 letter date titles?
   OR, do you want sample source for the old component, OR sample source of the new component so all you have to do is compile it into the new JVCL?
   Please be crystal clear about what you want so I'm not running around doing unnecessary things too; I also am short on time for such things. Thanks!


2011-09-22 16:55

administrator   ~0018974

Well, I thought that "sources of a sample application showing this" was clear enough.
What I want are the source files (pas, dfm, dpr, dproj) of an application that I can compile myself and that once I run it shows unequivocally the issue you are referring to.


2011-09-22 17:08

reporter   ~0018975

Okay, that's what I thought. Unfortunately, I cannot provide this because I have already modified the source to effect the desired improvement but as I said, you can easily see it by dropping a PickDate component on a form in a new project and compiling - we're talking about less than one minute of your time here!
   I can send an already compiled project showing the improvement with no undesired side effects... seems to me that this would be considerably more useful in moving this thing forward.

Issue History

Date Modified Username Field Change
2011-07-26 06:30 djsmith9 New Issue
2011-07-26 06:30 djsmith9 File Added: JvPickDate.pas
2011-09-21 11:57 obones Note Added: 0018938
2011-09-21 11:57 obones Status new => feedback
2011-09-21 16:35 djsmith9 Note Added: 0018966
2011-09-22 11:33 obones Note Added: 0018970
2011-09-22 16:43 djsmith9 Note Added: 0018973
2011-09-22 16:55 obones Note Added: 0018974
2011-09-22 17:08 djsmith9 Note Added: 0018975
2012-02-23 12:27 obones Status feedback => resolved
2012-02-23 12:27 obones Resolution open => unable to reproduce
2012-02-23 12:27 obones Assigned To => obones