View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005695 | JEDI VCL | 00 JVCL Components | public | 2011-10-28 14:48 | 2012-09-10 14:15 |
| Reporter | inprosis | Assigned To | obones | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | Daily / GIT | ||||
| Target Version | Fixed in Version | 3.46 | |||
| Summary | 0005695: tjvcolorbutton does not get focus | ||||
| Description | tjvcolorbutton does not get focus from previous field with tab or enter but with Shift tab from next field works fine | ||||
| Tags | No tags attached. | ||||
|
|
can u double-check this ??? it is weird, it SHOULD NOT acquire focus on Shift+Tab. What is OS, Delphi and JVCL version. i try in XE2-Upd2 / Win7x64 / JVCL SVN and it does not acquire focus both directions. Here there are two bugs i thinks. 1) i can confirm - focus is not acquired on Tab/Shift+Tab. Really stupid bug. Someone changed one place and forgotten another. Outcome - focus should be acquired in nether directions. 2) i can not confirm - focus is acquired on Shift+Tab while should not, due to 1st bug. If the 2nd also happens - it should be found ad fixed as well. ------------------ after re-checking Shift+Tab issue - do the following test: at RUNTIME after in TForm.OnShow do ColorButton.TabStop := true; It should work. |
|
|
So, as no news from topic starter, i believe that we should 1) Make value the same in constructor (TabStop := ...) and class declaration (property TabStop ... default ....) 2) probably make a framework, that will assure that for all components the alues set in constructor match default values from RTTI. |
|
|
please. someone with SVN commit, implement this oneliner please |
|
|
Logging here message from NNTP, so it would not get lost once someone would start rolling-up the tracker into SVN -------- ?? ????: "Tomasz Kaczanowski" <tomasz.kaczanowski@sesto.pl> ???????????: jedi.jvcl ????: JvColorButton ????: Tue, 07 Feb 2012 14:28:10 +0400 URL: news://<jgqu5t$kni$1@jediserver.grizzlydev.com> I've found small problem with this gadget: - I change status Enebled to False. - I change status Enabled to True. - I change color - Showing color is wrong.... I've fixed it for my copy: part of procedure TJvColorButton.Paint: if Enabled then Frame3D(Canvas, Rec, cl3DDkShadow, cl3DDkShadow, 1) else begin Frame3D(Canvas, Rec, clBtnShadow, clBtnHighLight, 1); Canvas.Brush.Style := bsBDiagonal; end; I've changed to: if Enabled then begin Frame3D(Canvas, Rec, cl3DDkShadow, cl3DDkShadow, 1); Canvas.Brush.Style := bsSolid; end else begin Frame3D(Canvas, Rec, clBtnShadow, clBtnHighLight, 1); Canvas.Brush.Style := bsBDiagonal; end; Kaczus |
|
|
Please provide the zipped sources of a sample application showing this |
|
|
We really need a sample application showing this |
|
|
> Make value the same in constructor (TabStop := ...) and class declaration (property TabStop ... default ....) showing what ? that TabStop has different values in .Create and in default ? can't u just open and see ? Afterall that just cannot manifest itself in the project, it would look like incorrectly set properties, just so simple. Design-time errors can hardly be tested in runtime! |
|
|
About what Kaczus wrote - u would read the demo longer than you'd make it. Buttons 1 and 2 should revert each over, but they do not. PS. Frankly, diagonal style of "Disabled" button brush is not obvious solution. IT might be bright black stripes over bright black background for example. The overall "disabled" style should be rethought or maybe even made customized. |
|
2012-06-14 16:03
|
JVCL-0005695.rar (530,534 bytes) |
|
|
This is now in SVN |
|
|
plz, look attached demo and comments (0019417) and (0019998) There's more to be fixed in that component. |
|
|
Please, one problem, one issue in Mantis |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-10-28 14:48 | inprosis | New Issue | |
| 2011-10-28 14:48 | inprosis | IDE version | => FPC |
| 2011-10-28 21:40 | outchy | Project | JEDI Code Library => JEDI VCL |
| 2011-11-11 19:47 | Arioch | Note Added: 0019108 | |
| 2011-11-17 12:10 | Arioch | Reproducibility | have not tried => always |
| 2011-11-17 12:10 | Arioch | Status | new => acknowledged |
| 2011-11-17 12:10 | Arioch | Category | Miscellanous => 00 JVCL Components |
| 2011-11-17 12:10 | Arioch | Product Version | => Daily / SVN |
| 2011-11-17 12:10 | Arioch | Note Added: 0019117 | |
| 2011-11-17 12:10 | Arioch | Description Updated | |
| 2011-11-23 18:09 | Arioch | Note Added: 0019123 | |
| 2011-11-24 21:35 | Arioch | Status | acknowledged => closed |
| 2011-11-24 21:36 | Arioch | Status | closed => resolved |
| 2011-11-24 21:36 | Arioch | Status | resolved => feedback |
| 2012-02-14 11:41 | Arioch | Note Added: 0019417 | |
| 2012-02-14 11:41 | Arioch | Status | feedback => acknowledged |
| 2012-02-22 15:17 | obones | Note Added: 0019472 | |
| 2012-06-12 10:50 | obones | Note Added: 0019896 | |
| 2012-06-12 10:50 | obones | Status | acknowledged => feedback |
| 2012-06-14 15:52 | Arioch | Note Added: 0019997 | |
| 2012-06-14 15:54 | Arioch | Note Edited: 0019997 | |
| 2012-06-14 16:03 | Arioch | Note Added: 0019998 | |
| 2012-06-14 16:03 | Arioch | File Added: JVCL-0005695.rar | |
| 2012-06-18 11:33 | obones | Note Added: 0020011 | |
| 2012-06-18 11:33 | obones | Status | feedback => resolved |
| 2012-06-18 11:33 | obones | Fixed in Version | => Daily / SVN |
| 2012-06-18 11:33 | obones | Resolution | open => fixed |
| 2012-06-18 11:33 | obones | Assigned To | => obones |
| 2012-06-18 15:48 | Arioch | Note Added: 0020027 | |
| 2012-06-18 15:48 | Arioch | Status | resolved => feedback |
| 2012-06-18 15:48 | Arioch | Resolution | fixed => reopened |
| 2012-06-25 11:06 | obones | Note Added: 0020029 | |
| 2012-06-25 11:06 | obones | Status | feedback => resolved |
| 2012-06-25 11:06 | obones | Resolution | reopened => fixed |
| 2012-09-10 14:15 | obones | Fixed in Version | Daily / SVN => 3.46 |
| 2013-01-15 15:07 | obones | Relationship added | related to 0005920 |
