View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006215JEDI VCL00 JVCL Componentspublic2013-10-14 23:242015-09-14 13:20
ReporterPostApAssigned ToAHUser 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.47 
Target VersionFixed in Version3.48 
Summary0006215: Unit JvLED: forgotten OnChange property
DescriptionUnit JvLED has code:

  TJvCustomLED = class(TJvGraphicControl)
  private
...
   FOnChange: TNotifyEvent;

...
procedure TJvCustomLED.SetStatus(Value: Boolean);
begin
  FStatus := Value;
  if Status then
    Color := ColorOn
  else
    Color := ColorOff;
  if Assigned(FOnChange) then
    FOnChange(Self);
end;

but forgotten code:
type
  TJvCustomLED = class(TJvGraphicControl)
  protected
...
    property OnChange: TNotifyEvent read FOnChange write FOnChange; // FIX

and

  TJvLED = class(TJvCustomLED)
  published
...
    property OnChange; // FIX

in my opinion procedure TJvCustomLED.SetStatus must be:

procedure TJvCustomLED.SetStatus(Value: Boolean);
begin
  if Value <> FStatus then
  begin
  FStatus := Value;
  if FStatus then
    Color := ColorOn
  else
    Color := ColorOff;
  if Assigned(FOnChange) then
    FOnChange(Self);
  end;
end;
TagsNo tags attached.

Activities

2013-10-14 23:24

 

JvLED_FIX.pas (7,589 bytes)

AHUser

2013-12-01 11:21

developer   ~0020702

Fixed in master branch.

Issue History

Date Modified Username Field Change
2013-10-14 23:24 PostAp New Issue
2013-10-14 23:24 PostAp File Added: JvLED_FIX.pas
2013-12-01 11:21 AHUser Note Added: 0020702
2013-12-01 11:21 AHUser Status new => resolved
2013-12-01 11:21 AHUser Fixed in Version => Daily / SVN
2013-12-01 11:21 AHUser Resolution open => fixed
2013-12-01 11:21 AHUser Assigned To => AHUser
2015-09-14 13:20 obones Fixed in Version Daily / GIT => 3.48