View Issue Details

IDProjectCategoryView StatusLast Update
0006302JEDI VCL00 JVCL Componentspublic2019-05-23 20:46
ReportercguserAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Product VersionDaily / GIT 
Target VersionFixed in Version 
Summary0006302: JvDBGrid: dgIndicator option currently required to show TitlePopup
DescriptionAssigning a TPopupMenu to the grid's TitlePopup, (which has dgTitle on it's options) but no dgIndicator included, won't trigger the display of such menu when right clicking on the Title.
Additional InformationSeems an old bug spotted on JvDBGrid.pas 12831 2010-09-05,
however the latest version from
https://github.com/project-jedi/jvcl/blob/master/jvcl/run/JvDBGrid.pas
still has it: line 2418
{code}
      if (Button = mbRight) and
        (dgTitles in Options) and (dgIndicator in Options) and
        (Cell.Y = 0) then
      begin
{/code}

Why is dgIndicator required to show the TitlePopup?

The third condition of "and (dgIndicator in Options)" seems kinda lost in there.
TagsNo tags attached.

Activities

cguser

2014-07-16 13:31

reporter   ~0021002

Hi Olivier, could you please check with Andreas if there is any reason to require the presence of dgIndicator to popup the TitlePopup menu?

I suspect that that isn't, and if so, the fix is just to remove the second condition on line 2419, where

" (dgTitles in Options) and (dgIndicator in Options) and"

becomes just
" (dgTitles in Options) and"

A workaround on every caller side is somewhat messy (catch mouse click, was it on title?, was it a right-click? is it internally reversed? etc...).

Thanks

obones

2014-09-03 11:39

administrator   ~0021034

Please provide the zipped sources of a sample application showing this

2014-09-03 17:55

 

Issue6302.zip (5,612 bytes)

cguser

2014-09-03 17:56

reporter   ~0021046

Uploaded.

mh

2019-05-23 20:46

reporter   ~0021850

Pull request created:
https://github.com/project-jedi/jvcl/pull/132

Issue History

Date Modified Username Field Change
2014-07-09 17:11 cguser New Issue
2014-07-16 13:31 cguser Note Added: 0021002
2014-09-03 11:39 obones Note Added: 0021034
2014-09-03 11:39 obones Status new => feedback
2014-09-03 17:55 cguser File Added: Issue6302.zip
2014-09-03 17:56 cguser Note Added: 0021046
2014-12-04 14:57 obones Status feedback => acknowledged
2019-05-23 20:46 mh Note Added: 0021850