View Issue Details

IDProjectCategoryView StatusLast Update
0006641JEDI VCL00 JVCL Componentspublic2019-08-20 18:10
ReportertstoicescuAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version3.48 
Target VersionFixed in Version 
Summary0006641: JvDBTreeView - insert record
Description/Jvcl/Run/JvDBTreeView.pas:
Bug: Editing items's parent in State = dsInsert, it do Post and (wrong) Insert again (a new item). Normally it should edit same item.
so: OldState isn't needed: it should never reinsert new item.
Stack:
TCustomTreeView.CNNotify ... TVN_SELCHANGEDA, TVN_SELCHANGEDW: ... Change
TJvCustomDBTreeView.Change ::
 case OldState of
      dsEdit:
        FDataLink.DataSet.Edit;
      dsInsert:
        FDataLink.DataSet.Insert; /// Edit
    end;
TagsNo tags attached.

Activities

obones

2018-07-18 16:05

administrator   ~0021549

Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.

mh

2019-04-27 14:00

reporter   ~0021760

I found the code snippet referenced above but it looks exactly like above. Question: what exactly shall be changed there? Shall in dsInsert also the Edit method be called? Or is the code as is already fixed?

tstoicescu

2019-07-03 08:02

reporter   ~0021871

Shall in dsInsert also the Edit method be called? Yes. Don't need to do test case: it, it's logical if already saved last record inserted cannot insert another. Because it was already Post before. Just re edit.
Is the code as is already fixed? No. We put the fix in comment, not reverse.
Thank you.

mh

2019-08-05 23:04

reporter   ~0021874

Can you still please provide a small demo?
Because with that verifying that the proposed fix is really the fix and that it has no other side effects is really easier!

I also have the feeling that your proposed fix will not make it into JVCL until you provide that small demo application...
It can be something really simplistic...

mh

2019-08-14 19:54

reporter   ~0021879

Created pull request for this one:
https://github.com/project-jedi/jvcl/pull/137

mh

2019-08-20 18:10

reporter   ~0021880

Hello tstoicescu,

things went like I envisioned them. I had created this pull request for you:
https://github.com/project-jedi/jvcl/pull/137

Now we got the reaction that it won't get merged in like it is as it looks doubtful to obones (something I can understand).
=> can you really please write a little demo showing the effect? Otherwise the pull request will sit there unmerged for months or years I feat.

Issue History

Date Modified Username Field Change
2018-06-25 10:10 tstoicescu New Issue
2018-07-18 16:05 obones Note Added: 0021549
2018-07-18 16:05 obones Status new => feedback
2019-04-27 14:00 mh Note Added: 0021760
2019-07-03 08:02 tstoicescu Note Added: 0021871
2019-07-03 08:02 tstoicescu Status feedback => new
2019-08-05 23:04 mh Note Added: 0021874
2019-08-14 19:54 mh Note Added: 0021879
2019-08-20 18:10 mh Note Added: 0021880