View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0006641||JEDI VCL||00 JVCL Components||public||2018-06-25 10:10||2019-08-20 18:10|
|Target Version||Fixed in Version|
|Summary||0006641: JvDBTreeView - insert record|
Bug: Editing items's parent in State = dsInsert, it do Post and (wrong) Insert again (a new item). Normally it should edit same item.
so: OldState isn't needed: it should never reinsert new item.
TCustomTreeView.CNNotify ... TVN_SELCHANGEDA, TVN_SELCHANGEDW: ... Change
case OldState of
FDataLink.DataSet.Insert; /// Edit
|Tags||No tags attached.|
||Could you check if the issue is still present in the latest GIT content? If yes, please provide the zipped sources of an application showing this.|
||I found the code snippet referenced above but it looks exactly like above. Question: what exactly shall be changed there? Shall in dsInsert also the Edit method be called? Or is the code as is already fixed?|
Shall in dsInsert also the Edit method be called? Yes. Don't need to do test case: it, it's logical if already saved last record inserted cannot insert another. Because it was already Post before. Just re edit.
Is the code as is already fixed? No. We put the fix in comment, not reverse.
Can you still please provide a small demo?
Because with that verifying that the proposed fix is really the fix and that it has no other side effects is really easier!
I also have the feeling that your proposed fix will not make it into JVCL until you provide that small demo application...
It can be something really simplistic...
Created pull request for this one:
things went like I envisioned them. I had created this pull request for you:
Now we got the reaction that it won't get merged in like it is as it looks doubtful to obones (something I can understand).
=> can you really please write a little demo showing the effect? Otherwise the pull request will sit there unmerged for months or years I feat.
|2018-06-25 10:10||tstoicescu||New Issue|
|2018-07-18 16:05||obones||Note Added: 0021549|
|2018-07-18 16:05||obones||Status||new => feedback|
|2019-04-27 14:00||mh||Note Added: 0021760|
|2019-07-03 08:02||tstoicescu||Note Added: 0021871|
|2019-07-03 08:02||tstoicescu||Status||feedback => new|
|2019-08-05 23:04||mh||Note Added: 0021874|
|2019-08-14 19:54||mh||Note Added: 0021879|
|2019-08-20 18:10||mh||Note Added: 0021880|