View Issue Details

IDProjectCategoryView StatusLast Update
0006665JEDI VCL02 Installationpublic2019-04-23 22:55
ReportermhAssigned To 
PrioritynormalSeverityblockReproducibilityalways
Status newResolutionopen 
Product VersionDaily / GIT 
Target VersionFixed in Version 
Summary0006665: 10.3 Rio Update 1: Installer fails to compile JvAppIniStorage.pas
DescriptionInstaller fails to compile the JvAppIniStorage.pas file as Rio made some changes to TMemIniFile JvAppIniStorage.pas needs to adapt to.

The reason is, that JvAppIniStorage.pas accesses the non public/protected FSection field from TMemIniFile via class helper which is no longer present in Rio.

At least between XE8 and Rio 10.3 Update 1 there was a change in TMemIniFile where the code of JVCL has not been completely adapted to.

The change was, that TMemIniFile is now based on TDictionary and the FSection StringList used in the old MemIni code is no longer there. Unfortunately JVCL has several places where it wants to access FSection.
TagsNo tags attached.

Relationships

has duplicate 0006655 resolvedjfudickar Delphi 10.3 JVCL installation impossible 

Activities

mh

2019-03-03 15:18

reporter   ~0021611

Further investigation leads me to the suspiccion that the code path around line 251 which is for Rio and newer makes not much sense. It introduces a ClassHelper which introduces a FSections TStringList field, but this ins nowhere created nor freed and later on it is being accessed.

Shouldn't that code work with the FEsctions dictionary from TMemIniFile?
Another question: the original newsgroup poster's report pointed to line 251 which is in the pre Rio code path. If I'm not mistaken he talked about a Rio x64 isntallation. Why is the 64 bit compiler stepping into this path? Is there an issue with the RTL330_UP define in the 64 bit compiler?

mh

2019-03-04 22:49

reporter   ~0021613

Ok, looking at it again (after being pointed out that I didn't read it right the first time) I found out that this part of the code is for versions from D2009 to Tokyo, but not for Rio.

But this now leads to the question why the error messages posted by the original reporter of this in the JVCL newsgroup point to line 251 which is inside this block (at least in the JVCL version available via GetIt directly after installing Rio 10.3 Update 1)?

Here's the relevant excerpt from the original report from the newsgroup:

"[Compiling: JvCore260.bpl]
Embarcadero Delphi for Win64 compiler version 33.0
Copyright (c) 1983,2017 Embarcadero Technologies, Inc.

C:\ProgramData\Jvcl 201902Git\jvcl\run\JvAppIniStorage.pas(251) Erreur: E2003 Identificateur non déclaré : 'IndexOf'
C:\ProgramData\Jvcl 201902Git\jvcl\run\JvAppIniStorage.pas(251) Avertissement: W1023 Comparaison de types signés et non signés - opérandes élargis

C:\ProgramData\Jvcl 201902Git\jvcl\run\JvAppIniStorage.pas(260) Erreur: E2010 Types incompatibles : 'TStringList' et 'TMemIniFile.TSections'
JvCore.dpk(2501) Fatale: F2063 Impossible de compiler l'unité utilisée 'JvAppIniStorage.pas' "

jfudickar

2019-04-14 13:13

developer   ~0021695

The interesting question for me is, where is this error coming from?
I'm compiling the current release without any problems with latest Rio Relase.

DidierL

2019-04-20 17:52

reporter   ~0021723

Same problem for me (+1 another one).
I'm also using a french version of Rio 10.3 update 1
[dcc32 Erreur] JvAppIniStorage.pas(251): E2003 Identificateur non déclaré : 'IndexOf'
[dcc32 Erreur] JvTimerList.pas(595): E2003 Identificateur non déclaré : 'cnAdded'

Looks like a problem with RTL330_UP define

DidierL

2019-04-22 23:33

reporter   ~0021728

I managed to do a clean manual install from GitHub.
But no success with Delphi GetIt utility.

mh

2019-04-23 20:37

reporter   ~0021730

Ok, if you could install by fetching the verasion from Github,but not the one delivered via GetIt my question would be: what's the difference between those two?

DidierL

2019-04-23 22:55

reporter   ~0021731

RTL330_UP wasn't defined when I installed with GetIt.
Probably a path issue with jedi.inc

Issue History

Date Modified Username Field Change
2019-03-03 10:05 mh New Issue
2019-03-03 15:18 mh Note Added: 0021611
2019-03-04 22:49 mh Note Added: 0021613
2019-04-14 13:13 jfudickar Note Added: 0021695
2019-04-20 17:52 DidierL Note Added: 0021723
2019-04-22 23:33 DidierL Note Added: 0021728
2019-04-23 20:37 mh Note Added: 0021730
2019-04-23 22:55 DidierL Note Added: 0021731
2019-04-27 15:44 jfudickar Relationship added has duplicate 0006655