View Issue Details

IDProjectCategoryView StatusLast Update
0004037JEDI VCL00 JVCL Componentspublic2008-06-01 12:01
ReporterSalvatore BessoAssigned Tojfudickar 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionDaily / GIT 
Target VersionFixed in Version 
Summary0004037: TJvFormStorage inserts unwanted "FormVersion" values in all keys
DescriptionI'm currently using daily snapshot and my latest update is of 1-Nov-2006. This is an old problem that appeared again after the update of november. I have another application that was compiled with a JVCL snapshot of around mid May 2006 and this problem doesn't happen.

If you have this structure:

Key1
  MyValue1
  MyValue2
Key2
  MyValue1
  MyValue2
Key3
  MyValue1
  MyValue2

after executing and closing the application you'll have:

Key1
  MyValue1
  MyValue2
  FormVersion
Key2
  MyValue1
  MyValue2
  FormVersion
Key3
  MyValue1
  MyValue2
  FormVersion

This is absolutely unwanted. The addition happens in this method:

------------------------------------------------
const
   siVersion = 'FormVersion'; // do not localize

procedure TJvFormPlacement.SaveFormPlacement;
begin
   { (marcelb) say what? Store when the component has done a restore
previously or if it's inactive?
     I think it should only store if Active is set to True. Changed
accordingly }
// if FRestored or not Active then
   if Assigned(AppStorage) then
   begin
     WriteInteger(siVersion, FVersion);
     Save;
     SavePlacement;
     FSaved := True;
   end;
end;
TagsNo tags attached.

Activities

jfudickar

2007-01-30 16:33

developer   ~0010690

Done

Salvatore Besso

2008-03-05 04:58

reporter   ~0014279

I have noticed that this problem is back again. I'm using the latest snapshot of JVCL with Delphi 2007 Enterprise. The FormVersion Integer value is written back again in every key. The problem lies in the same method and it was fixed some time ago, but it seems that it likes to return back every now and then :-) Of course there is the counterpart problem in RestoreFormPlacement as well where the component tries to read this value.

jfudickar

2008-05-28 13:52

developer   ~0014313

Sorry Salvatore,

i can't reproduce it.

The fix is already included and working.

Did you have checked the property "VersionCheck".

I've tested it in this moment with the "examples\JvAppStroage\Base Example" projcet, and everything is fine.

Greetings
Jens

Salvatore Besso

2008-05-29 04:01

reporter   ~0014318

hi Jens,

> Did you have checked the property "VersionCheck".

sorry, I didn't notice that property :-) Do I have to set it to fpvcNocheck to eliminate the FormVersion problem?

Thank you

jfudickar

2008-05-29 04:42

developer   ~0014319

Yes!

Please give me a feedback if it solves your problem.

Greetings
Jens

Salvatore Besso

2008-06-01 09:46

reporter   ~0014320

hi Jens,

> Please give me a feedback if it solves your problem

sorry to come back so late, but it has been a very hard week :-(

Yes, setting that property to fpvcNocheck solves the problem. You can close the issue definitely.

Thank you
Salvatore

Issue History

Date Modified Username Field Change
2007-01-15 08:40 Salvatore Besso New Issue
2007-01-26 04:25 jfudickar Status new => assigned
2007-01-26 04:25 jfudickar Assigned To => jfudickar
2007-01-30 16:33 jfudickar Status assigned => resolved
2007-01-30 16:33 jfudickar Resolution open => fixed
2007-01-30 16:33 jfudickar Note Added: 0010690
2008-03-05 04:58 Salvatore Besso Status resolved => feedback
2008-03-05 04:58 Salvatore Besso Resolution fixed => reopened
2008-03-05 04:58 Salvatore Besso Note Added: 0014279
2008-05-28 13:52 jfudickar Note Added: 0014313
2008-05-29 04:01 Salvatore Besso Note Added: 0014318
2008-05-29 04:42 jfudickar Note Added: 0014319
2008-06-01 09:46 Salvatore Besso Note Added: 0014320
2008-06-01 12:00 jfudickar Status feedback => resolved
2008-06-01 12:00 jfudickar Resolution reopened => fixed