|Anonymous | Login | Signup for a new account||2019-05-20 13:44 CEST|
|Main | My View | View Issues | Change Log | Roadmap | Docs|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0005255||[JEDI VCL] 04 Feature Request||feature||N/A||2010-05-26 20:51||2012-02-29 16:53|
|Summary||0005255: A change to TJvAlarms/TJvAlarmItem|
I have need of a change to TJvAlarms/TJvAlarmItem to support an individual event being triggered for each TJvAlarmItem instead of a unified alarm event for TJvAlarms. My thought was to add the event to TJvAlarmItem and trigger that event when assigned instead of triggering the TJvAlarms event. That way, no existing code should be broken while still allowing individual events to be created and used.
procedure TJvAlarms.DoAlarm(const Alarm: TJvAlarmItem;
const TriggerTime: TDateTime);
if Assigned(Alarm.FOnAlarm) then
else if Assigned(FOnAlarm) then
FOnAlarm(Self, Alarm, TriggerTime);
Where the TJvAlarmItem.FOnAlarm type would be declared as follows:
TJvAlarmItemEvent = procedure(Sender: TObject;
const TriggerTime: TDateTime) of object;
Additions to TJvAlarmItem:
FOnAlarm : TJvAlarmItemEvent;
property OnAlarm : TJvAlarmItemEvent read FOnAlarm write FOnAlarm;
I think that would pretty much cover my needs.
I am capable of making the changes and testing them thoroughly, but I am completely new to the submission process and unsure how best to proceed. Should I just make the relatively minor changes to the JvAlarms.PAS file and submit it (zipped, of course) or do I create an extended version in a new source file and submit that instead or do I have one of you make the changes for me?
Thank you for your time.
|Tags||No tags attached.|
|Attached Files||JvAlarms.diff [^] (1,421 bytes) 2010-05-30 01:34|
Best way to submit changes is to use a diff tool to attach just the diffs to the issue.
The best format for us is the one created by TortoiseSVN
|Ok, I added the diff file with the changes. It was tested in D2007 but I don't really see anything that would negatively affect any other versions.|
|Thanks, this is now in SVN|
|2010-05-26 20:51||jgagnon||New Issue|
|2010-05-27 22:27||obones||Note Added: 0017419|
|2010-05-27 22:27||obones||Status||new => feedback|
|2010-05-30 01:34||jgagnon||File Added: JvAlarms.diff|
|2010-05-30 01:36||jgagnon||Note Added: 0017424|
|2010-10-08 14:59||obones||Note Added: 0017775|
|2010-10-08 14:59||obones||Status||feedback => resolved|
|2010-10-08 14:59||obones||Fixed in Version||=> Daily / SVN|
|2010-10-08 14:59||obones||Resolution||open => fixed|
|2010-10-08 14:59||obones||Assigned To||=> obones|
|2012-02-29 16:53||obones||Fixed in Version||Daily / SVN => 3.45|
|Mantis 1.1.6[^] Copyright © 2000 - 2008 Mantis Group|