View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001515 | JEDI VCL | 00 JVCL Components | public | 2004-03-22 05:49 | 2004-03-22 16:12 |
| Reporter | glchapman | Assigned To | obones | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Summary | 0001515: TJvCustomImageButton missing Notification override | ||||
| Description | TJvCustomImageButton (JvCtrls.pas) needs to override Notification to see if the imagelist to which Images refers is being removed. | ||||
| Tags | No tags attached. | ||||
|
2004-03-22 05:49
|
JvCtrls.pas.diff (998 bytes)
--- JvCtrls.pas.orig 2004-03-05 22:34:58.000000000 -0800
+++ JvCtrls.pas 2004-03-22 05:59:50.000000000 -0800
@@ -99,6 +99,7 @@
procedure WMLButtonDblClk(var Msg: TWMLButtonDblClk); message WM_LBUTTONDBLCLK;
procedure WMTimer(var Msg: TWMTimer); message WM_TIMER;
protected
+ procedure Notification(AComponent: TComponent; Operation: TOperation); override;
procedure ActionChange(Sender: TObject; CheckDefaults: Boolean); override;
procedure CalcButtonParts(ButtonRect: TRect; var RectText, RectImage: TRect);
procedure CreateParams(var Params: TCreateParams); override;
@@ -249,6 +250,14 @@
FreeAndNil(FCanvas);
end;
+procedure TJvCustomImageButton.Notification(AComponent: TComponent;
+ Operation: TOperation);
+begin
+ inherited;
+ if (Operation = opRemove) and (AComponent = Images) then
+ Images:= nil;
+end;
+
procedure TJvCustomImageButton.CreateParams(var Params: TCreateParams);
begin
inherited CreateParams(Params);
|
|
|
Thanks for the diff file. This is now in CVS. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2004-03-22 05:49 | glchapman | New Issue | |
| 2004-03-22 05:49 | glchapman | File Added: JvCtrls.pas.diff | |
| 2004-03-22 16:08 | obones | Status | new => assigned |
| 2004-03-22 16:08 | obones | Assigned To | => obones |
| 2004-03-22 16:12 | obones | Status | assigned => resolved |
| 2004-03-22 16:12 | obones | Resolution | open => fixed |
| 2004-03-22 16:12 | obones | Note Added: 0003427 |