View Issue Details

IDProjectCategoryView StatusLast Update
0001626JEDI VCL00 JVCL Componentspublic2004-04-22 08:58
ReporterhamiltonAssigned Touser72 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0001626: TJvDBSpinEdit OnClick event puts the dataset in edit mode
DescriptionClicking on the edit control portion of the SpinEdit puts the dataset in edit mode.
This behaviour still exists in JVCL3-Latest.zip from 12-Apr-2004
Additional InformationNormal behaviour would be for the dataset to be put in edit mode only when the value is changed.
TagsNo tags attached.

Activities

user72

2004-04-12 08:52

  ~0003816

That is caused be the following lines in MouseDown:

  if (not ReadOnlyField) and FFieldDataLink.Edit then { OK to edit. }
    inherited MouseDown(Button, Shift, X, Y)
  else
  ...

What happens if you remove the entire MouseDown implementation and replace it with a call to "inherited;"?

hamilton

2004-04-15 10:21

reporter   ~0003879

Your suggestion solved the problem.

Removing MouseDown from TJvDBSpinEdit altogether would seem to be the best solution.

Fixing this problem has not created any side-effects I could spot. In particular, changing the value in the edit or clicking the spin buttons still put the dataset in edit mode as you would expect.

Great work!

user72

2004-04-22 08:58

  ~0004011

I'll update CVS at the same time as I do 0001625, but I'll close this report now.

Issue History

Date Modified Username Field Change
2004-04-12 08:25 hamilton New Issue
2004-04-12 08:52 user72 Note Added: 0003816
2004-04-14 03:51 user72 Status new => assigned
2004-04-14 03:51 user72 Assigned To => user72
2004-04-14 03:51 user72 Status assigned => feedback
2004-04-15 10:21 hamilton Note Added: 0003879
2004-04-22 08:58 user72 Status feedback => resolved
2004-04-22 08:58 user72 Resolution open => fixed
2004-04-22 08:58 user72 Note Added: 0004011