|
2004-04-15 08:34
|
JvCaptionBug_XP_withoutThemes1.jpg (66,034 bytes) |
|
2004-04-15 08:34
|
JvCaptionBug_XP_withoutThemes2.jpg (71,786 bytes) |
|
|
Mmm, never tried that :) will check it. edited on: 04-15-04 11:41 |
|
|
Compiler: D7 Enterprise And this happens only when you use the Demo executable under Windows XP Home/Pro and create a shortcut of the exe-file and edit the properties of the *.lnk File (Compatibility - Themes disabled). This should happend with every kind of compiler, because i think there is a bug in the sources to detect that the theming is not enabled. UXTHEME? |
|
|
Yeah, I can reproduce it now; I was just reading a bit too fast and thought I recognized a D6<= problem. |
|
|
Changing function TJvCaptionButton.GetIsThemed to function TJvCaptionButton.GetIsThemed: Boolean; begin Result := ThemeServices.ThemesAvailable and IsThemeActive and IsAppThemed; end; seems to be enough, but will investigate some more. |
|
|
Yeah this seems much better now :-) Small Things could do sooo much! *smile* Is there a way to paint the button in caption bar color or to show an custom image (whole button size) to create a better WinXP looking custom button? I think there could be a way to get the background image from the current theme for the custom button (Windows XP - e. g. Blue Button) or a gradient style? Thanks again for your great support! |
|
|
Ok... for example look under C:\WINDOWS\Resources\Themes\Luna\luna.msstyles (open with ResourceHacker or something else) now open the BITMAP Tree! BITMAP -> BLUE_CAPTIONBUTTON_BMP shows the correct background images for the a custom caption button. It would be great if we could use these images (from the current theme) as background? :-) |
|
|
Yeah, I know it looks really ugly now, but I don't know a straight forward way to make it better. That is, I don't know a good way to construct a good image for the button at run-time. I know e-mule just includes 3x8 (3 themes (blue,green,gray), 8 states of the button) images for the minimize to tray caption button. I think allmost all XP users use one of these three themes so that might be a reasonable good solution. |
|
2004-04-15 13:27
|
BLUE_CAPTIONBUTTON.bmp (14,166 bytes) |
|
2004-04-15 13:27
|
HOMESTEAD_CAPTIONBUTTON.bmp (10,808 bytes) |
|
2004-04-15 13:27
|
METALLIC_CAPTIONBUTTON.bmp (10,808 bytes) |
|
|
Ok i've uploaded the extracted Bitmaps out of C:\WINDOWS\Resources\Themes\Luna\luna.msstyles ... Maybe there is a way to check out if theming is used and which msstyles file is used to extract the current background bitmap online? With this solution you could extract anykind of msstyles <name>_CAPTIONBUTTON_BMP resource! :-) |
|
|
Okay didn't know that :) But I see 2 problems: 1. You might have to resize the image (large/extra large caption) This is not so big problem but might look not so good. 2. It's undocumented by Microsoft, thus it might be broken in newer systems (for example windows 2003 but can't test that) Offcourse you can check whether the luna.msstyles file exists and if it the file does not exists, draw the button as it is done now; or include the bmps as a resource file. Anyways will check what can be done. Looks promising :) |
|
|
Ok... Here it's the next step to the perfect solution... With this documented function you could check out the correct used msstyles file. The last problem is to know which of the included 3 themes is used (BLUE, HOMESTEAD or METALLIC) ... i'm still working on it! ------ USE THIS CODE! uses ComObj, SyncObjs; // <-- add this to uses clauses var GetCurrentThemeName: function (pszThemeFileName: LPWSTR; cchMaxNameChars: Integer; pszColorBuff: LPWSTR; cchMaxColorChars: Integer; pszSizeBuff: LPWSTR; cchMaxSizeChars: Integer): HRESULT; stdcall; procedure TForm1.Button1Click(Sender: TObject); var FileName, ColorScheme, SizeName: WideString; hThemeLib: THandle; begin try hThemeLib := LoadLibrary('uxtheme.dll'); if hThemeLib > 0 then GetCurrentThemeName := GetProcAddress(hThemeLib, 'GetCurrentThemeName'); if Assigned(GetCurrentThemeName) then begin SetLength(FileName, 255); SetLength(ColorScheme, 255); SetLength(SizeName, 255); OleCheck(GetCurrentThemeName(PWideChar(FileName), 255, PWideChar(ColorScheme), 255, PWideChar(SizeName), 255)); // show the the theme path and file name. ShowMessage(PWideChar(FileName)); // show the color scheme name ShowMessage(PWideChar(ColorScheme)); // show the size name ShowMessage(PWideChar(SizeName)); end; finally FreeLibrary(hThemeLib); end; end; |
|
|
There is now problem with this under Windows 2003 Server / Advanced Server :-) all newer OS uses the UXTHEME.DLL for Theming. |
|
|
Okay, it is in Rev 1.21. |
|
2004-04-17 13:29
|
Usage_of_StretchBltTransparent.jpg (40,061 bytes) |
|
2004-04-17 13:29
|
Usage_of_TransparentBlt.jpg (40,040 bytes) |
|
2004-04-17 13:30
|
STRETCHED_CAPTIONBUTTON.BMP (9,654 bytes) |
|
|
Ok... i'll try to allow each theming not only luna.msstyles. This seems to work good for now, but there is a strange bug in the procedure TGlobalXPData.Draw(HDC: HDC; State: Integer; const DrawRect: TRect); .... with the function StretchBltTransparent (see uploaded Screenshot) when i alternative use the TransparentBlt then it seems better (not stretched) but the Transparentcolor doesn't work :-( (see also uploaded Screenshot) Please try this with the attached STRETCHED_CAPTIONBUTTON.BMP! Thanks a lot ... and great work! Soren |
|
|
Is this topic closed? It would be great if someone could help me out with the STRETCH-Problem (see bugnote above). Best regards, Soren |
|
|
I have changed StretchBltTransparent to TransparentBlt. AFAICS TransparentBlt does not work right when the source rect has not the same dimensions as the dest rect. (Your STRETCHED_CAPTIONBUTTON.BMP has dimension 20x20, the button probably 21x21) I've changed the copy routine again, and now it looks pretty good on my machine. Please test and feedback whether it works for you. It is in rev 1.23. > Is this topic closed? No, just not much free time :) |
|
2004-04-28 00:38
|
Drawing_Failure.jpg (73,543 bytes) |
|
|
It seems now that the wrong background image is used? (see screenshot: drawing_failure.jpg) |
|
|
The caption button saw that the default style was not used, thus used SimpleDraw instead of Draw. This should be fixed in rev 1.24. edited on: 04-28-04 06:14 |
|
|
This bug has not had any activity for more than a month, it is therefore considered resolved. To the original poster: If you think the issue is still there, even after having tested with the JVCL3, please create a new bug report. |
- Anonymous
