View Issue Details

IDProjectCategoryView StatusLast Update
0001799JEDI VCL00 JVCL Componentspublic2004-05-28 01:16
ReporterhamiltonAssigned Touser72 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version 
Summary0001799: The button for the JvComboEdit covers the text edit
DescriptionThe consequence of the button covering the edit is that the end of long strings are covered. ie If the text in the edit is longer than can be displayed on the screen then pressing 'end' takes you to the end of the string - except that the last couple of characters are covered by the button.

The control could be modified to place the button alongside the edit rather than on top of it, perhaps using a panel as a base.
TagsNo tags attached.

Activities

remkobonte

2004-05-26 14:23

developer   ~0004365

Last edited: 2004-05-26 14:23

Which JVCL version do you have?

If you have 3.0 (beta) then can you upload a picture showing the problem?

edited on: 05-26-04 14:23

user72

2004-05-26 23:47

  ~0004366

That is not the result I am getting. Pressing <END> takes me to the end of the string and the last character is clearly visible to the left of the button.

hamilton

2004-05-27 08:40

reporter   ~0004376

Strange that neither of you are unable to replicate the problem. Seems the error may be at my end.

My testing was conducted using JCL and JVCL code from the 2004-05-24.

I will download last nights' source and try again in case this fixes the problem then get back to you.

As requested, I have uploaded a small bitmap showing my control not working. I selected the edit part of the control and pressed END - the image shows my result.

Incidently, over the last 2 weeks you two have fixed several other bugs that I would otherwise have reported last night - thanks heaps :) It was nice to try the latest code just before reporting these bugs and finding them already fixed!

hamilton

2004-05-27 11:50

reporter   ~0004392

Ok, now I know the real issue - changing the width of the JvComboEdit causes the problem.

To demonstrate:
1. Add a JvComboEdit to a form.
2. Add a OnButtonClick method with the following code:
      TJvComboEdit(Sender).Text := 'some really long sentence';
      TJvComboEdit(Sender).Width := 100;
3. Run the code, click the button
4. Try and view the end of the sentence.

I can replicate this behaviour with last nights' backup of the JCL and JVCL code.

user72

2004-05-27 12:01

  ~0004393

Now we're cookin'! I can replicate it here as well.

Don't know if this is the best fix, but the following seems to solve it (in JvToolEdit.pas):
type
  TJvCustomComboEdit = class
  ...
  public
    procedure SetBounds(ALeft, ATop, AWidth,
      AHeight: Integer);override;

...

procedure TJvCustomComboEdit.SetBounds(ALeft, ATop, AWidth,
  AHeight: Integer);
begin
  inherited SetBounds(ALeft, ATop, AWidth, AHeight);
  if HandleAllocated then
    SetEditRect;
end;

hamilton

2004-05-27 12:15

reporter   ~0004395

Ya, that got it alright. Nice work :)

user72

2004-05-28 01:16

  ~0004403

Updated in CVS

Issue History

Date Modified Username Field Change
2004-05-26 12:13 hamilton New Issue
2004-05-26 14:23 remkobonte Note Added: 0004365
2004-05-26 14:23 remkobonte Note Edited: 0004365
2004-05-26 23:47 user72 Note Added: 0004366
2004-05-27 00:31 user72 Status new => feedback
2004-05-27 08:40 hamilton Note Added: 0004376
2004-05-27 11:50 hamilton Note Added: 0004392
2004-05-27 12:01 user72 Note Added: 0004393
2004-05-27 12:15 hamilton Note Added: 0004395
2004-05-28 01:16 user72 Status feedback => resolved
2004-05-28 01:16 user72 Resolution open => fixed
2004-05-28 01:16 user72 Assigned To => user72
2004-05-28 01:16 user72 Note Added: 0004403