View Issue Details

IDProjectCategoryView StatusLast Update
0002363JEDI VCL00 JVCL Componentspublic2005-08-10 08:28
ReporternestorAssigned Toobones 
Status resolvedResolutionwon't fix 
Product Version 
Target VersionFixed in Version 
Summary0002363: TjvFormStorage slow down its owner form on display/close
DescriptionTjvFormStorage is a very useful component. I drop it on many of my forms. But this component slow the display and the close (Hide) of its owner form. In fact, when active is true, it performs a “Save” on every OnCloseQuery Event and does a “Restore” on every OnShowEvent of its owner form. I don’t understand the utility of such “save” and “restore”.

I suggest modifying this component to do when it’s active a:
- “Restore” just after its owner onCreate event.
- “Save” just before its owner OnDesrtroy event.
- Remove the redirection events of owner form: OnCloseQuery and OnShow.

For test and more information, here is my owner derived component of TjvFormStorage.
TagsNo tags attached.


2004-12-06 07:52


PxFormStorage.pas (3,427 bytes)


2004-12-06 14:54

viewer   ~0005836

And When there are no modiofication's to save, do not save it anyway.
I Uses it to modify my application settings, normol users have no write access to the aplication path and get a error after clossing.


2004-12-06 15:23

reporter   ~0005837

To anonymous: Use OnRestorePlacement event to set Active to false when user have no write access to your application path. this is : TjvFormStorage(Sender).active := False.
When active is false no more save well be done any more after the first restore.


2004-12-08 00:31

developer   ~0005840

For prevention of write down, you can also use JvAppStorage.Readonly := TRUE;


2004-12-14 00:17

developer   ~0005880

Anyone else with comments?

For me the FormShow, FormOnClose Events are better. But i'm not shure.



2004-12-20 07:07

administrator   ~0005960

Close is not always called, especially when the system is shutting down.
As to the initial bug, I don't like the proposed modifications, I'd rather have the user deactivate the TJvFormStorage from the appropriate event (or even constructor).


2005-08-10 08:28

administrator   ~0007781

See my last remark.

Issue History

Date Modified Username Field Change
2004-12-06 07:52 nestor New Issue
2004-12-06 07:52 nestor File Added: PxFormStorage.pas
2004-12-06 14:54 anonymous Note Added: 0005836
2004-12-06 15:23 nestor Note Added: 0005837
2004-12-08 00:31 jfudickar Note Added: 0005840
2004-12-14 00:17 jfudickar Note Added: 0005880
2004-12-20 07:07 obones Note Added: 0005960
2004-12-20 07:07 obones Status new => feedback
2005-08-10 08:28 obones Status feedback => resolved
2005-08-10 08:28 obones Resolution open => won't fix
2005-08-10 08:28 obones Assigned To => obones
2005-08-10 08:28 obones Note Added: 0007781