View Issue Details

IDProjectCategoryView StatusLast Update
0003439JEDI VCL00 JVCL Componentspublic2006-01-24 07:42
ReporterultimoAssigned Tojfudickar 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionwon't fix 
Product Version3.10 
Target VersionFixed in Version 
Summary0003439: JvDBGrid, Cursor allowed on ReadOnly Column - Fixed
DescriptionClick on read only column, grid allow cursor; but not allowed on prior version
Here there are a solution:

On procedure CanEditShow

  if (dgAlwaysShowEditor in Options) and not EditorMode then
    EditorMode := True;
  Result := False;
  if (inherited CanEditShow) and Assigned(SelectedField)
    and not (Columns[SelectedIndex].ReadOnly) <-------------- Added this line
    and (SelectedIndex >= 0) and (SelectedIndex < Columns.Count) then
  begin
    FBooleanFieldToEdit := nil;
    Result := UseDefaultEditor;
  end
  else
  begin
    if Assigned(DataLink) and not DataLink.Editing then
      HideCurrentControl;
    if not (Assigned(InplaceEditor) and InplaceEditor.Visible) then
      HideEditor;
  end;
Additional InformationFixed
TagsNo tags attached.

Activities

jfudickar

2006-01-20 10:19

developer   ~0008411

Changed in cvs.

Please give it a try.

Informatix

2006-01-23 08:37

developer   ~0008427

No... no... THIS IS NOT A BUG.

You lost two things with that change:
- Same behavior as TDBGrid;
- Ability to copy values in read-only cells.

It would be a bug if the user could change the value in the cell, but that's not the case.

moore

2006-01-23 10:30

reporter   ~0008429

i agree with informatix, pliz let it as it is with ability to copy in read only cells when grid readonly is true, if you want not to allow cursor simply put dgEditing to false, now i can't update my jvcl if this is commited because this will break my apps..

jfudickar

2006-01-23 16:28

developer   ~0008431

Fixed removed.

Sorry for the problems?

Should we close this issue?

ultimo

2006-01-24 06:46

reporter   ~0008443

Last edited: 2006-01-24 06:50

Yes, You can close
Sorry for the incovenience, I have only noticed the problem on version 3.10.
Prior to this version the DBgrid work how I has explained.
On my situation I have SOME cell grid not editable, and also other editable and I can't use dgEditing.
However I think you're right.

Issue History

Date Modified Username Field Change
2006-01-12 03:59 ultimo New Issue
2006-01-20 10:19 jfudickar Note Added: 0008411
2006-01-20 10:19 jfudickar Assigned To => jfudickar
2006-01-20 10:19 jfudickar Status new => feedback
2006-01-23 08:37 Informatix Note Added: 0008427
2006-01-23 10:30 moore Note Added: 0008429
2006-01-23 16:28 jfudickar Note Added: 0008431
2006-01-24 06:46 ultimo Note Added: 0008443
2006-01-24 06:50 ultimo Note Edited: 0008443
2006-01-24 07:42 jfudickar Status feedback => resolved
2006-01-24 07:42 jfudickar Resolution open => won't fix