View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004877 | JEDI VCL | 00 JVCL Components | public | 2009-07-27 10:56 | 2009-08-23 13:55 |
| Reporter | ZENsan | Assigned To | AHUser | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | Daily / GIT | ||||
| Target Version | Fixed in Version | 3.38 | |||
| Summary | 0004877: TJvRichEditToHtml under Delphi 2009 | ||||
| Description | 1) header, Footer properties are not saved in DFM file (always are default values) 2) I suggest a small change for Delphi 2009 (at least) in ConvertToHTML function, because if not this way, then when I convert "???????" - it's totally corrupt the original string when converting it to entities (Diff file for this issue is attached). | ||||
| Tags | No tags attached. | ||||
|
2009-07-27 10:56
|
jvRichEditToHtml.diff (986 bytes)
--- C:/Users/U7/AppData/Local/Temp/JvRichEditToHtml.pas-revBASE.svn000.tmp.pas �� �� 27 11:53:04 2009
+++ C:/Comps/jvcl/run/JvRichEditToHtml.pas �� �� 27 11:52:18 2009
@@ -211,6 +211,7 @@
inherited Create(AOwner);
FCToH := TJvRgbToHtml.Create(Self);
FCharToH := TJvStrToHtml.Create(Self);
+
FHeader := TStringList.Create;
FHeader.Add('<HTML>');
FHeader.Add(' <HEAD>');
@@ -391,7 +392,7 @@
end
else
begin
- if CharInSet(Text[J], ['A'..'Z', 'a'..'z', '0'..'9']) then
+ if CharIsAlphaNum(Text[J]) then
St.Append(Text[J])
else
St.Append(CharToHtml(Text[J]));
@@ -501,7 +502,7 @@
end
else
begin
- if CharInSet(Text[J], ['A'..'Z', 'a'..'z', '0'..'9']) then
+ if CharIsAlphaNum(Text[J]) then
St.Append(Text[J])
else
St.Append(CharToHtml(Text[J]));
|
|
|
???? - that was russian text... |
|
|
Please provide the zipped sources of a sample application showing this. |
|
2009-08-04 15:52
|
Projects.zip (5,780 bytes) |
|
2009-08-04 15:53
|
JvRichEditToHtml - new.diff (1,204 bytes)
--- C:/Comps/jvcl/run/JvRichEditToHtml.pas �� ��� 4 16:27:32 2009
+++ C:/Users/U7/Documents/RAD Studio/Projects/JvRichEditToHtml.pas �� ��� 4 16:43:00 2009
@@ -391,7 +391,7 @@
end
else
begin
- if CharInSet(Text[J], ['A'..'Z', 'a'..'z', '0'..'9']) then
+ if CharIsAlphaNum(Text[J]) then
St.Append(Text[J])
else
St.Append(CharToHtml(Text[J]));
@@ -501,7 +501,7 @@
end
else
begin
- if CharInSet(Text[J], ['A'..'Z', 'a'..'z', '0'..'9']) then
+ if CharIsAlphaNum(Text[J]) then
St.Append(Text[J])
else
St.Append(CharToHtml(Text[J]));
@@ -561,11 +561,11 @@
begin
case Value.Alignment of
Classes.taLeftJustify:
- Result := 'ALIGN="LEFT"';
+ Result := 'STYLE="text-align: left;"';
Classes.taRightJustify:
- Result := 'ALIGN="RIGHT"';
+ Result := 'STYLE="text-align: right;"';
Classes.taCenter:
- Result := 'ALIGN="CENTER"';
+ Result := 'STYLE="text-align: center;"';
end;
if Value.Numbering = ComCtrls.nsBullet then
begin
|
|
|
And try to set header and Footer to Empty - it is immpossible. We need to set for properties Header, Footer property Header/Footer.... stored True; So that this properties are always stored or write function which compare that values with defaults. |
|
|
More info required for this report? |
|
|
Patch applied to SVN. Empty Header/Footer are now written to the DFM. (TStrings.DefineProperties doesn't write empty string lists, so I had to "reimplement" it for empty string lists) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-07-27 10:56 | ZENsan | New Issue | |
| 2009-07-27 10:56 | ZENsan | File Added: jvRichEditToHtml.diff | |
| 2009-07-27 11:04 | ZENsan | Note Added: 0015894 | |
| 2009-08-04 09:39 | obones | Note Added: 0015909 | |
| 2009-08-04 09:39 | obones | Status | new => feedback |
| 2009-08-04 15:52 | ZENsan | File Added: Projects.zip | |
| 2009-08-04 15:53 | ZENsan | File Added: JvRichEditToHtml - new.diff | |
| 2009-08-04 15:54 | ZENsan | Note Added: 0015917 | |
| 2009-08-13 16:00 | ZENsan | Note Added: 0015995 | |
| 2009-08-23 13:55 | AHUser | Note Added: 0016009 | |
| 2009-08-23 13:55 | AHUser | Status | feedback => resolved |
| 2009-08-23 13:55 | AHUser | Fixed in Version | => Daily / SVN |
| 2009-08-23 13:55 | AHUser | Resolution | open => fixed |
| 2009-08-23 13:55 | AHUser | Assigned To | => AHUser |
