|
|
This is also with the latest official version. |
|
|
Could you send me the archive (split in files < 10MB) and I'll try to reproduce. EMail is outchy at users dot sourceforge dot net |
|
|
Well received. But I cannot reproduce the freeze here using 7z 9.16. Here are the steps I did: - save the 3 rar archive parts; - extract them; - compile the latest development version of the JCL (daily zips at http://jcl.sf.net/daily or SVN) - compile the ArchiveDemo project in jcl/examples/windows/compression/archive - open it - switch to the tab "read and write" - open the archive "0022 - Super Mario 64 DS.zip" - add several files 1a.png, ... - click on "Save" The compression runs as expected. System is windows 2k. Note that in your code, you could avoid multiple typecasts by declaring imageArchive as TJclUpdateArchive. |
|
|
Strange, it's failing for me. I do have Winzip installed.. I don't know if that's part of it?? Since when I open the Zip file in the Demo, I get a Winzip error later on also (randomly) with this error Assert Error (.\PreviewCOM.cpp@365): The operation completed successfully. And I am using Windows 7 64 Bit I am doing the same steps, and after "Save" the green bar at the bottom doesn't so anything. Let me uninstall Winzip and I will try again, that's the only thing I didn't do. |
|
2010-11-07 13:47
|
working.JPG (50,890 bytes) |
|
2010-11-07 13:47
|
failing.JPG (55,482 bytes) |
|
|
btw, regarding the comment about imageArchive typecast. This is what I use Var imagearchive : TJclCompressionArchive; AFormat : TJclUpdateArchiveClass; file1 : string; begin AFormat := GetArchiveFormats.FindUpdateFormat(file1); if AFormat <> nil then begin imagearchive := AFormat.Create(file1, 0, false); imagearchive.OnProgress := ArchiveProgress; TJclUpdateArchive(imagearchive).ListFiles; imagearchive as TJclCompressArchive).AddFile('coverimage.png','coverimage.png'); imagearchive as TJclCompressArchive).AddFile('gameicon.png', 'gameicon.png'); (imagearchive as TJclCompressArchive).Compress ; FreeAndNil(imagearchive); end; Is this not correct then? (got the compression one from the demo) |
|
|
About the compression problem, make sure the files are not edit-locked while editing the archive (the archive should not be opened in Winzip or in the explorer). The demo is able to work with compression/decompression/update archive classes. That's why its archive is declared as TJclCompressionArchive. Since your code does update and only update, you should be able to declare imagearchive as TJclUpdateArchive: Var imagearchive : TJclUpdateArchive; AFormat : TJclUpdateArchiveClass; file1 : string; begin AFormat := GetArchiveFormats.FindUpdateFormat(file1); if AFormat <> nil then begin imagearchive := AFormat.Create(file1, 0, false); imagearchive.OnProgress := ArchiveProgress; imagearchive.ListFiles; imagearchive.AddFile('coverimage.png','coverimage.png'); imagearchive.AddFile('gameicon.png', 'gameicon.png'); imagearchive.Compress ; FreeAndNil(imagearchive); end; This change limits the amount of potentially unsafe/slow typecasts. |
|
|
ok, I figured out where the problem is, but don't know what.. it's failing on the .Onprogress := Archiveprogress; If I comment that one out, then it's fine. I do have a procedure with Archiveprogress. But don't see what could be wrong with that?? procedure Tdsmainform.ArchiveProgress(Sender: TObject; const Value, MaxValue: Int64); var MyValue, MyMaxValue: Int64; begin MyValue := Value; MyMaxValue := MaxValue; while MyMaxValue > High(Word) do begin MyMaxValue := MyMaxValue shr 8; MyValue := MyValue shr 8; end; mainprogressbar.TotalParts:=MyMaxValue; mainprogressbar.PartsComplete:=myvalue; end; |
|
|
Which version of Delphi? |
|
|
ok, did some more work.. it's getting in an endless loop sometimes with this while MyMaxValue > High(Word) do begin MyMaxValue := MyMaxValue shr 8; MyValue := MyValue shr 8; end; Mymaxvalue is not changing sometimes. and the other issue is that sometimes it locks up on sending the results to the progressbar mainprogressbar.TotalParts:=MyMaxValue; mainprogressbar.PartsComplete:=myvalue; EDIT 2: After playing with it for hours, it seems that it's coming for 99% from the value parsing to the Progressbar. I tried all the progressbars on my form (standard Delphi, and all the JV progressbars, and they all do the same). when I disable the last 2 lines, I don't have any problems. Other think noticed, with all the JV progress bars, that when you min, max the form, that the progressbar disappears. |
|
|
That's wierd, I'll try to spend some time on this issue on today... |
|
|
I played some more with it, and keeps failing also on the demo file for the statusbar. There's not really a logic in it. Tried looking at the code, but couldn't figure it out, and also no clue what to look for. Could it be some kind of a conflict with another component, even though I'm not using other ones (like Razor,Toolbar 2000, Berg Soft) |
|
|
Perhaps a problem of thread safety, 7zip is threaded. Could you have a look at the thread ID each time the breakpoint is hit? |
|
|
ooh, good one.. I do remember seeing something like that, and then it stops. let me work on that, to see if that's true or not. EDIT: it starts a thread, and then stops. was trying to break on the Onprogress procedure, but couldn't get it too stop either. Can I set an option somewhere to use only 1 thread ? |
|
|
I'm stepping through the code line by line, and noticed something weird. mainprogressbar.TotalParts:=MyMaxValue; mainprogressbar.PartsComplete:=myvalue; mymaxvalue is always 1014 eventhough the max should only be 100 ? Myvalue steps from 2,4,6 .. 62 and then locks up. it's repeating the procedure procedure TJclCompressionArchive.DoProgress(const Value, MaxValue: Int64); begin if Assigned(FOnProgress) then FOnProgress(Self, Value, MaxValue); end; the "self" contains the values ((mainform.Tdsmainform.ArchiveProgress,$48D1FD0), (nil,nil), (nil,nil), '', 1, 1, 0, '', 66488116, $6FF0ED0, $6FF0550) and it seems to freeze at some point on the DoProgress event |
|
|
Please have a look at the archive demo, revision 3417. |
|
|
no, tomorrow's daily zip (2010-11-12), you can already download rev 3417 in Sourceforge ViewVC (see Download GNU Tarball at the bottom of http://jcl.svn.sf.net/viewvc/jcl/trunk/jcl/ ). |
|
|
ok, updated my code with the new items, in the Demo and in my program. but it's still locking up, then it's doing the TThread function. I did see that you updated the sevenzip.pas file. Do I need that one also? It's freezing here after about 6-9 times it's stops executing that TThread it never reaches the procedure for that one. procedure Tdsmainform.ArchiveProgress(Sender: TObject; const Value, MaxValue: Int64); var MyValue, MyMaxValue: Int64; begin MyValue := Value; MyMaxValue := MaxValue; while MyMaxValue > High(Word) do begin MyMaxValue := MyMaxValue shr 8; MyValue := MyValue shr 8; end; FProgressmax:=mymaxvalue; FProgressvalue:=myvalue; ------> tthread.Synchronize (nil,syncharchiveprogress); // never makes it to syncharchiveprogress after 6-9 times end; procedure Tdsmainform.syncharchiveprogress; begin mainprogressbar.Max :=FProgressmax; mainprogressbar.Position :=FProgressvalue; end; Installed the whole package from 11/12 JCL and JVCL and same problem. locks up right away |
|
|
I'm playing around, and don't know if it helps. but it only seems to be happening when you open the archive and Add files. it works fine, when you unzip files, and creating new files seems to be fine too. |
|
|
There is also something else wrong.. FProgressmax:=mymaxvalue; FProgressvalue:=myvalue; FProgressvalue always stays 0 while myvalue has a number... how is that possible ? Edit: both were declared as Byte. Changed it to Integer and now that part is working. Now back to the original issue. 7Z works with no problems, I tried a lot of files... As soon as I use Zip, it freezes up on me |
|
|
I started debugging the JCLcompression.pas file and it's getting stuck on this line in the following procedure procedure TJclSevenzipUpdateArchive.Compress; begin . . SevenzipCheck(OutArchive.UpdateItems(OutStream, ItemCount, UpdateCallback)); . . end; it doesn't even go to Sevenzipcheck |
|
|
ok, now I know why it's failing. You can only ADD 1 file to a ZIP at a time. If you do 2 files, then it fails. so I need to add 1 file, save, add 1 file and save. Strange. since for 7z I don't need to do that. |
|
|
Will this be fixed???? |
|
|
That sounds like an internal error in sevenzip code. A copy/paste from Perry's message in newsgroups that sums this problem up: <copy> ok, I figured out, when it's failing when you ADD files to a ZIP file. If you add only 1 File and save it, then it works just fine. When you add 2 or more files to a ZIP file, then it freezes the whole thing up. When I do this for 7Z files, then it's working just fine. Guess that explains, why it was working for adding just 1 file. I updated my Bug report on the web, and hope someone could look into it. since now I need to open - update - close file a lot of times. thank you Perry </copy> |
|
|
I am Perry :) |
|
|
I guess you can close this ticket. Have to found out from 7z if this is or will be fixed. |
- Anonymous
