View Issue Details

IDProjectCategoryView StatusLast Update
0005660JEDI Code LibraryIDE Expertspublic2011-09-23 14:37
ReportergskoczylasAssigned Tooutchy 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformDelphi XE ProfessionalOSWindows Vista ProfessionalOS Version15.0.3953.35171
Product VersionVersion 2.3 
Target VersionFixed in VersionVersion 2.4 
Summary0005660: Error in source code
DescriptionSource file: JclOtaUtils.pas
Lines: 1305-1315
Oryginal code:

    ReadEnvVariables(EnvVariables);
    {$IFDEF BDS8_UP}
    // add the config environment variable
    if Supports(Project.ProjectOptions, IOTAProjectOptionsConfigurations, Configurations) then
    begin
      EnvVariables.Values['Config'] := Configurations.ActiveConfigurationName;
      EnvVariables.Values['Platform'] := Configurations.ActivePlatformName;
    end;
    {$ENDIF BDS8_UP}

Compilation error: unknown identifier: ActivePlatformName

Perhaps it should be:

    ReadEnvVariables(EnvVariables);
    {$IFDEF BDS8_UP}
    // add the config environment variable
    if Supports(Project.ProjectOptions, IOTAProjectOptionsConfigurations, Configurations) then
    begin
      EnvVariables.Values['Config'] := Configurations.ActiveConfigurationName;
      {$IFDEF BDS9_UP} // <------
      EnvVariables.Values['Platform'] := Configurations.ActivePlatformName;
      {$ENDIF BDS9_UP} // <------
    end;
    {$ENDIF BDS8_UP}
Steps To ReproduceCompile in Delphi XE.
Additional InformationPerhaps the Configurations.ActivePlatformName identifier is available in Delphi XE2 and up.
TagsNo tags attached.
Fixed in GIT commit
Fixed in SVN revision3600
IDE versionDelphi/C++Builder XE

Relationships

duplicate of 0005649 resolvedjfudickar Delphi XE JCLOtaUtils.pas (1311) undeclared identifier "ActivePlatformName" 

Activities

outchy

2011-09-23 14:37

administrator   ~0018976

already fixed in revision 3600.

Issue History

Date Modified Username Field Change
2011-09-21 21:54 gskoczylas New Issue
2011-09-21 21:54 gskoczylas IDE version => Delphi/C++Builder XE
2011-09-23 14:33 outchy Category Installation => IDE Experts
2011-09-23 14:33 outchy Product Version => Version 2.3 (Subversion repository/Daily zips)
2011-09-23 14:33 outchy Relationship added duplicate of 0005649
2011-09-23 14:37 outchy Fixed in revision => 3600
2011-09-23 14:37 outchy Note Added: 0018976
2011-09-23 14:37 outchy Status new => resolved
2011-09-23 14:37 outchy Fixed in Version => Version 2.4 (Subversion repository/Daily zips)
2011-09-23 14:37 outchy Resolution open => fixed
2011-09-23 14:37 outchy Assigned To => outchy