|
|
Please use the latest SVN version and provide the zipped sources of a sample application showing this. Also, please try to provide a patch for this |
|
|
TopicStarter is a bit wrong. The condition required is not high DPI but any custom font of windows "message" area. That can be set even in Win95 using Display properties. Surely Win98 Themes made thsi even easier, and modern monitors with 120+ PPI made it yet more frequent. RxLib scrin size was calculated by hands and set for MS Sans Serif font sz 8 height -11 default for early Delphi and Windows 3.x. Then someone smart changed it to request font from OS instead. And the calculation made for fixed SansSerif 8 became irrelevant... I made a crude fox for it, but well... it is just crude. using non-standard component in RxLib is reasonable - there was no DateTime Picker in 16-bit Win 3.1, But today is almost 20 years after Win95 release... |
|
2013-04-19 17:57
|
RxDateTime_1_MSS8.png (37,708 bytes) |
|
2013-04-19 17:57
|
RxDateTime_2_Current.png (56,343 bytes) |
|
2013-04-19 17:57
|
RxDateTime_3_Fixed.png (60,937 bytes) |
|
2013-04-19 17:57
|
RxDateTime_4_Fixed_Classic.png (31,241 bytes) |
|
|
JvPickDate.pas changes are: 1) adding a variable 2) commenting out SetFont call in the beginning 3) setting Anchors for buttons 4) adding ScaleBy in the very end constructor TJvPopupCalendar.Create(AOwner: TComponent); .......... {$ENDIF JVCLThemesEnabled} tmpF: TFont; // need to get PPI for Windows default font for text, since // global VCL.TScreen PPI may be different from this one, since // user theme may have different fonts for different form elements. begin inherited Create(AOwner); ............... Color := clBtnFace; // FontSetDefault(Font); // moved to bottom if AOwner is TControl then FBtns[0] := TJvTimerSpeedButton.Create(Self); with FBtns[0] do begin ....... Anchors := [akLeft, akTop]; // for ScaleBy later end; FBtns[1] := TJvTimerSpeedButton.Create(Self); with FBtns[1] do begin ....... Anchors := [akLeft, akTop]; // for ScaleBy later end; ....... FBtns[2] := TJvTimerSpeedButton.Create(Self); with FBtns[2] do begin ....... Anchors := [akRight, akTop]; // for ScaleBy later end; FBtns[3] := TJvTimerSpeedButton.Create(Self); with FBtns[3] do begin ....... Anchors := [akRight, akTop]; // for ScaleBy later end; tmpf := TFont.Create; try FontSetDefault(tmpF); // controls coordinates are hardcoded for MS Sans Serif sz 8 ht -11 if tmpF.Height <> -11 then begin // default for sz 8 font if tmpF.Height < 0 // MSDN LOGFONT: >0 and <0 are different beasts, can not be compared then ScaleBy(tmpF.Height, -11) else ScaleBy(tmpF.Size, 8); // much less precision FBtns[1].Left := FBtns[0].Left + FBtns[0].Width + HorzOffset; FBtns[2].Left := FBtns[3].Left - FBtns[2].Width - HorzOffset; end; Font.Assign(tmpF); finally tmpF.Free; end; //Polaris CheckButton; end; |
|
2013-04-19 18:02
|
Unit3.pas (532 bytes) |
|
2013-04-19 18:02
|
Unit3.dfm (1,493 bytes) |
|
|
for Edit.csDialog == csDialog we need to make analogue fix in constructor TJvSelectDateDlg.Create 1) add var tmpF: TFont; 2) in the beginning disable // FontSetDefault(Font); - doing it below, when all controls created 3) add to the bottom of contructor: tmpf := TFont.Create; try FontSetDefault(tmpF); // controls coordinates are hardcoded for MS Sans Serif sz 8 ht -11 if tmpF.Height <> -11 then begin // default for sz 8 font if tmpF.Height < 0 // MSDN LOGFONT: >0 and <0 are different beasts, can not be compared then ScaleBy(tmpF.Height, -11) else ScaleBy(tmpF.Size, 8); // much less precision end; Font.Assign(tmpF); finally tmpF.Free; end; OnKeyDown := FormKeyDown; Calendar.CalendarDate := Trunc(Now); ActiveControl := Calendar; end; This is not a proper fix, but proper one would be complete remaking of the whole dialogs... |
|
|
Thanks, it works but only if in TJvSelectDateDlg.Create I make this changes:
if tmpF.Height <> -12 then begin // default for sz 8 font
if tmpF.Height < 0 // MSDN LOGFONT: >0 and <0 are different beasts, can not be compared
then ScaleBy(tmpF.Height, -9)
else ScaleBy(tmpF.Size, 8); // much less precision
|
|
|
this would work somewhat differently with Classic/Aero/Glass and 96/120/150 and XP/Vista-7 did not tried on win8 or win2k "magic constants" are bad thing, especially in problematic area like VCL scaling (a lot of quantization errors, different on different machines) If you would make proper implementation, rather than quick and dirty hack, then everyone may benefit from it. Or a reliable approach would be to remove this function all together, and come back to initial layout assumption that everithing is "MS Sans Serif font sz 8 height -11 default for early Delphi and Windows 3.x." |
|
|
if tmpF.Height <> -12 then begin // default for sz 8 font then ScaleBy(tmpF.Height, -9) Actually this should not work. The constant should be the same. My code does ScaleBy from default "-11" if the actual value is "not default -11" But your code looks plain wrong. For example it would make no scaling if Height == -9 <> -12 |
|
2013-05-15 08:31
|
screenshot1.png (8,558 bytes) |
|
|
Thank for your comment. With your code the numbers where also cut. See Screenshot1. I tried a little bit in the numbers and found, that changing it in this way it worked. It works also with if tmpF.Height <> -11 but as the default with 96dpi was -12 I changed it, but it is not necessery. The only change that give me a good result is ScaleBy(tmpF.Height, -9). Do you have an Idea, what I can change? I develope under Windows 8 with 96 dpi. The font of the control is Tahoma 8. I test it with windows 7 in a VirtualBox with 125% Font size. |
|
|
i was developing on win7 125% natively and my co-workers developed on XP 96dpi i just note that your code should have no sense, that all i can do. perhaps it is affected by the parent form's scaling or whatever |
|
2013-08-22 19:00
|
|
|
|
So, what do we do here? |
|
|
No news, suspending the issue |
- Anonymous
