View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006607JEDI VCL00 JVCL Componentspublic2017-12-24 13:252018-07-18 15:58
ReporterpyscripterAssigned Toobones 
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionno change required 
Product VersionDaily / GIT 
Target VersionFixed in Version 
Summary0006607: Please remove unnnecessary IFDEFs in JvGnugettext
DescriptionIn JvGnugettext there are about 70 lines of IFDEFs such as the following:
{$ifdef VER200}
  // Delphi 2009 with Unicode
  {$DEFINE DELPHI2009OROLDER}
{$endif}

which are not only unnecessary but confusing.

For example in TGnuGettextInstance.TranslateStrings we have the code:

        {$ifdef DELPHI2009OROLDER}
        if Assigned(slAsTStringList) then begin
          originalOwnsObjects := slAsTStringList.OwnsObjects;
          slAsTStringList.OwnsObjects := False;
        end;
        {$endif}

In fact DELPHI2009OROLDER actually means Delphi 2009 or newer!

Since the unit includes JEDI.inc, the above can be replaced with DELPHI12_UP etc.
TagsNo tags attached.

Activities

obones

2018-07-18 15:58

administrator   ~0021532

This will not be changed as the unit comes from a third party project that has its own life.

Issue History

Date Modified Username Field Change
2017-12-24 13:25 pyscripter New Issue
2018-07-18 15:58 obones Note Added: 0021532
2018-07-18 15:58 obones Status new => resolved
2018-07-18 15:58 obones Resolution open => no change required
2018-07-18 15:58 obones Assigned To => obones